rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5 heartwoodf20c93e458a06468d1b49240f6b74e7f8ce033b6
{
"request": "trigger",
"version": 1,
"event_type": "patch",
"repository": {
"id": "rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5",
"name": "heartwood",
"description": "Radicle Heartwood Protocol & Stack",
"private": false,
"default_branch": "master",
"delegates": [
"did:key:z6MksFqXN3Yhqk8pTJdUGLwATkRfQvwZXPqR2qMEhbS9wzpT",
"did:key:z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM",
"did:key:z6MkkPvBfjP4bQmco5Dm7UGsX2ruDBieEHi8n9DVJWX5sTEz"
]
},
"action": "Created",
"patch": {
"id": "72c31bfc6764b6369c73e1bef3a60c89ca574d64",
"author": {
"id": "did:key:z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM",
"alias": null
},
"title": "fetch: allow missing default branch",
"state": {
"status": "merged",
"conflicts": []
},
"before": "f6aa46a283f63025882551a27e6d2145939560f5",
"after": "f20c93e458a06468d1b49240f6b74e7f8ce033b6",
"commits": [
"f20c93e458a06468d1b49240f6b74e7f8ce033b6"
],
"target": "3fc92f83fe089263c470b328414d923227cf0e4a",
"labels": [],
"assignees": [],
"revisions": [
{
"id": "72c31bfc6764b6369c73e1bef3a60c89ca574d64",
"author": {
"id": "did:key:z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM",
"alias": null
},
"description": "When fetching, the validation logic would prune a delegate if it was missing the\ndefault branch. Originally, this was done to prevent any broken state, but later\nit was realised that this can be too restrictive and would not allow nodes to\nrecover into an improved state.\n\nRemove this check so thtat nodes can still fetch from each other when the\ndefault branch is missing.\n\nAn e2e test is added to show that nodes can still fetch from each other and\nstill receive other references, even when a delegate is missing their default\nbranch.",
"base": "f6aa46a283f63025882551a27e6d2145939560f5",
"oid": "f20c93e458a06468d1b49240f6b74e7f8ce033b6",
"timestamp": 1730888916
},
{
"id": "35f251175832b63ad44ac79cb6d92fbc87524a90",
"author": {
"id": "did:key:z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM",
"alias": null
},
"description": "Fix clippy lint.",
"base": "f6aa46a283f63025882551a27e6d2145939560f5",
"oid": "eb095c109b176eb9594ab5f99881bccf06213459",
"timestamp": 1730908029
}
]
}
}
{
"response": "triggered",
"run_id": {
"id": "df8f6a32-4e20-400f-9511-3aa140e327ef"
},
"info_url": "https://cci.rad.levitte.org//df8f6a32-4e20-400f-9511-3aa140e327ef.html"
}
Started at: 2026-09-07 23:02:12.923358+02:00
Commands:
$ rad clone rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5 .
✓ Creating checkout in ./...
✓ Remote cloudhead@z6MksFqXN3Yhqk8pTJdUGLwATkRfQvwZXPqR2qMEhbS9wzpT added
✓ Remote-tracking branch cloudhead@z6MksFqXN3Yhqk8pTJdUGLwATkRfQvwZXPqR2qMEhbS9wzpT/master created for z6MksFqXN3Yhqk8pTJdUGLwATkRfQvwZXPqR2qMEhbS9wzpT
✓ Remote fintohaps@z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM added
✓ Remote-tracking branch fintohaps@z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM/master created for z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM
✓ Remote lorenz@z6MkkPvBfjP4bQmco5Dm7UGsX2ruDBieEHi8n9DVJWX5sTEz added
✓ Remote-tracking branch lorenz@z6MkkPvBfjP4bQmco5Dm7UGsX2ruDBieEHi8n9DVJWX5sTEz/master created for z6MkkPvBfjP4bQmco5Dm7UGsX2ruDBieEHi8n9DVJWX5sTEz
✓ Repository successfully cloned under /opt/radcis/ci.rad.levitte.org/cci/state/df8f6a32-4e20-400f-9511-3aa140e327ef/w/
╭────────────────────────────────────╮
│ heartwood │
│ Radicle Heartwood Protocol & Stack │
│ 189 issues · 38 patches │
╰────────────────────────────────────╯
Run `cd ./.` to go to the repository directory.
Exit code: 0
$ rad patch checkout 72c31bfc6764b6369c73e1bef3a60c89ca574d64
✓ Switched to branch patch/72c31bf at revision 72c31bf
✓ Branch patch/72c31bf setup to track rad/patches/72c31bfc6764b6369c73e1bef3a60c89ca574d64
Exit code: 0
$ git config advice.detachedHead false
Exit code: 0
$ git checkout f20c93e458a06468d1b49240f6b74e7f8ce033b6
HEAD is now at f20c93e4 fetch: allow missing default branch
Exit code: 0
$ rad patch show 72c31bfc6764b6369c73e1bef3a60c89ca574d64 -p
╭──────────────────────────────────────────────────────────────────────────────────╮
│ Title fetch: allow missing default branch │
│ Patch 72c31bfc6764b6369c73e1bef3a60c89ca574d64 │
│ Author fintohaps z6Mkire…SQZ3voM │
│ Head f20c93e458a06468d1b49240f6b74e7f8ce033b6 │
│ Base f6aa46a283f63025882551a27e6d2145939560f5 │
│ Target master │
│ Branches patch/72c31bf │
│ Commits ahead 1, behind 1172 │
│ Status merged │
│ │
│ When fetching, the validation logic would prune a delegate if it was missing the │
│ default branch. Originally, this was done to prevent any broken state, but later │
│ it was realised that this can be too restrictive and would not allow nodes to │
│ recover into an improved state. │
│ │
│ Remove this check so thtat nodes can still fetch from each other when the │
│ default branch is missing. │
│ │
│ An e2e test is added to show that nodes can still fetch from each other and │
│ still receive other references, even when a delegate is missing their default │
│ branch. │
├──────────────────────────────────────────────────────────────────────────────────┤
│ f20c93e fetch: allow missing default branch │
├──────────────────────────────────────────────────────────────────────────────────┤
│ ● Revision 72c31bf @ f6aa46a..f20c93e by fintohaps z6Mkire…SQZ3voM 1 year ago │
│ ↑ Revision 35f2511 @ f6aa46a..eb095c1 by cloudhead z6MksFq…bS9wzpT 1 year ago │
│ └─ ✓ merged by cloudhead z6MksFq…bS9wzpT │
╰──────────────────────────────────────────────────────────────────────────────────╯
commit f20c93e458a06468d1b49240f6b74e7f8ce033b6
Author: Fintan Halpenny <fintan.halpenny@gmail.com>
Date: Mon Nov 4 15:52:14 2024 +0000
fetch: allow missing default branch
When fetching, the validation logic would prune a delegate if it was missing the
default branch. Originally, this was done to prevent any broken state, but later
it was realised that this can be too restrictive and would not allow nodes to
recover into an improved state.
Remove this check so thtat nodes can still fetch from each other when the
default branch is missing.
An e2e test is added to show that nodes can still fetch from each other and
still receive other references, even when a delegate is missing their default
branch.
diff --git a/radicle-fetch/src/state.rs b/radicle-fetch/src/state.rs
index 8397aed3f..90a9f2030 100644
--- a/radicle-fetch/src/state.rs
+++ b/radicle-fetch/src/state.rs
@@ -8,7 +8,7 @@ use radicle::identity::{Did, Doc, DocError};
use radicle::prelude::Verified;
use radicle::storage;
-use radicle::storage::refs::{RefsAt, SignedRefs};
+use radicle::storage::refs::RefsAt;
use radicle::storage::{
git::Validation, Remote, RemoteId, RemoteRepository, Remotes, ValidateRepository, Validations,
};
@@ -547,15 +547,8 @@ impl FetchState {
}
let cache = self.as_cached(handle);
- let mut fails = Validations::default();
- // N.b. we only validate the existence of the
- // default branch for delegates, since it safe for
- // non-delegates to not have this branch.
- let branch_validation =
- validate_project_default_branch(&anchor, &sigrefs.sigrefs);
- fails.extend(branch_validation.into_iter());
- let validations = sigrefs::validate(&cache, sigrefs)?;
- fails.extend(validations.into_iter().flatten());
+ let mut fails =
+ sigrefs::validate(&cache, sigrefs)?.unwrap_or(Validations::default());
if !fails.is_empty() {
log::warn!(target: "fetch", "Pruning delegate {remote} tips, due to validation failures");
self.prune(&remote);
@@ -729,20 +722,3 @@ impl<'a, S> ValidateRepository for Cached<'a, S> {
Ok(validations)
}
}
-
-/// If the repository has a project payload, in `anchor`, then
-/// validate that the `sigrefs` contains the listed default branch.
-///
-/// N.b. if the repository does not have the project payload or a
-/// deserialization error occurs, then this will return `None`.
-fn validate_project_default_branch(
- anchor: &Doc,
- sigrefs: &SignedRefs<Verified>,
-) -> Option<Validation> {
- let proj = anchor.project().ok()?;
- let branch = radicle::git::refs::branch(proj.default_branch()).to_ref_string();
- (!sigrefs.contains_key(&branch)).then_some(Validation::MissingRef {
- remote: sigrefs.id,
- refname: branch,
- })
-}
diff --git a/radicle-node/src/tests/e2e.rs b/radicle-node/src/tests/e2e.rs
index 33d4afd1d..f4050a95b 100644
--- a/radicle-node/src/tests/e2e.rs
+++ b/radicle-node/src/tests/e2e.rs
@@ -1209,6 +1209,125 @@ fn missing_default_branch() {
);
}
+#[test]
+fn missing_delegate_default_branch() {
+ use radicle::git::raw;
+ use radicle::identity::Identity;
+ use radicle::storage::git::Repository;
+
+ logger::init(log::Level::Debug);
+
+ let tmp = tempfile::tempdir().unwrap();
+
+ let mut alice = Node::init(tmp.path(), config::relay("alice"));
+ let bob = Node::init(tmp.path(), config::relay("bob"));
+ let seed = Node::init(tmp.path(), config::relay("seed"));
+
+ let rid = alice.project("acme", "");
+
+ let mut alice = alice.spawn();
+ let mut bob = bob.spawn();
+ let mut seed = seed.spawn();
+
+ alice.handle.seed(rid, Scope::All).unwrap();
+ bob.handle.seed(rid, Scope::All).unwrap();
+ seed.handle.seed(rid, Scope::All).unwrap();
+ alice.connect(&seed);
+ converge([&seed]);
+ bob.connect(&seed);
+
+ bob.handle.fetch(rid, seed.id, DEFAULT_TIMEOUT).unwrap();
+ assert!(bob.storage.contains(&rid).unwrap());
+
+ // Helper to assert that Bob's default branch is not in storage
+ let assert_bobs_default_is_missing = |repo: &Repository| {
+ let doc = repo.identity_doc().unwrap();
+ let project = doc.project().unwrap();
+ let default_branch = repo.reference(
+ bob.signer.public_key(),
+ &radicle::git::refs::branch(project.default_branch()),
+ );
+ assert!(matches!(
+ default_branch,
+ Err(radicle::git::Error::Git(e)) if e.code() == raw::ErrorCode::NotFound
+ ));
+ };
+
+ // Add Bob as a delegate to the identity document
+ {
+ let repo = alice.storage.repository(rid).unwrap();
+ let mut identity = Identity::load_mut(&repo).unwrap();
+ let doc = repo
+ .identity_doc()
+ .unwrap()
+ .doc
+ .with_edits(|doc| {
+ doc.delegate(bob.signer.public_key().into());
+ })
+ .unwrap();
+ let rev = identity.update("Add Bob", "", &doc, &alice.signer).unwrap();
+ repo.set_identity_head_to(rev).unwrap();
+
+ let new = repo.identity_doc().unwrap().doc;
+ assert!(
+ new.is_delegate(&bob.signer.public_key().into()),
+ "Bob must be a delegate after the update"
+ );
+ }
+
+ // We ensure that Bob does not have the default branch
+ let repo = bob.storage.repository(rid).unwrap();
+ assert_bobs_default_is_missing(&repo);
+
+ // Create an issue to ensure there are new refs to fetch
+ let issue = bob.issue(
+ rid,
+ "Delegate Issue",
+ "Further investigation into delegates",
+ );
+ let assert_bobs_issue_exists = |repo: &Repository| {
+ let issue_ref = radicle::git::refs::storage::cob(
+ bob.signer.public_key(),
+ &radicle::cob::issue::TYPENAME,
+ &issue,
+ );
+ assert!(matches!(
+ repo.backend.find_reference(issue_ref.as_str()),
+ Ok(_)
+ ));
+ };
+
+ // The seed fetches from Bob and checks that:
+ // a) Bob's default branch is still missing
+ // b) Bob's issue is there
+ assert_matches!(
+ seed.handle.fetch(rid, bob.id, DEFAULT_TIMEOUT).unwrap(),
+ FetchResult::Success { .. }
+ );
+ {
+ let repo = seed.storage.repository(rid).unwrap();
+ assert_bobs_default_is_missing(&repo);
+ assert_bobs_issue_exists(&repo);
+ }
+
+ // Do the same for Alice
+ assert_matches!(
+ alice.handle.fetch(rid, seed.id, DEFAULT_TIMEOUT).unwrap(),
+ FetchResult::Success { .. }
+ );
+ {
+ let repo = alice.storage.repository(rid).unwrap();
+ assert_bobs_default_is_missing(&repo);
+ assert_bobs_issue_exists(&repo);
+ }
+
+ // Check that Bob can still fetch from the seed
+ assert_matches!(
+ bob.handle.fetch(rid, seed.id, DEFAULT_TIMEOUT).unwrap(),
+ FetchResult::Success { .. }
+ );
+}
+
#[test]
fn test_background_foreground_fetch() {
logger::init(log::Level::Debug);
Exit code: 0
shell: 'cargo --version rustc --version cargo fmt --check cargo clippy --all-targets --workspace -- --deny clippy::all cargo build --all-targets --workspace cargo doc --workspace cargo test --workspace --no-fail-fast '
Commands:
$ podman run --name df8f6a32-4e20-400f-9511-3aa140e327ef -v /opt/radcis/ci.rad.levitte.org/cci/state/df8f6a32-4e20-400f-9511-3aa140e327ef/s:/df8f6a32-4e20-400f-9511-3aa140e327ef/s:ro -v /opt/radcis/ci.rad.levitte.org/cci/state/df8f6a32-4e20-400f-9511-3aa140e327ef/w:/df8f6a32-4e20-400f-9511-3aa140e327ef/w -w /df8f6a32-4e20-400f-9511-3aa140e327ef/w -v /opt/radcis/ci.rad.levitte.org/.radicle:/${id}/.radicle:ro -e RAD_HOME=/${id}/.radicle rust:trixie bash /df8f6a32-4e20-400f-9511-3aa140e327ef/s/script.sh
+ cargo --version
info: syncing channel updates for '1.80-x86_64-unknown-linux-gnu'
info: latest update on 2024-08-08, rust version 1.80.1 (3f5fd8dd4 2024-08-06)
info: downloading component 'cargo'
info: downloading component 'clippy'
info: downloading component 'rust-docs'
info: downloading component 'rust-src'
info: downloading component 'rust-std'
info: downloading component 'rustc'
info: downloading component 'rustfmt'
info: installing component 'cargo'
info: installing component 'clippy'
info: installing component 'rust-docs'
info: installing component 'rust-src'
info: installing component 'rust-std'
info: installing component 'rustc'
info: installing component 'rustfmt'
cargo 1.80.1 (376290515 2024-07-16)
+ rustc --version
rustc 1.80.1 (3f5fd8dd4 2024-08-06)
+ cargo fmt --check
+ cargo clippy --all-targets --workspace -- --deny clippy::all
Updating crates.io index
Downloading crates ...
Downloaded aead v0.5.2
Downloaded amplify_derive v4.0.0
Downloaded aes-gcm v0.10.3
Downloaded adler v1.0.2
Downloaded shell-words v1.1.0
Downloaded shlex v1.3.0
Downloaded similar v2.5.0
Downloaded siphasher v1.0.1
Downloaded tinyvec v1.6.0
Downloaded tinyvec_macros v0.1.1
Downloaded inout v0.1.3
Downloaded tree-sitter-python v0.20.4
Downloaded time-macros v0.2.18
Downloaded itoa v1.0.11
Downloaded localtime v1.3.1
Downloaded gix-prompt v0.8.4
Downloaded gix-url v0.27.3
Downloaded popol v3.0.0
Downloaded rand_chacha v0.3.1
Downloaded nonempty v0.9.0
Downloaded rfc6979 v0.4.0
Downloaded gix-trace v0.1.9
Downloaded scopeguard v1.2.0
Downloaded salsa20 v0.10.2
Downloaded poly1305 v0.8.0
Downloaded quote v1.0.36
Downloaded same-file v1.0.6
Downloaded num-conv v0.1.0
Downloaded parking_lot v0.12.1
Downloaded scrypt v0.11.0
Downloaded qcheck v1.0.0
Downloaded polyval v0.6.2
Downloaded proc-macro-error-attr v1.0.4
Downloaded miniz_oxide v0.7.2
Downloaded ryu v1.0.17
Downloaded pkcs1 v0.7.5
Downloaded rsa v0.9.6
Downloaded sha1_smol v1.0.0
Downloaded pem-rfc7468 v0.7.0
Downloaded num-bigint-dig v0.8.4
Downloaded parking_lot_core v0.9.9
Downloaded memmap2 v0.9.4
Downloaded rustix v0.38.34
Downloaded regex-automata v0.4.6
Downloaded sha2 v0.10.8
Downloaded memchr v2.7.2
Downloaded serde_json v1.0.116
Downloaded libm v0.2.8
Downloaded tree-sitter-md v0.1.7
Downloaded vcpkg v0.2.15
Downloaded regex-syntax v0.8.3
Downloaded tree-sitter-ruby v0.20.1
Downloaded idna v0.5.0
Downloaded sha3 v0.10.8
Downloaded libc v0.2.155
Downloaded tree-sitter-rust v0.20.4
Downloaded linux-raw-sys v0.4.13
Downloaded tree-sitter-typescript v0.20.5
Downloaded libgit2-sys v0.17.0+1.8.1
Downloaded tree-sitter-c v0.20.8
Downloaded tree-sitter-bash v0.20.5
Downloaded syn v2.0.60
Downloaded syn v1.0.109
Downloaded sqlite3-src v0.5.1
Downloaded inquire v0.7.5
Downloaded unicode-normalization v0.1.23
Downloaded tree-sitter v0.20.10
Downloaded ssh-key v0.6.6
Downloaded serde_derive v1.0.198
Downloaded proc-macro2 v1.0.81
Downloaded pretty_assertions v1.4.0
Downloaded libz-sys v1.1.16
Downloaded once_cell v1.19.0
Downloaded num-traits v0.2.18
Downloaded serde v1.0.198
Downloaded indexmap v2.2.6
Downloaded hashbrown v0.14.3
Downloaded gix-transport v0.42.0
Downloaded winnow v0.6.8
Downloaded url v2.5.0
Downloaded unicode-segmentation v1.11.0
Downloaded tar v0.4.40
Downloaded primeorder v0.13.6
Downloaded proc-macro-error v1.0.4
Downloaded num-integer v0.1.46
Downloaded regex v1.10.4
Downloaded p384 v0.13.0
Downloaded iana-time-zone v0.1.60
Downloaded git2 v0.19.0
Downloaded bstr v1.9.1
Downloaded radicle-surf v0.22.0
Downloaded p521 v0.13.3
Downloaded jobserver v0.1.31
Downloaded hmac v0.12.1
Downloaded unicode-bidi v0.3.15
Downloaded tree-sitter-go v0.20.0
Downloaded prodash v28.0.0
Downloaded numtoa v0.1.0
Downloaded num_threads v0.1.7
Downloaded log v0.4.21
Downloaded unicode-ident v1.0.12
Downloaded typenum v1.17.0
Downloaded cyphernet v0.5.2
Downloaded rand v0.8.5
Downloaded gix-pack v0.51.1
Downloaded crypto-bigint v0.5.5
Downloaded crossbeam-channel v0.5.13
Downloaded p256 v0.13.2
Downloaded der v0.7.9
Downloaded flate2 v1.0.28
Downloaded arc-swap v1.7.1
Downloaded gix-odb v0.61.1
Downloaded ppv-lite86 v0.2.17
Downloaded pkcs8 v0.10.2
Downloaded percent-encoding v2.3.1
Downloaded netservices v0.8.0
Downloaded home v0.5.9
Downloaded gix-tempfile v14.0.1
Downloaded yansi v0.5.1
Downloaded timeago v0.4.2
Downloaded elliptic-curve v0.13.8
Downloaded lexopt v0.3.0
Downloaded tree-sitter-html v0.20.0
Downloaded io-reactor v0.5.2
Downloaded zeroize v1.7.0
Downloaded sec1 v0.7.3
Downloaded lock_api v0.4.11
Downloaded gix-traverse v0.39.2
Downloaded tree-sitter-toml v0.20.0
Downloaded anstyle-parse v0.2.3
Downloaded group v0.13.0
Downloaded gix-validate v0.8.5
Downloaded ed25519 v1.5.3
Downloaded diff v0.1.13
Downloaded pkg-config v0.3.30
Downloaded rand_core v0.6.4
Downloaded num-iter v0.1.44
Downloaded ctr v0.9.2
Downloaded qcheck-macros v1.0.0
Downloaded pbkdf2 v0.12.2
Downloaded powerfmt v0.2.0
Downloaded walkdir v2.5.0
Downloaded nonempty v0.5.0
Downloaded gix-revwalk v0.13.2
Downloaded gix-object v0.42.3
Downloaded getrandom v0.2.14
Downloaded ff v0.13.0
Downloaded crc32fast v1.4.0
Downloaded utf8parse v0.2.1
Downloaded gix-diff v0.44.1
Downloaded gix-credentials v0.24.2
Downloaded gix-commitgraph v0.24.3
Downloaded dyn-clone v1.0.17
Downloaded digest v0.10.7
Downloaded noise-framework v0.4.0
Downloaded newline-converter v0.3.0
Downloaded multibase v0.9.1
Downloaded radicle-std-ext v0.1.0
Downloaded opaque-debug v0.3.1
Downloaded maybe-async v0.2.10
Downloaded universal-hash v0.5.1
Downloaded gix-date v0.8.7
Downloaded radicle-git-ext v0.8.0
Downloaded normalize-line-endings v0.3.0
Downloaded xattr v1.3.1
Downloaded unicode-display-width v0.3.0
Downloaded gix-quote v0.4.12
Downloaded crossbeam-utils v0.8.19
Downloaded sqlite3-sys v0.15.2
Downloaded git-ref-format v0.3.0
Downloaded fastrand v2.1.0
Downloaded escargot v0.5.10
Downloaded deranged v0.3.11
Downloaded gix-features v0.38.2
Downloaded git-ref-format-core v0.3.0
Downloaded either v1.11.0
Downloaded ecdsa v0.16.9
Downloaded cyphergraphy v0.3.0
Downloaded cypheraddr v0.4.0
Downloaded crypto-common v0.1.6
Downloaded lazy_static v1.4.0
Downloaded keccak v0.1.5
Downloaded gix-sec v0.10.6
Downloaded gix-hash v0.14.2
Downloaded gix-command v0.3.6
Downloaded ghash v0.5.1
Downloaded fxhash v0.2.1
Downloaded filetime v0.2.23
Downloaded data-encoding-macro v0.1.14
Downloaded gix-utils v0.1.12
Downloaded version_check v0.9.4
Downloaded unicode-width v0.1.11
Downloaded tree-sitter-json v0.20.2
Downloaded tree-sitter-highlight v0.20.1
Downloaded tree-sitter-css v0.20.0
Downloaded thiserror-impl v1.0.59
Downloaded termion v3.0.0
Downloaded ssh-encoding v0.2.0
Downloaded sqlite v0.32.0
Downloaded socks5-client v0.4.1
Downloaded gix-path v0.10.9
Downloaded gix-packetline v0.17.5
Downloaded gix-hashtable v0.5.2
Downloaded gix-config-value v0.14.6
Downloaded gix-actor v0.31.5
Downloaded git-ref-format-macro v0.3.0
Downloaded generic-array v0.14.7
Downloaded form_urlencoded v1.2.1
Downloaded faster-hex v0.9.0
Downloaded data-encoding v2.5.0
Downloaded cbc v0.1.2
Downloaded bcrypt-pbkdf v0.10.0
Downloaded anstyle v1.0.6
Downloaded termion v2.0.3
Downloaded time v0.3.36
Downloaded ssh-cipher v0.2.0
Downloaded spki v0.7.3
Downloaded gix-fs v0.11.2
Downloaded gix-chunk v0.4.8
Downloaded equivalent v1.0.1
Downloaded data-encoding-macro-internal v0.1.12
Downloaded ct-codecs v1.1.1
Downloaded colorchoice v1.0.0
Downloaded cfg-if v1.0.0
Downloaded blowfish v0.9.1
Downloaded autocfg v1.2.0
Downloaded anstyle-query v1.0.2
Downloaded time-core v0.1.2
Downloaded socket2 v0.5.7
Downloaded snapbox-macros v0.3.8
Downloaded snapbox v0.4.17
Downloaded errno v0.3.8
Downloaded cc v1.0.95
Downloaded amplify_syn v2.0.1
Downloaded thiserror v1.0.59
Downloaded tempfile v3.10.1
Downloaded subtle v2.5.0
Downloaded spin v0.5.2
Downloaded smallvec v1.13.2
Downloaded siphasher v0.3.11
Downloaded signature v2.2.0
Downloaded signature v1.6.4
Downloaded ec25519 v0.1.0
Downloaded colored v2.1.0
Downloaded byteorder v1.5.0
Downloaded bloomy v1.2.0
Downloaded base-x v0.2.11
Downloaded ascii v1.1.0
Downloaded anyhow v1.0.82
Downloaded chrono v0.4.38
Downloaded const-oid v0.9.6
Downloaded chacha20poly1305 v0.10.1
Downloaded bitflags v2.5.0
Downloaded base64ct v1.6.0
Downloaded gix-protocol v0.45.0
Downloaded cpufeatures v0.2.12
Downloaded cipher v0.4.4
Downloaded chacha20 v0.9.1
Downloaded block-padding v0.3.3
Downloaded block-buffer v0.10.4
Downloaded base64 v0.13.1
Downloaded base32 v0.4.0
Downloaded anstream v0.6.13
Downloaded aho-corasick v1.1.3
Downloaded base64 v0.21.7
Downloaded base16ct v0.2.0
Downloaded amplify_num v0.5.2
Downloaded amplify v4.6.0
Downloaded aes v0.8.4
Compiling libc v0.2.155
Compiling proc-macro2 v1.0.81
Compiling unicode-ident v1.0.12
Checking cfg-if v1.0.0
Compiling once_cell v1.19.0
Compiling version_check v0.9.4
Checking memchr v2.7.2
Checking aho-corasick v1.1.3
Compiling quote v1.0.36
Compiling jobserver v0.1.31
Compiling syn v2.0.60
Checking regex-syntax v0.8.3
Compiling cc v1.0.95
Compiling thiserror v1.0.59
Compiling typenum v1.17.0
Checking getrandom v0.2.14
Checking regex-automata v0.4.6
Compiling generic-array v0.14.7
Checking rand_core v0.6.4
Checking tinyvec_macros v0.1.1
Checking tinyvec v1.6.0
Checking unicode-normalization v0.1.23
Checking crypto-common v0.1.6
Checking fastrand v2.1.0
Checking subtle v2.5.0
Compiling syn v1.0.109
Checking zeroize v1.7.0
Checking cpufeatures v0.2.12
Checking bitflags v2.5.0
Checking block-padding v0.3.3
Checking inout v0.1.3
Checking block-buffer v0.10.4
Compiling pkg-config v0.3.30
Checking bstr v1.9.1
Compiling thiserror-impl v1.0.59
Checking digest v0.10.7
Checking cipher v0.4.4
Compiling autocfg v1.2.0
Compiling crc32fast v1.4.0
Checking sha2 v0.10.8
Checking percent-encoding v2.3.1
Checking unicode-bidi v0.3.15
Checking form_urlencoded v1.2.1
Checking universal-hash v0.5.1
Checking idna v0.5.0
Compiling serde v1.0.198
Checking opaque-debug v0.3.1
Compiling vcpkg v0.2.15
Compiling amplify_syn v2.0.1
Checking url v2.5.0
Compiling serde_derive v1.0.198
Compiling libz-sys v1.1.16
Compiling rustix v0.38.34
Compiling data-encoding v2.5.0
Checking byteorder v1.5.0
Checking signature v1.6.4
Checking log v0.4.21
Checking itoa v1.0.11
Checking amplify_num v0.5.2
Checking linux-raw-sys v0.4.13
Compiling amplify_derive v4.0.0
Compiling data-encoding-macro-internal v0.1.12
Checking ascii v1.1.0
Checking data-encoding-macro v0.1.14
Checking ed25519 v1.5.3
Compiling libgit2-sys v0.17.0+1.8.1
Checking aead v0.5.2
Compiling proc-macro-error-attr v1.0.4
Checking amplify v4.6.0
Checking base-x v0.2.11
Checking ct-codecs v1.1.1
Checking multibase v0.9.1
Checking ec25519 v0.1.0
Checking poly1305 v0.8.0
Checking chacha20 v0.9.1
Compiling proc-macro-error v1.0.4
Checking cyphergraphy v0.3.0
Checking keccak v0.1.5
Checking sha3 v0.10.8
Compiling git-ref-format-core v0.3.0
Checking polyval v0.6.2
Checking hmac v0.12.1
Compiling sqlite3-src v0.5.1
Checking hashbrown v0.14.3
Checking base32 v0.4.0
Checking base64ct v1.6.0
Checking ppv-lite86 v0.2.17
Checking pem-rfc7468 v0.7.0
Checking rand_chacha v0.3.1
Checking cypheraddr v0.4.0
Compiling git-ref-format-macro v0.3.0
Checking pbkdf2 v0.12.2
Checking ghash v0.5.1
Checking chacha20poly1305 v0.10.1
Checking tempfile v3.10.1
Checking ctr v0.9.2
Checking aes v0.8.4
Compiling crossbeam-utils v0.8.19
Checking aes-gcm v0.10.3
Checking git-ref-format v0.3.0
Checking noise-framework v0.4.0
Checking socks5-client v0.4.1
Checking rand v0.8.5
Checking ssh-encoding v0.2.0
Checking blowfish v0.9.1
Checking cbc v0.1.2
Checking radicle-std-ext v0.1.0
Checking ssh-cipher v0.2.0
Checking bcrypt-pbkdf v0.10.0
Checking cyphernet v0.5.2
Checking signature v2.2.0
Checking ssh-key v0.6.6
Checking crossbeam-channel v0.5.13
Checking qcheck v1.0.0
Checking radicle-ssh v0.9.0 (/df8f6a32-4e20-400f-9511-3aa140e327ef/w/radicle-ssh)
Compiling num-traits v0.2.18
Compiling tree-sitter v0.20.10
Checking equivalent v1.0.1
Compiling serde_json v1.0.116
Checking indexmap v2.2.6
Checking regex v1.10.4
Checking ryu v1.0.17
Checking nonempty v0.9.0
Checking radicle-dag v0.9.0 (/df8f6a32-4e20-400f-9511-3aa140e327ef/w/radicle-dag)
Compiling anyhow v1.0.82
Checking lazy_static v1.4.0
Checking anstyle-query v1.0.2
Checking iana-time-zone v0.1.60
Checking chrono v0.4.38
Checking colored v2.1.0
Checking localtime v1.3.1
Checking base64 v0.21.7
Checking utf8parse v0.2.1
Checking siphasher v1.0.1
Checking anstyle-parse v0.2.3
Checking anstyle v1.0.6
Checking colorchoice v1.0.0
Checking anstream v0.6.13
Checking snapbox-macros v0.3.8
Checking similar v2.5.0
Checking normalize-line-endings v0.3.0
Checking radicle-signals v0.10.0 (/df8f6a32-4e20-400f-9511-3aa140e327ef/w/radicle-signals)
Checking snapbox v0.4.17
Checking numtoa v0.1.0
Checking diff v0.1.13
Checking unicode-segmentation v1.11.0
Compiling adler v1.0.2
Checking gix-trace v0.1.9
Checking yansi v0.5.1
Checking pretty_assertions v1.4.0
Compiling miniz_oxide v0.7.2
Compiling filetime v0.2.23
Compiling xattr v1.3.1
Checking shlex v1.3.0
Compiling escargot v0.5.10
Checking lexopt v0.3.0
Compiling flate2 v1.0.28
Compiling tar v0.4.40
Checking newline-converter v0.3.0
Checking termion v2.0.3
Checking fxhash v0.2.1
Checking faster-hex v0.9.0
Checking unicode-width v0.1.11
Checking dyn-clone v1.0.17
Compiling radicle-surf v0.22.0
Checking inquire v0.7.5
Checking unicode-display-width v0.3.0
Checking termion v3.0.0
Checking gix-utils v0.1.12
Compiling tree-sitter-python v0.20.4
Compiling tree-sitter-md v0.1.7
Compiling tree-sitter-c v0.20.8
Compiling tree-sitter-toml v0.20.0
Compiling tree-sitter-typescript v0.20.5
Compiling tree-sitter-go v0.20.0
Compiling tree-sitter-bash v0.20.5
Compiling tree-sitter-json v0.20.2
Compiling tree-sitter-rust v0.20.4
Compiling tree-sitter-ruby v0.20.1
Compiling tree-sitter-html v0.20.0
Compiling tree-sitter-css v0.20.0
Checking sqlite3-sys v0.15.2
Checking sqlite v0.32.0
Checking gix-hash v0.14.2
Checking base64 v0.13.1
Compiling radicle-cli v0.11.0 (/df8f6a32-4e20-400f-9511-3aa140e327ef/w/radicle-cli)
Checking nonempty v0.5.0
Checking same-file v1.0.6
Checking walkdir v2.5.0
Checking tree-sitter-highlight v0.20.1
Checking sha1_smol v1.0.0
Checking prodash v28.0.0
Checking timeago v0.4.2
Checking smallvec v1.13.2
Checking gix-features v0.38.2
Compiling lock_api v0.4.11
Compiling parking_lot_core v0.9.9
Checking scopeguard v1.2.0
Checking powerfmt v0.2.0
Compiling time-core v0.1.2
Compiling num-conv v0.1.0
Checking deranged v0.3.11
Compiling time-macros v0.2.18
Checking home v0.5.9
Checking num_threads v0.1.7
Checking gix-path v0.10.9
Checking parking_lot v0.12.1
Checking winnow v0.6.8
Checking gix-validate v0.8.5
Checking gix-chunk v0.4.8
Checking memmap2 v0.9.4
Checking shell-words v1.1.0
Checking gix-command v0.3.6
Checking gix-commitgraph v0.24.3
Checking time v0.3.36
Checking gix-hashtable v0.5.2
Checking gix-url v0.27.3
Checking gix-config-value v0.14.6
Checking gix-fs v0.11.2
Checking gix-quote v0.4.12
Checking gix-sec v0.10.6
Checking gix-tempfile v14.0.1
Checking gix-prompt v0.8.4
Checking gix-packetline v0.17.5
Checking gix-credentials v0.24.2
Checking gix-transport v0.42.0
Compiling maybe-async v0.2.10
Checking arc-swap v1.7.1
Checking popol v3.0.0
Checking either v1.11.0
Checking io-reactor v0.5.2
Checking gix-date v0.8.7
Checking gix-actor v0.31.5
Checking salsa20 v0.10.2
Checking socket2 v0.5.7
Checking gix-object v0.42.3
Checking gix-protocol v0.45.0
Checking siphasher v0.3.11
Compiling radicle-node v0.10.0 (/df8f6a32-4e20-400f-9511-3aa140e327ef/w/radicle-node)
Checking bloomy v1.2.0
Checking netservices v0.8.0
Checking gix-revwalk v0.13.2
Checking gix-traverse v0.39.2
Checking gix-diff v0.44.1
Checking scrypt v0.11.0
Checking radicle-systemd v0.9.0 (/df8f6a32-4e20-400f-9511-3aa140e327ef/w/radicle-systemd)
Compiling qcheck-macros v1.0.0
Compiling radicle-remote-helper v0.10.0 (/df8f6a32-4e20-400f-9511-3aa140e327ef/w/radicle-remote-helper)
Checking gix-pack v0.51.1
Checking gix-odb v0.61.1
Checking git2 v0.19.0
Checking radicle-git-ext v0.8.0
Checking radicle-term v0.11.0 (/df8f6a32-4e20-400f-9511-3aa140e327ef/w/radicle-term)
Checking radicle-crypto v0.11.0 (/df8f6a32-4e20-400f-9511-3aa140e327ef/w/radicle-crypto)
Checking radicle-cob v0.12.0 (/df8f6a32-4e20-400f-9511-3aa140e327ef/w/radicle-cob)
Checking radicle-crdt v0.1.0 (/df8f6a32-4e20-400f-9511-3aa140e327ef/w/radicle-crdt)
Checking radicle v0.13.0 (/df8f6a32-4e20-400f-9511-3aa140e327ef/w/radicle)
Checking radicle-cli-test v0.10.0 (/df8f6a32-4e20-400f-9511-3aa140e327ef/w/radicle-cli-test)
Checking radicle-fetch v0.10.0 (/df8f6a32-4e20-400f-9511-3aa140e327ef/w/radicle-fetch)
error: all variants have the same prefix: `File`
--> radicle-cli/src/commands/patch/review/builder.rs:140:1
|
140 | / pub enum ReviewItem {
141 | | FileAdded {
142 | | path: PathBuf,
143 | | header: FileHeader,
... |
178 | | },
179 | | }
| |_^
|
= help: remove the prefixes and use full paths to the variants instead of glob imports
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
= note: `-D clippy::enum-variant-names` implied by `-D clippy::all`
= help: to override `-D clippy::all` add `#[allow(clippy::enum_variant_names)]`
error: very complex type used. Consider factoring parts into `type` definitions
--> radicle-cli/src/commands/patch/review/builder.rs:195:24
|
195 | fn paths(&self) -> (Option<(&Path, Oid)>, Option<(&Path, Oid)>) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `-D clippy::type-complexity` implied by `-D clippy::all`
= help: to override `-D clippy::all` add `#[allow(clippy::type_complexity)]`
error: could not compile `radicle-cli` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
error: redundant pattern matching, consider using `is_ok()`
--> radicle-node/src/tests/e2e.rs:1294:17
|
1294 | assert!(matches!(
| _________________^
1295 | | repo.backend.find_reference(issue_ref.as_str()),
1296 | | Ok(_)
1297 | | ));
| |_________^ help: try: `repo.backend.find_reference(issue_ref.as_str()).is_ok()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
= note: `-D clippy::redundant-pattern-matching` implied by `-D clippy::all`
= help: to override `-D clippy::all` add `#[allow(clippy::redundant_pattern_matching)]`
error: could not compile `radicle-node` (lib test) due to 1 previous error
Exit code: 101
{
"response": "finished",
"result": "failure"
}