rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5 heartwood06aa51ab784cd00a1e1efa7908963f5956ad24ba
{
"request": "trigger",
"version": 1,
"event_type": "patch",
"repository": {
"id": "rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5",
"name": "heartwood",
"description": "Radicle Heartwood Protocol & Stack",
"private": false,
"default_branch": "master",
"delegates": [
"did:key:z6MksFqXN3Yhqk8pTJdUGLwATkRfQvwZXPqR2qMEhbS9wzpT",
"did:key:z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM",
"did:key:z6MkkPvBfjP4bQmco5Dm7UGsX2ruDBieEHi8n9DVJWX5sTEz"
]
},
"action": "Created",
"patch": {
"id": "093e668517ad84d23c2274804f2b579ebcfcd40c",
"author": {
"id": "did:key:z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM",
"alias": null
},
"title": "cli: improve passphrase input experience",
"state": {
"status": "archived",
"conflicts": []
},
"before": "0581c017ae1fa7cd3d553c855c439d40e12357e9",
"after": "06aa51ab784cd00a1e1efa7908963f5956ad24ba",
"commits": [
"06aa51ab784cd00a1e1efa7908963f5956ad24ba"
],
"target": "919d5c780c4da0b5b9f18f1549bc59dffd7125af",
"labels": [],
"assignees": [],
"revisions": [
{
"id": "093e668517ad84d23c2274804f2b579ebcfcd40c",
"author": {
"id": "did:key:z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM",
"alias": null
},
"description": "When an incorrect passphrase is entered, the characters are not\nremoved. Unfortunately, this is due to the upstream library we are\nusing[[0]].\n\nTo improve the experience, however, the `with_display_toggle_enabled`\ncan be used to reveal the user's input using the Ctrl+R hotkey. They\ncan then reveal the password, if able to, and fix the problematic\ninput.\n\nOnce the feature request in the upstream library is made, that can be\nused instead.\n\n[0]: https://github.com/mikaelmello/inquire/issues/108#issuecomment-2015745056",
"base": "0581c017ae1fa7cd3d553c855c439d40e12357e9",
"oid": "06aa51ab784cd00a1e1efa7908963f5956ad24ba",
"timestamp": 1711134843
}
]
}
}
{
"response": "triggered",
"run_id": {
"id": "d2ebe884-78ff-40a2-90e0-97d7791f0b70"
},
"info_url": "https://cci.rad.levitte.org//d2ebe884-78ff-40a2-90e0-97d7791f0b70.html"
}
Started at: 2026-09-07 18:42:57.579761+02:00
Commands:
$ rad clone rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5 .
✓ Creating checkout in ./...
✓ Remote cloudhead@z6MksFqXN3Yhqk8pTJdUGLwATkRfQvwZXPqR2qMEhbS9wzpT added
✓ Remote-tracking branch cloudhead@z6MksFqXN3Yhqk8pTJdUGLwATkRfQvwZXPqR2qMEhbS9wzpT/master created for z6MksFqXN3Yhqk8pTJdUGLwATkRfQvwZXPqR2qMEhbS9wzpT
✓ Remote fintohaps@z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM added
✓ Remote-tracking branch fintohaps@z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM/master created for z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM
✓ Remote lorenz@z6MkkPvBfjP4bQmco5Dm7UGsX2ruDBieEHi8n9DVJWX5sTEz added
✓ Remote-tracking branch lorenz@z6MkkPvBfjP4bQmco5Dm7UGsX2ruDBieEHi8n9DVJWX5sTEz/master created for z6MkkPvBfjP4bQmco5Dm7UGsX2ruDBieEHi8n9DVJWX5sTEz
✓ Repository successfully cloned under /opt/radcis/ci.rad.levitte.org/cci/state/d2ebe884-78ff-40a2-90e0-97d7791f0b70/w/
╭────────────────────────────────────╮
│ heartwood │
│ Radicle Heartwood Protocol & Stack │
│ 189 issues · 37 patches │
╰────────────────────────────────────╯
Run `cd ./.` to go to the repository directory.
Exit code: 0
$ rad patch checkout 093e668517ad84d23c2274804f2b579ebcfcd40c
✓ Switched to branch patch/093e668 at revision 093e668
✓ Branch patch/093e668 setup to track rad/patches/093e668517ad84d23c2274804f2b579ebcfcd40c
Exit code: 0
$ git config advice.detachedHead false
Exit code: 0
$ git checkout 06aa51ab784cd00a1e1efa7908963f5956ad24ba
HEAD is now at 06aa51ab cli: improve passphrase input experience
Exit code: 0
$ rad patch show 093e668517ad84d23c2274804f2b579ebcfcd40c -p
╭────────────────────────────────────────────────────────────────────────────────╮
│ Title cli: improve passphrase input experience │
│ Patch 093e668517ad84d23c2274804f2b579ebcfcd40c │
│ Author fintohaps z6Mkire…SQZ3voM │
│ Head 06aa51ab784cd00a1e1efa7908963f5956ad24ba │
│ Base 0581c017ae1fa7cd3d553c855c439d40e12357e9 │
│ Target master │
│ Branches patch/093e668 │
│ Commits ahead 1, behind 1499 │
│ Status archived │
│ │
│ When an incorrect passphrase is entered, the characters are not │
│ removed. Unfortunately, this is due to the upstream library we are │
│ using[[0]]. │
│ │
│ To improve the experience, however, the `with_display_toggle_enabled` │
│ can be used to reveal the user's input using the Ctrl+R hotkey. They │
│ can then reveal the password, if able to, and fix the problematic │
│ input. │
│ │
│ Once the feature request in the upstream library is made, that can be │
│ used instead. │
│ │
│ [0]: https://github.com/mikaelmello/inquire/issues/108#issuecomment-2015745056 │
├────────────────────────────────────────────────────────────────────────────────┤
│ 06aa51a cli: improve passphrase input experience │
├────────────────────────────────────────────────────────────────────────────────┤
│ ● Revision 093e668 @ 0581c01..06aa51a by fintohaps z6Mkire…SQZ3voM 2 years ago │
╰────────────────────────────────────────────────────────────────────────────────╯
commit 06aa51ab784cd00a1e1efa7908963f5956ad24ba
Author: Fintan Halpenny <fintan.halpenny@gmail.com>
Date: Fri Mar 22 19:11:05 2024 +0000
cli: improve passphrase input experience
When an incorrect passphrase is entered, the characters are not
removed. Unfortunately, this is due to the upstream library we are
using[[0]].
To improve the experience, however, the `with_display_toggle_enabled`
can be used to reveal the user's input using the Ctrl+R hotkey. They
can then reveal the password, if able to, and fix the problematic
input.
Once the feature request in the upstream library is made, that can be
used instead.
[0]: https://github.com/mikaelmello/inquire/issues/108#issuecomment-2015745056
Signed-off-by: Fintan Halpenny <fintan.halpenny@gmail.com>
X-Clacks-Overhead: GNU Terry Pratchett
diff --git a/radicle-term/src/io.rs b/radicle-term/src/io.rs
index 252c8a9a8..44698d2bd 100644
--- a/radicle-term/src/io.rs
+++ b/radicle-term/src/io.rs
@@ -222,9 +222,10 @@ pub fn passphrase<V: validator::StringValidator + 'static>(
validate: V,
) -> Result<Passphrase, inquire::InquireError> {
Ok(Passphrase::from(
- Password::new("Passphrase:")
+ Password::new("Passphrase (use Ctrl+R to reveal input):")
.with_render_config(*CONFIG)
.with_display_mode(inquire::PasswordDisplayMode::Masked)
+ .with_display_toggle_enabled()
.without_confirmation()
.with_validator(validate)
.prompt()?,
Exit code: 0
shell: 'cargo --version rustc --version cargo fmt --check cargo clippy --all-targets --workspace -- --deny clippy::all cargo build --all-targets --workspace cargo doc --workspace cargo test --workspace --no-fail-fast '
Commands:
$ podman run --name d2ebe884-78ff-40a2-90e0-97d7791f0b70 -v /opt/radcis/ci.rad.levitte.org/cci/state/d2ebe884-78ff-40a2-90e0-97d7791f0b70/s:/d2ebe884-78ff-40a2-90e0-97d7791f0b70/s:ro -v /opt/radcis/ci.rad.levitte.org/cci/state/d2ebe884-78ff-40a2-90e0-97d7791f0b70/w:/d2ebe884-78ff-40a2-90e0-97d7791f0b70/w -w /d2ebe884-78ff-40a2-90e0-97d7791f0b70/w -v /opt/radcis/ci.rad.levitte.org/.radicle:/${id}/.radicle:ro -e RAD_HOME=/${id}/.radicle rust:trixie bash /d2ebe884-78ff-40a2-90e0-97d7791f0b70/s/script.sh
+ cargo --version
info: syncing channel updates for '1.74-x86_64-unknown-linux-gnu'
info: latest update on 2023-12-07, rust version 1.74.1 (a28077b28 2023-12-04)
info: downloading component 'cargo'
info: downloading component 'rust-std'
info: downloading component 'rustc'
info: installing component 'cargo'
info: installing component 'rust-std'
info: installing component 'rustc'
cargo 1.74.1 (ecb9851af 2023-10-18)
+ rustc --version
rustc 1.74.1 (a28077b28 2023-12-04)
+ cargo fmt --check
error: 'cargo-fmt' is not installed for the toolchain '1.74-x86_64-unknown-linux-gnu'.
To install, run `rustup component add --toolchain 1.74-x86_64-unknown-linux-gnu rustfmt`
Exit code: 1
{
"response": "finished",
"result": "failure"
}