rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5 heartwood1f0d2ce14c00790f412efc1a7717c76751521db4
{
"request": "trigger",
"version": 1,
"event_type": "patch",
"repository": {
"id": "rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5",
"name": "heartwood",
"description": "Radicle Heartwood Protocol & Stack",
"private": false,
"default_branch": "master",
"delegates": [
"did:key:z6MksFqXN3Yhqk8pTJdUGLwATkRfQvwZXPqR2qMEhbS9wzpT",
"did:key:z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM",
"did:key:z6MkkPvBfjP4bQmco5Dm7UGsX2ruDBieEHi8n9DVJWX5sTEz"
]
},
"action": "Created",
"patch": {
"id": "a0aa156fa6ab1534182ca5aab716392f632cd5ac",
"author": {
"id": "did:key:z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM",
"alias": null
},
"title": "node: use `TempDir::close` in clone",
"state": {
"status": "archived",
"conflicts": []
},
"before": "6ab3bfcba0577fabdcb84498441c6605391290f4",
"after": "1f0d2ce14c00790f412efc1a7717c76751521db4",
"commits": [
"1f0d2ce14c00790f412efc1a7717c76751521db4"
],
"target": "3fc92f83fe089263c470b328414d923227cf0e4a",
"labels": [],
"assignees": [],
"revisions": [
{
"id": "a0aa156fa6ab1534182ca5aab716392f632cd5ac",
"author": {
"id": "did:key:z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM",
"alias": null
},
"description": "It was reported that on WSL after dropping `TempDir` there are still open file\nhandles.\n\nAttempt to close the `TempDir` and any open file handles, if possible -- logging\nthe error, if any.",
"base": "6ab3bfcba0577fabdcb84498441c6605391290f4",
"oid": "1f0d2ce14c00790f412efc1a7717c76751521db4",
"timestamp": 1715251877
}
]
}
}
{
"response": "triggered",
"run_id": {
"id": "c696f619-dd35-4b6d-8d4e-6253ecbc7544"
},
"info_url": "https://cci.rad.levitte.org//c696f619-dd35-4b6d-8d4e-6253ecbc7544.html"
}
Started at: 2026-09-08 01:48:41.514919+02:00
Commands:
$ rad clone rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5 .
✓ Creating checkout in ./...
✓ Remote cloudhead@z6MksFqXN3Yhqk8pTJdUGLwATkRfQvwZXPqR2qMEhbS9wzpT added
✓ Remote-tracking branch cloudhead@z6MksFqXN3Yhqk8pTJdUGLwATkRfQvwZXPqR2qMEhbS9wzpT/master created for z6MksFqXN3Yhqk8pTJdUGLwATkRfQvwZXPqR2qMEhbS9wzpT
✓ Remote fintohaps@z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM added
✓ Remote-tracking branch fintohaps@z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM/master created for z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM
✓ Remote lorenz@z6MkkPvBfjP4bQmco5Dm7UGsX2ruDBieEHi8n9DVJWX5sTEz added
✓ Remote-tracking branch lorenz@z6MkkPvBfjP4bQmco5Dm7UGsX2ruDBieEHi8n9DVJWX5sTEz/master created for z6MkkPvBfjP4bQmco5Dm7UGsX2ruDBieEHi8n9DVJWX5sTEz
✓ Repository successfully cloned under /opt/radcis/ci.rad.levitte.org/cci/state/c696f619-dd35-4b6d-8d4e-6253ecbc7544/w/
╭────────────────────────────────────╮
│ heartwood │
│ Radicle Heartwood Protocol & Stack │
│ 189 issues · 38 patches │
╰────────────────────────────────────╯
Run `cd ./.` to go to the repository directory.
Exit code: 0
$ rad patch checkout a0aa156fa6ab1534182ca5aab716392f632cd5ac
✓ Switched to branch patch/a0aa156 at revision a0aa156
✓ Branch patch/a0aa156 setup to track rad/patches/a0aa156fa6ab1534182ca5aab716392f632cd5ac
Exit code: 0
$ git config advice.detachedHead false
Exit code: 0
$ git checkout 1f0d2ce14c00790f412efc1a7717c76751521db4
HEAD is now at 1f0d2ce1 node: use `TempDir::close` in clone
Exit code: 0
$ rad patch show a0aa156fa6ab1534182ca5aab716392f632cd5ac -p
╭──────────────────────────────────────────────────────────────────────────────────╮
│ Title node: use `TempDir::close` in clone │
│ Patch a0aa156fa6ab1534182ca5aab716392f632cd5ac │
│ Author fintohaps z6Mkire…SQZ3voM │
│ Head 1f0d2ce14c00790f412efc1a7717c76751521db4 │
│ Base 6ab3bfcba0577fabdcb84498441c6605391290f4 │
│ Target master │
│ Branches patch/a0aa156 │
│ Commits ahead 1, behind 1372 │
│ Status archived │
│ │
│ It was reported that on WSL after dropping `TempDir` there are still open file │
│ handles. │
│ │
│ Attempt to close the `TempDir` and any open file handles, if possible -- logging │
│ the error, if any. │
├──────────────────────────────────────────────────────────────────────────────────┤
│ 1f0d2ce node: use `TempDir::close` in clone │
├──────────────────────────────────────────────────────────────────────────────────┤
│ ● Revision a0aa156 @ 6ab3bfc..1f0d2ce by fintohaps z6Mkire…SQZ3voM 2 years ago │
╰──────────────────────────────────────────────────────────────────────────────────╯
commit 1f0d2ce14c00790f412efc1a7717c76751521db4
Author: Fintan Halpenny <fintan.halpenny@gmail.com>
Date: Thu May 9 11:49:29 2024 +0100
node: use `TempDir::close` in clone
It was reported that on WSL after dropping `TempDir` there are still open file
handles.
Attempt to close the `TempDir` and any open file handles, if possible -- logging
the error, if any.
Signed-off-by: Fintan Halpenny <fintan.halpenny@gmail.com>
X-Clacks-Overhead: GNU Terry Pratchett
diff --git a/radicle-node/src/worker/fetch.rs b/radicle-node/src/worker/fetch.rs
index bed41ab81..f8a8a9780 100644
--- a/radicle-node/src/worker/fetch.rs
+++ b/radicle-node/src/worker/fetch.rs
@@ -186,6 +186,13 @@ fn mv(tmp: tempfile::TempDir, storage: &Storage, rid: &RepoId) -> Result<(), err
.into());
}
+ // N.b. Attempt to explicitly close the `TempDir`, since open file handles
+ // causes issues on WSL
+ let path = tmp.path().to_path_buf();
+ if let Err(e) = tmp.close() {
+ log::warn!(target: "worker", "Failed to cleanup temporary repository path {:?}: {e}", path);
+ }
+
Ok(())
}
Exit code: 0
shell: 'cargo --version rustc --version cargo fmt --check cargo clippy --all-targets --workspace -- --deny clippy::all cargo build --all-targets --workspace cargo doc --workspace cargo test --workspace --no-fail-fast '
Commands:
$ podman run --name c696f619-dd35-4b6d-8d4e-6253ecbc7544 -v /opt/radcis/ci.rad.levitte.org/cci/state/c696f619-dd35-4b6d-8d4e-6253ecbc7544/s:/c696f619-dd35-4b6d-8d4e-6253ecbc7544/s:ro -v /opt/radcis/ci.rad.levitte.org/cci/state/c696f619-dd35-4b6d-8d4e-6253ecbc7544/w:/c696f619-dd35-4b6d-8d4e-6253ecbc7544/w -w /c696f619-dd35-4b6d-8d4e-6253ecbc7544/w -v /opt/radcis/ci.rad.levitte.org/.radicle:/${id}/.radicle:ro -e RAD_HOME=/${id}/.radicle rust:trixie bash /c696f619-dd35-4b6d-8d4e-6253ecbc7544/s/script.sh
+ cargo --version
info: syncing channel updates for '1.77-x86_64-unknown-linux-gnu'
info: latest update on 2024-04-09, rust version 1.77.2 (25ef9e3d8 2024-04-09)
info: downloading component 'cargo'
info: downloading component 'rust-std'
info: downloading component 'rustc'
info: installing component 'cargo'
info: installing component 'rust-std'
info: installing component 'rustc'
cargo 1.77.2 (e52e36006 2024-03-26)
+ rustc --version
rustc 1.77.2 (25ef9e3d8 2024-04-09)
+ cargo fmt --check
error: 'cargo-fmt' is not installed for the toolchain '1.77-x86_64-unknown-linux-gnu'.
To install, run `rustup component add --toolchain 1.77-x86_64-unknown-linux-gnu rustfmt`
Exit code: 1
{
"response": "finished",
"result": "failure"
}