rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5 heartwoodd46587a98e20efb165c1b7fa81dac8c16c32d402
{
"request": "trigger",
"version": 1,
"event_type": "patch",
"repository": {
"id": "rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5",
"name": "heartwood",
"description": "Radicle Heartwood Protocol & Stack",
"private": false,
"default_branch": "master",
"delegates": [
"did:key:z6MksFqXN3Yhqk8pTJdUGLwATkRfQvwZXPqR2qMEhbS9wzpT",
"did:key:z6MktaNvN1KVFMkSRAiN4qK5yvX1zuEEaseeX5sffhzPZRZW",
"did:key:z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM",
"did:key:z6MkgFq6z5fkF2hioLLSNu1zP2qEL1aHXHZzGH1FLFGAnBGz",
"did:key:z6MkkPvBfjP4bQmco5Dm7UGsX2ruDBieEHi8n9DVJWX5sTEz"
]
},
"action": "Updated",
"patch": {
"id": "c4d7407924da99d09988cf92efefdf26e4b47668",
"author": {
"id": "did:key:z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM",
"alias": "fintohaps"
},
"title": "Sans-IO Connection Management",
"state": {
"status": "open",
"conflicts": []
},
"before": "9cdd08ab83c92a212dbe52f93908a26f15879afd",
"after": "d46587a98e20efb165c1b7fa81dac8c16c32d402",
"commits": [
"d46587a98e20efb165c1b7fa81dac8c16c32d402",
"be76721d492de8dd422577602aed7eb6644972c0",
"c8095f343ec356105d492cd1a26a5efe4f88f49b",
"4bfc8fff53a9e4ccd51904c6dca610330568850b",
"5358735530e98f50b023a196518f812ce0607b92",
"7ad3b3c8ea855ef687eb1647f8cb283bdcc841f5",
"d7ba3a243fb81e5d6160b5404957213b2b65dbca"
],
"target": "d2ab7b1b46935c95a46d0e7ddac3130b595eb15a",
"labels": [],
"assignees": [],
"revisions": [
{
"id": "c4d7407924da99d09988cf92efefdf26e4b47668",
"author": {
"id": "did:key:z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM",
"alias": "fintohaps"
},
"description": "This patch defines the connection session management in a sans-IO\nfashion, and replaces the old logic in `Service`.\n\nIt is stacked on [patches/806043519e7439bebe26a66b247025ef5a7f8ef0](https://app.radicle.xyz/nodes/rosa.radicle.xyz/rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5/patches/806043519e7439bebe26a66b247025ef5a7f8ef0).",
"base": "a1c445fe8f3f7ef7f71d2159405d46edabdf3833",
"oid": "f2c71f424cdbfdbfa08a3e60f282eff9bd97ba09",
"timestamp": 1766601700
},
{
"id": "762c79b1a2a5616a4a2f7cd88f55ac0190bab160",
"author": {
"id": "did:key:z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM",
"alias": "fintohaps"
},
"description": "Rebase",
"base": "400573526421cebe8b5b4e3bfd1dbd5f349da147",
"oid": "a0480fff8237586945bd881070f3e3ea69cf3eb7",
"timestamp": 1767712650
},
{
"id": "da74376f141f9e82bd35bf55375101c4c36c9854",
"author": {
"id": "did:key:z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM",
"alias": "fintohaps"
},
"description": "Rebase",
"base": "6e0692a9a815855e7fe091cc6f0838980f3e3ce3",
"oid": "d20e3609784f8c842f25cb92f1270c2b009f1813",
"timestamp": 1768321430
},
{
"id": "641094e312d21bb0d79c097d4cbeee00f94bc8b6",
"author": {
"id": "did:key:z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM",
"alias": "fintohaps"
},
"description": "Changes:\n- Rebase\n- Adjusted log levels",
"base": "9cdd08ab83c92a212dbe52f93908a26f15879afd",
"oid": "d46587a98e20efb165c1b7fa81dac8c16c32d402",
"timestamp": 1769447954
}
]
}
}
{
"response": "triggered",
"run_id": {
"id": "7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec"
},
"info_url": "https://cci.rad.levitte.org//7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec.html"
}
Started at: 2026-01-26 18:19:17.171994+01:00
Commands:
$ rad clone rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5 .
✓ Creating checkout in ./...
✓ Remote cloudhead@z6MksFqXN3Yhqk8pTJdUGLwATkRfQvwZXPqR2qMEhbS9wzpT added
✓ Remote-tracking branch cloudhead@z6MksFqXN3Yhqk8pTJdUGLwATkRfQvwZXPqR2qMEhbS9wzpT/master created for z6MksFqXN3Yhqk8pTJdUGLwATkRfQvwZXPqR2qMEhbS9wzpT
✓ Remote cloudhead@z6MktaNvN1KVFMkSRAiN4qK5yvX1zuEEaseeX5sffhzPZRZW added
✓ Remote-tracking branch cloudhead@z6MktaNvN1KVFMkSRAiN4qK5yvX1zuEEaseeX5sffhzPZRZW/master created for z6MktaNvN1KVFMkSRAiN4qK5yvX1zuEEaseeX5sffhzPZRZW
✓ Remote fintohaps@z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM added
✓ Remote-tracking branch fintohaps@z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM/master created for z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM
✓ Remote erikli@z6MkgFq6z5fkF2hioLLSNu1zP2qEL1aHXHZzGH1FLFGAnBGz added
✓ Remote-tracking branch erikli@z6MkgFq6z5fkF2hioLLSNu1zP2qEL1aHXHZzGH1FLFGAnBGz/master created for z6MkgFq6z5fkF2hioLLSNu1zP2qEL1aHXHZzGH1FLFGAnBGz
✓ Remote lorenz@z6MkkPvBfjP4bQmco5Dm7UGsX2ruDBieEHi8n9DVJWX5sTEz added
✓ Remote-tracking branch lorenz@z6MkkPvBfjP4bQmco5Dm7UGsX2ruDBieEHi8n9DVJWX5sTEz/master created for z6MkkPvBfjP4bQmco5Dm7UGsX2ruDBieEHi8n9DVJWX5sTEz
✓ Repository successfully cloned under /opt/radcis/ci.rad.levitte.org/cci/state/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/
╭────────────────────────────────────╮
│ heartwood │
│ Radicle Heartwood Protocol & Stack │
│ 136 issues · 18 patches │
╰────────────────────────────────────╯
Run `cd ./.` to go to the repository directory.
Exit code: 0
$ rad patch checkout c4d7407924da99d09988cf92efefdf26e4b47668
✓ Switched to branch patch/c4d7407 at revision 641094e
✓ Branch patch/c4d7407 setup to track rad/patches/c4d7407924da99d09988cf92efefdf26e4b47668
Exit code: 0
$ git config advice.detachedHead false
Exit code: 0
$ git checkout d46587a98e20efb165c1b7fa81dac8c16c32d402
HEAD is now at d46587a9 protocol/connections: testing Connections
Exit code: 0
$ rad patch show c4d7407924da99d09988cf92efefdf26e4b47668 -p
╭────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ Title Sans-IO Connection Management │
│ Patch c4d7407924da99d09988cf92efefdf26e4b47668 │
│ Author fintohaps z6Mkire…SQZ3voM │
│ Head d46587a98e20efb165c1b7fa81dac8c16c32d402 │
│ Base 9cdd08ab83c92a212dbe52f93908a26f15879afd │
│ Branches patch/c4d7407 │
│ Commits ahead 11, behind 0 │
│ Status open │
│ │
│ This patch defines the connection session management in a sans-IO │
│ fashion, and replaces the old logic in `Service`. │
│ │
│ It is stacked on │
│ [patches/806043519e7439bebe26a66b247025ef5a7f8ef0](https://app.radicle.xyz/nodes/rosa.radicle.xyz/rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5/patches/806043519e7439bebe26a66b247025ef5a7f8ef0). │
├────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ d46587a protocol/connections: testing Connections │
│ be76721 protocol/connections: noting not using the address during connected │
│ c8095f3 protocol/connections: ensure no sessions for local node │
│ 4bfc8ff protocol/service: wire up connections management │
│ 5358735 protocol/connections: refactor config │
│ 7ad3b3c protocol: connections manager │
│ d7ba3a2 protocol: session state │
├────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ ● Revision c4d7407 @ f2c71f4 by fintohaps z6Mkire…SQZ3voM 1 month ago │
│ ↑ Revision 762c79b @ a0480ff by fintohaps z6Mkire…SQZ3voM 2 weeks ago │
│ ↑ Revision da74376 @ d20e360 by fintohaps z6Mkire…SQZ3voM 1 week ago │
│ ↑ Revision 641094e @ d46587a by fintohaps z6Mkire…SQZ3voM 4 seconds ago │
╰────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
commit d46587a98e20efb165c1b7fa81dac8c16c32d402
Author: Fintan Halpenny <fintan.halpenny@gmail.com>
Date: Wed Dec 17 14:24:09 2025 +0000
protocol/connections: testing Connections
Adds property based tests to ensure the correctness of the
`Connections` logic.
The basis of the tests is to ensure that the state transitions are
correct, and that the machine cannot end up in an unexpected state.
There are also tests that ensure that certain state is preserved
across transitions, as well as other domain logic.
Disclaimer: the basis of the test suite was generated using Claude
with human input on what properties to start off with. All generated
code was reviewed for correctness and modified to fit the style of the
project as best as possible.
Squash to tests
diff --git a/crates/radicle-protocol/src/connections/state.rs b/crates/radicle-protocol/src/connections/state.rs
index 592004a8d..4826036e8 100644
--- a/crates/radicle-protocol/src/connections/state.rs
+++ b/crates/radicle-protocol/src/connections/state.rs
@@ -1,6 +1,9 @@
pub mod command;
pub mod event;
+#[cfg(test)]
+mod test;
+
use std::net::IpAddr;
use localtime::{LocalDuration, LocalTime};
diff --git a/crates/radicle-protocol/src/connections/state/test.rs b/crates/radicle-protocol/src/connections/state/test.rs
new file mode 100644
index 000000000..b97a88b00
--- /dev/null
+++ b/crates/radicle-protocol/src/connections/state/test.rs
@@ -0,0 +1,3139 @@
+//! Property-Based Tests for Connection State Management
+
+mod arbitrary;
+use arbitrary::{ArbitraryTime, NonLocalNode, RoutableAddress, TestCommand};
+
+mod invariants;
+use invariants::{check_invariants, get_session_state, is_invalid_transition, SessionState};
+
+use std::collections::{HashMap, HashSet};
+use std::net::{IpAddr, Ipv4Addr, Ipv6Addr};
+
+use localtime::{LocalDuration, LocalTime};
+use qcheck::{Arbitrary, Gen, TestResult};
+use qcheck_macros::quickcheck;
+use radicle::crypto;
+use radicle::node::config::{RateLimit, RateLimits};
+use radicle::node::{Address, HostName, Link, NodeId, Timestamp};
+use radicle::prelude::RepoId;
+
+use crate::connections::config;
+use crate::connections::config::{
+ ReconnectionDelay, MAX_RECONNECTION_DELTA, MIN_RECONNECTION_DELTA,
+};
+use crate::connections::session::{ConnectionType, Pong};
+use crate::connections::state::{command, event, Connections};
+use crate::connections::{Attempts, Config};
+use crate::service::filter::Filter;
+use crate::service::limiter::RateLimiter;
+use crate::service::DisconnectReason;
+use crate::service::{message, MAX_LATENCIES};
+
+// =============================================================================
+// Test Helpers
+// =============================================================================
+
+fn test_config() -> Config {
+ let durations = config::Durations {
+ idle: LocalDuration::from_secs(60),
+ keep_alive: LocalDuration::from_secs(30),
+ stale: LocalDuration::from_secs(120),
+ reconnection_delay: ReconnectionDelay::default(),
+ };
+ let limits = RateLimits::default();
+ let inbound = config::Inbound {
+ rate_limit: limits.inbound.into(),
+ maximum: 10,
+ };
+ let outbound = config::Outbound {
+ rate_limit: limits.outbound.into(),
+ target: 8,
+ };
+ Config {
+ durations,
+ inbound,
+ outbound,
+ }
+}
+
+fn new_connections(local: NodeId) -> Connections {
+ Connections::new(local, test_config(), RateLimiter::default())
+}
+
+fn test_config_low_limits() -> Config {
+ let durations = config::Durations {
+ idle: LocalDuration::from_secs(60),
+ keep_alive: LocalDuration::from_secs(30),
+ stale: LocalDuration::from_secs(120),
+ reconnection_delay: ReconnectionDelay::default(),
+ };
+ let inbound = config::Inbound {
+ rate_limit: RateLimit {
+ capacity: 1,
+ fill_rate: 0.0,
+ }, // 1 token, no refill
+ maximum: 10,
+ };
+ let outbound = config::Outbound {
+ rate_limit: RateLimit {
+ capacity: 1,
+ fill_rate: 0.0,
+ },
+ target: 8,
+ };
+ Config {
+ durations,
+ inbound,
+ outbound,
+ }
+}
+
+fn new_connections_with_low_limits(local: NodeId) -> Connections {
+ Connections::new(local, test_config_low_limits(), RateLimiter::default())
+}
+
+fn apply_command(connections: &mut Connections, cmd: TestCommand, time: &mut LocalTime) {
+ *time = *time + LocalDuration::from_secs(1);
+ let now = *time;
+
+ match cmd {
+ TestCommand::Accept { ip } => {
+ connections.accept(command::Accept { ip }, now);
+ }
+ TestCommand::Connect {
+ node,
+ addr,
+ connection_type,
+ } => {
+ connections.connect(
+ command::Connect {
+ node,
+ addr,
+ connection_type,
+ },
+ now,
+ );
+ }
+ TestCommand::Attempt { node } => {
+ connections.attempted(command::Attempt { node });
+ }
+ TestCommand::ConnectedInbound {
+ node,
+ addr,
+ connection_type,
+ } => {
+ connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr,
+ connection_type,
+ },
+ now,
+ );
+ }
+ TestCommand::ConnectedOutbound {
+ node,
+ addr,
+ connection_type,
+ } => {
+ connections.connected(
+ command::Connected::Outbound {
+ node,
+ addr,
+ connection_type,
+ },
+ now,
+ );
+ }
+ TestCommand::Disconnect {
+ node,
+ link,
+ connection_type,
+ } => {
+ connections.disconnected(
+ command::Disconnect {
+ node,
+ link,
+ since: now,
+ connection_type,
+ },
+ &DisconnectReason::Command,
+ );
+ }
+ TestCommand::Reconnect { node } => {
+ connections.reconnect(command::Reconnect { node });
+ }
+ TestCommand::Message {
+ node,
+ connection_type,
+ } => {
+ connections.handle_message(
+ command::Message {
+ node,
+ payload: None,
+ connection_type,
+ },
+ now,
+ );
+ }
+ }
+}
+
+// =============================================================================
+// Session Uniqueness Properties
+// =============================================================================
+
+/// Single Session Per Node
+///
+/// After any sequence of commands, no node appears in more than one state collection.
+///
+/// ∀ node ∈ NodeId:
+/// |{s ∈ initial | s.node = node}| +
+/// |{s ∈ attempted | s.node = node}| +
+/// |{s ∈ connected | s.node = node}| +
+/// |{s ∈ disconnected | s.node = node}| ≤ 1
+#[quickcheck]
+fn prop_single_session_per_node(commands: Vec<TestCommand>) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+ let mut time = LocalTime::from_secs(1577836800);
+
+ for cmd in commands {
+ apply_command(&mut connections, cmd, &mut time);
+ }
+
+ match invariants::check_single_session_per_node(connections.sessions()) {
+ Ok(()) => TestResult::passed(),
+ Err(e) => TestResult::error(e.to_string()),
+ }
+}
+
+/// Local Node Exclusion
+///
+/// The local node should never exist in any session collection.
+///
+/// ∀ state ∈ {Initial, Attempted, Connected, Disconnected}:
+/// local_node ∉ sessions[state].keys()
+#[quickcheck]
+fn prop_local_node_exclusion(commands: Vec<TestCommand>) {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+ let mut time = LocalTime::from_secs(1577836800);
+
+ for cmd in commands {
+ apply_command(&mut connections, cmd, &mut time);
+ }
+
+ assert!(!connections.has_session(&local));
+}
+
+/// Session Existence Consistency
+///
+/// has_session_for(node) is true iff exactly one state check returns true.
+///
+/// has_session_for(node) ⟺
+/// (is_initial(node) ⊕ is_attempted(node) ⊕ is_connected(node) ⊕ is_disconnected(node))
+#[quickcheck]
+fn prop_session_existence_consistency(commands: Vec<TestCommand>) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+ let mut time = LocalTime::from_secs(1577836800);
+
+ for cmd in commands {
+ apply_command(&mut connections, cmd, &mut time);
+ }
+
+ match invariants::check_session_existence_consistency(connections.sessions()) {
+ Ok(()) => TestResult::passed(),
+ Err(e) => TestResult::error(e.to_string()),
+ }
+}
+
+// =============================================================================
+// State Transition Properties
+// =============================================================================
+
+/// All State Transitions Are Valid
+///
+/// No command sequence produces an invalid state transition.
+#[quickcheck]
+fn prop_valid_transitions(commands: Vec<TestCommand>) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+ let mut time = LocalTime::from_secs(1577836800);
+
+ // Track previous state for each node
+ let mut previous_states: HashMap<NodeId, SessionState> = HashMap::new();
+
+ for (i, cmd) in commands.iter().enumerate() {
+ apply_command(&mut connections, cmd.clone(), &mut time);
+
+ // Check all nodes we're tracking
+ let mut to_remove = Vec::new();
+ for (node, prev_state) in previous_states.iter() {
+ match get_session_state(connections.sessions(), node) {
+ Some(current) => {
+ if *prev_state != current && is_invalid_transition(*prev_state, current) {
+ return TestResult::error(format!(
+ "Invalid transition at command {}: {:?} -> {:?} for node {:?}",
+ i, prev_state, current, node
+ ));
+ }
+ }
+ None => {
+ // Session was removed (valid for ephemeral)
+ to_remove.push(*node);
+ }
+ }
+ }
+
+ // Remove tracked nodes that no longer exist
+ for node in to_remove {
+ previous_states.remove(&node);
+ }
+
+ // Update states for all current sessions
+ for (node, _) in connections.sessions().iter() {
+ if let Some(state) = get_session_state(connections.sessions(), node) {
+ previous_states.insert(*node, state);
+ }
+ }
+ }
+
+ TestResult::passed()
+}
+
+// =============================================================================
+// Command Safety Properties
+// =============================================================================
+
+/// Connect Idempotency for Connected Sessions
+///
+/// Calling connect on an already-connected node returns AlreadyConnected.
+///
+/// ∀ node ∈ connected.keys():
+/// let state_before = sessions.clone()
+/// connect(node) = AlreadyConnected
+/// sessions = state_before
+#[quickcheck]
+fn prop_connect_idempotency(
+ NonLocalNode(node): NonLocalNode,
+ addr: Address,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ let event::Connected::Established { session } = connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr: addr.clone(),
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ ) else {
+ return TestResult::error("Expected Established");
+ };
+
+ assert_eq!(
+ connections.connect(
+ command::Connect {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ ),
+ event::Connect::AlreadyConnected { session }
+ );
+ TestResult::passed()
+}
+
+/// Connect Blocked for Disconnected Sessions
+///
+/// Calling connect on a disconnected node returns Disconnected.
+///
+/// ∀ node ∈ disconnected.keys():
+/// connect(node) = Disconnected { node }
+#[quickcheck]
+fn prop_connect_blocked_for_disconnected(
+ NonLocalNode(node): NonLocalNode,
+ addr: Address,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr: addr.clone(),
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+
+ let event::Disconnected::Retry { .. } = connections.disconnected(
+ command::Disconnect {
+ node,
+ link: Link::Inbound,
+ since: now,
+ connection_type: ConnectionType::Persistent,
+ },
+ &DisconnectReason::Command,
+ ) else {
+ return TestResult::error("Expected Retry");
+ };
+
+ assert!(connections.sessions().is_diconnected(&node));
+ assert_eq!(
+ connections.connect(
+ command::Connect {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ ),
+ event::Connect::Disconnected { node }
+ );
+ TestResult::passed()
+}
+
+/// Connect Blocked for Connecting Sessions
+///
+/// Calling connect on Initial/Attempted returns AlreadyConnecting.
+///
+/// ∀ node ∈ (initial.keys() ∪ attempted.keys()):
+/// connect(node) = AlreadyConnecting { node }
+#[quickcheck]
+fn prop_connect_blocked_for_connecting(
+ NonLocalNode(node): NonLocalNode,
+ addr: Address,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ connections.connect(
+ command::Connect {
+ node,
+ addr: addr.clone(),
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+
+ assert_eq!(
+ connections.connect(
+ command::Connect {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ ),
+ event::Connect::AlreadyConnecting { node }
+ );
+ TestResult::passed()
+}
+
+/// Missing Session Handling
+///
+/// Commands requiring existing session return MissingSession when none exists.
+///
+/// ∀ node ∉ sessions.keys():
+/// attempt(node) = MissingSession { node }
+/// ∧ disconnect(node) = MissingSession { node }
+/// ∧ reconnect(node) = MissingSession { node }
+/// ∧ connected_outbound(node) = MissingSession { node }
+#[quickcheck]
+fn prop_missing_session_handling(
+ NonLocalNode(node): NonLocalNode,
+ addr: Address,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ // Attempt on missing session
+ assert_eq!(
+ connections.attempted(command::Attempt { node }),
+ event::Attempted::MissingSession { node }
+ );
+
+ // Disconnect on missing session
+ assert_eq!(
+ connections.disconnected(
+ command::Disconnect {
+ node,
+ link: Link::Inbound,
+ since: now,
+ connection_type: ConnectionType::Persistent
+ },
+ &DisconnectReason::Command
+ ),
+ event::Disconnected::MissingSession { node }
+ );
+
+ // Reconnect on missing session
+ assert_eq!(
+ connections.reconnect(command::Reconnect { node }),
+ event::Reconnect::MissingSession { node }
+ );
+
+ // Connected Outbound on missing session
+ assert_eq!(
+ connections.connected(
+ command::Connected::Outbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent
+ },
+ now
+ ),
+ event::Connected::MissingSession { node }
+ );
+
+ TestResult::passed()
+}
+
+// =============================================================================
+// Link Direction Properties
+// =============================================================================
+
+/// Outbound Link for Outbound Connections
+///
+/// Sessions created via connect have Link::Outbound.
+///
+/// ∀ session created via connect():
+/// session.link = Link::Outbound
+#[quickcheck]
+fn prop_outbound_link(
+ NonLocalNode(node): NonLocalNode,
+ addr: Address,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ connections.connect(
+ command::Connect {
+ node,
+ addr: addr.clone(),
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+
+ match connections.connected(
+ command::Connected::Outbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ ) {
+ event::Connected::Established { session } => {
+ if *session.link() == Link::Outbound {
+ TestResult::passed()
+ } else {
+ TestResult::error(format!("Expected Outbound, got {:?}", session.link()))
+ }
+ }
+ other => TestResult::error(format!("Expected Established, got {:?}", other)),
+ }
+}
+
+/// Inbound Link for Inbound Connections
+///
+/// Sessions created via Connected::Inbound have Link::Inbound.
+///
+/// ∀ session created via Connected::Inbound:
+/// session.link = Link::Inbound
+#[quickcheck]
+fn prop_inbound_link(
+ NonLocalNode(node): NonLocalNode,
+ addr: Address,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ match connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ ) {
+ event::Connected::Established { session } => {
+ assert_eq!(*session.link(), Link::Inbound);
+ TestResult::passed()
+ }
+ other => TestResult::error(format!("Expected Established, got {:?}", other)),
+ }
+}
+
+/// Link Conflict Detection (Inbound session, Outbound disconnect)
+///
+/// Disconnect with mismatched link returns LinkConflict.
+///
+/// ∀ session, link where session.link ≠ link:
+/// disconnect(session.node, link) = LinkConflict {
+/// node: session.node,
+/// found: session.link,
+/// expected: link
+/// }
+#[quickcheck]
+fn prop_link_conflict_inbound_session(
+ NonLocalNode(node): NonLocalNode,
+ addr: Address,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ // Create Inbound session
+ connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+
+ // Disconnect with wrong link (Outbound)
+ match connections.disconnected(
+ command::Disconnect {
+ node,
+ link: Link::Outbound,
+ since: now,
+ connection_type: ConnectionType::Persistent,
+ },
+ &DisconnectReason::Command,
+ ) {
+ event::Disconnected::LinkConflict {
+ found, expected, ..
+ } => {
+ if found == Link::Inbound && expected == Link::Outbound {
+ TestResult::passed()
+ } else {
+ TestResult::error(format!(
+ "Unexpected conflict: found={:?}, expected={:?}",
+ found, expected
+ ))
+ }
+ }
+ other => TestResult::error(format!("Expected LinkConflict, got {:?}", other)),
+ }
+}
+
+/// Link Conflict Detection (Outbound session, Inbound disconnect)
+///
+/// Disconnect with mismatched link returns LinkConflict.
+///
+/// ∀ session, link where session.link ≠ link:
+/// disconnect(session.node, link) = LinkConflict {
+/// node: session.node,
+/// found: session.link,
+/// expected: link
+/// }
+#[quickcheck]
+fn prop_link_conflict_outbound_session(
+ NonLocalNode(node): NonLocalNode,
+ addr: Address,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ // Create Outbound session
+ connections.connect(
+ command::Connect {
+ node,
+ addr: addr.clone(),
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+ connections.connected(
+ command::Connected::Outbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+
+ // Disconnect with wrong link (Inbound)
+ match connections.disconnected(
+ command::Disconnect {
+ node,
+ link: Link::Inbound,
+ since: now,
+ connection_type: ConnectionType::Persistent,
+ },
+ &DisconnectReason::Command,
+ ) {
+ event::Disconnected::LinkConflict {
+ found, expected, ..
+ } => {
+ if found == Link::Outbound && expected == Link::Inbound {
+ TestResult::passed()
+ } else {
+ TestResult::error(format!(
+ "Unexpected conflict: found={:?}, expected={:?}",
+ found, expected
+ ))
+ }
+ }
+ other => TestResult::error(format!("Expected LinkConflict, got {:?}", other)),
+ }
+}
+
+/// Link Count Consistency
+///
+/// connected_inbound() and connected_outbound() match actual counts.
+///
+/// connected_inbound() = |{s ∈ connected | s.link = Link::Inbound}|
+/// connected_outbound() = |{s ∈ connected | s.link = Link::Outbound}|
+#[quickcheck]
+fn prop_link_counts(commands: Vec<TestCommand>) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+ let mut time = LocalTime::from_secs(1577836800);
+
+ for cmd in commands {
+ apply_command(&mut connections, cmd, &mut time);
+ }
+
+ match invariants::check_link_count_consistency(connections.sessions()) {
+ Ok(()) => TestResult::passed(),
+ Err(e) => TestResult::error(e.to_string()),
+ }
+}
+
+// =============================================================================
+// Connection Type Properties
+// =============================================================================
+
+/// Ephemeral Disconnection Removes Session
+///
+/// Disconnecting an ephemeral session removes it entirely.
+///
+/// ∀ session where session.connection_type = Ephemeral:
+/// disconnect(session) → session ∉ sessions
+#[quickcheck]
+fn prop_ephemeral_removes(
+ NonLocalNode(node): NonLocalNode,
+ addr: Address,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Ephemeral,
+ },
+ now,
+ );
+
+ match connections.disconnected(
+ command::Disconnect {
+ node,
+ link: Link::Inbound,
+ since: now,
+ connection_type: ConnectionType::Ephemeral,
+ },
+ &DisconnectReason::Command,
+ ) {
+ event::Disconnected::Severed { .. } => {
+ if connections.has_session(&node) {
+ TestResult::error("Session should be removed after ephemeral disconnect")
+ } else {
+ TestResult::passed()
+ }
+ }
+ other => TestResult::error(format!("Expected Severed, got {:?}", other)),
+ }
+}
+
+/// Persistent Disconnection Preserves Session
+///
+/// Disconnecting a persistent session transitions to Disconnected state.
+///
+/// ∀ session where session.connection_type = Persistent:
+/// disconnect(session) → session ∈ disconnected
+#[quickcheck]
+fn prop_persistent_preserves(
+ NonLocalNode(node): NonLocalNode,
+ addr: Address,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+
+ match connections.disconnected(
+ command::Disconnect {
+ node,
+ link: Link::Inbound,
+ since: now,
+ connection_type: ConnectionType::Persistent,
+ },
+ &DisconnectReason::Command,
+ ) {
+ event::Disconnected::Retry { .. } => {
+ if connections.sessions().is_diconnected(&node) {
+ TestResult::passed()
+ } else {
+ TestResult::error("Session should be in Disconnected state")
+ }
+ }
+ other => TestResult::error(format!("Expected Retry, got {:?}", other)),
+ }
+}
+
+/// Persistent Sessions Have Retry Time
+///
+/// Disconnected persistent sessions have retry_at > disconnect time.
+///
+/// ∀ session ∈ disconnected:
+/// session.retry_at.is_some()
+#[quickcheck]
+fn prop_has_retry_time(
+ NonLocalNode(node): NonLocalNode,
+ addr: Address,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+
+ match connections.disconnected(
+ command::Disconnect {
+ node,
+ link: Link::Inbound,
+ since: now,
+ connection_type: ConnectionType::Persistent,
+ },
+ &DisconnectReason::Command,
+ ) {
+ event::Disconnected::Retry { retry_at, .. } => {
+ if retry_at > now {
+ TestResult::passed()
+ } else {
+ TestResult::error(format!(
+ "retry_at ({:?}) should be > now ({:?})",
+ retry_at, now
+ ))
+ }
+ }
+ other => TestResult::error(format!("Expected Retry, got {:?}", other)),
+ }
+}
+
+// =============================================================================
+// Attempt Counter Properties
+// =============================================================================
+
+/// Attempt Monotonicity During Connection Phase
+///
+/// The attempt counter never decreases during Initial → Attempted → Connected.
+///
+/// ∀ transitions Initial → Attempted → Connected:
+/// attempts_before ≤ attempts_after
+#[quickcheck]
+fn prop_attempt_monotonic(
+ NonLocalNode(node): NonLocalNode,
+ addr: Address,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+ let mut attempts: Vec<Attempts> = Vec::new();
+
+ // Initial state
+ connections.connect(
+ command::Connect {
+ node,
+ addr: addr.clone(),
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+ match connections.session_for(&node) {
+ Some(s) => attempts.push(s.attempts()),
+ None => return TestResult::error("Session should exist after connect"),
+ }
+
+ // Attempted state
+ match connections.attempted(command::Attempt { node }) {
+ event::Attempted::ConnectionAttempt { session } => {
+ attempts.push(session.attempts());
+ }
+ other => return TestResult::error(format!("Expected ConnectionAttempt, got {:?}", other)),
+ }
+
+ // Connected state
+ match connections.connected(
+ command::Connected::Outbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ ) {
+ event::Connected::Established { session } => {
+ attempts.push(session.attempts());
+ }
+ other => return TestResult::error(format!("Expected Established, got {:?}", other)),
+ }
+
+ // Verify we have all 3 data points
+ assert_eq!(attempts.len(), 3);
+
+ // Verify monotonicity
+ for window in attempts.windows(2) {
+ if window[1] < window[0] {
+ return TestResult::error(format!(
+ "Attempt count decreased: {} -> {}",
+ window[0], window[1]
+ ));
+ }
+ }
+
+ TestResult::passed()
+}
+
+/// Attempt Increment on Attempt Command
+///
+/// The Attempt command increments the attempt counter by exactly 1.
+///
+/// ∀ session in Initial:
+/// let attempts_before = session.attempts
+/// attempt(session.node)
+/// let attempts_after = session.attempts
+/// attempts_after = attempts_before + 1
+#[quickcheck]
+fn prop_attempt_increments(
+ NonLocalNode(node): NonLocalNode,
+ addr: Address,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ connections.connect(
+ command::Connect {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+
+ let before = match connections.session_for(&node) {
+ Some(s) => s.attempts(),
+ None => return TestResult::error("Session should exist after connect"),
+ };
+
+ match connections.attempted(command::Attempt { node }) {
+ event::Attempted::ConnectionAttempt { session } => {
+ let after = session.attempts();
+ if after == before.attempted() {
+ TestResult::passed()
+ } else {
+ TestResult::error(format!(
+ "Expected attempts={}, got {}",
+ before.attempted(),
+ after
+ ))
+ }
+ }
+ other => TestResult::error(format!("Expected ConnectionAttempt, got {:?}", other)),
+ }
+}
+
+/// Attempt Preservation Through Disconnection
+///
+/// The attempt count is preserved when transitioning to Disconnected.
+///
+/// ∀ session transitioning to Disconnected:
+/// disconnected.attempts = original.attempts
+#[quickcheck]
+fn prop_attempt_preserved_on_disconnect(
+ NonLocalNode(node): NonLocalNode,
+ addr: Address,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ connections.connect(
+ command::Connect {
+ node,
+ addr: addr.clone(),
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+ connections.attempted(command::Attempt { node });
+ connections.connected(
+ command::Connected::Outbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+
+ let before = match connections.sessions().get_connected(&node) {
+ Some(session) => session.attempts(),
+ None => return TestResult::error("Session should be connected"),
+ };
+
+ connections.disconnected(
+ command::Disconnect {
+ node,
+ link: Link::Outbound,
+ since: now,
+ connection_type: ConnectionType::Persistent,
+ },
+ &DisconnectReason::Command,
+ );
+
+ let after = match connections.session_for(&node) {
+ Some(session) => session.attempts(),
+ None => return TestResult::error("Session should exist after disconnect"),
+ };
+
+ if before == after {
+ TestResult::passed()
+ } else {
+ TestResult::error(format!(
+ "Attempts changed through disconnect: {} -> {}",
+ before, after
+ ))
+ }
+}
+
+/// Attempt Reset on Stabilization
+///
+/// When a session is stabilised, its attempt counter is reset to zero.
+///
+/// ∀ session where stabilise(session) = true:
+/// session.attempts = 0
+#[quickcheck]
+fn prop_attempt_reset_on_stabilise(
+ NonLocalNode(node): NonLocalNode,
+ addr: Address,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ // Build up some attempts
+ connections.connect(
+ command::Connect {
+ node,
+ addr: addr.clone(),
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+ connections.attempted(command::Attempt { node });
+ connections.connected(
+ command::Connected::Outbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+
+ // Verify we have attempts > 0
+ let before = match connections.sessions().get_connected(&node) {
+ Some(session) => session.attempts(),
+ None => return TestResult::error("Session should be connected"),
+ };
+
+ if before == 0 {
+ return TestResult::error("Expected attempts > 0 before stabilise");
+ }
+
+ let later = now + connections.config().stale() + LocalDuration::from_secs(1);
+
+ let stabilised = connections.stabilise(later);
+
+ // Verify this session was stabilised
+ assert!(stabilised.iter().any(|s| s.node() == node));
+
+ // Verify attempts reset
+ let after = match connections.sessions().get_connected(&node) {
+ Some(session) => session.attempts(),
+ None => return TestResult::error("Session should still be connected"),
+ };
+
+ if after == 0 {
+ TestResult::passed()
+ } else {
+ TestResult::error(format!(
+ "Attempts should be 0 after stabilise, got {}",
+ after
+ ))
+ }
+}
+
+// =============================================================================
+// Rate Limiting Properties
+// =============================================================================
+
+/// Inbound Limit Enforcement
+///
+/// When inbound connections reach the limit, accept returns LimitExceeded.
+///
+/// connected_inbound() ≥ inbound_limit ∧ ¬ip.is_loopback() ∧ ¬ip.is_unspecified()
+/// → accept(ip) = LimitExceeded
+#[test]
+fn prop_inbound_limit() {
+ const INBOUND_LIMIT: u8 = 2;
+
+ let local = NonLocalNode::local_node();
+ let config = {
+ let mut config = test_config();
+ config.inbound.maximum = INBOUND_LIMIT as usize;
+ config
+ };
+ let mut connections = Connections::new(local, config, RateLimiter::default());
+ let now = LocalTime::from_secs(1577836800);
+ let mut g = Gen::new(100);
+
+ // Fill up to the inbound limit
+ for i in 0..INBOUND_LIMIT {
+ let node = NodeId::from(crypto::PublicKey::from([i + 10; 32]));
+ let addr = Address::arbitrary(&mut g);
+ connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Ephemeral,
+ },
+ now,
+ );
+ }
+
+ // Next accept should be limited
+ let ip = IpAddr::V4(Ipv4Addr::new(8, 8, 8, 8));
+ assert!(
+ matches!(
+ connections.accept(command::Accept { ip }, now),
+ event::Accept::LimitExceeded { .. }
+ ),
+ "Accept should return LimitExceeded when at inbound limit"
+ );
+}
+
+/// Localhost Always Accepted
+///
+/// Localhost and unspecified IPs are always accepted regardless of limits.
+///
+/// ip.is_loopback() ∨ ip.is_unspecified() → accept(ip) = LocalHost
+#[test]
+fn prop_localhost_accepted() {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+ let now = LocalTime::from_secs(1577836800);
+
+ let localhost_ips = [
+ IpAddr::V4(Ipv4Addr::LOCALHOST),
+ IpAddr::V6(Ipv6Addr::LOCALHOST),
+ IpAddr::V4(Ipv4Addr::UNSPECIFIED),
+ IpAddr::V6(Ipv6Addr::UNSPECIFIED),
+ ];
+
+ for ip in localhost_ips {
+ assert!(
+ matches!(
+ connections.accept(command::Accept { ip }, now),
+ event::Accept::LocalHost { .. }
+ ),
+ "Expected LocalHost for {:?}",
+ ip
+ );
+ }
+}
+
+/// Host Rate Limiting
+///
+/// IPs that exceed the rate limit return HostLimited.
+///
+/// rate_limited(ip) → accept(ip) = HostLimited { ip }
+#[test]
+fn prop_host_rate_limited() {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections_with_low_limits(local);
+ let now = LocalTime::from_secs(1577836800);
+ let ip = IpAddr::V4(Ipv4Addr::new(8, 8, 8, 8));
+
+ // First accept consumes the single token
+ assert!(
+ matches!(
+ connections.accept(command::Accept { ip }, now),
+ event::Accept::Accepted { .. }
+ ),
+ "First accept should succeed"
+ );
+
+ // Second accept should be rate limited (no tokens, no refill)
+ assert_eq!(
+ connections.accept(command::Accept { ip }, now),
+ event::Accept::HostLimited { ip }
+ );
+}
+
+/// Message Rate Limiting
+///
+/// Messages from rate-limited nodes return RateLimited.
+///
+/// ∀ message from rate_limited node:
+/// handle_message(message) = RateLimited { node }
+#[quickcheck]
+fn prop_message_rate_limited(
+ NonLocalNode(node): NonLocalNode,
+ RoutableAddress(addr): RoutableAddress,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections_with_low_limits(local);
+
+ // Establish a connected session
+ match connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ ) {
+ event::Connected::Established { .. } => {}
+ other => return TestResult::error(format!("Expected Established, got {:?}", other)),
+ }
+
+ // First message consumes the single token
+ match connections.handle_message(
+ command::Message {
+ node,
+ payload: None,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ ) {
+ event::HandledMessage::Connected { .. } => {}
+ other => {
+ return TestResult::error(format!("First message should succeed, got {:?}", other))
+ }
+ }
+
+ // Second message should be rate limited
+ match connections.handle_message(
+ command::Message {
+ node,
+ payload: None,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ ) {
+ event::HandledMessage::RateLimited { node: n } if n == node => TestResult::passed(),
+ other => TestResult::error(format!("Expected RateLimited for {node}, got {:?}", other)),
+ }
+}
+
+// =============================================================================
+// Timing Properties
+// =============================================================================
+
+/// Reconnection Delay Bounds
+///
+/// Reconnection delay is always within configured min/max bounds.
+///
+/// ∀ delay returned by disconnect:
+/// min_delta ≤ delay ≤ max_delta
+#[quickcheck]
+fn prop_delay_bounds(
+ NonLocalNode(node): NonLocalNode,
+ addr: Address,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+
+ match connections.disconnected(
+ command::Disconnect {
+ node,
+ link: Link::Inbound,
+ since: now,
+ connection_type: ConnectionType::Persistent,
+ },
+ &DisconnectReason::Command,
+ ) {
+ event::Disconnected::Retry { delay, .. } => {
+ if delay < MIN_RECONNECTION_DELTA {
+ TestResult::error(format!(
+ "Delay {:?} is below minimum {:?}",
+ delay, MIN_RECONNECTION_DELTA
+ ))
+ } else if delay > MAX_RECONNECTION_DELTA {
+ TestResult::error(format!(
+ "Delay {:?} is above maximum {:?}",
+ delay, MAX_RECONNECTION_DELTA
+ ))
+ } else {
+ TestResult::passed()
+ }
+ }
+ other => TestResult::error(format!("Expected Retry, got {:?}", other)),
+ }
+}
+
+/// Exponential Backoff
+///
+/// Reconnection delays are increasing across reconnection cycles.
+#[quickcheck]
+fn prop_exponential_backoff(
+ NonLocalNode(node): NonLocalNode,
+ addr: Address,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+ let mut delays: Vec<LocalDuration> = Vec::new();
+
+ for _ in 0..5 {
+ connections.connect(
+ command::Connect {
+ node,
+ addr: addr.clone(),
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+ connections.attempted(command::Attempt { node });
+ connections.connected(
+ command::Connected::Outbound {
+ node,
+ addr: addr.clone(),
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+
+ match connections.disconnected(
+ command::Disconnect {
+ node,
+ link: Link::Outbound,
+ since: now,
+ connection_type: ConnectionType::Persistent,
+ },
+ &DisconnectReason::Command,
+ ) {
+ event::Disconnected::Retry { delay, .. } => delays.push(delay),
+ other => return TestResult::error(format!("Expected Retry, got {:?}", other)),
+ }
+
+ connections.reconnect(command::Reconnect { node });
+ }
+
+ // Verify we collected all delays
+ if delays.len() != 5 {
+ return TestResult::error(format!("Expected 5 delays, got {}", delays.len()));
+ }
+
+ // Verify increasing
+ for window in delays.windows(2) {
+ if window[1] < window[0] {
+ return TestResult::error(format!(
+ "Delay decreased: {:?} -> {:?}",
+ window[0], window[1]
+ ));
+ }
+ }
+
+ TestResult::passed()
+}
+
+/// Last Active Update on Connection
+///
+/// last_active is set when a session transitions to Connected.
+///
+/// ∀ connection at time t:
+/// session.last_active = t
+#[quickcheck]
+fn prop_last_active_on_connect(
+ NonLocalNode(node): NonLocalNode,
+ RoutableAddress(addr): RoutableAddress,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ match connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ ) {
+ event::Connected::Established { session } => {
+ assert_eq!(*session.last_active(), now);
+ TestResult::passed()
+ }
+ other => TestResult::error(format!("Expected Established, got {:?}", other)),
+ }
+}
+
+/// Last Active Update on Message
+///
+/// last_active is updated when a session receives a message.
+///
+/// ∀ connection at time t:
+/// session.last_active = t
+#[quickcheck]
+fn prop_last_active_on_message(
+ NonLocalNode(node): NonLocalNode,
+ RoutableAddress(addr): RoutableAddress,
+ ArbitraryTime(connect_time): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ connect_time,
+ );
+
+ let message_time = connect_time + LocalDuration::from_secs(10);
+
+ match connections.handle_message(
+ command::Message {
+ node,
+ payload: None,
+ connection_type: ConnectionType::Persistent,
+ },
+ message_time,
+ ) {
+ event::HandledMessage::Connected { session } => {
+ assert_eq!(*session.last_active(), message_time);
+ TestResult::passed()
+ }
+ other => TestResult::error(format!("Expected Connected, got {:?}", other)),
+ }
+}
+
+/// Inactivity Detection
+///
+/// is_inactive returns true iff time since last activity exceeds threshold.
+#[quickcheck]
+fn prop_inactivity_detection(
+ NonLocalNode(node): NonLocalNode,
+ RoutableAddress(addr): RoutableAddress,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+
+ let session = match connections.sessions().get_connected(&node) {
+ Some(s) => s,
+ None => return TestResult::error("Session should be connected"),
+ };
+
+ let delta = LocalDuration::from_secs(60);
+
+ // Before threshold: not inactive
+ let before_threshold = now + connections.config().idle() - LocalDuration::from_secs(1);
+ assert!(!session.is_inactive(&before_threshold, delta));
+
+ // At threshold: inactive
+ let at_threshold = now + delta;
+ assert!(session.is_inactive(&at_threshold, delta));
+
+ // After threshold: inactive
+ let after_threshold = now + connections.config().idle();
+ assert!(session.is_inactive(&after_threshold, delta));
+ TestResult::passed()
+}
+
+/// Stability Threshold
+///
+/// A session becomes stable only after connected for longer than the stability threshold.
+///
+/// session.stable = true ⟺ (now - session.since ≥ stable_threshold)
+#[quickcheck]
+fn prop_stability_threshold(
+ NonLocalNode(node): NonLocalNode,
+ RoutableAddress(addr): RoutableAddress,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+
+ let before_threshold = now + connections.config().stale() - LocalDuration::from_secs(1);
+ connections.stabilise(before_threshold);
+
+ let session = match connections.sessions().get_connected(&node) {
+ Some(s) => s,
+ None => return TestResult::error("Session should be connected"),
+ };
+ assert!(!session.is_stable());
+
+ let after_threshold = now + connections.config().stale();
+ connections.stabilise(after_threshold);
+
+ let session = match connections.sessions().get_connected(&node) {
+ Some(s) => s,
+ None => return TestResult::error("Session should be connected"),
+ };
+ assert!(session.is_stable());
+
+ TestResult::passed()
+}
+
+// =============================================================================
+// Subscription Properties
+// =============================================================================
+
+/// Subscription Persistence Across States
+///
+/// Subscription data is preserved through state transitions.
+///
+/// ∀ state transition:
+/// session_before.subscribe = session_after.subscribe
+#[quickcheck]
+fn prop_subscription_persistence_through_disconnect(
+ NonLocalNode(node): NonLocalNode,
+ RoutableAddress(addr): RoutableAddress,
+ ArbitraryTime(now): ArbitraryTime,
+ rid: RepoId,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ // Connect with Persistent type
+ connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr: addr.clone(),
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+
+ // Set subscription with the repo ID
+ let mut filter = Filter::empty();
+ filter.insert(&rid);
+ let subscription = message::Subscribe {
+ filter,
+ since: Timestamp::from(now),
+ until: Timestamp::MAX,
+ };
+
+ match connections.handle_message(
+ command::Message {
+ node,
+ payload: Some(command::Payload::Subscribe(subscription)),
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ ) {
+ event::HandledMessage::Subscribed { session } => {
+ assert!(session.is_subscribed_to(&rid));
+ }
+ other => return TestResult::error(format!("Expected Subscribed, got {:?}", other)),
+ }
+
+ // Disconnect
+ connections.disconnected(
+ command::Disconnect {
+ node,
+ link: Link::Inbound,
+ since: now,
+ connection_type: ConnectionType::Persistent,
+ },
+ &DisconnectReason::Command,
+ );
+
+ // Verify subscription is preserved in disconnected state
+ match connections.session_for(&node) {
+ Some(session) => {
+ assert!(session.is_subscribed_to(&rid));
+ TestResult::passed()
+ }
+ None => TestResult::error("Session should exist after persistent disconnect"),
+ }
+}
+
+/// Subscription Persistence Across States
+///
+/// Subscription data is preserved through state transitions.
+///
+/// ∀ state transition:
+/// session_before.subscribe = session_after.subscribe
+#[quickcheck]
+fn prop_subscription_persistence(
+ NonLocalNode(node): NonLocalNode,
+ RoutableAddress(addr): RoutableAddress,
+ ArbitraryTime(now): ArbitraryTime,
+ rid: RepoId,
+ commands: Vec<TestCommand>,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ // Connect with Persistent type
+ connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+
+ // Set subscription with the repo ID
+ let mut filter = Filter::empty();
+ filter.insert(&rid);
+ let subscription = message::Subscribe {
+ filter,
+ since: Timestamp::from(now),
+ until: Timestamp::MAX,
+ };
+
+ match connections.handle_message(
+ command::Message {
+ node,
+ payload: Some(command::Payload::Subscribe(subscription)),
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ ) {
+ event::HandledMessage::Subscribed { session } => {
+ if !session.is_subscribed_to(&rid) {
+ return TestResult::error("Subscription should be set");
+ }
+ }
+ other => return TestResult::error(format!("Expected Subscribed, got {:?}", other)),
+ }
+
+ let mut time = now;
+
+ for cmd in commands {
+ // Track if this command might replace our session
+ let is_inbound_for_node = matches!(
+ &cmd,
+ TestCommand::ConnectedInbound { node: n, .. } if *n == node
+ );
+ let is_ephemeral_disconnect_for_node = matches!(
+ &cmd,
+ TestCommand::Disconnect {
+ node: n,
+ connection_type: ConnectionType::Ephemeral,
+ ..
+ } if *n == node
+ );
+
+ apply_command(&mut connections, cmd, &mut time);
+
+ // If session was replaced by inbound or removed by ephemeral disconnect, stop checking
+ if is_inbound_for_node || is_ephemeral_disconnect_for_node {
+ continue;
+ }
+
+ // If session still exists, verify subscription is preserved
+ if let Some(session) = connections.session_for(&node) {
+ assert!(session.is_subscribed_to(&rid));
+ }
+ }
+
+ // Final check if session exists
+ if let Some(session) = connections.session_for(&node) {
+ assert!(session.is_subscribed_to(&rid));
+ }
+
+ TestResult::passed()
+}
+
+/// Subscribe Returns Success Only for Existing Connected Sessions
+///
+/// subscribe returns Subscribed only if the session exists and is connected.
+///
+/// subscribe(node, subscription) = true ⟺ has_session_for(node)
+#[quickcheck]
+fn prop_subscribe_requires_connected_session(
+ NonLocalNode(node): NonLocalNode,
+ RoutableAddress(addr): RoutableAddress,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ let subscription = message::Subscribe {
+ filter: Filter::default(),
+ since: Timestamp::from(now),
+ until: Timestamp::MAX,
+ };
+
+ // Subscribe on missing session should fail
+ match connections.handle_message(
+ command::Message {
+ node,
+ payload: Some(command::Payload::Subscribe(subscription.clone())),
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ ) {
+ event::HandledMessage::MissingSession { .. } => {}
+ other => {
+ return TestResult::error(format!(
+ "Expected MissingSession for missing session, got {:?}",
+ other
+ ))
+ }
+ }
+
+ // Connect the session
+ connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+
+ // Subscribe on connected session should succeed
+ match connections.handle_message(
+ command::Message {
+ node,
+ payload: Some(command::Payload::Subscribe(subscription.clone())),
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ ) {
+ event::HandledMessage::Subscribed { .. } => {}
+ other => {
+ return TestResult::error(format!(
+ "Expected Subscribed for connected session, got {:?}",
+ other
+ ))
+ }
+ }
+
+ // Disconnect the session
+ connections.disconnected(
+ command::Disconnect {
+ node,
+ link: Link::Inbound,
+ since: now,
+ connection_type: ConnectionType::Persistent,
+ },
+ &DisconnectReason::Command,
+ );
+
+ // Subscribe on disconnected session should fail
+ match connections.handle_message(
+ command::Message {
+ node,
+ payload: Some(command::Payload::Subscribe(subscription)),
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ ) {
+ event::HandledMessage::Disconnected { .. } => TestResult::passed(),
+ other => TestResult::error(format!(
+ "Expected Disconnected for disconnected session, got {:?}",
+ other
+ )),
+ }
+}
+
+// =============================================================================
+// Ping/Pong Properties
+// =============================================================================
+
+/// Pong Only in Connected State
+///
+/// Pong processing only succeeds for connected sessions.
+///
+/// pinged(node, pong) = Ok(_) ⟺ node ∈ connected.keys()
+#[quickcheck]
+fn prop_pong_only_connected(
+ NonLocalNode(node): NonLocalNode,
+ RoutableAddress(addr): RoutableAddress,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ let pong = Pong {
+ now,
+ zeroes: message::ZeroBytes::new(10),
+ };
+
+ // Pong on missing session
+ match connections.handle_message(
+ command::Message {
+ node,
+ payload: Some(command::Payload::Pong(pong.clone())),
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ ) {
+ event::HandledMessage::MissingSession { .. } => {}
+ other => {
+ return TestResult::error(format!(
+ "Expected MissingSession for missing session, got {:?}",
+ other
+ ))
+ }
+ }
+
+ // Connect and set up ping state
+ connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr: addr.clone(),
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+
+ // Ping the session to set up AwaitingResponse state
+ let later = now + LocalDuration::from_secs(60);
+ let ponglen = 10u16;
+ let mut ping_called = false;
+ for event in connections.ping(
+ || {
+ ping_called = true;
+ message::Ping {
+ ponglen,
+ zeroes: message::ZeroBytes::new(0),
+ }
+ },
+ later,
+ ) {
+ // Consume the iterator to trigger pings
+ let _ = event;
+ }
+ assert!(ping_called);
+
+ // Valid pong on connected session should succeed
+ let valid_pong = Pong {
+ now: later,
+ zeroes: message::ZeroBytes::new(ponglen),
+ };
+
+ match connections.handle_message(
+ command::Message {
+ node,
+ payload: Some(command::Payload::Pong(valid_pong)),
+ connection_type: ConnectionType::Persistent,
+ },
+ later,
+ ) {
+ event::HandledMessage::Pinged {
+ pinged: Some(_), ..
+ } => {}
+ other => {
+ return TestResult::error(format!(
+ "Expected Pinged with Some for connected session, got {:?}",
+ other
+ ))
+ }
+ }
+
+ // Disconnect the session
+ connections.disconnected(
+ command::Disconnect {
+ node,
+ link: Link::Inbound,
+ since: later,
+ connection_type: ConnectionType::Persistent,
+ },
+ &DisconnectReason::Command,
+ );
+
+ // Pong on disconnected session should fail
+ let pong = Pong {
+ now: later,
+ zeroes: message::ZeroBytes::new(10),
+ };
+
+ match connections.handle_message(
+ command::Message {
+ node,
+ payload: Some(command::Payload::Pong(pong)),
+ connection_type: ConnectionType::Persistent,
+ },
+ later,
+ ) {
+ event::HandledMessage::Disconnected { .. } => TestResult::passed(),
+ other => TestResult::error(format!(
+ "Expected Disconnected for disconnected session, got {:?}",
+ other
+ )),
+ }
+}
+
+/// Latency Recording
+///
+/// Successful pong responses record latency
+///
+/// ∀ successful pong:
+/// session.latencies.push_back(latency)
+/// ∧ |session.latencies| ≤ MAX_LATENCIES
+#[quickcheck]
+fn prop_latency_bounded(
+ NonLocalNode(node): NonLocalNode,
+ RoutableAddress(addr): RoutableAddress,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+
+ let ponglen = 10u16;
+ let mut successful_pongs = 0;
+
+ // Send more pongs than MAX_LATENCIES to verify bounded storage
+ for i in 0..(MAX_LATENCIES + 5) {
+ let ping_time = now + LocalDuration::from_secs(60 * (i as u64 + 1));
+
+ // Ping to set up AwaitingResponse
+ for _ in connections.ping(
+ || message::Ping {
+ ponglen,
+ zeroes: message::ZeroBytes::new(0),
+ },
+ ping_time,
+ ) {}
+
+ // Pong with valid response
+ let pong_time = ping_time + LocalDuration::from_secs(1);
+ let pong = Pong {
+ now: pong_time,
+ zeroes: message::ZeroBytes::new(ponglen),
+ };
+
+ match connections.handle_message(
+ command::Message {
+ node,
+ payload: Some(command::Payload::Pong(pong)),
+ connection_type: ConnectionType::Persistent,
+ },
+ pong_time,
+ ) {
+ event::HandledMessage::Pinged {
+ pinged: Some(pinged),
+ ..
+ } => {
+ successful_pongs += 1;
+ // Verify latency is recorded correctly
+ assert_eq!(pinged.latency, LocalDuration::from_secs(1));
+ }
+ other => {
+ return TestResult::error(format!("Expected Pinged with latency, got {:?}", other))
+ }
+ }
+ }
+
+ assert_eq!(successful_pongs, MAX_LATENCIES + 5);
+ TestResult::passed()
+}
+
+/// Ping State Transition
+///
+/// After ping, session enters AwaitingResponse state until valid pong.
+///
+/// after ping(): session.ping = AwaitingResponse { len, since }
+/// after valid pong(): session.ping = Ok
+#[quickcheck]
+fn prop_ping_state_transition(
+ NonLocalNode(node): NonLocalNode,
+ RoutableAddress(addr): RoutableAddress,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+
+ let ponglen = 10u16;
+
+ // Before ping: pong should return None (no AwaitingResponse)
+ let pong = Pong {
+ now,
+ zeroes: message::ZeroBytes::new(ponglen),
+ };
+
+ match connections.handle_message(
+ command::Message {
+ node,
+ payload: Some(command::Payload::Pong(pong)),
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ ) {
+ event::HandledMessage::Pinged { pinged: None, .. } => {}
+ other => {
+ return TestResult::error(format!(
+ "Expected Pinged with None before ping, got {:?}",
+ other
+ ))
+ }
+ }
+
+ // Ping to enter AwaitingResponse
+ let ping_time = now + LocalDuration::from_secs(60);
+ for _ in connections.ping(
+ || message::Ping {
+ ponglen,
+ zeroes: message::ZeroBytes::new(0),
+ },
+ ping_time,
+ ) {}
+
+ // Invalid pong (wrong length) should return None
+ let invalid_pong = Pong {
+ now: ping_time,
+ zeroes: message::ZeroBytes::new(ponglen + 1), // Wrong length
+ };
+
+ match connections.handle_message(
+ command::Message {
+ node,
+ payload: Some(command::Payload::Pong(invalid_pong)),
+ connection_type: ConnectionType::Persistent,
+ },
+ ping_time,
+ ) {
+ event::HandledMessage::Pinged { pinged: None, .. } => {}
+ other => {
+ return TestResult::error(format!(
+ "Expected Pinged with None for invalid pong, got {:?}",
+ other
+ ))
+ }
+ }
+
+ // Need to ping again since state may have changed
+ let ping_time2 = ping_time + LocalDuration::from_secs(60);
+ for _ in connections.ping(
+ || message::Ping {
+ ponglen,
+ zeroes: message::ZeroBytes::new(0),
+ },
+ ping_time2,
+ ) {}
+
+ // Valid pong should return Some and reset state
+ let valid_pong = Pong {
+ now: ping_time2,
+ zeroes: message::ZeroBytes::new(ponglen),
+ };
+
+ match connections.handle_message(
+ command::Message {
+ node,
+ payload: Some(command::Payload::Pong(valid_pong)),
+ connection_type: ConnectionType::Persistent,
+ },
+ ping_time2,
+ ) {
+ event::HandledMessage::Pinged {
+ pinged: Some(_), ..
+ } => {}
+ other => {
+ return TestResult::error(format!(
+ "Expected Pinged with Some for valid pong, got {:?}",
+ other
+ ))
+ }
+ }
+
+ // After valid pong: back to Ok state, pong should return None
+ let final_pong = Pong {
+ now: ping_time2,
+ zeroes: message::ZeroBytes::new(ponglen),
+ };
+
+ match connections.handle_message(
+ command::Message {
+ node,
+ payload: Some(command::Payload::Pong(final_pong)),
+ connection_type: ConnectionType::Persistent,
+ },
+ ping_time2,
+ ) {
+ event::HandledMessage::Pinged { pinged: None, .. } => TestResult::passed(),
+ other => TestResult::error(format!(
+ "Expected Pinged with None after valid pong (back to Ok), got {:?}",
+ other
+ )),
+ }
+}
+
+// =============================================================================
+// Iterator Properties
+// =============================================================================
+
+/// Iterator Completeness
+///
+/// Iterating over sessions yields exactly all sessions across all states.
+///
+/// |sessions.iter()| = |initial| + |attempted| + |connected| + |disconnected|
+#[quickcheck]
+fn prop_iterator_complete(commands: Vec<TestCommand>) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+ let mut time = LocalTime::from_secs(1577836800);
+
+ for cmd in commands {
+ apply_command(&mut connections, cmd, &mut time);
+ }
+
+ let sessions = connections.sessions();
+ let iter_count = sessions.iter().count();
+
+ let mut state_count = 0;
+ for (node, _) in sessions.iter() {
+ let in_state = sessions.is_initial(node) as usize
+ + sessions.is_attempted(node) as usize
+ + sessions.get_connected(node).is_some() as usize
+ + sessions.is_diconnected(node) as usize;
+
+ assert_eq!(in_state, 1);
+ state_count += 1;
+ }
+
+ assert_eq!(iter_count, state_count);
+ TestResult::passed()
+}
+
+/// Connected Iterator Correctness
+///
+/// connected() iterator yields exactly all connected sessions.
+///
+/// sessions.connected().count() = |connected|
+/// ∧ ∀ session in sessions.connected(): session ∈ connected
+#[quickcheck]
+fn prop_connected_iterator(commands: Vec<TestCommand>) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+ let mut time = LocalTime::from_secs(1577836800);
+
+ for cmd in commands {
+ apply_command(&mut connections, cmd, &mut time);
+ }
+
+ let sessions = connections.sessions();
+ let iter_count = sessions.connected().sessions().count();
+
+ let manual_count = sessions
+ .iter()
+ .filter(|(node, _)| sessions.get_connected(node).is_some())
+ .count();
+
+ assert_eq!(iter_count, manual_count);
+ TestResult::passed()
+}
+
+/// Unresponsive Filter Correctness
+///
+/// unresponsive returns only connected sessions that are inactive.
+///
+/// ∀ session in unresponsive(now, threshold):
+/// session ∈ connected ∧ session.is_inactive(now, threshold)
+#[quickcheck]
+fn prop_unresponsive_filter(
+ NonLocalNode(node): NonLocalNode,
+ RoutableAddress(addr): RoutableAddress,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ // Connect the session
+ connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+
+ let stale_connection = connections.config().stale();
+
+ // Before stale_connection threshold: not unresponsive
+ let before_threshold = now + stale_connection - LocalDuration::from_secs(1);
+ let unresponsive_before: Vec<_> = connections.unresponsive(&before_threshold).collect();
+ assert!(!unresponsive_before.iter().any(|(n, _)| **n == node));
+
+ // At/after stale_connection threshold: unresponsive
+ let after_threshold = now + stale_connection + LocalDuration::from_secs(1);
+ let unresponsive_after: Vec<_> = connections.unresponsive(&after_threshold).collect();
+ assert!(unresponsive_after.iter().any(|(n, _)| **n == node));
+
+ // Verify all returned sessions are actually connected and inactive
+ for (nid, session) in unresponsive_after {
+ if connections.sessions().get_connected(nid).is_none() {
+ return TestResult::error(format!("Unresponsive session {:?} is not connected", nid));
+ }
+ if !session.is_inactive(&after_threshold, stale_connection) {
+ return TestResult::error(format!("Unresponsive session {:?} is not inactive", nid));
+ }
+ }
+
+ TestResult::passed()
+}
+
+// =============================================================================
+// State Machine Model Properties
+// =============================================================================
+
+/// Deterministic Transitions
+///
+/// Given the same state and command, the resulting state is always the same.
+///
+/// ∀ state S, command C:
+/// apply(S, C) always produces the same result
+#[quickcheck]
+fn prop_deterministic_transitions(commands: Vec<TestCommand>) -> TestResult {
+ let local = NonLocalNode::local_node();
+
+ let mut connections1 = new_connections(local);
+ let mut connections2 = new_connections(local);
+ let mut time1 = LocalTime::from_secs(1577836800);
+ let mut time2 = LocalTime::from_secs(1577836800);
+
+ for cmd in commands {
+ apply_command(&mut connections1, cmd.clone(), &mut time1);
+ apply_command(&mut connections2, cmd, &mut time2);
+
+ // Verify session sets match
+ let nodes1: HashSet<_> = connections1.sessions().iter().map(|(n, _)| *n).collect();
+ let nodes2: HashSet<_> = connections2.sessions().iter().map(|(n, _)| *n).collect();
+
+ if nodes1 != nodes2 {
+ return TestResult::error("Session sets differ after identical commands");
+ }
+
+ // Verify states match for each node
+ for node in nodes1 {
+ let s1 = connections1.sessions();
+ let s2 = connections2.sessions();
+
+ let state1 = (
+ s1.is_initial(&node),
+ s1.is_attempted(&node),
+ s1.get_connected(&node).is_some(),
+ s1.is_diconnected(&node),
+ );
+ let state2 = (
+ s2.is_initial(&node),
+ s2.is_attempted(&node),
+ s2.get_connected(&node).is_some(),
+ s2.is_diconnected(&node),
+ );
+
+ if state1 != state2 {
+ return TestResult::error(format!(
+ "State differs for node {:?}: {:?} vs {:?}",
+ node, state1, state2
+ ));
+ }
+ }
+ }
+
+ TestResult::passed()
+}
+
+/// No State Loss
+///
+/// A session cannot disappear except through Disconnect(Ephemeral).
+///
+/// session ∈ sessions at time t ∧ session ∉ sessions at time t+1
+/// → ∃ Disconnect(Ephemeral) for session.node between t and t+1
+/// ∨ ∃ Connected(Inbound) that replaced session
+#[quickcheck]
+fn prop_no_state_loss(commands: Vec<TestCommand>) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+ let mut time = LocalTime::from_secs(1577836800);
+
+ // Track which nodes have sessions
+ let mut had_session: HashSet<NodeId> = HashSet::new();
+
+ for cmd in commands {
+ // Record nodes that have sessions before command
+ had_session.extend(connections.sessions().iter().map(|(n, _)| n));
+
+ // Track if this command is an ephemeral disconnect or inbound connect
+ let is_ephemeral_disconnect = matches!(
+ &cmd,
+ TestCommand::Disconnect {
+ connection_type: ConnectionType::Ephemeral,
+ ..
+ }
+ );
+ let inbound_node = match &cmd {
+ TestCommand::ConnectedInbound { node, .. } => Some(*node),
+ _ => None,
+ };
+
+ apply_command(&mut connections, cmd, &mut time);
+
+ // Check for disappeared sessions
+ for node in had_session.iter() {
+ if !connections.has_session(node) {
+ // Session disappeared - must be due to ephemeral disconnect
+ // or it was overwritten by inbound (which keeps the session)
+ if !is_ephemeral_disconnect && inbound_node != Some(*node) {
+ return TestResult::error(format!(
+ "Session {:?} disappeared without ephemeral disconnect or inbound overwrite",
+ node
+ ));
+ }
+ }
+ }
+
+ // Update tracked sessions
+ had_session.clear();
+ had_session.extend(connections.sessions().iter().map(|(n, _)| n));
+ }
+
+ TestResult::passed()
+}
+
+/// Command Reversibility (Partial)
+///
+/// Reconnect reverses disconnect in terms of session state (Disconnected → Initial).
+///
+/// reconnect(node) reverses disconnect(node)
+/// only in terms of session existence, not exact state
+#[quickcheck]
+fn prop_reconnect_reverses_disconnect(
+ NonLocalNode(node): NonLocalNode,
+ RoutableAddress(addr): RoutableAddress,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ // Connect and establish session
+ connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+
+ assert!(connections.sessions().get_connected(&node).is_some());
+
+ connections.disconnected(
+ command::Disconnect {
+ node,
+ link: Link::Inbound,
+ since: now,
+ connection_type: ConnectionType::Persistent,
+ },
+ &DisconnectReason::Command,
+ );
+ assert!(connections.sessions().is_diconnected(&node));
+
+ // Reconnect should bring session back to Initial
+ match connections.reconnect(command::Reconnect { node }) {
+ event::Reconnect::Reconnecting { .. } => {}
+ other => {
+ return TestResult::error(format!("Expected Reconnecting, got {:?}", other));
+ }
+ }
+ assert!(connections.sessions().is_initial(&node));
+ assert!(connections.has_session(&node));
+
+ TestResult::passed()
+}
+
+// =============================================================================
+// Inbound Special Cases
+// =============================================================================
+
+/// Inbound Creates Session if Missing
+///
+/// Connected::Inbound creates a new connected session if none exists.
+///
+/// node ∉ sessions.keys() ∧ Connected::Inbound(node)
+/// → node ∈ connected.keys()
+#[quickcheck]
+fn prop_inbound_creates(
+ NonLocalNode(node): NonLocalNode,
+ addr: Address,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ match connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ ) {
+ event::Connected::Established { session } => {
+ assert_eq!(session.node(), node);
+ assert!(connections.sessions().get_connected(&node).is_some());
+ TestResult::passed()
+ }
+ other => TestResult::error(format!("Expected Established, got {:?}", other)),
+ }
+}
+
+/// Inbound Overwrites Disconnected State
+///
+/// Connected::Inbound transitions disconnected session to Connected.
+///
+/// ∀ existing session state:
+/// Connected::Inbound(node) → node ∈ connected.keys()
+#[quickcheck]
+fn prop_inbound_overwrites_disconnected(
+ NonLocalNode(node): NonLocalNode,
+ addr: Address,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ // Create a disconnected session
+ connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr: addr.clone(),
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+ connections.disconnected(
+ command::Disconnect {
+ node,
+ link: Link::Inbound,
+ since: now,
+ connection_type: ConnectionType::Persistent,
+ },
+ &DisconnectReason::Command,
+ );
+ assert!(connections.sessions().is_diconnected(&node));
+
+ // Inbound should overwrite
+ match connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ ) {
+ event::Connected::Established { .. } => {
+ assert!(connections.sessions().get_connected(&node).is_some());
+ TestResult::passed()
+ }
+ other => TestResult::error(format!("Expected Established, got {:?}", other)),
+ }
+}
+
+/// Inbound Overwrites Initial State
+///
+/// Connected::Inbound transitions initial session to Connected.
+///
+/// ∀ existing session state:
+/// Connected::Inbound(node) → node ∈ connected.keys()
+#[quickcheck]
+fn prop_inbound_overwrites_initial(
+ NonLocalNode(node): NonLocalNode,
+ addr: Address,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ // Create an initial session via connect
+ connections.connect(
+ command::Connect {
+ node,
+ addr: addr.clone(),
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+ assert!(connections.sessions().is_initial(&node));
+
+ // Inbound should overwrite
+ match connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ ) {
+ event::Connected::Established { .. } => {
+ assert!(connections.sessions().get_connected(&node).is_some());
+ TestResult::passed()
+ }
+ other => TestResult::error(format!("Expected Established, got {:?}", other)),
+ }
+}
+
+/// Inbound Overwrites Attempted State
+///
+/// Connected::Inbound transitions attempted session to Connected.
+///
+/// ∀ existing session state:
+/// Connected::Inbound(node) → node ∈ connected.keys()
+#[quickcheck]
+fn prop_inbound_overwrites_attempted(
+ NonLocalNode(node): NonLocalNode,
+ addr: Address,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ // Create an attempted session
+ connections.connect(
+ command::Connect {
+ node,
+ addr: addr.clone(),
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+ connections.attempted(command::Attempt { node });
+ assert!(connections.sessions().is_attempted(&node));
+
+ // Inbound should overwrite
+ match connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ ) {
+ event::Connected::Established { .. } => {
+ assert!(connections.sessions().get_connected(&node).is_some());
+ TestResult::passed()
+ }
+ other => TestResult::error(format!("Expected Established, got {:?}", other)),
+ }
+}
+
+/// Outbound Requires Existing Session
+///
+/// Connected::Outbound fails if no session exists.
+///
+/// node ∉ sessions.keys() ∧ Connected::Outbound(node)
+/// → result = MissingSession { node }
+#[quickcheck]
+fn prop_outbound_requires_session(
+ NonLocalNode(node): NonLocalNode,
+ addr: Address,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ match connections.connected(
+ command::Connected::Outbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ ) {
+ event::Connected::MissingSession { node: n } if n == node => TestResult::passed(),
+ other => TestResult::error(format!(
+ "Expected MissingSession for {node}, got {:?}",
+ other
+ )),
+ }
+}
+
+// =============================================================================
+// Address Properties
+// =============================================================================
+
+/// Address Preservation
+///
+/// Session address is preserved through state transitions.
+///
+/// ∀ state transition:
+/// session_before.addr = session_after.addr
+#[quickcheck]
+fn prop_address_preservation(
+ NonLocalNode(node): NonLocalNode,
+ RoutableAddress(addr): RoutableAddress,
+ ArbitraryTime(now): ArbitraryTime,
+ commands: Vec<TestCommand>,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ let expected_addr = addr.clone();
+
+ // Create session via connect
+ connections.connect(
+ command::Connect {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+
+ let mut time = now;
+
+ for cmd in commands {
+ // Track if this command might replace our session
+ let is_inbound_for_node = matches!(
+ &cmd,
+ TestCommand::ConnectedInbound { node: n, .. } if *n == node
+ );
+ let is_ephemeral_disconnect_for_node = matches!(
+ &cmd,
+ TestCommand::Disconnect {
+ node: n,
+ connection_type: ConnectionType::Ephemeral,
+ ..
+ } if *n == node
+ );
+
+ apply_command(&mut connections, cmd, &mut time);
+
+ // If session was replaced by inbound or removed by ephemeral disconnect, stop checking
+ if is_inbound_for_node || is_ephemeral_disconnect_for_node {
+ continue;
+ }
+
+ // If session still exists, verify address is preserved
+ if let Some(session) = connections.session_for(&node) {
+ assert_eq!(*session.address(), expected_addr);
+ }
+ }
+
+ // Final check if session exists
+ if let Some(session) = connections.session_for(&node) {
+ assert_eq!(*session.address(), expected_addr);
+ }
+
+ TestResult::passed()
+}
+
+/// Record IP for Routable Addresses
+///
+/// connect signals to record IP only for non-local IP addresses.
+///
+/// connect(node, addr) = Establish { record_ip: Some(ip) }
+/// ⟺ addr.host = Ip(ip) ∧ ¬is_local(ip)
+#[quickcheck]
+fn prop_record_ip_for_routable(
+ NonLocalNode(node): NonLocalNode,
+ RoutableAddress(addr): RoutableAddress,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ match connections.connect(
+ command::Connect {
+ node,
+ addr: addr.clone(),
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ ) {
+ event::Connect::Establish { record_ip, .. } => match record_ip {
+ Some(_) => TestResult::passed(),
+ None => TestResult::error("Expected record_ip for routable address"),
+ },
+ other => TestResult::error(format!("Expected Establish, got {:?}", other)),
+ }
+}
+
+/// Record IP is None for non-IP addresses
+///
+/// connect signals record_ip=None for DNS hostnames.
+#[quickcheck]
+fn prop_no_record_ip_for_dns(
+ NonLocalNode(node): NonLocalNode,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ let addr = Address::from(cyphernet::addr::NetAddr {
+ host: HostName::Dns(String::from("seed.radicle.example.com")),
+ port: 8080,
+ });
+
+ match connections.connect(
+ command::Connect {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ ) {
+ event::Connect::Establish {
+ record_ip: None, ..
+ } => TestResult::passed(),
+ event::Connect::Establish {
+ record_ip: Some(ip),
+ ..
+ } => TestResult::error(format!(
+ "Expected record_ip=None for DNS address, got {:?}",
+ ip
+ )),
+ other => TestResult::error(format!("Expected Establish, got {:?}", other)),
+ }
+}
+
+/// Record IP is None for localhost addresses.
+#[quickcheck]
+fn prop_no_record_ip_for_localhost(
+ NonLocalNode(node): NonLocalNode,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ let localhost_ips = [
+ IpAddr::V4(Ipv4Addr::LOCALHOST),
+ IpAddr::V6(Ipv6Addr::LOCALHOST),
+ ];
+
+ for ip in localhost_ips {
+ let addr = Address::from(cyphernet::addr::NetAddr {
+ host: HostName::Ip(ip),
+ port: 8080,
+ });
+
+ match connections.connect(
+ command::Connect {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ ) {
+ event::Connect::Establish {
+ record_ip: None, ..
+ } => {}
+ event::Connect::Establish {
+ record_ip: Some(recorded),
+ ..
+ } => {
+ return TestResult::error(format!(
+ "Expected record_ip=None for localhost {:?}, got {:?}",
+ ip, recorded
+ ));
+ }
+ other => {
+ return TestResult::error(format!(
+ "Expected Establish for {:?}, got {:?}",
+ ip, other
+ ))
+ }
+ }
+
+ connections.disconnected(
+ command::Disconnect {
+ node,
+ link: Link::Outbound,
+ since: now,
+ connection_type: ConnectionType::Ephemeral,
+ },
+ &DisconnectReason::Command,
+ );
+ }
+
+ TestResult::passed()
+}
+
+// =============================================================================
+// Additional Properties
+// =============================================================================
+
+/// Empty State Initial Condition
+///
+/// New Connections instance has empty sessions.
+#[test]
+fn prop_empty_initial() {
+ let local = NonLocalNode::local_node();
+ let connections = new_connections(local);
+
+ assert_eq!(
+ connections.sessions().iter().count(),
+ 0,
+ "Sessions should be empty"
+ );
+ assert_eq!(
+ connections.sessions().connected().sessions().count(),
+ 0,
+ "Connected sessions should be empty"
+ );
+ assert_eq!(
+ connections.sessions().connected_inbound(),
+ 0,
+ "Inbound count should be 0"
+ );
+ assert_eq!(
+ connections.sessions().connected_outbound(),
+ 0,
+ "Outbound count should be 0"
+ );
+}
+
+/// Double Disconnect Prevention
+///
+/// Disconnecting an already disconnected session returns AlreadyDisconnected.
+#[quickcheck]
+fn prop_double_disconnect(
+ NonLocalNode(node): NonLocalNode,
+ addr: Address,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+
+ // First disconnect
+ connections.disconnected(
+ command::Disconnect {
+ node,
+ link: Link::Inbound,
+ since: now,
+ connection_type: ConnectionType::Persistent,
+ },
+ &DisconnectReason::Command,
+ );
+
+ // Second disconnect should return AlreadyDisconnected
+ match connections.disconnected(
+ command::Disconnect {
+ node,
+ link: Link::Inbound,
+ since: now,
+ connection_type: ConnectionType::Persistent,
+ },
+ &DisconnectReason::Command,
+ ) {
+ event::Disconnected::AlreadyDisconnected { node: n } if n == node => TestResult::passed(),
+ other => TestResult::error(format!(
+ "Expected AlreadyDisconnected for {node}, got {:?}",
+ other
+ )),
+ }
+}
+
+/// Number of Connections Calculation
+///
+/// number_of_outbound_connections counts only Attempted and Connected with outbound links.
+#[quickcheck]
+fn prop_number_of_outbound_connections(
+ NonLocalNode(node1): NonLocalNode,
+ NonLocalNode(node2): NonLocalNode,
+ NonLocalNode(node3): NonLocalNode,
+ RoutableAddress(addr): RoutableAddress,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ // Ensure distinct nodes
+ if node1 == node2 || node2 == node3 || node1 == node3 {
+ return TestResult::discard();
+ }
+
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ // Initial state: 0 outbound
+ assert_eq!(connections.number_of_outbound_connections(), 0);
+
+ // Initial connections are not counted
+ connections.connect(
+ command::Connect {
+ node: node1,
+ addr: addr.clone(),
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+ assert_eq!(connections.number_of_outbound_connections(), 0);
+
+ connections.attempted(command::Attempt { node: node1 });
+ assert_eq!(connections.number_of_outbound_connections(), 1);
+
+ // Add Connected (outbound) - should count
+ connections.connected(
+ command::Connected::Outbound {
+ node: node1,
+ addr: addr.clone(),
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+ assert_eq!(connections.number_of_outbound_connections(), 1);
+
+ // Add Connected (inbound) - should NOT count
+ connections.connected(
+ command::Connected::Inbound {
+ node: node2,
+ addr: addr.clone(),
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+ assert_eq!(connections.number_of_outbound_connections(), 1);
+
+ // Disconnect outbound to Disconnected - should NOT count
+ connections.disconnected(
+ command::Disconnect {
+ node: node1,
+ link: Link::Outbound,
+ since: now,
+ connection_type: ConnectionType::Persistent,
+ },
+ &DisconnectReason::Command,
+ );
+ assert_eq!(connections.number_of_outbound_connections(), 0);
+
+ TestResult::passed()
+}
+
+/// Message Handling for Disconnected Nodes
+///
+/// Messages from disconnected nodes return Disconnected and don't modify state.
+#[quickcheck]
+fn prop_message_from_disconnected(
+ NonLocalNode(node): NonLocalNode,
+ RoutableAddress(addr): RoutableAddress,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ // Connect then disconnect
+ connections.connected(
+ command::Connected::Inbound {
+ node,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+
+ connections.disconnected(
+ command::Disconnect {
+ node,
+ link: Link::Inbound,
+ since: now,
+ connection_type: ConnectionType::Persistent,
+ },
+ &DisconnectReason::Command,
+ );
+ assert!(connections.sessions().is_diconnected(&node));
+
+ // Message to disconnected node
+ let later = now + LocalDuration::from_secs(10);
+ match connections.handle_message(
+ command::Message {
+ node,
+ payload: None,
+ connection_type: ConnectionType::Persistent,
+ },
+ later,
+ ) {
+ event::HandledMessage::Disconnected { node: n } if n == node => {}
+ other => {
+ return TestResult::error(format!(
+ "Expected Disconnected for message to disconnected node, got {:?}",
+ other
+ ))
+ }
+ }
+
+ // State should not have changed
+ assert!(connections.sessions().is_diconnected(&node));
+ TestResult::passed()
+}
+
+/// Stabilization Batch Correctness
+///
+/// stabilise returns exactly the sessions that transition to stable, not all stable sessions.
+#[quickcheck]
+fn prop_stabilise_returns_newly_stable(
+ NonLocalNode(node1): NonLocalNode,
+ NonLocalNode(node2): NonLocalNode,
+ RoutableAddress(addr): RoutableAddress,
+ ArbitraryTime(now): ArbitraryTime,
+) -> TestResult {
+ if node1 == node2 {
+ return TestResult::discard();
+ }
+
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+
+ let stale_connection = connections.config().stale();
+
+ // Connect first session
+ connections.connected(
+ command::Connected::Inbound {
+ node: node1,
+ addr: addr.clone(),
+ connection_type: ConnectionType::Persistent,
+ },
+ now,
+ );
+
+ // Stabilise first session
+ let after_threshold = now + stale_connection + LocalDuration::from_secs(1);
+ let stabilised1 = connections.stabilise(after_threshold);
+ assert_eq!(stabilised1.len(), 1);
+ assert_eq!(stabilised1[0].node(), node1);
+
+ // Connect second session at later time
+ let later = after_threshold + LocalDuration::from_secs(1);
+ connections.connected(
+ command::Connected::Inbound {
+ node: node2,
+ addr,
+ connection_type: ConnectionType::Persistent,
+ },
+ later,
+ );
+
+ // Stabilise again - first session is already stable, should not be returned
+ let much_later = later + stale_connection + LocalDuration::from_secs(1);
+ let stabilised2 = connections.stabilise(much_later);
+ assert_eq!(stabilised2.len(), 1);
+ assert_eq!(stabilised2[0].node(), node2);
+
+ // Stabilise again - both already stable, should return empty
+ let even_later = much_later + LocalDuration::from_secs(1);
+ let stabilised3 = connections.stabilise(even_later);
+ assert!(stabilised3.is_empty());
+
+ TestResult::passed()
+}
+
+// =============================================================================
+// Comprehensive Invariant Test
+// =============================================================================
+
+/// All invariants hold after any command sequence.
+#[quickcheck]
+fn prop_all_invariants(commands: Vec<TestCommand>) -> TestResult {
+ let local = NonLocalNode::local_node();
+ let mut connections = new_connections(local);
+ let mut time = LocalTime::from_secs(1577836800);
+
+ for (i, cmd) in commands.iter().enumerate() {
+ apply_command(&mut connections, cmd.clone(), &mut time);
+
+ if let Err(e) = check_invariants(&connections, &local) {
+ return TestResult::error(format!("Invariant violated after command {}: {}", i, e));
+ }
+ }
+
+ TestResult::passed()
+}
diff --git a/crates/radicle-protocol/src/connections/state/test/arbitrary.rs b/crates/radicle-protocol/src/connections/state/test/arbitrary.rs
new file mode 100644
index 000000000..027f20abb
--- /dev/null
+++ b/crates/radicle-protocol/src/connections/state/test/arbitrary.rs
@@ -0,0 +1,351 @@
+//! Arbitrary implementations for property-based testing of connections.
+
+use std::net::{IpAddr, Ipv4Addr, Ipv6Addr};
+
+use localtime::LocalTime;
+use qcheck::{Arbitrary, Gen};
+use radicle::crypto;
+use radicle::node::{address, Address, HostName, Link, NodeId};
+
+use crate::connections::session::ConnectionType;
+
+// =============================================================================
+// Generation Functions (for types we don't own)
+// =============================================================================
+
+pub fn link(g: &mut Gen) -> Link {
+ if bool::arbitrary(g) {
+ Link::Inbound
+ } else {
+ Link::Outbound
+ }
+}
+
+pub fn local_time(g: &mut Gen) -> LocalTime {
+ // Generate time between year 2020 and 2030
+ let secs = u64::arbitrary(g) % (10 * 365 * 24 * 60 * 60);
+ LocalTime::from_secs(1577836800 + secs)
+}
+
+pub fn routable_ip(g: &mut Gen) -> IpAddr {
+ loop {
+ let ip: IpAddr = if bool::arbitrary(g) {
+ IpAddr::V4(Ipv4Addr::from(u32::arbitrary(g)))
+ } else {
+ let octets: [u8; 16] = Arbitrary::arbitrary(g);
+ IpAddr::V6(Ipv6Addr::from(octets))
+ };
+ if !ip.is_loopback() && !ip.is_unspecified() {
+ return ip;
+ }
+ }
+}
+
+// =============================================================================
+// Newtype Wrappers for Quickcheck Integration
+// =============================================================================
+
+/// Newtype for LocalTime that implements Arbitrary.
+#[derive(Clone, Debug)]
+pub struct ArbitraryTime(pub LocalTime);
+
+impl Arbitrary for ArbitraryTime {
+ fn arbitrary(g: &mut Gen) -> Self {
+ ArbitraryTime(local_time(g))
+ }
+
+ fn shrink(&self) -> Box<dyn Iterator<Item = Self>> {
+ // Shrink toward epoch (1577836800 = 2020-01-01)
+ let secs = self.0.as_secs();
+ let base = 1577836800u64;
+ if secs > base {
+ Box::new(std::iter::once(ArbitraryTime(LocalTime::from_secs(base))))
+ } else {
+ Box::new(std::iter::empty())
+ }
+ }
+}
+
+/// Newtype for Link that implements Arbitrary.
+#[derive(Clone, Debug)]
+pub struct ArbitraryLink(pub Link);
+
+impl Arbitrary for ArbitraryLink {
+ fn arbitrary(g: &mut Gen) -> Self {
+ ArbitraryLink(link(g))
+ }
+
+ fn shrink(&self) -> Box<dyn Iterator<Item = Self>> {
+ // Shrink Outbound to Inbound
+ match self.0 {
+ Link::Outbound => Box::new(std::iter::once(ArbitraryLink(Link::Inbound))),
+ Link::Inbound => Box::new(std::iter::empty()),
+ }
+ }
+}
+
+/// Newtype for NodeId that is never equal to the test local node.
+#[derive(Clone, Debug)]
+pub struct NonLocalNode(pub NodeId);
+
+impl NonLocalNode {
+ pub(super) fn local_node() -> NodeId {
+ NodeId::from(crypto::PublicKey::from([1u8; 32]))
+ }
+}
+
+impl Arbitrary for NonLocalNode {
+ fn arbitrary(g: &mut Gen) -> Self {
+ let local = Self::local_node();
+ loop {
+ let node = NodeId::arbitrary(g);
+ if node != local {
+ return NonLocalNode(node);
+ }
+ }
+ }
+
+ fn shrink(&self) -> Box<dyn Iterator<Item = Self>> {
+ let local = Self::local_node();
+ Box::new(
+ self.0
+ .shrink()
+ .filter(move |n| *n != local)
+ .map(NonLocalNode),
+ )
+ }
+}
+
+/// Newtype for Address with a routable IP.
+#[derive(Clone, Debug)]
+pub struct RoutableAddress(pub Address);
+
+impl Arbitrary for RoutableAddress {
+ fn arbitrary(g: &mut Gen) -> Self {
+ loop {
+ let ip: IpAddr = if bool::arbitrary(g) {
+ IpAddr::V4(Ipv4Addr::from(u32::arbitrary(g)))
+ } else {
+ let octets: [u8; 16] = Arbitrary::arbitrary(g);
+ IpAddr::V6(Ipv6Addr::from(octets))
+ };
+ if address::is_routable(&ip) {
+ let port = u16::arbitrary(g);
+ let addr = Address::from(cyphernet::addr::NetAddr {
+ host: HostName::Ip(ip),
+ port,
+ });
+ return RoutableAddress(addr);
+ }
+ }
+ }
+
+ fn shrink(&self) -> Box<dyn Iterator<Item = Self>> {
+ // Shrinking while maintaining routability is complex; skip it
+ Box::new(std::iter::empty())
+ }
+}
+
+// =============================================================================
+// ConnectionType Arbitrary
+// =============================================================================
+
+impl Arbitrary for ConnectionType {
+ fn arbitrary(g: &mut Gen) -> Self {
+ if bool::arbitrary(g) {
+ ConnectionType::Ephemeral
+ } else {
+ ConnectionType::Persistent
+ }
+ }
+
+ fn shrink(&self) -> Box<dyn Iterator<Item = Self>> {
+ // Shrink Persistent to Ephemeral
+ match self {
+ ConnectionType::Persistent => Box::new(std::iter::once(ConnectionType::Ephemeral)),
+ ConnectionType::Ephemeral => Box::new(std::iter::empty()),
+ }
+ }
+}
+
+// =============================================================================
+// Test Command
+// =============================================================================
+
+/// A command that can be applied to the Connections state machine.
+#[derive(Clone, Debug)]
+pub enum TestCommand {
+ Accept {
+ ip: IpAddr,
+ },
+ Connect {
+ node: NodeId,
+ addr: Address,
+ connection_type: ConnectionType,
+ },
+ Attempt {
+ node: NodeId,
+ },
+ ConnectedInbound {
+ node: NodeId,
+ addr: Address,
+ connection_type: ConnectionType,
+ },
+ ConnectedOutbound {
+ node: NodeId,
+ addr: Address,
+ connection_type: ConnectionType,
+ },
+ Disconnect {
+ node: NodeId,
+ link: Link,
+ connection_type: ConnectionType,
+ },
+ Reconnect {
+ node: NodeId,
+ },
+ Message {
+ node: NodeId,
+ connection_type: ConnectionType,
+ },
+}
+
+impl Arbitrary for TestCommand {
+ fn arbitrary(g: &mut Gen) -> Self {
+ let choice = u8::arbitrary(g) % 8;
+
+ match choice {
+ 0 => TestCommand::Accept { ip: routable_ip(g) },
+ 1 => TestCommand::Connect {
+ node: NodeId::arbitrary(g),
+ addr: Address::arbitrary(g),
+ connection_type: ConnectionType::arbitrary(g),
+ },
+ 2 => TestCommand::Attempt {
+ node: NodeId::arbitrary(g),
+ },
+ 3 => TestCommand::ConnectedInbound {
+ node: NodeId::arbitrary(g),
+ addr: Address::arbitrary(g),
+ connection_type: ConnectionType::arbitrary(g),
+ },
+ 4 => TestCommand::ConnectedOutbound {
+ node: NodeId::arbitrary(g),
+ addr: Address::arbitrary(g),
+ connection_type: ConnectionType::arbitrary(g),
+ },
+ 5 => TestCommand::Disconnect {
+ node: NodeId::arbitrary(g),
+ link: ArbitraryLink::arbitrary(g).0,
+ connection_type: ConnectionType::arbitrary(g),
+ },
+ 6 => TestCommand::Reconnect {
+ node: NodeId::arbitrary(g),
+ },
+ _ => TestCommand::Message {
+ node: NodeId::arbitrary(g),
+ connection_type: ConnectionType::arbitrary(g),
+ },
+ }
+ }
+
+ fn shrink(&self) -> Box<dyn Iterator<Item = Self>> {
+ match self {
+ TestCommand::Connect {
+ node,
+ addr,
+ connection_type,
+ } => {
+ let node = *node;
+ let addr = addr.clone();
+ let ct = *connection_type;
+
+ // Shrink node, then try simpler command
+ let node_shrinks = node.shrink().map(move |n| TestCommand::Connect {
+ node: n,
+ addr: addr.clone(),
+ connection_type: ct,
+ });
+ let simpler = std::iter::once(TestCommand::Attempt { node });
+
+ Box::new(node_shrinks.chain(simpler))
+ }
+ TestCommand::ConnectedInbound {
+ node,
+ addr,
+ connection_type,
+ } => {
+ let node = *node;
+ let addr = addr.clone();
+ let ct = *connection_type;
+
+ let node_shrinks = node.shrink().map(move |n| TestCommand::ConnectedInbound {
+ node: n,
+ addr: addr.clone(),
+ connection_type: ct,
+ });
+ let simpler = std::iter::once(TestCommand::Attempt { node });
+
+ Box::new(node_shrinks.chain(simpler))
+ }
+ TestCommand::ConnectedOutbound {
+ node,
+ addr,
+ connection_type,
+ } => {
+ let node = *node;
+ let addr = addr.clone();
+ let ct = *connection_type;
+
+ let node_shrinks = node.shrink().map(move |n| TestCommand::ConnectedOutbound {
+ node: n,
+ addr: addr.clone(),
+ connection_type: ct,
+ });
+ let simpler = std::iter::once(TestCommand::Attempt { node });
+
+ Box::new(node_shrinks.chain(simpler))
+ }
+ TestCommand::Disconnect {
+ node,
+ link,
+ connection_type,
+ } => {
+ let node = *node;
+ let link = *link;
+ let ct = *connection_type;
+
+ let node_shrinks = node.shrink().map(move |n| TestCommand::Disconnect {
+ node: n,
+ link,
+ connection_type: ct,
+ });
+
+ Box::new(node_shrinks)
+ }
+ TestCommand::Attempt { node } => {
+ let node_shrinks = node.shrink().map(|n| TestCommand::Attempt { node: n });
+ Box::new(node_shrinks)
+ }
+ TestCommand::Reconnect { node } => {
+ let node_shrinks = node.shrink().map(|n| TestCommand::Reconnect { node: n });
+ Box::new(node_shrinks)
+ }
+ TestCommand::Message {
+ node,
+ connection_type,
+ } => {
+ let node = *node;
+ let ct = *connection_type;
+
+ let node_shrinks = node.shrink().map(move |n| TestCommand::Message {
+ node: n,
+ connection_type: ct,
+ });
+
+ Box::new(node_shrinks)
+ }
+ TestCommand::Accept { .. } => Box::new(std::iter::empty()),
+ }
+ }
+}
diff --git a/crates/radicle-protocol/src/connections/state/test/invariants.rs b/crates/radicle-protocol/src/connections/state/test/invariants.rs
new file mode 100644
index 000000000..265e40376
--- /dev/null
+++ b/crates/radicle-protocol/src/connections/state/test/invariants.rs
@@ -0,0 +1,182 @@
+//! Invariant checking functions for connection state management.
+
+use std::collections::HashSet;
+
+use radicle::node::{Link, NodeId};
+
+use crate::connections::session::Sessions;
+use crate::connections::state::Connections;
+
+// =============================================================================
+// Error Types
+// =============================================================================
+
+#[derive(Debug, Clone, PartialEq, Eq)]
+pub enum InvariantViolation {
+ /// A node appears in multiple state collections
+ DuplicateSession { node: NodeId },
+ /// The local node appears in a session collection
+ LocalNodeInSession { node: NodeId },
+ /// Session existence check is inconsistent with state checks
+ SessionExistenceInconsistent { node: NodeId },
+ /// Link count mismatch
+ LinkCountMismatch {
+ link: Link,
+ counted: usize,
+ reported: usize,
+ },
+}
+
+impl std::fmt::Display for InvariantViolation {
+ fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+ match self {
+ Self::DuplicateSession { node } => {
+ write!(f, "Node {:?} appears in multiple states", node)
+ }
+ Self::LocalNodeInSession { node } => {
+ write!(f, "Local node {:?} found in sessions", node)
+ }
+ Self::SessionExistenceInconsistent { node } => {
+ write!(f, "Session existence inconsistent for node {:?}", node)
+ }
+ Self::LinkCountMismatch {
+ link,
+ counted,
+ reported,
+ } => {
+ write!(
+ f,
+ "{:?} count mismatch: counted={}, reported={}",
+ link, counted, reported
+ )
+ }
+ }
+ }
+}
+
+impl std::error::Error for InvariantViolation {}
+
+// =============================================================================
+// Invariant Checking Functions
+// =============================================================================
+
+/// Check all core invariants on a Connections instance.
+pub fn check_invariants(
+ connections: &Connections,
+ local: &NodeId,
+) -> Result<(), InvariantViolation> {
+ let sessions = connections.sessions();
+ check_single_session_per_node(sessions)?;
+ check_local_node_exclusion(sessions, local)?;
+ check_session_existence_consistency(sessions)?;
+ check_link_count_consistency(sessions)?;
+ Ok(())
+}
+
+/// A node should only appear in the sessions exactly once, or not at all.
+pub fn check_single_session_per_node(sessions: &Sessions) -> Result<(), InvariantViolation> {
+ let mut seen_nodes: HashSet<NodeId> = HashSet::new();
+ for (node, _) in sessions.iter() {
+ if !seen_nodes.insert(*node) {
+ return Err(InvariantViolation::DuplicateSession { node: *node });
+ }
+ }
+ Ok(())
+}
+
+/// The local node should never appear in any session collection.
+pub fn check_local_node_exclusion(
+ sessions: &Sessions,
+ local: &NodeId,
+) -> Result<(), InvariantViolation> {
+ if sessions.has_session_for(local) {
+ return Err(InvariantViolation::LocalNodeInSession { node: *local });
+ }
+ Ok(())
+}
+
+/// For every session, the corresponding node should appear exactly once.
+pub fn check_session_existence_consistency(sessions: &Sessions) -> Result<(), InvariantViolation> {
+ for (node, _) in sessions.iter() {
+ let has_session = sessions.has_session_for(node);
+ let state_count = sessions.is_initial(node) as u8
+ + sessions.is_attempted(node) as u8
+ + sessions.get_connected(node).is_some() as u8
+ + sessions.is_diconnected(node) as u8;
+
+ if has_session && state_count != 1 {
+ return Err(InvariantViolation::SessionExistenceInconsistent { node: *node });
+ }
+ if !has_session && state_count != 0 {
+ return Err(InvariantViolation::SessionExistenceInconsistent { node: *node });
+ }
+ }
+ Ok(())
+}
+
+/// For every connected session, the computed link counts should match.
+pub fn check_link_count_consistency(sessions: &Sessions) -> Result<(), InvariantViolation> {
+ let mut inbound_count = 0;
+ let mut outbound_count = 0;
+
+ for session in sessions.connected().sessions() {
+ match session.link() {
+ Link::Inbound => inbound_count += 1,
+ Link::Outbound => outbound_count += 1,
+ }
+ }
+
+ if inbound_count != sessions.connected_inbound() {
+ return Err(InvariantViolation::LinkCountMismatch {
+ link: Link::Inbound,
+ counted: inbound_count,
+ reported: sessions.connected_inbound(),
+ });
+ }
+ if outbound_count != sessions.connected_outbound() {
+ return Err(InvariantViolation::LinkCountMismatch {
+ link: Link::Outbound,
+ counted: outbound_count,
+ reported: sessions.connected_outbound(),
+ });
+ }
+ Ok(())
+}
+
+// =============================================================================
+// State Transition Oracle
+// =============================================================================
+
+#[derive(Clone, Copy, Debug, PartialEq, Eq, Hash)]
+pub enum SessionState {
+ Initial,
+ Attempted,
+ Connected,
+ Disconnected,
+}
+
+/// Check if a state transition is explicitly invalid.
+pub fn is_invalid_transition(from: SessionState, to: SessionState) -> bool {
+ matches!(
+ (from, to),
+ (SessionState::Attempted, SessionState::Initial)
+ | (SessionState::Connected, SessionState::Initial)
+ | (SessionState::Connected, SessionState::Attempted)
+ | (SessionState::Disconnected, SessionState::Attempted)
+ )
+}
+
+/// Determine the current state of a session.
+pub fn get_session_state(sessions: &Sessions, node: &NodeId) -> Option<SessionState> {
+ if sessions.is_initial(node) {
+ Some(SessionState::Initial)
+ } else if sessions.is_attempted(node) {
+ Some(SessionState::Attempted)
+ } else if sessions.get_connected(node).is_some() {
+ Some(SessionState::Connected)
+ } else if sessions.is_diconnected(node) {
+ Some(SessionState::Disconnected)
+ } else {
+ None // Session doesn't exist
+ }
+}
commit be76721d492de8dd422577602aed7eb6644972c0
Author: Fintan Halpenny <fintan.halpenny@gmail.com>
Date: Thu Dec 18 17:34:09 2025 +0000
protocol/connections: noting not using the address during connected
The address is only used in the case of a fresh inbound connection but
is ignored if the connection existed or is an outbound case.
Adding a note to investigate this behaviour, and add a
`debug_assert_eq` for the time being.
diff --git a/crates/radicle-protocol/src/connections/state.rs b/crates/radicle-protocol/src/connections/state.rs
index 730cf31a2..592004a8d 100644
--- a/crates/radicle-protocol/src/connections/state.rs
+++ b/crates/radicle-protocol/src/connections/state.rs
@@ -247,13 +247,18 @@ impl Connections {
let session = self.sessions.inbound(node, addr, connection_type, now);
event::Connected::established(session)
}
- Some(session) => event::Connected::established(session),
+ Some(session) => {
+ // TODO(finto): the address was never used in the
+ // previous code in the case of the link being outbound
+ // – it assumes that the session's address is the same
+ debug_assert_eq!(session.address(), &addr);
+ event::Connected::established(session)
+ }
}
}
- // TODO(finto): why was the address never used? Or did I miss something
command::Connected::Outbound {
node,
- addr: _,
+ addr,
connection_type,
} => {
if let Some(event) =
@@ -269,7 +274,13 @@ impl Connections {
connection_type,
) {
None => event::Connected::missing(node),
- Some(session) => event::Connected::established(session),
+ Some(session) => {
+ // TODO(finto): the address was never used in the
+ // previous code in the case of the link being outbound
+ // – it assumes that the session's address is the same
+ debug_assert_eq!(session.address(), &addr);
+ event::Connected::established(session)
+ }
}
}
}
commit c8095f343ec356105d492cd1a26a5efe4f88f49b
Author: Fintan Halpenny <fintan.halpenny@gmail.com>
Date: Wed Dec 17 16:26:38 2025 +0000
protocol/connections: ensure no sessions for local node
Ensure that a `Session` is never created for the local node by
carrying the `NodeId` and guarding against it when calling state
transitioning methods.
diff --git a/crates/radicle-protocol/src/connections/state.rs b/crates/radicle-protocol/src/connections/state.rs
index bf23b44f3..730cf31a2 100644
--- a/crates/radicle-protocol/src/connections/state.rs
+++ b/crates/radicle-protocol/src/connections/state.rs
@@ -71,6 +71,8 @@ use super::Attempts;
/// [`ConnectionType`]: session::ConnectionType
#[derive(Debug)]
pub struct Connections {
+ /// [`NodeId`] of the running node.
+ local: NodeId,
/// The state of the connection lifecycle for each node in the network.
sessions: Sessions,
/// Rate limiter of IP hosts.
@@ -83,8 +85,9 @@ impl Connections {
/// Construct a new [`Connections`] with the provided [`Config`] and [`RateLimiter`].
///
/// The state will start with no [`Sessions`], to begin.
- pub fn new(config: Config, limiter: RateLimiter) -> Self {
+ pub fn new(local: NodeId, config: Config, limiter: RateLimiter) -> Self {
Self {
+ local,
sessions: Sessions::default(),
limiter,
config,
@@ -145,6 +148,11 @@ impl Connections {
///
/// Transitions the state of the existing session to `Attempted`.
pub fn attempted(&mut self, command::Attempt { node }: command::Attempt) -> event::Attempted {
+ if let Some(event) =
+ self.guard_self_session(&node, event::Attempted::SelfConnection { node })
+ {
+ return event;
+ }
self.sessions
.session_to_attempted(&node)
.map(event::Attempted::attempt)
@@ -169,6 +177,10 @@ impl Connections {
if self.is_disconnected(&node) {
return event::Connect::disconnected(node);
}
+ if let Some(event) = self.guard_self_session(&node, event::Connect::SelfConnection { node })
+ {
+ return event;
+ }
if self.is_connecting(&node) {
return event::Connect::already_connecting(node);
}
@@ -211,6 +223,11 @@ impl Connections {
addr,
connection_type,
} => {
+ if let Some(event) =
+ self.guard_self_session(&node, event::Connected::SelfConnection { node })
+ {
+ return event;
+ }
// In this scenario, it's possible that our peer is persistent, and
// disconnected. We get an inbound connection before we attempt a re-connection,
// and therefore we treat it as a regular inbound connection.
@@ -239,6 +256,11 @@ impl Connections {
addr: _,
connection_type,
} => {
+ if let Some(event) =
+ self.guard_self_session(&node, event::Connected::SelfConnection { node })
+ {
+ return event;
+ }
// Transitions the session to connected no matter what state it is in
match self.sessions.session_to_connected(
&node,
@@ -284,6 +306,11 @@ impl Connections {
}: command::Disconnect,
reason: &DisconnectReason,
) -> event::Disconnected {
+ if let Some(event) =
+ self.guard_self_session(&node, event::Disconnected::SelfConnection { node })
+ {
+ return event;
+ }
let Some(session) = self.sessions.get_session(&node) else {
return event::Disconnected::missing(node);
};
@@ -323,6 +350,11 @@ impl Connections {
&mut self,
command::Reconnect { node }: command::Reconnect,
) -> event::Reconnect {
+ if let Some(event) =
+ self.guard_self_session(&node, event::Reconnect::SelfConnection { node })
+ {
+ return event;
+ }
self.sessions
.session_to_initial(&node)
.map(event::Reconnect::reconnecting)
@@ -397,6 +429,11 @@ impl Connections {
}: command::Message,
now: LocalTime,
) -> event::HandledMessage {
+ if let Some(event) =
+ self.guard_self_session(&node, event::HandledMessage::SelfConnection { node })
+ {
+ return event;
+ }
if self.sessions.is_diconnected(&node) {
return event::HandledMessage::Disconnected { node };
}
@@ -502,6 +539,10 @@ impl Connections {
self.sessions.unresponsive(*now, self.config.stale())
}
+ fn guard_self_session<T>(&self, node: &NodeId, event: T) -> Option<T> {
+ (&self.local == node).then_some(event)
+ }
+
fn has_reached_inbound_limit(&self) -> bool {
self.sessions.connected_inbound() >= self.config.inbound.maximum
}
diff --git a/crates/radicle-protocol/src/connections/state/event.rs b/crates/radicle-protocol/src/connections/state/event.rs
index dec75d4ee..b35aef8fa 100644
--- a/crates/radicle-protocol/src/connections/state/event.rs
+++ b/crates/radicle-protocol/src/connections/state/event.rs
@@ -43,6 +43,8 @@ pub enum Attempted {
},
/// The session did not exist for this node, and it was expected to.
MissingSession { node: NodeId },
+ /// Attempted to connect to the local node.
+ SelfConnection { node: NodeId },
}
impl Attempted {
@@ -80,6 +82,8 @@ pub enum Connect {
/// local node.
record_ip: Option<IpAddr>,
},
+ /// Attempted to connect to the local node.
+ SelfConnection { node: NodeId },
}
impl Connect {
@@ -119,6 +123,8 @@ pub enum Connected {
},
/// An existing session was expected for the node, but there was none.
MissingSession { node: NodeId },
+ /// Connection came from the local node.
+ SelfConnection { node: NodeId },
}
impl Connected {
@@ -169,6 +175,8 @@ pub enum Disconnected {
/// The link that was expected from the call to disconnect.
expected: Link,
},
+ /// Attempted to disconnect from the local node.
+ SelfConnection { node: NodeId },
}
impl Disconnected {
@@ -215,6 +223,8 @@ pub enum Reconnect {
},
/// An existing session was expected for the node, but there was none.
MissingSession { node: NodeId },
+ /// Attempted to reconnect to the local node.
+ SelfConnection { node: NodeId },
}
impl Reconnect {
@@ -251,6 +261,8 @@ pub enum HandledMessage {
},
/// An existing session was expected for the node, but there was none.
MissingSession { node: NodeId },
+ /// Message originated from the local node.
+ SelfConnection { node: NodeId },
}
/// The result of pinging a connected session.
diff --git a/crates/radicle-protocol/src/service.rs b/crates/radicle-protocol/src/service.rs
index 724e27200..fa66688fe 100644
--- a/crates/radicle-protocol/src/service.rs
+++ b/crates/radicle-protocol/src/service.rs
@@ -493,6 +493,7 @@ where
outbound,
};
connections::state::Connections::new(
+ *signer.node_id(),
connections_config,
RateLimiter::new(config.peers()),
)
@@ -1262,6 +1263,9 @@ where
#[cfg(debug_assertions)]
panic!("Service::attempted: unknown session {nid}@{addr}");
}
+ event::Attempted::SelfConnection { node } => {
+ debug!(target: "service", "Attempted connection to this running node {node}");
+ }
}
}
@@ -1298,6 +1302,9 @@ where
event::Connected::MissingSession { node } => {
debug!(target: "service", "Could not transition {node} to connect since its session is missing");
}
+ event::Connected::SelfConnection { node } => {
+ warn!(target: "service", "Connected to local node {node}");
+ }
}
}
@@ -1361,6 +1368,9 @@ where
// connections. In that case we don't want the service to remove the session.
trace!(target: "service", "Conflicting sessions {node} found={found} expected={expected}");
}
+ event::Disconnected::SelfConnection { node } => {
+ warn!(target: "service", "Disconnection came for local node {node}");
+ }
}
let cmd = fetcher::state::command::Cancel { from: remote };
@@ -1756,6 +1766,10 @@ where
HandledMessage::Connected { session } => session,
HandledMessage::Subscribed { session } => session,
HandledMessage::Pinged { session, pinged: _ } => session,
+ HandledMessage::SelfConnection { node } => {
+ warn!(target: "service", "Message sender is the local node {node}");
+ return Ok(());
+ }
};
message.log(log::Level::Debug, remote, Link::Inbound);
@@ -2135,6 +2149,10 @@ where
debug!("Reconnecting to missing session for {node}");
false
}
+ event::Reconnect::SelfConnection { node } => {
+ warn!(target: "service", "Attempted reconnect with local node {node}");
+ false
+ }
}
}
@@ -2142,16 +2160,16 @@ where
use connections::state::command;
use connections::state::event;
- if nid == self.node_id() {
- return Err(ConnectError::SelfConnection);
- }
-
let command = command::Connect {
node: nid,
addr: addr.clone(),
connection_type: self.connection_type(&nid),
};
match self.connections.connect(command, self.clock) {
+ event::Connect::SelfConnection { node } => {
+ debug!(target: "service", "Attempted connect to local node {node}");
+ Err(ConnectError::SelfConnection)
+ }
event::Connect::AlreadyConnected { session } => {
let node = session.node();
trace!(target: "service", "Connected to {node} already");
commit 4bfc8fff53a9e4ccd51904c6dca610330568850b
Author: Fintan Halpenny <fintan.halpenny@gmail.com>
Date: Wed Jul 2 10:36:43 2025 +0100
protocol/service: wire up connections management
This replaces the `Sessions` logic by using `Connections`.
Wherever there was a use of `Sessions`, `Connections` is now used to
drive the state forward.
There are two ways we use the commands, paired with the I/O actions.
The first is to provide the command before the I/O action, so that the
state can be checked and validated that it can transition,
e.g. `connect` to see if a connection can be made.
The second is the I/O action drives the updating of the state that is
reflective of the real-world, e.g. `connected` since an inbound
connection was made. Note that further actions may be take from events
output here, for example, disconnecting the connected node because the
running node is at its limit.
It also removes the configuration constants in `service` to
consolidate them into the one module `connections::config`, and reuses
values set via `connections.config()`.
diff --git a/crates/radicle-node/src/runtime/handle.rs b/crates/radicle-node/src/runtime/handle.rs
index d866bf07b..cf4bcab70 100644
--- a/crates/radicle-node/src/runtime/handle.rs
+++ b/crates/radicle-node/src/runtime/handle.rs
@@ -293,8 +293,8 @@ impl radicle::node::Handle for Handle {
let query: Arc<QueryState> = Arc::new(move |state| {
let sessions = state
.sessions()
- .values()
- .map(radicle::node::Session::from)
+ .iter()
+ .map(|(_, s)| radicle::node::Session::from(s))
.collect();
sender.send(sessions).ok();
@@ -312,7 +312,10 @@ impl radicle::node::Handle for Handle {
fn session(&self, nid: NodeId) -> Result<Option<radicle::node::Session>, Self::Error> {
let (sender, receiver) = chan::bounded(1);
let query: Arc<QueryState> = Arc::new(move |state| {
- let session = state.sessions().get(&nid).map(radicle::node::Session::from);
+ let session = state
+ .sessions()
+ .get_session(&nid)
+ .map(radicle::node::Session::from);
sender.send(session).ok();
Ok(())
diff --git a/crates/radicle-node/src/tests.rs b/crates/radicle-node/src/tests.rs
index 6f20ed443..8e2d53164 100644
--- a/crates/radicle-node/src/tests.rs
+++ b/crates/radicle-node/src/tests.rs
@@ -23,6 +23,8 @@ use radicle::storage::RefUpdate;
use radicle::test::arbitrary::gen;
use radicle::test::storage::MockRepository;
use radicle_protocol::bounded::BoundedVec;
+use radicle_protocol::connections::config::KEEP_ALIVE_DELTA;
+use radicle_protocol::connections::config::STALE_CONNECTION_TIMEOUT;
use crate::collections::{RandomMap, RandomSet};
use crate::identity::RepoId;
@@ -129,7 +131,7 @@ fn test_disconnecting_unresponsive_peer() {
let bob = Peer::new("bob", [9, 9, 9, 9]);
alice.connect_to(&bob);
- assert_eq!(1, alice.sessions().connected().count(), "bob connects");
+ assert_eq!(1, alice.sessions().connected().len(), "bob connects");
alice.elapse(STALE_CONNECTION_TIMEOUT + LocalDuration::from_secs(1));
alice
.outbox()
@@ -173,7 +175,7 @@ fn test_connection_kept_alive() {
ConnectOptions::default(),
));
sim.run_while([&mut alice, &mut bob], |s| !s.is_settled());
- assert_eq!(1, alice.sessions().connected().count(), "bob connects");
+ assert_eq!(1, alice.sessions().connected().len(), "bob connects");
let mut elapsed: LocalDuration = LocalDuration::from_secs(0);
let step: LocalDuration = STALE_CONNECTION_TIMEOUT / 10;
@@ -185,8 +187,16 @@ fn test_connection_kept_alive() {
elapsed = elapsed + step;
}
- assert_eq!(1, alice.sessions().len(), "alice remains connected to Bob");
- assert_eq!(1, bob.sessions().len(), "bob remains connected to Alice");
+ assert_eq!(
+ 1,
+ alice.sessions().connected().len(),
+ "alice remains connected to Bob"
+ );
+ assert_eq!(
+ 1,
+ bob.sessions().connected().len(),
+ "bob remains connected to Alice"
+ );
}
#[test]
@@ -202,7 +212,8 @@ fn test_outbound_connection() {
.service
.sessions()
.connected()
- .map(|(id, _)| *id)
+ .node_ids()
+ .copied()
.collect::<Vec<_>>();
assert!(peers.contains(&eve.id()));
@@ -222,7 +233,8 @@ fn test_inbound_connection() {
.service
.sessions()
.connected()
- .map(|(id, _)| *id)
+ .node_ids()
+ .copied()
.collect::<Vec<_>>();
assert!(peers.contains(&eve.id()));
@@ -1215,7 +1227,8 @@ fn test_persistent_peer_reconnect_attempt() {
let ips = alice
.sessions()
.connected()
- .map(|(id, _)| *id)
+ .node_ids()
+ .copied()
.collect::<Vec<_>>();
assert!(ips.contains(&bob.id()));
assert!(ips.contains(&eve.id()));
@@ -1304,7 +1317,7 @@ fn test_maintain_connections() {
}
assert_eq!(
connected.len(),
- alice.sessions().len(),
+ alice.sessions().connected().len(),
"alice should be connected to the first set of peers"
);
// We now import the other addresses.
@@ -2016,19 +2029,19 @@ fn test_announcement_message_amplification() {
});
// Ensure nodes are all connected, otherwise skip this test run.
- if alice.sessions().connected().count() != 4 {
+ if alice.sessions().connected().len() != 4 {
continue;
}
- if bob.sessions().connected().count() != 4 {
+ if bob.sessions().connected().len() != 4 {
continue;
}
- if eve.sessions().connected().count() != 4 {
+ if eve.sessions().connected().len() != 4 {
continue;
}
- if zod.sessions().connected().count() != 4 {
+ if zod.sessions().connected().len() != 4 {
continue;
}
- if tom.sessions().connected().count() != 4 {
+ if tom.sessions().connected().len() != 4 {
continue;
}
diff --git a/crates/radicle-protocol/src/service.rs b/crates/radicle-protocol/src/service.rs
index 13510e271..724e27200 100644
--- a/crates/radicle-protocol/src/service.rs
+++ b/crates/radicle-protocol/src/service.rs
@@ -9,10 +9,8 @@ pub mod limiter;
pub mod message;
pub mod session;
-use std::collections::hash_map::Entry;
use std::collections::{BTreeSet, HashMap, HashSet};
use std::net::IpAddr;
-use std::ops::{Deref, DerefMut};
use std::sync::Arc;
use std::{fmt, net, time};
@@ -26,18 +24,19 @@ use radicle::identity::Doc;
use radicle::node;
use radicle::node::address;
use radicle::node::address::Store as _;
-use radicle::node::address::{AddressBook, AddressType, KnownAddress};
+use radicle::node::address::{AddressType, KnownAddress};
use radicle::node::config::{PeerConfig, RateLimit};
use radicle::node::device::Device;
use radicle::node::refs::Store as _;
use radicle::node::routing::Store as _;
use radicle::node::seed;
use radicle::node::seed::Store as _;
-use radicle::node::{ConnectOptions, Penalty, Severity};
+use radicle::node::{ConnectOptions, Penalty};
use radicle::storage::refs::SIGREFS_BRANCH;
use radicle::storage::RepositoryError;
use radicle_fetch::policy::SeedingPolicy;
+use crate::connections;
use crate::fetcher;
use crate::fetcher::service::FetcherService;
use crate::fetcher::FetcherState;
@@ -50,9 +49,7 @@ use radicle::identity::RepoId;
use radicle::node::events::Emitter;
use radicle::node::routing;
use radicle::node::routing::InsertResult;
-use radicle::node::{
- Address, Alias, Features, FetchResult, HostName, Seed, Seeds, SyncStatus, SyncedAt,
-};
+use radicle::node::{Address, Alias, Features, FetchResult, Seed, Seeds, SyncStatus, SyncedAt};
use radicle::prelude::*;
use radicle::storage;
use radicle::storage::{refs::RefsAt, Namespaces, ReadStorage};
@@ -65,7 +62,6 @@ use radicle::node::PROTOCOL_VERSION;
use crate::bounded::BoundedVec;
use crate::service::filter::Filter;
pub use crate::service::message::{Message, ZeroBytes};
-pub use crate::service::session::{QueuedFetch, Session};
use crate::worker::FetchError;
use radicle::node::events::{Event, Events};
use radicle::node::{Config, NodeId};
@@ -77,8 +73,6 @@ use self::limiter::RateLimiter;
use self::message::InventoryAnnouncement;
use self::policy::NamespacesError;
-/// How often to run the "idle" task.
-pub const IDLE_INTERVAL: LocalDuration = LocalDuration::from_secs(30);
/// How often to run the "gossip" task.
pub const GOSSIP_INTERVAL: LocalDuration = LocalDuration::from_secs(6);
/// How often to run the "announce" task.
@@ -87,10 +81,6 @@ pub const ANNOUNCE_INTERVAL: LocalDuration = LocalDuration::from_mins(60);
pub const SYNC_INTERVAL: LocalDuration = LocalDuration::from_secs(60);
/// How often to run the "prune" task.
pub const PRUNE_INTERVAL: LocalDuration = LocalDuration::from_mins(30);
-/// Duration to wait on an unresponsive peer before dropping its connection.
-pub const STALE_CONNECTION_TIMEOUT: LocalDuration = LocalDuration::from_mins(2);
-/// How much time should pass after a peer was last active for a *ping* to be sent.
-pub const KEEP_ALIVE_DELTA: LocalDuration = LocalDuration::from_mins(1);
/// Maximum number of latency values to keep for a session.
pub const MAX_LATENCIES: usize = 16;
/// Maximum time difference between the local time, and an announcement timestamp.
@@ -111,8 +101,6 @@ pub const MAX_RECONNECTION_DELTA: LocalDuration = LocalDuration::from_mins(60);
pub const CONNECTION_RETRY_DELTA: LocalDuration = LocalDuration::from_mins(10);
/// How long to wait for a fetch to stall before aborting, default is 3s.
pub const FETCH_TIMEOUT: time::Duration = time::Duration::from_secs(3);
-/// Target number of peers to maintain connections to.
-pub const TARGET_OUTBOUND_PEERS: usize = 8;
/// Maximum external address limit imposed by message size limits.
pub use message::ADDRESS_LIMIT;
@@ -398,7 +386,7 @@ pub struct Service<D, S, G> {
/// Policy configuration.
policies: policy::Config<Write>,
/// Peer sessions, currently or recently connected.
- sessions: Sessions,
+ connections: connections::state::Connections,
/// Clock. Tells the time.
clock: LocalTime,
/// Who relayed what announcement to us. We keep track of this to ensure that
@@ -475,11 +463,13 @@ where
node: NodeAnnouncement,
emitter: Emitter<Event>,
) -> Self {
- let sessions = Sessions::new(rng.clone());
let limiter = RateLimiter::new(config.peers());
let last_timestamp = node.timestamp;
let clock = LocalTime::default(); // Updated on initialize.
let inventory = gossip::inventory(clock.into(), []); // Updated on initialize.
+
+ // TODO(finto): `Connections` and `Fetcher` should be configured outside
+ // of `Service::new` so that they can be setup in a fallible environment
let fetcher = {
let config = fetcher::Config::new()
.with_max_concurrency(
@@ -489,6 +479,24 @@ where
.with_max_capacity(fetcher::MaxQueueSize::default());
FetcherService::new(config)
};
+ let connections = {
+ use connections::config::{Durations, Inbound, Outbound};
+ let durations = Durations::default();
+ let inbound = Inbound::from(RateLimit::from(config.limits.rate.inbound));
+ let outbound = Outbound {
+ rate_limit: config.limits.rate.outbound.into(),
+ target: connections::config::TARGET_OUTBOUND_PEERS,
+ };
+ let connections_config = connections::Config {
+ durations,
+ inbound,
+ outbound,
+ };
+ connections::state::Connections::new(
+ connections_config,
+ RateLimiter::new(config.peers()),
+ )
+ };
Self {
config,
storage,
@@ -501,7 +509,7 @@ where
db,
outbox: Outbox::default(),
limiter,
- sessions,
+ connections,
fetcher,
filter: Filter::empty(),
relayed_by: HashMap::default(),
@@ -742,12 +750,16 @@ where
// Try to establish some connections.
self.maintain_connections();
// Start periodic tasks.
- self.outbox.wakeup(IDLE_INTERVAL);
+ self.outbox.wakeup(self.idle_interval());
self.outbox.wakeup(GOSSIP_INTERVAL);
Ok(())
}
+ pub fn idle_interval(&self) -> LocalDuration {
+ self.connections.config().idle()
+ }
+
pub fn tick(&mut self, now: LocalTime, metrics: &Metrics) {
trace!(
target: "service",
@@ -777,7 +789,7 @@ where
now - self.started_at.expect("Service::wake: service must be initialized")
);
- if now - self.last_idle >= IDLE_INTERVAL {
+ if now - self.last_idle >= self.idle_interval() {
trace!(target: "service", "Running 'idle' task...");
self.keep_alive(&now);
@@ -785,7 +797,7 @@ where
self.idle_connections();
self.maintain_connections();
self.dequeue_fetches();
- self.outbox.wakeup(IDLE_INTERVAL);
+ self.outbox.wakeup(self.idle_interval());
self.last_idle = now;
}
if now - self.last_gossip >= GOSSIP_INTERVAL {
@@ -841,6 +853,8 @@ where
match cmd {
Command::Connect(nid, addr, opts) => {
if opts.persistent {
+ // TODO(finto): I think these should live in the `Connections`
+ // as the persisted peers.
self.config.connect.insert((nid, addr.clone()).into());
}
if let Err(e) = self.connect(nid, addr) {
@@ -894,7 +908,7 @@ where
// Let all our peers know that we're interested in this repo from now on.
self.outbox.broadcast(
Message::subscribe(self.filter(), self.clock.into(), Timestamp::MAX),
- self.sessions.connected().map(|(_, s)| s),
+ self.connections.sessions().connected().sessions(),
);
}
Command::Unseed(id, resp) => {
@@ -996,18 +1010,12 @@ where
) {
let session = {
let reason = format!("peer {from} is not connected; cannot initiate fetch");
- let Some(session) = self.sessions.get_mut(&from) else {
+ let Some(session) = self.connections.get_connected(&from) else {
if let Some(c) = channel {
c.send(FetchResult::Failed { reason }).ok();
}
return;
};
- if !session.is_connected() {
- if let Some(c) = channel {
- c.send(FetchResult::Failed { reason }).ok();
- }
- return;
- }
session
};
@@ -1168,25 +1176,21 @@ where
/// 1. The RID was already being fetched.
/// 2. The session was already at fetch capacity.
pub fn dequeue_fetches(&mut self) {
- let sessions = self
- .sessions
- .shuffled()
- .map(|(k, _)| *k)
+ let mut connected = self
+ .sessions()
+ .connected()
+ .node_ids()
+ .copied()
.collect::<Vec<_>>();
+ self.rng.shuffle(&mut connected);
- for nid in sessions {
- #[allow(clippy::unwrap_used)]
- let sess = self.sessions.get_mut(&nid).unwrap();
- if !sess.is_connected() {
- continue;
- }
-
+ for node in connected {
let Some(fetcher::QueuedFetch {
rid,
from,
refs_at,
timeout,
- }) = self.fetcher.dequeue(&nid)
+ }) = self.fetcher.dequeue(&node)
else {
continue;
};
@@ -1216,15 +1220,9 @@ where
/// Inbound connection attempt.
pub fn accepted(&mut self, ip: IpAddr) -> bool {
- // Always accept localhost connections, even if we already reached
- // our inbound connection limit.
- if ip.is_loopback() || ip.is_unspecified() {
- return true;
- }
- // Check for inbound connection limit.
- if self.sessions.inbound().count() >= self.config.limits.connection.inbound.into() {
- return false;
- }
+ use connections::state::command;
+ use connections::state::event;
+
match self.db.addresses().is_ip_banned(ip) {
Ok(banned) => {
if banned {
@@ -1232,26 +1230,38 @@ where
return false;
}
}
- Err(e) => warn!(target: "service", "Failed to query ban status for {ip}: {e}"),
+ Err(e) => {
+ warn!(target: "service", "Failed to query ban status for {ip}: {e}");
+ return false;
+ }
}
- let host: HostName = ip.into();
- let tokens = self.config.limits.rate.inbound;
-
- if self.limiter.limit(host.clone(), None, &tokens, self.clock) {
- trace!(target: "service", "Rate limiting inbound connection from {host}..");
- return false;
+ match self.connections.accept(command::Accept { ip }, self.clock) {
+ event::Accept::LimitExceeded {
+ ip: _,
+ current_inbound: _,
+ } => false,
+ event::Accept::HostLimited { ip } => {
+ trace!(target: "service", "Rate limiting inbound connection from {ip}..");
+ false
+ }
+ // Always accept localhost connections, even if we already reached
+ // our inbound connection limit.
+ event::Accept::LocalHost { ip: _ } => true,
+ event::Accept::Accepted { ip: _ } => true,
}
- true
}
pub fn attempted(&mut self, nid: NodeId, addr: Address) {
- debug!(target: "service", "Attempted connection to {nid} ({addr})");
-
- if let Some(sess) = self.sessions.get_mut(&nid) {
- sess.to_attempted();
- } else {
- #[cfg(debug_assertions)]
- panic!("Service::attempted: unknown session {nid}@{addr}");
+ use connections::state::command;
+ use connections::state::event;
+ match self.connections.attempted(command::Attempt { node: nid }) {
+ event::Attempted::ConnectionAttempt { session } => {
+ debug!(target: "service", "Attempted connection nid={nid} addr={addr} link={} persistent={}", session.link(), session.persistent());
+ }
+ event::Attempted::MissingSession { node: _ } => {
+ #[cfg(debug_assertions)]
+ panic!("Service::attempted: unknown session {nid}@{addr}");
+ }
}
}
@@ -1262,88 +1272,99 @@ where
}
pub fn connected(&mut self, remote: NodeId, addr: Address, link: Link) {
- info!(target: "service", "Connected to {remote} ({addr}) ({link:?})");
- self.emitter.emit(Event::PeerConnected { nid: remote });
+ use connections::state::command;
+ use connections::state::event;
let msgs = self.initial(link);
-
- if link.is_outbound() {
- if let Some(peer) = self.sessions.get_mut(&remote) {
- peer.to_connected(self.clock);
- self.outbox.write_all(peer, msgs);
+ let connection_type = self.connection_type(&remote);
+ let command = match link {
+ Link::Outbound => command::Connected::Outbound {
+ node: remote,
+ addr: addr.clone(),
+ connection_type,
+ },
+ Link::Inbound => command::Connected::Inbound {
+ node: remote,
+ addr: addr.clone(),
+ connection_type,
+ },
+ };
+ match self.connections.connected(command, self.clock) {
+ event::Connected::Established { session: _ } => {
+ info!(target: "service", "Connected to {remote} ({addr}) ({link:?})");
+ self.emitter.emit(Event::PeerConnected { nid: remote });
+ self.outbox.write_all(remote, msgs);
}
- } else {
- match self.sessions.entry(remote) {
- Entry::Occupied(mut e) => {
- // In this scenario, it's possible that our peer is persistent, and
- // disconnected. We get an inbound connection before we attempt a re-connection,
- // and therefore we treat it as a regular inbound connection.
- //
- // It's also possible that a disconnection hasn't gone through yet and our
- // peer is still in connected state here, while a new inbound connection from
- // that same peer is made. This results in a new connection from a peer that is
- // already connected from the perspective of the service. This appears to be
- // a bug in the underlying networking library.
- let peer = e.get_mut();
- debug!(
- target: "service",
- "Connecting peer {remote} already has a session open ({peer})"
- );
- peer.link = link;
- peer.to_connected(self.clock);
- self.outbox.write_all(peer, msgs);
- }
- Entry::Vacant(e) => {
- if let HostName::Ip(ip) = addr.host {
- if !address::is_local(&ip) {
- if let Err(e) =
- self.db
- .addresses_mut()
- .record_ip(&remote, ip, self.clock.into())
- {
- log::debug!(target: "service", "Failed to record IP address for {remote}: {e}");
- }
- }
- }
- let peer = e.insert(Session::inbound(
- remote,
- addr,
- self.config.is_persistent(&remote),
- self.rng.clone(),
- self.clock,
- ));
- self.outbox.write_all(peer, msgs);
- }
+ event::Connected::MissingSession { node } => {
+ debug!(target: "service", "Could not transition {node} to connect since its session is missing");
}
}
}
pub fn disconnected(&mut self, remote: NodeId, link: Link, reason: &DisconnectReason) {
- let since = self.local_time();
- let Some(session) = self.sessions.get_mut(&remote) else {
- // Since we sometimes disconnect the service eagerly, it's not unusual to get a second
- // disconnection event once the transport is dropped.
- trace!(target: "service", "Redundant disconnection for {remote} ({reason})");
- return;
+ use connections::state::command;
+ use connections::state::event;
+
+ let command = command::Disconnect {
+ node: remote,
+ link,
+ connection_type: self.connection_type(&remote),
+ since: self.clock,
};
- // In cases of connection conflicts, there may be disconnections of one of the two
- // connections. In that case we don't want the service to remove the session.
- if session.link != link {
- return;
+ match self.connections.disconnected(command, reason) {
+ event::Disconnected::Retry {
+ session: _,
+ retry_at: _,
+ delay,
+ } => {
+ info!(target: "service", "Disconnected from {remote} ({reason})");
+ self.emitter.emit(Event::PeerDisconnected {
+ nid: remote,
+ reason: reason.to_string(),
+ });
+ debug!(target: "service", "Reconnecting to {remote} in {delay}..");
+ self.outbox.wakeup(delay);
+ }
+ event::Disconnected::Severed { session, severity } => {
+ info!(target: "service", "Disconnected from {remote} ({reason})");
+ self.emitter.emit(Event::PeerDisconnected {
+ nid: remote,
+ reason: reason.to_string(),
+ });
+ if let Err(e) =
+ self.db
+ .addresses_mut()
+ .disconnected(&remote, session.address(), severity)
+ {
+ error!(target: "service", "Error updating address store: {e}");
+ }
+ // Only re-attempt outbound connections, since we don't care if an inbound connection
+ // is dropped.
+ if link.is_outbound() {
+ self.maintain_connections();
+ }
+ }
+ event::Disconnected::MissingSession { node } => {
+ debug!(target: "service", "Attempted to disconnect missing session {node}");
+ }
+ event::Disconnected::AlreadyDisconnected { node: _ } => {
+ // Since we sometimes disconnect the service eagerly, it's not unusual to get a second
+ // disconnection event once the transport is dropped.
+ trace!(target: "service", "Redundant disconnection for {remote} ({reason})");
+ }
+ event::Disconnected::LinkConflict {
+ node,
+ found,
+ expected,
+ } => {
+ // In cases of connection conflicts, there may be disconnections of one of the two
+ // connections. In that case we don't want the service to remove the session.
+ trace!(target: "service", "Conflicting sessions {node} found={found} expected={expected}");
+ }
}
- info!(target: "service", "Disconnected from {remote} ({reason})");
- self.emitter.emit(Event::PeerDisconnected {
- nid: remote,
- reason: reason.to_string(),
- });
-
- let link = session.link;
- let addr = session.addr.clone();
-
let cmd = fetcher::state::command::Cancel { from: remote };
let fetcher::service::FetchesCancelled { event, orphaned } = self.fetcher.cancel(cmd);
-
match event {
fetcher::state::event::Cancel::Unexpected { from } => {
debug!(target: "service", "No fetches to cancel for {from}");
@@ -1366,53 +1387,6 @@ where
.ok();
}
- // Attempt to re-connect to persistent peers.
- if self.config.peer(&remote).is_some() {
- let delay = LocalDuration::from_secs(2u64.saturating_pow(session.attempts() as u32))
- .clamp(MIN_RECONNECTION_DELTA, MAX_RECONNECTION_DELTA);
-
- // Nb. We always try to reconnect to persistent peers, even when the error appears
- // to not be transient.
- session.to_disconnected(since, since + delay);
-
- debug!(target: "service", "Reconnecting to {remote} in {delay}..");
-
- self.outbox.wakeup(delay);
- } else {
- debug!(target: "service", "Dropping peer {remote}..");
- self.sessions.remove(&remote);
-
- let severity = match reason {
- DisconnectReason::Dial(_)
- | DisconnectReason::Fetch(_)
- | DisconnectReason::Connection(_) => {
- if self.is_online() {
- // If we're "online", there's something wrong with this
- // peer connection specifically.
- Severity::Medium
- } else {
- Severity::Low
- }
- }
- DisconnectReason::Session(e) => e.severity(),
- DisconnectReason::Command
- | DisconnectReason::Conflict
- | DisconnectReason::SelfConnection => Severity::Low,
- };
-
- if let Err(e) = self
- .db
- .addresses_mut()
- .disconnected(&remote, &addr, severity)
- {
- debug!(target: "service", "Failed to update address store: {e}");
- }
- // Only re-attempt outbound connections, since we don't care if an inbound connection
- // is dropped.
- if link.is_outbound() {
- self.maintain_connections();
- }
- }
self.dequeue_fetches();
}
@@ -1543,15 +1517,18 @@ where
// Here we handle the special case where the inventory we received is that of
// a connected peer, as opposed to being relayed to us.
- if let Some(sess) = self.sessions.get_mut(announcer) {
- for id in message.inventory.as_slice() {
- // If we are connected to the announcer of this inventory, update the peer's
- // subscription filter to include all inventory items. This way, we'll
- // relay messages relating to the peer's inventory.
- if let Some(sub) = &mut sess.subscribe {
- sub.filter.insert(id);
- }
-
+ for id in message.inventory.as_slice() {
+ // If we are connected to the announcer of this inventory, update the peer's
+ // subscription filter to include all inventory items. This way, we'll
+ // relay messages relating to the peer's inventory.
+ let should_route = matches!(
+ // The logic previously would consider a missing
+ // subscription as ok
+ self.connections.subscribe_to(announcer, id),
+ connections::session::SubscribeTo::NoSubscription
+ | connections::session::SubscribeTo::Subscribed
+ );
+ if should_route {
// If we're seeding and connected to the announcer, and we don't have
// the inventory, fetch it from the announcer.
if self.policies.is_seeding(id).expect(
@@ -1653,7 +1630,7 @@ where
// Refs can be relayed by peers who don't have the data in storage,
// therefore we only check whether we are connected to the *announcer*,
// which is required by the protocol to only announce refs it has.
- let Some(remote) = self.sessions.get(announcer).cloned() else {
+ let Some(remote) = self.connections.get_connected(announcer) else {
trace!(
target: "service",
"Skipping fetch of {}, no sessions connected to {announcer}",
@@ -1662,7 +1639,7 @@ where
return Ok(relay);
};
// Finally, start the fetch.
- self.fetch_refs_at(message.rid, remote.id, refs, scope, FETCH_TIMEOUT, None);
+ self.fetch_refs_at(message.rid, remote.node(), refs, scope, FETCH_TIMEOUT, None);
return Ok(relay);
}
@@ -1742,58 +1719,54 @@ where
remote: &NodeId,
message: Message,
) -> Result<(), session::Error> {
+ use connections::state::command;
+ use connections::state::command::Payload;
+ use connections::state::event::HandledMessage;
+
let local = self.node_id();
let relay = self.config.is_relay();
- let Some(peer) = self.sessions.get_mut(remote) else {
- debug!(target: "service", "Session not found for {remote}");
- return Ok(());
- };
- peer.last_active = self.clock;
- let limit: RateLimit = match peer.link {
- Link::Outbound => self.config.limits.rate.outbound.into(),
- Link::Inbound => self.config.limits.rate.inbound.into(),
+ let payload = match &message {
+ // TODO(finto): I need to convince myself why this is always from the
+ // sending node and not a relaying node – the previous code assumed so too.
+ Message::Subscribe(subscribe) => Some(Payload::Subscribe(subscribe.clone())),
+ Message::Announcement(_) => None,
+ Message::Info(_) => None,
+ Message::Ping(_) => None,
+ Message::Pong { zeroes } => Some(Payload::pong(zeroes.clone(), self.clock)),
};
- if self
- .limiter
- .limit(peer.addr.clone().into(), Some(remote), &limit, self.clock)
- {
- debug!(target: "service", "Rate limiting message from {remote} ({})", peer.addr);
- return Ok(());
- }
- message.log(log::Level::Debug, remote, Link::Inbound);
-
- let connected = match &mut peer.state {
- session::State::Disconnected { .. } => {
- debug!(target: "service", "Ignoring message from disconnected peer {}", peer.id);
+ let command = command::Message {
+ node: *remote,
+ payload,
+ connection_type: self.connection_type(remote),
+ };
+ let peer = match self.connections.handle_message(command, self.clock) {
+ HandledMessage::MissingSession { node } => {
+ debug!(target: "service", "Dropping message from unknown peer {}", node);
return Ok(());
}
- // In case of a discrepancy between the service state and the state of the underlying
- // wire protocol, we may receive a message from a peer that we consider not fully connected
- // at the service level. To remedy this, we simply transition the peer to a connected state.
- //
- // This is not ideal, but until the wire protocol and service are unified, it's the simplest
- // solution to converge towards the same state.
- session::State::Attempted | session::State::Initial => {
- debug!(target: "service", "Received unexpected message from connecting peer {}", peer.id);
- debug!(target: "service", "Transitioning peer {} to 'connected' state", peer.id);
-
- peer.to_connected(self.clock);
-
- None
+ HandledMessage::Disconnected { node } => {
+ debug!(target: "service", "Ignoring message from disconnected peer {}", node);
+ return Ok(());
}
- session::State::Connected {
- ping, latencies, ..
- } => Some((ping, latencies)),
+ HandledMessage::RateLimited { node } => {
+ info!(target: "service", "Peer {node} reached rate limit, ignoring message");
+ return Ok(());
+ }
+ HandledMessage::Connected { session } => session,
+ HandledMessage::Subscribed { session } => session,
+ HandledMessage::Pinged { session, pinged: _ } => session,
};
+ message.log(log::Level::Debug, remote, Link::Inbound);
+
trace!(target: "service", "Received message {message:?} from {remote}");
match message {
// Process a peer announcement.
Message::Announcement(ann) => {
let relayer = remote;
- let relayer_addr = peer.addr.clone();
+ let relayer_addr = peer.address().clone();
if let Some(id) = self.handle_announcement(relayer, &relayer_addr, &ann)? {
if self.config.is_relay() {
@@ -1834,7 +1807,7 @@ where
}
// Only send messages if we're a relay, or it's our own messages.
if relay || ann.node == local {
- self.outbox.write(peer, ann.into());
+ self.outbox.write(&peer, ann.into());
}
}
}
@@ -1842,7 +1815,6 @@ where
warn!(target: "service", "Failed to query gossip messages from store: {e}");
}
}
- peer.subscribe = Some(subscribe);
}
Message::Info(info) => {
self.handle_info(*remote, &info)?;
@@ -1853,30 +1825,13 @@ where
return Ok(());
}
self.outbox.write(
- peer,
+ &peer,
Message::Pong {
zeroes: ZeroBytes::new(ponglen),
},
);
}
- Message::Pong { zeroes } => {
- if let Some((ping, latencies)) = connected {
- if let session::PingState::AwaitingResponse {
- len: ponglen,
- since,
- } = *ping
- {
- if (ponglen as usize) == zeroes.len() {
- *ping = session::PingState::Ok;
- // Keep track of peer latency.
- latencies.push_back(self.clock - since);
- if latencies.len() > MAX_LATENCIES {
- latencies.pop_front();
- }
- }
- }
- }
- }
+ Message::Pong { zeroes: _ } => {}
}
Ok(())
}
@@ -1949,15 +1904,6 @@ where
]
}
- /// Try to guess whether we're online or not.
- fn is_online(&self) -> bool {
- self.sessions
- .connected()
- .filter(|(_, s)| s.addr.is_routable() && s.last_active >= self.clock - IDLE_INTERVAL)
- .count()
- > 0
- }
-
/// Remove a local repository from our inventory.
fn remove_inventory(&mut self, rid: &RepoId) -> Result<bool, Error> {
let node = self.node_id();
@@ -2140,7 +2086,7 @@ where
) -> Result<(Vec<RefsAt>, Timestamp), Error> {
let (ann, refs) = self.refs_announcement_for(rid, remotes)?;
let timestamp = ann.timestamp();
- let peers = self.sessions.connected().map(|(_, p)| p);
+ let peers = self.connections.sessions().connected().sessions();
// Update our sync status for our own refs. This is useful for determining if refs were
// updated while the node was stopped.
@@ -2157,52 +2103,94 @@ where
}
}
+ // Store our announcement so that it can be retrieved from us later, just like
+ // announcements we receive from peers.
+ if let Err(e) = self.db.gossip_mut().announced(&ann.node, &ann) {
+ error!(target: "service", "Error updating our gossip store with announced message: {e}");
+ }
+
self.outbox.announce(
ann,
peers.filter(|p| {
// Only announce to peers who are allowed to view this repo.
- doc.is_visible_to(&p.id.into())
+ doc.is_visible_to(&p.node().into())
}),
- self.db.gossip_mut(),
);
Ok((refs, timestamp))
}
fn reconnect(&mut self, nid: NodeId, addr: Address) -> bool {
- if let Some(sess) = self.sessions.get_mut(&nid) {
- sess.to_initial();
- self.outbox.connect(nid, addr);
+ use connections::state::command;
+ use connections::state::event;
- return true;
+ match self.connections.reconnect(command::Reconnect { node: nid }) {
+ event::Reconnect::Reconnecting { session } => {
+ debug_assert_eq!(nid, session.node());
+ debug_assert_eq!(addr, *session.address());
+ self.outbox
+ .connect(session.node(), session.address().clone());
+ true
+ }
+ event::Reconnect::MissingSession { node } => {
+ debug!("Reconnecting to missing session for {node}");
+ false
+ }
}
- false
}
fn connect(&mut self, nid: NodeId, addr: Address) -> Result<(), ConnectError> {
- debug!(target: "service", "Connecting to {nid} ({addr})..");
+ use connections::state::command;
+ use connections::state::event;
if nid == self.node_id() {
return Err(ConnectError::SelfConnection);
}
- if self.sessions.contains_key(&nid) {
- return Err(ConnectError::SessionExists { nid });
- }
- if self.sessions.outbound().count() >= self.config.limits.connection.outbound.into() {
- return Err(ConnectError::LimitReached { nid, addr });
- }
- let persistent = self.config.is_persistent(&nid);
- let timestamp: Timestamp = self.clock.into();
- if let Err(e) = self.db.addresses_mut().attempted(&nid, &addr, timestamp) {
- warn!(target: "service", "Failed to update address book with connection attempt: {e}");
+ let command = command::Connect {
+ node: nid,
+ addr: addr.clone(),
+ connection_type: self.connection_type(&nid),
+ };
+ match self.connections.connect(command, self.clock) {
+ event::Connect::AlreadyConnected { session } => {
+ let node = session.node();
+ trace!(target: "service", "Connected to {node} already");
+ Err(ConnectError::SessionExists { nid: node })
+ }
+ event::Connect::AlreadyConnecting { node } => {
+ trace!(target: "service", "Connecting to {node} already");
+ Err(ConnectError::SessionExists { nid: node })
+ }
+ event::Connect::Disconnected { node } => {
+ trace!(target: "service", "Attempted connect to {node} which is disconnected");
+ Err(ConnectError::SessionExists { nid: node })
+ }
+ event::Connect::Establish {
+ node,
+ connection_type: _,
+ record_ip,
+ } => {
+ if let Some(ip) = record_ip {
+ if let Err(e) = self
+ .db
+ .addresses_mut()
+ .record_ip(&node, ip, self.clock.into())
+ {
+ warn!(target: "service", "Failed to record IP address {ip} for {node}: {e}");
+ }
+ }
+ if let Err(e) = self
+ .db
+ .addresses_mut()
+ .attempted(&nid, &addr, self.clock.into())
+ {
+ warn!(target: "service", "Failed to update the address book with connection attempt: {e}");
+ }
+ debug!(target: "service", "Connecting to outbound {nid} ({addr})..");
+ self.outbox.connect(node, addr);
+ Ok(())
+ }
}
- self.sessions.insert(
- nid,
- Session::outbound(nid, addr.clone(), persistent, self.rng.clone()),
- );
- self.outbox.connect(nid, addr);
-
- Ok(())
}
fn seeds(&self, rid: &RepoId, namespaces: HashSet<PublicKey>) -> Result<Seeds, Error> {
@@ -2220,7 +2208,10 @@ where
for seed in self.db.seeds().seeds_for(rid)? {
let seed = seed?;
- let state = self.sessions.get(&seed.nid).map(|s| s.state.clone());
+ let state = self
+ .connections
+ .session_for(&seed.nid)
+ .map(|s| node::State::from(s.state().clone()));
let synced = if local.at == seed.synced_at.oid {
SyncStatus::Synced { at: seed.synced_at }
} else {
@@ -2248,7 +2239,10 @@ where
continue;
}
let addrs = self.db.addresses().addresses_of(&nid)?;
- let state = self.sessions.get(&nid).map(|s| s.state.clone());
+ let state = self
+ .connections
+ .session_for(&nid)
+ .map(|s| node::State::from(s.state().clone()));
seeds.insert(Seed::new(nid, addrs, state, None));
}
@@ -2289,8 +2283,10 @@ where
// 1. Don't relay to a peer who sent us this message.
// 2. Don't relay to the peer who signed this announcement.
let relay_to = self
- .sessions
+ .connections
+ .sessions()
.connected()
+ .into_iter()
.filter(|(id, _)| {
relayed_by
.map(|relayers| !relayers.contains(id))
@@ -2347,12 +2343,22 @@ where
return;
}
let msg = AnnouncementMessage::from(self.inventory.clone());
+ let ann = msg.signed(&self.signer);
+ // Store our announcement so that it can be retrieved from us later, just like
+ // announcements we receive from peers.
+ if let Err(e) = self.db.gossip_mut().announced(&ann.node, &ann) {
+ error!(target: "service", "Error updating our gossip store with announced message: {e}");
+ }
- self.outbox.announce(
- msg.signed(&self.signer),
- self.sessions.connected().map(|(_, p)| p),
- self.db.gossip_mut(),
- );
+ // Borrow-checker prevents us from passing the borrowed sessions, while
+ // we have a mutable borrow of outbox
+ let peers = self
+ .sessions()
+ .connected()
+ .sessions()
+ .cloned()
+ .collect::<Vec<_>>();
+ self.outbox.announce(ann, peers.iter());
self.last_inventory = timestamp;
}
@@ -2373,19 +2379,13 @@ where
}
fn disconnect_unresponsive_peers(&mut self, now: &LocalTime) {
- let stale = self
- .sessions
- .connected()
- .filter(|(_, session)| *now - session.last_active >= STALE_CONNECTION_TIMEOUT);
-
- for (_, session) in stale {
- debug!(target: "service", "Disconnecting unresponsive peer {}..", session.id);
+ for (_, session) in self.connections.unresponsive(now) {
+ debug!(target: "service", "Disconnecting unresponsive peer {}..", session.node());
// TODO: Should we switch the session state to "disconnected" even before receiving
// an official "disconnect"? Otherwise we keep pinging until we get the disconnection.
-
self.outbox.disconnect(
- session.id,
+ session.node(),
DisconnectReason::Session(session::Error::Timeout),
);
}
@@ -2393,13 +2393,13 @@ where
/// Ensure connection health by pinging connected peers.
fn keep_alive(&mut self, now: &LocalTime) {
- let inactive_sessions = self
- .sessions
- .connected_mut()
- .filter(|(_, session)| *now - session.last_active >= KEEP_ALIVE_DELTA)
- .map(|(_, session)| session);
- for session in inactive_sessions {
- session.ping(self.clock, &mut self.outbox).ok();
+ use connections::state::event::Ping;
+ for Ping { session, ping } in self
+ .connections
+ .ping(|| message::Ping::new(&mut self.rng), *now)
+ {
+ debug!(target: "service", "Pinging {}@{}", session.node(), session.address());
+ self.outbox.write(&session, Message::Ping(ping));
}
}
@@ -2413,7 +2413,7 @@ where
.filter(|entry| entry.version == PROTOCOL_VERSION)
.filter(|entry| !entry.address.banned)
.filter(|entry| !entry.penalty.is_connect_threshold_reached())
- .filter(|entry| !self.sessions.contains_key(&entry.node))
+ .filter(|entry| !self.connections.has_session(&entry.node))
.filter(|entry| !self.config.external_addresses.contains(&entry.address.addr))
.filter(|entry| &entry.node != self.nid())
.filter(|entry| !entry.address.addr.is_onion() || self.config.onion.is_some())
@@ -2496,18 +2496,14 @@ where
/// Run idle task for all connections.
fn idle_connections(&mut self) {
- for (_, sess) in self.sessions.iter_mut() {
- sess.idle(self.clock);
-
- if sess.is_stable() {
- // Mark as connected once connection is stable.
- if let Err(e) =
- self.db
- .addresses_mut()
- .connected(&sess.id, &sess.addr, self.clock.into())
- {
- warn!(target: "service", "Failed to update address book with connection: {e}");
- }
+ for session in self.connections.stabilise(self.clock) {
+ // Mark as connected once connection is stable.
+ if let Err(e) = self.db.addresses_mut().connected(
+ &session.node(),
+ session.address(),
+ self.clock.into(),
+ ) {
+ warn!(target: "service", "Error updating address book with connection: {e}");
}
}
}
@@ -2519,14 +2515,9 @@ where
};
trace!(target: "service", "Maintaining connections..");
- let target = TARGET_OUTBOUND_PEERS;
+ let target = self.connections.config().outbound_target();
let now = self.clock;
- let outbound = self
- .sessions
- .values()
- .filter(|s| s.link.is_outbound())
- .filter(|s| s.is_connected() || s.is_connecting())
- .count();
+ let outbound = self.connections.number_of_outbound_connections();
let wanted = target.saturating_sub(outbound);
// Don't connect to more peers than needed.
@@ -2581,27 +2572,33 @@ where
trace!(target: "service", "Maintaining persistent peers..");
let now = self.local_time();
- let mut reconnect = Vec::new();
-
- for (nid, session) in self.sessions.iter_mut() {
- if let Some(addr) = self.config.peer(nid) {
- if let session::State::Disconnected { retry_at, .. } = &mut session.state {
- // TODO: Try to reconnect only if the peer was attempted. A disconnect without
- // even a successful attempt means that we're unlikely to be able to reconnect.
-
- if now >= *retry_at {
- reconnect.push((*nid, addr.clone(), session.attempts()));
- }
+ let reconnect = self.connections.sessions().disconnected().into_iter().fold(
+ Vec::new(),
+ |mut reconnect, (node, session)| {
+ // TODO: Try to reconnect only if the peer was attempted. A disconnect without
+ // even a successful attempt means that we're unlikely to be able to reconnect.
+ if now >= *session.should_retry_at() {
+ reconnect.push((*node, session.address().clone(), session.attempts()))
}
- }
- }
+ reconnect
+ },
+ );
+ // TODO(finto): we don't need to iterate over this twice
for (nid, addr, attempts) in reconnect {
if self.reconnect(nid, addr) {
debug!(target: "service", "Reconnecting to {nid} (attempts={attempts})...");
}
}
}
+
+ fn connection_type(&self, node: &NodeId) -> connections::session::ConnectionType {
+ if self.config.is_persistent(node) {
+ connections::session::ConnectionType::Persistent
+ } else {
+ connections::session::ConnectionType::Ephemeral
+ }
+ }
}
/// Gives read access to the service state.
@@ -2609,7 +2606,7 @@ pub trait ServiceState {
/// Get the Node ID.
fn nid(&self) -> &NodeId;
/// Get the existing sessions.
- fn sessions(&self) -> &Sessions;
+ fn sessions(&self) -> &connections::Sessions;
/// Get fetch state.
fn fetching(&self) -> &FetcherState;
/// Get outbox.
@@ -2640,8 +2637,8 @@ where
self.signer.public_key()
}
- fn sessions(&self) -> &Sessions {
- &self.sessions
+ fn sessions(&self) -> &connections::Sessions {
+ self.connections.sessions()
}
fn fetching(&self) -> &FetcherState {
@@ -2748,67 +2745,3 @@ pub enum LookupError {
#[error(transparent)]
Repository(#[from] RepositoryError),
}
-
-#[derive(Debug, Clone)]
-/// Holds currently (or recently) connected peers.
-pub struct Sessions(AddressBook<NodeId, Session>);
-
-impl Sessions {
- pub fn new(rng: Rng) -> Self {
- Self(AddressBook::new(rng))
- }
-
- /// Iterator over fully connected peers.
- pub fn connected(&self) -> impl Iterator<Item = (&NodeId, &Session)> + Clone {
- self.0
- .iter()
- .filter_map(move |(id, sess)| match &sess.state {
- session::State::Connected { .. } => Some((id, sess)),
- _ => None,
- })
- }
-
- /// Iterator over connected inbound peers.
- pub fn inbound(&self) -> impl Iterator<Item = (&NodeId, &Session)> + Clone {
- self.connected().filter(|(_, s)| s.link.is_inbound())
- }
-
- /// Iterator over outbound peers.
- pub fn outbound(&self) -> impl Iterator<Item = (&NodeId, &Session)> + Clone {
- self.connected().filter(|(_, s)| s.link.is_outbound())
- }
-
- /// Iterator over mutable fully connected peers.
- pub fn connected_mut(&mut self) -> impl Iterator<Item = (&NodeId, &mut Session)> {
- self.0.iter_mut().filter(move |(_, s)| s.is_connected())
- }
-
- /// Iterator over disconnected peers.
- pub fn disconnected_mut(&mut self) -> impl Iterator<Item = (&NodeId, &mut Session)> {
- self.0.iter_mut().filter(move |(_, s)| s.is_disconnected())
- }
-
- /// Return whether this node has a fully established session.
- pub fn is_connected(&self, id: &NodeId) -> bool {
- self.0.get(id).map(|s| s.is_connected()).unwrap_or(false)
- }
-
- /// Return whether this node can be connected to.
- pub fn is_disconnected(&self, id: &NodeId) -> bool {
- self.0.get(id).map(|s| s.is_disconnected()).unwrap_or(true)
- }
-}
-
-impl Deref for Sessions {
- type Target = AddressBook<NodeId, Session>;
-
- fn deref(&self) -> &Self::Target {
- &self.0
- }
-}
-
-impl DerefMut for Sessions {
- fn deref_mut(&mut self) -> &mut Self::Target {
- &mut self.0
- }
-}
diff --git a/crates/radicle-protocol/src/service/io.rs b/crates/radicle-protocol/src/service/io.rs
index 92b7b0e74..0bc1f76e3 100644
--- a/crates/radicle-protocol/src/service/io.rs
+++ b/crates/radicle-protocol/src/service/io.rs
@@ -9,12 +9,12 @@ use radicle::node::Address;
use radicle::node::NodeId;
use radicle::storage::refs::RefsAt;
+use crate::connections::session;
+use crate::connections::session::Session;
use crate::service::message::Message;
-use crate::service::session::Session;
use crate::service::DisconnectReason;
use crate::service::Link;
-use super::gossip;
use super::message::{Announcement, AnnouncementMessage};
/// I/O operation to execute at the network/wire level.
@@ -61,46 +61,35 @@ impl Outbox {
self.io.push_back(Io::Disconnect(id, reason));
}
- pub fn write(&mut self, remote: &Session, msg: Message) {
+ // TODO(finto): use a `ConnectedNode` token that is a smart constructed
+ // `NodeId`. We can take that instead of `Session<session::Connected>`,
+ // which can relax the borrow-checker.
+ pub fn write(&mut self, remote: &Session<session::Connected>, msg: Message) {
let level = match &msg {
Message::Ping(_) | Message::Pong { .. } => log::Level::Trace,
_ => log::Level::Debug,
};
- msg.log(level, &remote.id, Link::Outbound);
+ msg.log(level, &remote.node(), Link::Outbound);
trace!(target: "service", "Write {:?} to {}", &msg, remote);
- self.io.push_back(Io::Write(remote.id, vec![msg]));
+ self.io.push_back(Io::Write(remote.node(), vec![msg]));
}
/// Announce something to a peer. This is meant for our own announcement messages.
pub fn announce<'a>(
&mut self,
ann: Announcement,
- peers: impl Iterator<Item = &'a Session>,
- gossip: &mut impl gossip::Store,
+ peers: impl Iterator<Item = &'a Session<session::Connected>>,
) {
- // Store our announcement so that it can be retrieved from us later, just like
- // announcements we receive from peers.
- if let Err(e) = gossip.announced(&ann.node, &ann) {
- warn!(target: "service", "Failed to update gossip store with announced message: {e}");
- }
-
for peer in peers {
if let AnnouncementMessage::Refs(refs) = &ann.message {
- if let Some(subscribe) = &peer.subscribe {
- if subscribe.filter.contains(&refs.rid) {
- self.write(peer, ann.clone().into());
- } else {
- debug!(
- target: "service",
- "Skipping refs announcement relay to {peer}: peer isn't subscribed to {}",
- refs.rid
- );
- }
+ if peer.is_subscribed_to(&refs.rid) {
+ self.write(peer, ann.clone().into());
} else {
debug!(
target: "service",
- "Skipping refs announcement relay to {peer}: peer didn't send a subscription filter"
+ "Skipping refs announcement relay to {peer}: peer isn't subscribed to {}",
+ refs.rid
);
}
} else {
@@ -109,7 +98,7 @@ impl Outbox {
}
}
- pub fn write_all(&mut self, remote: &Session, msgs: impl IntoIterator<Item = Message>) {
+ pub fn write_all(&mut self, remote: NodeId, msgs: impl IntoIterator<Item = Message>) {
let msgs = msgs.into_iter().collect::<Vec<_>>();
for (ix, msg) in msgs.iter().enumerate() {
@@ -121,18 +110,21 @@ impl Outbox {
ix + 1,
msgs.len()
);
- msg.log(log::Level::Trace, &remote.id, Link::Outbound);
+ msg.log(log::Level::Trace, &remote, Link::Outbound);
}
- self.io.push_back(Io::Write(remote.id, msgs));
+ self.io.push_back(Io::Write(remote, msgs));
}
pub fn wakeup(&mut self, after: LocalDuration) {
self.io.push_back(Io::Wakeup(after));
}
+ // TODO(finto): use a `ConnectedNode` token that is a smart constructed
+ // `NodeId`. We can take that instead of `Session<session::Connected>`,
+ // which can relax the borrow-checker.
pub fn fetch(
&mut self,
- peer: &mut Session,
+ peer: &Session<session::Connected>,
rid: RepoId,
refs_at: Vec<RefsAt>,
timeout: time::Duration,
@@ -152,7 +144,7 @@ impl Outbox {
self.io.push_back(Io::Fetch {
rid,
refs_at,
- remote: peer.id,
+ remote: peer.node(),
timeout,
reader_limit,
});
@@ -162,7 +154,7 @@ impl Outbox {
pub fn broadcast<'a>(
&mut self,
msg: impl Into<Message>,
- peers: impl IntoIterator<Item = &'a Session>,
+ peers: impl IntoIterator<Item = &'a Session<session::Connected>>,
) {
let msg = msg.into();
for peer in peers {
@@ -171,18 +163,14 @@ impl Outbox {
}
/// Relay a message to interested peers.
- pub fn relay<'a>(&mut self, ann: Announcement, peers: impl IntoIterator<Item = &'a Session>) {
+ pub fn relay<'a>(
+ &mut self,
+ ann: Announcement,
+ peers: impl IntoIterator<Item = &'a Session<session::Connected>>,
+ ) {
if let AnnouncementMessage::Refs(msg) = &ann.message {
let id = msg.rid;
- let peers = peers.into_iter().filter(|p| {
- if let Some(subscribe) = &p.subscribe {
- subscribe.filter.contains(&id)
- } else {
- // If the peer did not send us a `subscribe` message, we don't
- // relay any messages to them.
- false
- }
- });
+ let peers = peers.into_iter().filter(|p| p.is_subscribed_to(&id));
self.broadcast(ann, peers);
} else {
self.broadcast(ann, peers);
diff --git a/crates/radicle-protocol/src/service/session.rs b/crates/radicle-protocol/src/service/session.rs
index 121805cae..73a9e4e8f 100644
--- a/crates/radicle-protocol/src/service/session.rs
+++ b/crates/radicle-protocol/src/service/session.rs
@@ -1,15 +1,8 @@
-use std::collections::VecDeque;
-use std::{fmt, time};
-
-use crossbeam_channel as chan;
-use radicle::node::{FetchResult, Severity};
-use radicle::node::{Link, Timestamp};
+use radicle::node::Severity;
+use radicle::node::Timestamp;
pub use radicle::node::{PingState, State};
-use radicle::storage::refs::RefsAt;
-use crate::service::message;
-use crate::service::message::Message;
-use crate::service::{Address, LocalDuration, LocalTime, NodeId, Outbox, RepoId, Rng};
+use crate::service::LocalDuration;
/// Time after which a connection is considered stable.
pub const CONNECTION_STABLE_THRESHOLD: LocalDuration = LocalDuration::from_mins(1);
@@ -45,236 +38,3 @@ impl Error {
}
}
}
-
-/// Error when trying to queue a fetch.
-#[derive(thiserror::Error, Debug, Clone)]
-pub enum QueueError {
- /// The item already exists in the queue.
- #[error("item is already queued")]
- Duplicate(QueuedFetch),
- /// The queue is at capacity.
- #[error("queue capacity reached")]
- CapacityReached(QueuedFetch),
-}
-
-impl QueueError {
- /// Get the inner [`QueuedFetch`].
- pub fn inner(&self) -> &QueuedFetch {
- match self {
- Self::Duplicate(f) => f,
- Self::CapacityReached(f) => f,
- }
- }
-}
-
-/// Fetch waiting to be processed, in the fetch queue.
-#[derive(Debug, Clone)]
-pub struct QueuedFetch {
- /// Repo being fetched.
- pub rid: RepoId,
- /// Peer being fetched from.
- pub from: NodeId,
- /// Refs being fetched.
- pub refs_at: Vec<RefsAt>,
- /// The timeout given for the fetch request.
- pub timeout: time::Duration,
- /// Result channel.
- pub channel: Option<chan::Sender<FetchResult>>,
-}
-
-impl PartialEq for QueuedFetch {
- fn eq(&self, other: &Self) -> bool {
- self.rid == other.rid
- && self.from == other.from
- && self.refs_at == other.refs_at
- && self.channel.is_none()
- && other.channel.is_none()
- }
-}
-
-/// A peer session. Each connected peer will have one session.
-#[derive(Debug, Clone)]
-pub struct Session {
- /// Peer id.
- pub id: NodeId,
- /// Peer address.
- pub addr: Address,
- /// Connection direction.
- pub link: Link,
- /// Whether we should attempt to re-connect
- /// to this peer upon disconnection.
- pub persistent: bool,
- /// Peer connection state.
- pub state: State,
- /// Peer subscription.
- pub subscribe: Option<message::Subscribe>,
- /// Last time a message was received from the peer.
- pub last_active: LocalTime,
-
- /// Connection attempts. For persistent peers, Tracks
- /// how many times we've attempted to connect. We reset this to zero
- /// upon successful connection, once the connection is stable.
- attempts: usize,
- /// Source of entropy.
- rng: Rng,
-}
-
-impl fmt::Display for Session {
- fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
- let mut attrs = Vec::new();
- let state = self.state.to_string();
-
- if self.link.is_inbound() {
- attrs.push("inbound");
- } else {
- attrs.push("outbound");
- }
- if self.persistent {
- attrs.push("persistent");
- }
- attrs.push(state.as_str());
-
- write!(f, "{} [{}]", self.id, attrs.join(" "))
- }
-}
-
-impl From<&Session> for radicle::node::Session {
- fn from(s: &Session) -> Self {
- Self {
- nid: s.id,
- link: if s.link.is_inbound() {
- radicle::node::Link::Inbound
- } else {
- radicle::node::Link::Outbound
- },
- addr: s.addr.clone(),
- state: s.state.clone(),
- }
- }
-}
-
-impl Session {
- pub fn outbound(id: NodeId, addr: Address, persistent: bool, rng: Rng) -> Self {
- Self {
- id,
- addr,
- state: State::Initial,
- link: Link::Outbound,
- subscribe: None,
- persistent,
- last_active: LocalTime::default(),
- attempts: 1,
- rng,
- }
- }
-
- pub fn inbound(id: NodeId, addr: Address, persistent: bool, rng: Rng, time: LocalTime) -> Self {
- Self {
- id,
- addr,
- state: State::Connected {
- since: time,
- ping: PingState::default(),
- latencies: VecDeque::default(),
- stable: false,
- },
- link: Link::Inbound,
- subscribe: None,
- persistent,
- last_active: time,
- attempts: 0,
- rng,
- }
- }
-
- pub fn is_connecting(&self) -> bool {
- matches!(self.state, State::Attempted)
- }
-
- pub fn is_stable(&self) -> bool {
- matches!(self.state, State::Connected { stable: true, .. })
- }
-
- pub fn is_connected(&self) -> bool {
- self.state.is_connected()
- }
-
- pub fn is_disconnected(&self) -> bool {
- matches!(self.state, State::Disconnected { .. })
- }
-
- pub fn is_initial(&self) -> bool {
- matches!(self.state, State::Initial)
- }
-
- pub fn attempts(&self) -> usize {
- self.attempts
- }
-
- /// Run 'idle' task for session.
- pub fn idle(&mut self, now: LocalTime) {
- if let State::Connected {
- since,
- ref mut stable,
- ..
- } = self.state
- {
- if now >= since && now.duration_since(since) >= CONNECTION_STABLE_THRESHOLD {
- *stable = true;
- // Reset number of attempts for stable connections.
- self.attempts = 0;
- }
- }
- }
-
- pub fn to_attempted(&mut self) {
- assert!(
- self.is_initial(),
- "Can only transition to 'attempted' state from 'initial' state"
- );
- self.state = State::Attempted;
- self.attempts += 1;
- }
-
- pub fn to_connected(&mut self, since: LocalTime) {
- self.last_active = since;
-
- if let State::Connected { .. } = &self.state {
- log::debug!(target: "service", "Session {} is already in 'connected' state, resetting..", self.id);
- };
- self.state = State::Connected {
- since,
- ping: PingState::default(),
- latencies: VecDeque::default(),
- stable: false,
- };
- }
-
- /// Move the session state to "disconnected". Returns any pending RID
- /// that was requested.
- pub fn to_disconnected(&mut self, since: LocalTime, retry_at: LocalTime) {
- self.state = State::Disconnected { since, retry_at };
- }
-
- /// Return to initial state from disconnected state. This state transition
- /// happens when we attempt to re-connect to a disconnected peer.
- pub fn to_initial(&mut self) {
- assert!(
- self.is_disconnected(),
- "Can only transition to 'initial' state from 'disconnected' state"
- );
- self.state = State::Initial;
- }
-
- pub fn ping(&mut self, since: LocalTime, reactor: &mut Outbox) -> Result<(), Error> {
- if let State::Connected { ping, .. } = &mut self.state {
- let msg = message::Ping::new(&mut self.rng);
- *ping = PingState::AwaitingResponse {
- len: msg.ponglen,
- since,
- };
- reactor.write(self, Message::Ping(msg));
- }
- Ok(())
- }
-}
commit 5358735530e98f50b023a196518f812ce0607b92
Author: Fintan Halpenny <fintan.halpenny@gmail.com>
Date: Wed Dec 24 12:54:44 2025 +0000
protocol/connections: refactor config
Refactor the configuration of connections.
This places the config types and values into their own sub-module.
It then refactors to have more logical units for sub-configuration:
durations, inbound, and outbound.
It also defines the constants that can be used as the default values,
which will replace the constants defined in `service`.
diff --git a/crates/radicle-protocol/src/connections.rs b/crates/radicle-protocol/src/connections.rs
index 154876d8c..7849a8b54 100644
--- a/crates/radicle-protocol/src/connections.rs
+++ b/crates/radicle-protocol/src/connections.rs
@@ -1,46 +1,8 @@
+pub mod config;
+pub use config::Config;
+
pub mod state;
pub mod session;
pub use session::State;
pub use session::{Attempts, Pinged, Session, Sessions};
-
-use localtime::LocalDuration;
-use radicle::node::config::RateLimits;
-
-/// Minimum amount of time to wait before reconnecting to a peer.
-pub const MIN_RECONNECTION_DELTA: LocalDuration = LocalDuration::from_secs(3);
-/// Maximum amount of time to wait before reconnecting to a peer.
-pub const MAX_RECONNECTION_DELTA: LocalDuration = LocalDuration::from_mins(60);
-
-#[derive(Debug)]
-pub struct Config {
- /// Duration for a connection to be considered idle.
- pub idle: LocalDuration,
- /// Duration to wait until a ping is sent to a connection.
- pub keep_alive: LocalDuration,
- /// Duration to wait until a connection is considered stale.
- pub stale_connection: LocalDuration,
- /// Allowed number of inbound connections
- pub inbound_limit: usize,
- /// The number of outbound peers that we want to reach.
- pub target_outbound_peers: usize,
- pub limits: RateLimits,
- pub reconnection_delay: ReconnectionDelay,
-}
-
-#[derive(Clone, Copy, Debug, PartialEq, Eq)]
-pub struct ReconnectionDelay {
- /// The minimum amount of time to wait before attempting a re-connection.
- pub min_delta: LocalDuration,
- /// The maximum amount of time to wait before attempting a re-connection.
- pub max_delta: LocalDuration,
-}
-
-impl Default for ReconnectionDelay {
- fn default() -> Self {
- Self {
- min_delta: MIN_RECONNECTION_DELTA,
- max_delta: MAX_RECONNECTION_DELTA,
- }
- }
-}
diff --git a/crates/radicle-protocol/src/connections/config.rs b/crates/radicle-protocol/src/connections/config.rs
new file mode 100644
index 000000000..2fb267f2d
--- /dev/null
+++ b/crates/radicle-protocol/src/connections/config.rs
@@ -0,0 +1,160 @@
+//! Configuration parameter for the [`Connections`] state management.
+//!
+//! [`Connections`]: crate::connections::state::Connections
+
+use localtime::LocalDuration;
+
+// TODO(finto): these are realistically only used here. I think that components
+// should define their own configuration values, that eventually compose into
+// the final larger configuration. I think this would result in a more useful
+// layout of the config, e.g. connections.inbound.rateLimit,
+// connections.outbound.rateLimit, connections.duration.idle, etc.
+use radicle::node::config::{RateLimit, RateLimits};
+
+/// How often to run the "idle" task.
+pub const IDLE_INTERVAL: LocalDuration = LocalDuration::from_secs(30);
+/// How much time should pass after a peer was last active for a *ping* to be sent.
+pub const KEEP_ALIVE_DELTA: LocalDuration = LocalDuration::from_mins(1);
+/// Duration to wait on an unresponsive peer before dropping its connection.
+pub const STALE_CONNECTION_TIMEOUT: LocalDuration = LocalDuration::from_mins(2);
+/// Minimum amount of time to wait before reconnecting to a peer.
+pub const MIN_RECONNECTION_DELTA: LocalDuration = LocalDuration::from_secs(3);
+/// Maximum amount of time to wait before reconnecting to a peer.
+pub const MAX_RECONNECTION_DELTA: LocalDuration = LocalDuration::from_mins(60);
+/// Target number of peers to maintain connections to.
+pub const TARGET_OUTBOUND_PEERS: usize = 8;
+
+#[derive(Clone, Copy, Debug)]
+pub struct Config {
+ /// Configurations for connection durations, such as idleness, keep alive,
+ /// reconnection delays, etc.
+ pub durations: Durations,
+ /// Configurations for managing outbound connections.
+ pub outbound: Outbound,
+ /// Configurations for managing outbound connections.
+ pub inbound: Inbound,
+}
+
+impl Config {
+ /// The duration for a connection to be considered "idle".
+ pub fn idle(&self) -> LocalDuration {
+ self.durations.idle
+ }
+
+ /// How much time should pass after a peer was last active for a *ping* to be sent.
+ pub fn keep_alive(&self) -> LocalDuration {
+ self.durations.keep_alive
+ }
+
+ /// Duration to wait on an unresponsive peer before dropping its connection.
+ pub fn stale(&self) -> LocalDuration {
+ self.durations.stale
+ }
+
+ /// Target number of peers to maintain connections to.
+ pub fn outbound_target(&self) -> usize {
+ self.outbound.target
+ }
+
+ /// Maximum number of allowed inbound connections.
+ pub fn max_inbound(&self) -> usize {
+ self.inbound.maximum
+ }
+
+ /// The rate limits for an inbound connection.
+ pub fn inbound_rate_limit(&self) -> RateLimit {
+ self.inbound.rate_limit
+ }
+
+ /// The rate limits for an outbound connection.
+ pub fn outbound_rate_limit(&self) -> RateLimit {
+ self.outbound.rate_limit
+ }
+
+ /// The minimum and maximum durations before attempting reconnecting to a
+ /// node.
+ pub fn reconnection_delay(&self) -> ReconnectionDelay {
+ self.durations.reconnection_delay
+ }
+}
+
+#[derive(Clone, Copy, Debug)]
+pub struct Durations {
+ /// Duration for a connection to be considered idle.
+ pub idle: LocalDuration,
+ /// Duration to wait until a ping is sent to a connection.
+ pub keep_alive: LocalDuration,
+ /// Duration to wait until a connection is considered stale.
+ pub stale: LocalDuration,
+ /// Configure the minimum and maximum delay durations for attempting
+ /// reconnections.
+ pub reconnection_delay: ReconnectionDelay,
+}
+
+impl Default for Durations {
+ fn default() -> Self {
+ Self {
+ idle: IDLE_INTERVAL,
+ keep_alive: KEEP_ALIVE_DELTA,
+ stale: STALE_CONNECTION_TIMEOUT,
+ reconnection_delay: ReconnectionDelay::default(),
+ }
+ }
+}
+
+#[derive(Clone, Copy, Debug)]
+pub struct Outbound {
+ /// Rate limiting of inbound connection actions.
+ pub rate_limit: RateLimit,
+ /// Target number of outbound connections that we want to reach.
+ pub target: usize,
+}
+
+#[derive(Clone, Copy, Debug)]
+pub struct Inbound {
+ /// Rate limiting of inbound connection actions.
+ pub rate_limit: RateLimit,
+ /// The maximum number of inbound connections allowed.
+ pub maximum: usize,
+}
+
+impl From<RateLimit> for Inbound {
+ fn from(limit: RateLimit) -> Self {
+ let maximum = limit.capacity;
+ Self {
+ rate_limit: limit,
+ maximum,
+ }
+ }
+}
+
+pub struct Limits {
+ /// The rate limits for each direction of connection.
+ ///
+ /// This applies to rate limiting incoming connections to accept, and the
+ /// incoming protocol messages.
+ pub rates: RateLimits,
+ /// Allowed maximum number of inbound connections.
+ pub max_inbound: usize,
+}
+
+pub struct Reconnection {
+ pub delay: ReconnectionDelay,
+}
+
+#[derive(Clone, Copy, Debug)]
+pub struct ReconnectionDelay {
+ /// The minimum amount of time to wait before attempting a reconnection.
+ pub min_delta: LocalDuration,
+ /// The maximum amount of time to wait before attempting a reconnection.
+ pub max_delta: LocalDuration,
+}
+
+impl Default for ReconnectionDelay {
+ fn default() -> Self {
+ Self {
+ min_delta: MIN_RECONNECTION_DELTA,
+ max_delta: MAX_RECONNECTION_DELTA,
+ }
+ }
+}
diff --git a/crates/radicle-protocol/src/connections/state.rs b/crates/radicle-protocol/src/connections/state.rs
index f412c6f4a..bf23b44f3 100644
--- a/crates/radicle-protocol/src/connections/state.rs
+++ b/crates/radicle-protocol/src/connections/state.rs
@@ -346,7 +346,7 @@ impl Connections {
// Only stabilise sessions that are not already marked as stable
if !session.is_stable() {
let stable = session
- .stabilise(now, self.config.stale_connection)
+ .stabilise(now, self.config.stale())
.then_some(session.clone());
stabilised.extend(stable);
stabilised
@@ -366,7 +366,7 @@ impl Connections {
mut ping: impl FnMut() -> message::Ping + 'a,
now: LocalTime,
) -> impl Iterator<Item = event::Ping> + 'a {
- let keep_alive = self.config.keep_alive;
+ let keep_alive = self.config.keep_alive();
self.sessions
.inactive(now, keep_alive)
.map(move |(_, session)| event::Ping {
@@ -400,8 +400,8 @@ impl Connections {
if self.sessions.is_diconnected(&node) {
return event::HandledMessage::Disconnected { node };
}
- let outbound_limit = RateLimit::from(self.config.limits.outbound);
- let inbound_limit = RateLimit::from(self.config.limits.inbound);
+ let outbound_limit = self.config.outbound.rate_limit;
+ let inbound_limit = self.config.inbound.rate_limit;
let result =
self.sessions
.while_connecting(&node, None, connection_type, now, |connected| {
@@ -499,18 +499,17 @@ impl Connections {
&self,
now: &LocalTime,
) -> impl Iterator<Item = (&NodeId, &session::Session<session::Connected>)> {
- self.sessions
- .unresponsive(*now, self.config.stale_connection)
+ self.sessions.unresponsive(*now, self.config.stale())
}
fn has_reached_inbound_limit(&self) -> bool {
- self.sessions.connected_inbound() >= self.config.inbound_limit
+ self.sessions.connected_inbound() >= self.config.inbound.maximum
}
fn has_reached_ip_limit(&mut self, ip: &IpAddr, now: LocalTime) -> bool {
let addr = HostName::from(*ip);
self.limiter
- .limit(addr, None, &self.config.limits.inbound, now)
+ .limit(addr, None, &self.config.inbound.rate_limit, now)
}
fn reason_severity(&self, reason: &DisconnectReason, now: LocalTime) -> Severity {
@@ -544,14 +543,14 @@ impl Connections {
}
fn idle(&self) -> LocalDuration {
- self.config.idle
+ self.config.idle()
}
fn reconnection_delay(&self, attempts: Attempts) -> LocalDuration {
let attempts = u32::try_from(usize::from(attempts)).unwrap_or(u32::MAX);
LocalDuration::from_secs(2u64.saturating_pow(attempts)).clamp(
- self.config.reconnection_delay.min_delta,
- self.config.reconnection_delay.max_delta,
+ self.config.reconnection_delay().min_delta,
+ self.config.reconnection_delay().max_delta,
)
}
commit 7ad3b3c8ea855ef687eb1647f8cb283bdcc841f5
Author: Fintan Halpenny <fintan.halpenny@gmail.com>
Date: Wed Jul 2 10:36:43 2025 +0100
protocol: connections manager
This change defines the connections manager in a sans-IO fashion.
The goal is to have on-par behaviour with the management of connection
sessions that exists in the current `Service`.
It does this by using the `Sessions` state, defined in the previous
change, and pairs with commands and events.
The commands indicate what inputs the `Connections` state can receive
for changing the state of the sessions, and the events are the outputs
for those changes.
diff --git a/crates/radicle-protocol/src/connections.rs b/crates/radicle-protocol/src/connections.rs
index aa4d813b9..154876d8c 100644
--- a/crates/radicle-protocol/src/connections.rs
+++ b/crates/radicle-protocol/src/connections.rs
@@ -1,3 +1,46 @@
+pub mod state;
+
pub mod session;
pub use session::State;
pub use session::{Attempts, Pinged, Session, Sessions};
+
+use localtime::LocalDuration;
+use radicle::node::config::RateLimits;
+
+/// Minimum amount of time to wait before reconnecting to a peer.
+pub const MIN_RECONNECTION_DELTA: LocalDuration = LocalDuration::from_secs(3);
+/// Maximum amount of time to wait before reconnecting to a peer.
+pub const MAX_RECONNECTION_DELTA: LocalDuration = LocalDuration::from_mins(60);
+
+#[derive(Debug)]
+pub struct Config {
+ /// Duration for a connection to be considered idle.
+ pub idle: LocalDuration,
+ /// Duration to wait until a ping is sent to a connection.
+ pub keep_alive: LocalDuration,
+ /// Duration to wait until a connection is considered stale.
+ pub stale_connection: LocalDuration,
+ /// Allowed number of inbound connections
+ pub inbound_limit: usize,
+ /// The number of outbound peers that we want to reach.
+ pub target_outbound_peers: usize,
+ pub limits: RateLimits,
+ pub reconnection_delay: ReconnectionDelay,
+}
+
+#[derive(Clone, Copy, Debug, PartialEq, Eq)]
+pub struct ReconnectionDelay {
+ /// The minimum amount of time to wait before attempting a re-connection.
+ pub min_delta: LocalDuration,
+ /// The maximum amount of time to wait before attempting a re-connection.
+ pub max_delta: LocalDuration,
+}
+
+impl Default for ReconnectionDelay {
+ fn default() -> Self {
+ Self {
+ min_delta: MIN_RECONNECTION_DELTA,
+ max_delta: MAX_RECONNECTION_DELTA,
+ }
+ }
+}
diff --git a/crates/radicle-protocol/src/connections/state.rs b/crates/radicle-protocol/src/connections/state.rs
new file mode 100644
index 000000000..f412c6f4a
--- /dev/null
+++ b/crates/radicle-protocol/src/connections/state.rs
@@ -0,0 +1,565 @@
+pub mod command;
+pub mod event;
+
+use std::net::IpAddr;
+
+use localtime::{LocalDuration, LocalTime};
+use radicle::node::config::RateLimit;
+use radicle::node::{address, Severity};
+use radicle::node::{HostName, Link, NodeId};
+use radicle::prelude::RepoId;
+
+use crate::connections::session;
+use crate::connections::session::Sessions;
+use crate::connections::Config;
+use crate::service::limiter::RateLimiter;
+use crate::service::{message, DisconnectReason};
+
+use super::Attempts;
+
+/// Manage the state of node connections for a running node.
+///
+/// Note the following terminology:
+///
+/// - Outbound connection is one that is originating from this node to another node.
+/// - Inbound connection is one that is coming from another node to this node.
+///
+/// These [`Sessions`] are categorized into one of the four following states.
+///
+/// # Initial
+///
+/// - [`Connections::connect`]
+/// - [`Connections::reconnect`]
+///
+/// A connection is in the initial state when the running node has attempted to
+/// make an outbound connection to another node.
+///
+/// It can also be in an initial state when a disconnected node is being
+/// reconnected, and thus goes back to the initial state.
+///
+/// # Attempted
+///
+/// - [`Connections::attempted`]
+///
+/// A connection is in the attempted state when it was previously in the initial
+/// state, and an attempt to make a connection was made.
+///
+/// # Connected
+///
+/// - [`Connections::connected`]
+///
+/// A connection is considered connected in one of two cases.
+///
+/// The attempted outbound connection was established. In this case, there must
+/// have been a session to transition to being connected.
+///
+/// If the connection is inbound then the connection is simply marked as
+/// connected, regardless of the state of a previous connection.
+///
+/// # Disconnected
+///
+/// - [`Connections::disconnected`]
+///
+/// A connection is marked as disconnected only if it is considered a persisted
+/// peer (see [`ConnectionType`]). If this is the case, then a reconnection
+/// attempt should be made after an appropriate delay.
+///
+/// If the connection is not considered for persistence, then it will be removed
+/// from the [`Sessions`], and may be penalized for the severity of its
+/// disconnection reason.
+///
+/// [`ConnectionType`]: session::ConnectionType
+#[derive(Debug)]
+pub struct Connections {
+ /// The state of the connection lifecycle for each node in the network.
+ sessions: Sessions,
+ /// Rate limiter of IP hosts.
+ limiter: RateLimiter,
+ /// Configuration for managing connections.
+ config: Config,
+}
+
+impl Connections {
+ /// Construct a new [`Connections`] with the provided [`Config`] and [`RateLimiter`].
+ ///
+ /// The state will start with no [`Sessions`], to begin.
+ pub fn new(config: Config, limiter: RateLimiter) -> Self {
+ Self {
+ sessions: Sessions::default(),
+ limiter,
+ config,
+ }
+ }
+
+ /// Return the [`Config`] the [`Connections`] were initialized with.
+ pub fn config(&self) -> &Config {
+ &self.config
+ }
+}
+
+impl Connections {
+ // TODO(finto): we could enforce that only an accepted `IpAddr` is allowed
+ // for calling to `connected` – which also helps reinforce that they are
+ // interconnected.
+ /// Perform checks on whether an incoming IP address should be accepted for
+ /// connecting to.
+ ///
+ /// The caller can decide based on the resulting [`event::Accept`] whether
+ /// to accept the connection. However, the following events are recommended
+ /// to result in a rejected address:
+ /// - [`event::Accept::LimitExceeded`]
+ /// - [`event::Accept::HostLimited`]
+ ///
+ /// # State Transition
+ ///
+ /// This does not transition any session states, and simply inspects the
+ /// rate limiter and [`IpAddr`] properties.
+ pub fn accept(
+ &mut self,
+ command::Accept { ip }: command::Accept,
+ now: LocalTime,
+ ) -> event::Accept {
+ // Always accept localhost connections, even if we already reached
+ // our inbound connection limit.
+ if ip.is_loopback() || ip.is_unspecified() {
+ return event::Accept::LocalHost { ip };
+ }
+
+ if self.has_reached_inbound_limit() {
+ return event::Accept::LimitExceeded {
+ ip,
+ current_inbound: self.sessions.connected_inbound(),
+ };
+ }
+
+ if self.has_reached_ip_limit(&ip, now) {
+ return event::Accept::HostLimited { ip };
+ }
+
+ event::Accept::Accepted { ip }
+ }
+
+ /// Mark a connection, with the given node, as attempted.
+ ///
+ /// # State Transition
+ ///
+ /// Transitions the state of the existing session to `Attempted`.
+ pub fn attempted(&mut self, command::Attempt { node }: command::Attempt) -> event::Attempted {
+ self.sessions
+ .session_to_attempted(&node)
+ .map(event::Attempted::attempt)
+ .unwrap_or(event::Attempted::missing(node))
+ }
+
+ /// Make an outbound connection to another node.
+ ///
+ /// # State Transition
+ ///
+ /// A new session will only be created for the given node if a session does
+ /// already exist.
+ pub fn connect(
+ &mut self,
+ command::Connect {
+ node,
+ addr,
+ connection_type,
+ }: command::Connect,
+ now: LocalTime,
+ ) -> event::Connect {
+ if self.is_disconnected(&node) {
+ return event::Connect::disconnected(node);
+ }
+ if self.is_connecting(&node) {
+ return event::Connect::already_connecting(node);
+ }
+ match self.sessions.get_connected(&node) {
+ Some(session) => event::Connect::already_connected(session.clone()),
+ None => {
+ let record_ip = match addr.host {
+ HostName::Ip(ip) => (!address::is_local(&ip)).then_some(ip),
+ _ => None,
+ };
+ self.sessions.outbound(node, addr, connection_type, now);
+ event::Connect::establish(node, connection_type, record_ip)
+ }
+ }
+ }
+
+ /// Mark a connection as connected to another node.
+ ///
+ /// # State Transition
+ ///
+ /// The transition of the connection depends on the kind of the incoming
+ /// connection.
+ ///
+ /// ## Inbound
+ ///
+ /// The connection transitions to connected regardless of what state of the
+ /// session was in before and if the session did not exist.
+ ///
+ /// If the session existed, before the transition, then it is marked as
+ /// inbound.
+ ///
+ /// ## Outbound
+ ///
+ /// The connection transitions to connected regardless of what state of the
+ /// session was in before, however, it must have had an existing session before.
+ pub fn connected(&mut self, connected: command::Connected, now: LocalTime) -> event::Connected {
+ match connected {
+ command::Connected::Inbound {
+ node,
+ addr,
+ connection_type,
+ } => {
+ // In this scenario, it's possible that our peer is persistent, and
+ // disconnected. We get an inbound connection before we attempt a re-connection,
+ // and therefore we treat it as a regular inbound connection.
+ //
+ // It's also possible that a disconnection hasn't gone through yet and our
+ // peer is still in connected state here, while a new inbound connection from
+ // that same peer is made. This results in a new connection from a peer that is
+ // already connected from the perspective of the service. This appears to be
+ // a bug in the underlying networking library.
+ match self.sessions.session_to_connected(
+ &node,
+ now,
+ Some(Link::Inbound),
+ connection_type,
+ ) {
+ None => {
+ let session = self.sessions.inbound(node, addr, connection_type, now);
+ event::Connected::established(session)
+ }
+ Some(session) => event::Connected::established(session),
+ }
+ }
+ // TODO(finto): why was the address never used? Or did I miss something
+ command::Connected::Outbound {
+ node,
+ addr: _,
+ connection_type,
+ } => {
+ // Transitions the session to connected no matter what state it is in
+ match self.sessions.session_to_connected(
+ &node,
+ now,
+ Some(Link::Outbound),
+ connection_type,
+ ) {
+ None => event::Connected::missing(node),
+ Some(session) => event::Connected::established(session),
+ }
+ }
+ }
+ }
+
+ /// Disconnect a node.
+ ///
+ /// # State Transition
+ ///
+ /// The [`ConnectionType`] decides how a disconnected node should be
+ /// treated.
+ ///
+ /// ## `Ephemeral`
+ ///
+ /// If the connection is ephemeral, then the session for that connection is
+ /// removed, and the severity of the reason is recorded.
+ ///
+ /// The severity can then be used for penalizing a node.
+ ///
+ /// ## `Persistent`
+ ///
+ /// If the connection is persistent, then the session will remain, and be
+ /// marked as disconnected. The connection should then be retried after the
+ /// returned delay.
+ ///
+ /// [`ConnectionType`]: session::ConnectionType
+ pub fn disconnected(
+ &mut self,
+ command::Disconnect {
+ node,
+ link,
+ since,
+ connection_type,
+ }: command::Disconnect,
+ reason: &DisconnectReason,
+ ) -> event::Disconnected {
+ let Some(session) = self.sessions.get_session(&node) else {
+ return event::Disconnected::missing(node);
+ };
+ if matches!(session.state(), session::State::Disconnected(_)) {
+ return event::Disconnected::already_disconnected(node);
+ }
+ if *session.link() != link {
+ return event::Disconnected::conflict(&session, link);
+ }
+
+ match connection_type {
+ session::ConnectionType::Ephemeral => {
+ let severity = self.reason_severity(reason, since);
+ self.sessions
+ .remove_session(&node)
+ .map(|session| event::Disconnected::severed(session, severity))
+ .unwrap_or(event::Disconnected::missing(node))
+ }
+ session::ConnectionType::Persistent => {
+ let delay = self.reconnection_delay(session.attempts());
+ let retry_at = since + delay;
+ self.sessions
+ .session_to_disconnected(&node, since, retry_at)
+ .map(|session| event::Disconnected::retry(session, delay, retry_at))
+ .unwrap_or(event::Disconnected::missing(node))
+ }
+ }
+ }
+
+ /// Reconnect the node.
+ ///
+ /// # State Transition
+ ///
+ /// The session must be in the disconnected state, and transitions to the
+ /// initial state.
+ pub fn reconnect(
+ &mut self,
+ command::Reconnect { node }: command::Reconnect,
+ ) -> event::Reconnect {
+ self.sessions
+ .session_to_initial(&node)
+ .map(event::Reconnect::reconnecting)
+ .unwrap_or(event::Reconnect::missing(node))
+ }
+
+ /// Mark connected nodes as stable.
+ ///
+ /// If the connected session has lasted longer than the configured stable
+ /// threshold duration, then the session will be marked as stable, and the
+ /// attempts counter is reset.
+ ///
+ /// # State Transition
+ ///
+ /// This does not change the session's state.
+ pub fn stabilise(&mut self, now: LocalTime) -> Vec<session::Session<session::Connected>> {
+ self.sessions
+ .connected_mut()
+ .sessions()
+ .fold(Vec::new(), |mut stabilised, session| {
+ // Only stabilise sessions that are not already marked as stable
+ if !session.is_stable() {
+ let stable = session
+ .stabilise(now, self.config.stale_connection)
+ .then_some(session.clone());
+ stabilised.extend(stable);
+ stabilised
+ } else {
+ stabilised
+ }
+ })
+ }
+
+ /// Ping any inactive connections to see if they are alive.
+ ///
+ /// # State Transition
+ ///
+ /// This does not change the sessions' state.
+ pub fn ping<'a>(
+ &'a mut self,
+ mut ping: impl FnMut() -> message::Ping + 'a,
+ now: LocalTime,
+ ) -> impl Iterator<Item = event::Ping> + 'a {
+ let keep_alive = self.config.keep_alive;
+ self.sessions
+ .inactive(now, keep_alive)
+ .map(move |(_, session)| event::Ping {
+ session: session.clone(),
+ ping: session.ping(ping(), now),
+ })
+ }
+
+ /// Process a incoming message from a node.
+ ///
+ /// The [`Payload`] of the message may alter the state of the session.
+ ///
+ /// If the node is marked as disconnected, then the message is dropped from
+ /// affecting the node's session.
+ ///
+ /// # State Transition
+ ///
+ /// Since a message must come from a connected node, the session will
+ /// transition from its initial or attempted state to connected.
+ ///
+ /// [`Payload`]: command::Payload
+ pub fn handle_message(
+ &mut self,
+ command::Message {
+ node,
+ payload,
+ connection_type,
+ }: command::Message,
+ now: LocalTime,
+ ) -> event::HandledMessage {
+ if self.sessions.is_diconnected(&node) {
+ return event::HandledMessage::Disconnected { node };
+ }
+ let outbound_limit = RateLimit::from(self.config.limits.outbound);
+ let inbound_limit = RateLimit::from(self.config.limits.inbound);
+ let result =
+ self.sessions
+ .while_connecting(&node, None, connection_type, now, |connected| {
+ let limit: RateLimit = match connected.link() {
+ Link::Outbound => outbound_limit,
+ Link::Inbound => inbound_limit,
+ };
+ if self.limiter.limit(
+ connected.address().clone().into(),
+ Some(&connected.node()),
+ &limit,
+ now,
+ ) {
+ return event::HandledMessage::RateLimited { node };
+ }
+ match payload {
+ Some(command::Payload::Subscribe(subscription)) => {
+ connected.set_subscription(subscription);
+ event::HandledMessage::Subscribed {
+ session: connected.clone(),
+ }
+ }
+ Some(command::Payload::Pong(pong)) => {
+ let pinged = connected.pinged(pong);
+ event::HandledMessage::Pinged {
+ session: connected.clone(),
+ pinged,
+ }
+ }
+ None => event::HandledMessage::Connected {
+ session: connected.clone(),
+ },
+ }
+ });
+ result.unwrap_or(event::HandledMessage::MissingSession { node })
+ }
+
+ /// Add a repository to the given node's subscription.
+ ///
+ /// Returns `true` if the session existed and the repository was added to
+ /// the subscription successfully.
+ pub fn subscribe_to(&mut self, node: &NodeId, rid: &RepoId) -> session::SubscribeTo {
+ self.sessions.subscribe_to(node, rid)
+ }
+}
+
+impl Connections {
+ /// The [`Sessions`] that are currently being managed.
+ pub fn sessions(&self) -> &Sessions {
+ &self.sessions
+ }
+
+ /// Returns `true` is the session exists for the given node.
+ pub fn has_session(&self, node: &NodeId) -> bool {
+ self.sessions.has_session_for(node)
+ }
+
+ /// Returns the number of outbound connections that are in a "connecting"
+ /// state. That is, they are either attempting to connect or have already
+ /// connected.
+ pub fn number_of_outbound_connections(&self) -> usize {
+ self.sessions.number_of_outbound_connections()
+ }
+
+ /// Returns the number of inbound connections that are in a "connecting"
+ /// state. That is, they are either attempting to connect or have already
+ /// connected.
+ pub fn number_of_inbound_connections(&self) -> usize {
+ self.sessions.number_of_inbound_connections()
+ }
+
+ /// Return the [`Session`] for the given [`NodeId`], if it exists.
+ /// Note that the session can be in any [`State`].
+ ///
+ /// [`Session`]: session::Session
+ /// [`State`]: session::State
+ pub fn session_for(&self, node: &NodeId) -> Option<session::Session<session::State>> {
+ self.sessions.get_session(node)
+ }
+
+ /// Return the connected [`Session`] for the given [`NodeId`], if it exists.
+ ///
+ /// [`Session`]: session::Session
+ pub fn get_connected(&self, node: &NodeId) -> Option<&session::Session<session::Connected>> {
+ self.sessions.get_connected(node)
+ }
+
+ /// Return an `Iterator` of all unresponsive, connected [`Session`]s.
+ ///
+ /// A session is considered unresponsive, if it has be inactive after the
+ /// configured stale connection duration.
+ ///
+ /// [`Session`]: session::Session
+ pub fn unresponsive(
+ &self,
+ now: &LocalTime,
+ ) -> impl Iterator<Item = (&NodeId, &session::Session<session::Connected>)> {
+ self.sessions
+ .unresponsive(*now, self.config.stale_connection)
+ }
+
+ fn has_reached_inbound_limit(&self) -> bool {
+ self.sessions.connected_inbound() >= self.config.inbound_limit
+ }
+
+ fn has_reached_ip_limit(&mut self, ip: &IpAddr, now: LocalTime) -> bool {
+ let addr = HostName::from(*ip);
+ self.limiter
+ .limit(addr, None, &self.config.limits.inbound, now)
+ }
+
+ fn reason_severity(&self, reason: &DisconnectReason, now: LocalTime) -> Severity {
+ match reason {
+ DisconnectReason::Dial(_)
+ | DisconnectReason::Fetch(_)
+ | DisconnectReason::Connection(_) => {
+ if self.is_online(now) {
+ // If we're "online", there's something wrong with this
+ // peer connection specifically.
+ Severity::Medium
+ } else {
+ Severity::Low
+ }
+ }
+ DisconnectReason::Session(e) => e.severity(),
+ DisconnectReason::Command
+ | DisconnectReason::Conflict
+ | DisconnectReason::SelfConnection => Severity::Low,
+ }
+ }
+
+ /// Try to guess whether we're online or not.
+ fn is_online(&self, now: LocalTime) -> bool {
+ self.sessions
+ .connected()
+ .sessions()
+ .filter(|s| s.address().is_routable() && *s.last_active() >= now - self.idle())
+ .count()
+ > 0
+ }
+
+ fn idle(&self) -> LocalDuration {
+ self.config.idle
+ }
+
+ fn reconnection_delay(&self, attempts: Attempts) -> LocalDuration {
+ let attempts = u32::try_from(usize::from(attempts)).unwrap_or(u32::MAX);
+ LocalDuration::from_secs(2u64.saturating_pow(attempts)).clamp(
+ self.config.reconnection_delay.min_delta,
+ self.config.reconnection_delay.max_delta,
+ )
+ }
+
+ fn is_connecting(&self, node: &NodeId) -> bool {
+ self.sessions.is_initial(node) || self.sessions.is_attempted(node)
+ }
+
+ fn is_disconnected(&self, node: &NodeId) -> bool {
+ self.sessions.is_diconnected(node)
+ }
+}
diff --git a/crates/radicle-protocol/src/connections/state/command.rs b/crates/radicle-protocol/src/connections/state/command.rs
new file mode 100644
index 000000000..3c1063146
--- /dev/null
+++ b/crates/radicle-protocol/src/connections/state/command.rs
@@ -0,0 +1,104 @@
+use std::net::IpAddr;
+
+use localtime::LocalTime;
+use radicle::node::{Address, Link, NodeId};
+
+use crate::connections::session;
+use crate::connections::session::ConnectionType;
+use crate::service::message;
+use crate::service::ZeroBytes;
+
+/// Check whether the incoming [`IpAddr`] should be accepted for connection.
+#[derive(Clone, Debug, PartialEq, Eq)]
+pub struct Accept {
+ pub ip: IpAddr,
+}
+
+/// Mark a connection as attempted.
+pub struct Attempt {
+ /// The node that is being attempted.
+ pub node: NodeId,
+}
+
+/// Make an outbound connection to a node.
+#[derive(Clone, Debug, PartialEq, Eq)]
+pub struct Connect {
+ /// The node that is being connected to.
+ pub node: NodeId,
+ /// The found address of the node that is being contacted.
+ pub addr: Address,
+ /// Mark the session with the given [`ConnectionType`].
+ pub connection_type: ConnectionType,
+}
+
+/// Mark the node as connected.
+pub enum Connected {
+ /// The connected node is made through an inbound connection.
+ Inbound {
+ /// The node that is now connected.
+ node: NodeId,
+ /// The address the node is connected via.
+ addr: Address,
+ /// Mark the session with the given [`ConnectionType`].
+ connection_type: ConnectionType,
+ },
+ /// The connected node is made through an outbound connection.
+ Outbound {
+ /// The node that is now connected.
+ node: NodeId,
+ /// The address the node is connected via.
+ addr: Address,
+ /// Mark the session with the given [`ConnectionType`].
+ connection_type: ConnectionType,
+ },
+}
+
+/// Either mark the node as disconnected, or remove its session.
+#[derive(Debug)]
+pub struct Disconnect {
+ /// The node being disconnected.
+ pub node: NodeId,
+ /// The link of the disconnection.
+ pub link: Link,
+ /// When did the disconnection occur.
+ pub since: LocalTime,
+ /// Decides whether the session is disconnected or removed.
+ pub connection_type: ConnectionType,
+}
+
+/// Mark the node as initial, if it was disconnected.
+#[derive(Debug)]
+pub struct Reconnect {
+ pub node: NodeId,
+}
+
+/// Handle an incoming message from the given node.
+pub struct Message {
+ /// The node sending the message.
+ pub node: NodeId,
+ /// The payload that is part of the incoming message.
+ ///
+ /// Not all messages are required for changing the state of the connection's
+ /// state, so it is optional.
+ pub payload: Option<Payload>,
+ /// Mark the session with the given [`ConnectionType`].
+ pub connection_type: ConnectionType,
+}
+
+/// The payload of an incoming message.
+pub enum Payload {
+ /// The message describes the node's subscription payload.
+ Subscribe(message::Subscribe),
+ /// The message was a "pong" in response to this node's "ping".
+ Pong(session::Pong),
+}
+
+impl Payload {
+ pub fn pong(zeroes: ZeroBytes, now: LocalTime) -> Self {
+ Self::Pong(session::Pong { now, zeroes })
+ }
+
+ pub fn subscribe(subscription: message::Subscribe) -> Self {
+ Self::Subscribe(subscription)
+ }
+}
diff --git a/crates/radicle-protocol/src/connections/state/event.rs b/crates/radicle-protocol/src/connections/state/event.rs
new file mode 100644
index 000000000..dec75d4ee
--- /dev/null
+++ b/crates/radicle-protocol/src/connections/state/event.rs
@@ -0,0 +1,262 @@
+use std::net::IpAddr;
+
+use localtime::{LocalDuration, LocalTime};
+use radicle::node::{Link, NodeId, Severity};
+
+use crate::connections::session;
+use crate::connections::session::{ConnectionType, Pinged, Session};
+use crate::service::message;
+
+/// The result of checking an address for accepting an inbound connection.
+#[derive(Clone, Copy, Debug, PartialEq, Eq, Hash)]
+pub enum Accept {
+ /// The inbound limit for the node has been reached.
+ ///
+ /// It is recommended that the incoming connection is rejected.
+ LimitExceeded {
+ /// The [`IpAddr`] that made the attempt.
+ ip: IpAddr,
+ /// The current inbound size.
+ current_inbound: usize,
+ },
+ /// The address has been rate limited.
+ ///
+ /// It is recommended that the incoming connection is rejected.
+ HostLimited {
+ /// The [`IpAddr`] that made the attempt, and is being rate limited.
+ ip: IpAddr,
+ },
+ /// The [`IpAddr`] is likely a localhost connection.
+ ///
+ /// It is recommended that this is accepted for local area networks.
+ LocalHost { ip: IpAddr },
+ /// The [`IpAddr`] should be accepted by the system, and the connection allowed.
+ Accepted { ip: IpAddr },
+}
+
+/// The result of a connection attempt from a node.
+#[derive(Clone, Debug, PartialEq, Eq)]
+pub enum Attempted {
+ /// The connection was transitioned to attempted.
+ ConnectionAttempt {
+ session: Box<Session<session::Attempted>>,
+ },
+ /// The session did not exist for this node, and it was expected to.
+ MissingSession { node: NodeId },
+}
+
+impl Attempted {
+ pub(super) fn attempt(session: Session<session::Attempted>) -> Self {
+ Self::ConnectionAttempt {
+ session: Box::new(session),
+ }
+ }
+
+ pub(super) fn missing(node: NodeId) -> Self {
+ Self::MissingSession { node }
+ }
+}
+
+/// The result when making an outbound connection to a node.
+#[derive(Clone, Debug, PartialEq, Eq)]
+pub enum Connect {
+ /// The node is already being connected to, but has not transitioned to
+ /// fully-connected.
+ AlreadyConnecting { node: NodeId },
+ /// The node already has a connected session.
+ AlreadyConnected {
+ session: Box<session::Session<session::Connected>>,
+ },
+ /// The node is already in a disconnected state, and requires a call to
+ /// reconnect to transition it to initial.
+ Disconnected { node: NodeId },
+ /// The caller should establish the outbound connection.
+ Establish {
+ /// The node to establish the connection with.
+ node: NodeId,
+ /// The session was given this [`ConnectionType`].
+ connection_type: ConnectionType,
+ /// If this is `Some`, then the [`IpAddr`] should be recorded by the
+ /// local node.
+ record_ip: Option<IpAddr>,
+ },
+}
+
+impl Connect {
+ pub(super) fn already_connecting(node: NodeId) -> Self {
+ Self::AlreadyConnecting { node }
+ }
+
+ pub(super) fn already_connected(session: session::Session<session::Connected>) -> Self {
+ Self::AlreadyConnected {
+ session: Box::new(session),
+ }
+ }
+
+ pub(super) fn disconnected(node: NodeId) -> Self {
+ Self::Disconnected { node }
+ }
+
+ pub(super) fn establish(
+ node: NodeId,
+ connection_type: ConnectionType,
+ record_ip: Option<IpAddr>,
+ ) -> Self {
+ Self::Establish {
+ node,
+ connection_type,
+ record_ip,
+ }
+ }
+}
+
+/// The result when a node is marked a connected.
+#[derive(Clone, Debug, PartialEq, Eq)]
+pub enum Connected {
+ /// The connection was marked as connected.
+ Established {
+ session: Box<session::Session<session::Connected>>,
+ },
+ /// An existing session was expected for the node, but there was none.
+ MissingSession { node: NodeId },
+}
+
+impl Connected {
+ pub(super) fn established(session: session::Session<session::Connected>) -> Self {
+ Self::Established {
+ session: Box::new(session),
+ }
+ }
+
+ pub(super) fn missing(node: NodeId) -> Self {
+ Self::MissingSession { node }
+ }
+}
+
+/// The result when a node is disconnected.
+#[derive(Clone, Debug, PartialEq, Eq)]
+pub enum Disconnected {
+ /// The session was marked as disconnected and a reconnection should be
+ /// tried.
+ Retry {
+ /// The session that is now marked as disconnected.
+ session: session::Session<session::Disconnected>,
+ /// The delay to wait until the reconnection.
+ delay: LocalDuration,
+ /// The time for when the reconnection should happen.
+ retry_at: LocalTime,
+ },
+ /// The session was removed, and the severity of the disconnection is
+ /// recorded.
+ Severed {
+ /// The session that was removed.
+ session: session::Session<session::State>,
+ /// The severity of the reason for disconnection.
+ ///
+ /// Can be used for penalizing the node for bad behavior.
+ severity: Severity,
+ },
+ /// An existing session was expected for the node, but there was none.
+ MissingSession { node: NodeId },
+ /// The node was already marked as disconnected.
+ AlreadyDisconnected { node: NodeId },
+ /// The reported link of the disconnect did not match the existing link of
+ /// the session.
+ LinkConflict {
+ node: NodeId,
+ /// The link that was found in the existing session.
+ found: Link,
+ /// The link that was expected from the call to disconnect.
+ expected: Link,
+ },
+}
+
+impl Disconnected {
+ pub(super) fn retry(
+ session: session::Session<session::Disconnected>,
+ delay: LocalDuration,
+ retry_at: LocalTime,
+ ) -> Self {
+ Self::Retry {
+ session,
+ delay,
+ retry_at,
+ }
+ }
+
+ pub(super) fn severed(session: session::Session<session::State>, severity: Severity) -> Self {
+ Self::Severed { session, severity }
+ }
+
+ pub(super) fn already_disconnected(node: NodeId) -> Self {
+ Self::AlreadyDisconnected { node }
+ }
+
+ pub(super) fn conflict<S>(session: &session::Session<S>, expected: Link) -> Self {
+ Self::LinkConflict {
+ node: session.node(),
+ found: *session.link(),
+ expected,
+ }
+ }
+
+ pub(super) fn missing(node: NodeId) -> Self {
+ Self::MissingSession { node }
+ }
+}
+
+/// The result when a node is being reconnected to.
+#[derive(Clone, Debug, PartialEq, Eq)]
+pub enum Reconnect {
+ /// The connection was marked as initial, transitioning from a disconnected
+ /// state.
+ Reconnecting {
+ session: Box<session::Session<session::Initial>>,
+ },
+ /// An existing session was expected for the node, but there was none.
+ MissingSession { node: NodeId },
+}
+
+impl Reconnect {
+ pub(super) fn reconnecting(session: session::Session<session::Initial>) -> Self {
+ Self::Reconnecting {
+ session: Box::new(session),
+ }
+ }
+
+ pub(super) fn missing(node: NodeId) -> Self {
+ Self::MissingSession { node }
+ }
+}
+
+/// The result of handling an incoming message from a node.
+#[derive(Clone, Debug, PartialEq, Eq)]
+pub enum HandledMessage {
+ /// The node was in a disconnected state, so the message was dropped.
+ Disconnected { node: NodeId },
+ /// The node was rate limited, so the message was dropped.
+ RateLimited { node: NodeId },
+ /// The node's subscription was updated, and is in a connected state.
+ Subscribed {
+ session: session::Session<session::Connected>,
+ },
+ /// The node's pong was received, and is in a connected state.
+ Pinged {
+ session: session::Session<session::Connected>,
+ pinged: Option<Pinged>,
+ },
+ /// There was no message to process, and the node is in a connected state.
+ Connected {
+ session: session::Session<session::Connected>,
+ },
+ /// An existing session was expected for the node, but there was none.
+ MissingSession { node: NodeId },
+}
+
+/// The result of pinging a connected session.
+pub struct Ping {
+ /// The session that was being pinged.
+ pub session: session::Session<session::Connected>,
+ /// The ping message.
+ pub ping: message::Ping,
+}
commit d7ba3a243fb81e5d6160b5404957213b2b65dbca
Author: Fintan Halpenny <fintan.halpenny@gmail.com>
Date: Wed Jul 2 10:36:43 2025 +0100
protocol: session state
This change introduces session state as part of the sans-IO rewrite of
connection management. It is similar to the `Session` and `Sessions`
types that are defined as part of `service`.
Where the `Session` and `Sessions` type differ is by providing a
generic type for keeping track of which state they are in: initial,
attempted, connected, or disconnected. The nodes in each state are
then kept track of in individual maps – one for each state.
The transition logic and mutation of session state are all
encapsulated in this module, so as not to leak these details.
The other benefit of using the generic parameter allows us to define
methods that are specific to a specific state for a session,
e.g. being able to ping a connected session.
diff --git a/crates/radicle-protocol/src/connections.rs b/crates/radicle-protocol/src/connections.rs
new file mode 100644
index 000000000..aa4d813b9
--- /dev/null
+++ b/crates/radicle-protocol/src/connections.rs
@@ -0,0 +1,3 @@
+pub mod session;
+pub use session::State;
+pub use session::{Attempts, Pinged, Session, Sessions};
diff --git a/crates/radicle-protocol/src/connections/session.rs b/crates/radicle-protocol/src/connections/session.rs
new file mode 100644
index 000000000..3ad478913
--- /dev/null
+++ b/crates/radicle-protocol/src/connections/session.rs
@@ -0,0 +1,1001 @@
+//! State management for node connection states.
+//!
+//! # Session
+//!
+//! The main type to describe a node connection is [`Session`]. It has a single
+//! generic parameter that describes the current state the session is in, which
+//! is one of:
+//! - [`Initial`]
+//! - [`Attempted`]
+//! - [`Connected`]
+//! - [`Disconnected`]
+//!
+//! Or, if a collection of sessions in various states is required, then
+//! [`State`] enumerates all of them.
+//!
+//! The are two main ways to construct a [`Session`]:
+//! - [`Session::outbound`]
+//! - [`Session::inbound`]
+//!
+//! # Sessions
+//!
+//! The [`Sessions`] type keeps track of what the current state a [`NodeId`] is
+//! in, with its corresponding [`Session`].
+//!
+//! A given [`NodeId`] must only appear in one state at a given time, if a
+//! session for it exists.
+
+mod iter;
+use iter::SessionsViewMut;
+pub use iter::{SessionsIter, SessionsView};
+
+use std::collections::{HashMap, VecDeque};
+use std::fmt;
+
+use localtime::{LocalDuration, LocalTime};
+use radicle::node::{Address, Link, NodeId, PingState};
+use radicle::prelude::RepoId;
+
+use crate::service::{message, ZeroBytes, MAX_LATENCIES};
+
+/// Enumeration of the various session states.
+#[derive(Clone, Debug, PartialEq, Eq)]
+pub enum State {
+ Initial(Initial),
+ Attempted(Attempted),
+ Connected(Connected),
+ Disconnected(Disconnected),
+}
+
+impl From<Initial> for State {
+ fn from(value: Initial) -> Self {
+ Self::Initial(value)
+ }
+}
+
+impl From<Attempted> for State {
+ fn from(value: Attempted) -> Self {
+ Self::Attempted(value)
+ }
+}
+
+impl From<Connected> for State {
+ fn from(value: Connected) -> Self {
+ Self::Connected(value)
+ }
+}
+
+impl From<Disconnected> for State {
+ fn from(value: Disconnected) -> Self {
+ Self::Disconnected(value)
+ }
+}
+
+impl From<State> for radicle::node::State {
+ fn from(state: State) -> Self {
+ match state {
+ State::Initial(initial) => Self::from(initial),
+ State::Attempted(attempted) => Self::from(attempted),
+ State::Connected(connected) => Self::from(connected),
+ State::Disconnected(disconnected) => Self::from(disconnected),
+ }
+ }
+}
+
+impl From<Initial> for radicle::node::State {
+ fn from(_: Initial) -> Self {
+ Self::Initial
+ }
+}
+
+impl From<Attempted> for radicle::node::State {
+ fn from(_: Attempted) -> Self {
+ Self::Attempted
+ }
+}
+
+impl From<Disconnected> for radicle::node::State {
+ fn from(Disconnected { since, retry_at }: Disconnected) -> Self {
+ Self::Disconnected { since, retry_at }
+ }
+}
+
+impl From<Connected> for radicle::node::State {
+ fn from(
+ Connected {
+ since,
+ ping,
+ latencies,
+ stable,
+ }: Connected,
+ ) -> Self {
+ Self::Connected {
+ since,
+ ping,
+ latencies,
+ stable,
+ }
+ }
+}
+
+/// Keeps track of multiple node sessions and their connection lifecycle.
+///
+/// Each node has one [`Session`], and can be in of the following states:
+/// - [`Initial`]
+/// - [`Attempted`]
+/// - [`Connected`]
+/// - [`Disconnected`]
+///
+/// # State Transitions
+///
+/// It is ensured that a given [`NodeId`] can only be in, at most, one state at
+/// a given time.
+///
+/// A [`Session::outbound`] starts in the [`Initial`] state, and can then move
+/// to [`Attempted`], [`Connected`], or [`Disconnected`].
+///
+/// A [`Session::inbound`] starts in the [`Connected`] state immediately – since
+/// the connection was established by the incoming node. It can then move to
+/// [`Disconnected`].
+///
+/// A [`Disconnected`] session can be reconnected to, which transitions it to
+/// the [`Initial`] state, restarting the lifecycle.
+#[derive(Debug, Default)]
+pub struct Sessions {
+ initial: HashMap<NodeId, Session<Initial>>,
+ attempted: HashMap<NodeId, Session<Attempted>>,
+ disconnected: HashMap<NodeId, Session<Disconnected>>,
+ connected: HashMap<NodeId, Session<Connected>>,
+}
+
+impl<'a> IntoIterator for &'a Sessions {
+ type Item = (&'a NodeId, Session<State>);
+ type IntoIter = SessionsIter<'a>;
+
+ fn into_iter(self) -> Self::IntoIter {
+ self.iter()
+ }
+}
+
+impl Sessions {
+ /// Construct a new [`Sessions`] state.
+ pub fn new() -> Self {
+ Self {
+ initial: HashMap::new(),
+ attempted: HashMap::new(),
+ disconnected: HashMap::new(),
+ connected: HashMap::new(),
+ }
+ }
+
+ /// Get an iterator over all the sessions, see [`SessionsIter`] for more
+ /// information.
+ pub fn iter<'a>(&'a self) -> SessionsIter<'a> {
+ SessionsIter {
+ initial: self.initial.iter(),
+ attempted: self.attempted.iter(),
+ disconnected: self.disconnected.iter(),
+ connected: self.connected.iter(),
+ }
+ }
+
+ /// Get the number of sessions that are connected and have an [inbound]
+ /// link.
+ ///
+ /// [inbound]: Link::Inbound
+ pub fn connected_inbound(&self) -> usize {
+ self.connected
+ .values()
+ .filter(|session| session.link().is_inbound())
+ .count()
+ }
+
+ /// Get the number of sessions that are connected and have an [outbound]
+ /// link.
+ ///
+ /// [outbound]: Link::Outbound
+ pub fn connected_outbound(&self) -> usize {
+ self.connected
+ .values()
+ .filter(|session| session.link().is_outbound())
+ .count()
+ }
+
+ /// Checks that an existing [`Session`] exists for the given [`NodeId`].
+ pub fn has_session_for(&self, node: &NodeId) -> bool {
+ self.initial.contains_key(node)
+ || self.attempted.contains_key(node)
+ || self.disconnected.contains_key(node)
+ || self.connected.contains_key(node)
+ }
+
+ /// Get all [`Session`]s that are in the [`Connected`] state, along with
+ /// their [`NodeId`]s.
+ pub fn connected(&self) -> SessionsView<'_, Connected> {
+ SessionsView {
+ inner: &self.connected,
+ }
+ }
+
+ /// Get all [`Session`]s that are in the [`Initial`] state, along with
+ /// their [`NodeId`]s.
+ pub fn initial(&self) -> SessionsView<'_, Initial> {
+ SessionsView {
+ inner: &self.initial,
+ }
+ }
+
+ /// Get all [`Session`]s that are in the [`Attempted`] state, along with
+ /// their [`NodeId`]s.
+ pub fn attempted(&self) -> SessionsView<'_, Attempted> {
+ SessionsView {
+ inner: &self.attempted,
+ }
+ }
+
+ /// Get all [`Session`]s that are in the [`Disconnected`] state, along with
+ /// their [`NodeId`]s.
+ pub fn disconnected(&self) -> SessionsView<'_, Disconnected> {
+ SessionsView {
+ inner: &self.disconnected,
+ }
+ }
+
+ /// Check if the given [`NodeId`] has a connected session.
+ pub fn is_connected(&self, node: &NodeId) -> bool {
+ self.connected.contains_key(node)
+ }
+
+ /// Check if the given [`NodeId`] has a disconnected session.
+ pub fn is_diconnected(&self, node: &NodeId) -> bool {
+ self.disconnected.contains_key(node)
+ }
+
+ /// Check if the given [`NodeId`] has an initial session.
+ pub fn is_initial(&self, node: &NodeId) -> bool {
+ self.initial.contains_key(node)
+ }
+
+ /// Check if the given [`NodeId`] has an attempted session.
+ pub fn is_attempted(&self, node: &NodeId) -> bool {
+ self.attempted.contains_key(node)
+ }
+
+ /// Get a [`Session`], for the given [`NodeId`], that can be in any [`State`].
+ pub fn get_session(&self, node: &NodeId) -> Option<Session<State>> {
+ self.initial
+ .get(node)
+ .cloned()
+ .map(|s| s.into_any_state())
+ .or_else(|| {
+ self.attempted
+ .get(node)
+ .cloned()
+ .map(|s| s.into_any_state())
+ })
+ .or_else(|| {
+ self.disconnected
+ .get(node)
+ .cloned()
+ .map(|s| s.into_any_state())
+ })
+ .or_else(|| {
+ self.connected
+ .get(node)
+ .cloned()
+ .map(|s| s.into_any_state())
+ })
+ }
+
+ /// Get the [`Session`], for the given [`NodeId`], that is expected to be in
+ /// the [`Connected`] state.
+ pub fn get_connected(&self, node: &NodeId) -> Option<&Session<Connected>> {
+ self.connected.get(node)
+ }
+
+ /// Get a mutable iterator of the [`Sessions`]s that are in the
+ /// [`Connected`] state, along with their [`NodeId`]s.
+ pub(super) fn connected_mut(&mut self) -> SessionsViewMut<'_, Connected> {
+ SessionsViewMut {
+ inner: &mut self.connected,
+ }
+ }
+
+ pub(super) fn unresponsive(
+ &self,
+ now: LocalTime,
+ stale_connection: LocalDuration,
+ ) -> impl Iterator<Item = (&NodeId, &Session<Connected>)> {
+ self.connected()
+ .into_iter()
+ .filter(move |(_, session)| session.is_inactive(&now, stale_connection))
+ }
+
+ pub(super) fn inactive(
+ &mut self,
+ now: LocalTime,
+ keep_alive: LocalDuration,
+ ) -> impl Iterator<Item = (&NodeId, &mut Session<Connected>)> {
+ self.connected_mut()
+ .into_iter()
+ .filter(move |(_, session)| session.is_inactive(&now, keep_alive))
+ }
+
+ /// Transition the [`Session`], identified by the [`NodeId`], to the [`Initial`] state.
+ ///
+ /// If the [`Session`] does not exist, then `None` is returned.
+ ///
+ /// This is used when reconnecting a disconnected session, that needs to be
+ /// kept as a persistent connection.
+ pub(super) fn session_to_initial(&mut self, node: &NodeId) -> Option<Session<Initial>> {
+ let s = self.disconnected.remove(node)?.into_initial();
+ self.initial.insert(*node, s.clone());
+ Some(s)
+ }
+
+ /// Transition the [`Session`], identified by the [`NodeId`], to the
+ /// [`Attempted`] state.
+ ///
+ /// If the [`Session`] does not exist, then `None` is returned.
+ pub(super) fn session_to_attempted(&mut self, node: &NodeId) -> Option<Session<Attempted>> {
+ let s = self.initial.remove(node)?.into_attempted();
+ self.attempted.insert(*node, s.clone());
+ Some(s)
+ }
+
+ /// Transition the [`Session`], identified by the [`NodeId`], to the
+ /// [`Disconnected`] state.
+ ///
+ /// The time this [`Session`] was disconnected is marked by `since`, and if
+ /// the connection should be retried then a `retry_at` value should be
+ /// provided.
+ ///
+ /// If the [`Session`] does not exist, then `None` is returned.
+ pub(super) fn session_to_disconnected(
+ &mut self,
+ node: &NodeId,
+ since: LocalTime,
+ retry_at: LocalTime,
+ ) -> Option<Session<Disconnected>> {
+ match self.remove_session(node) {
+ None => None,
+ Some(session) => {
+ let s = session.into_disconnected(since, retry_at);
+ self.disconnected.insert(*node, s.clone());
+ Some(s)
+ }
+ }
+ }
+
+ /// Transition the [`Session`], identified by the [`NodeId`], to the
+ /// [`Connected`] state.
+ ///
+ /// The [`Session`] is last active given by the time given for `now`, the
+ /// type of [`Link`] is also marked by the provided value, and also keep
+ /// track of whether the session should be persisted.
+ ///
+ /// If the [`Session`] does not exist, then `None` is returned.
+ pub(super) fn session_to_connected(
+ &mut self,
+ node: &NodeId,
+ now: LocalTime,
+ link: Option<Link>,
+ connection_type: ConnectionType,
+ ) -> Option<Session<Connected>> {
+ let s = self.remove_session(node)?;
+ let link = link.unwrap_or(s.link);
+ let state = match s.state {
+ State::Connected(connected) => connected,
+ State::Initial(_) | State::Attempted(_) | State::Disconnected(_) => Connected::new(now),
+ };
+ let s = Session {
+ state,
+ id: s.id,
+ addr: s.addr,
+ link,
+ connection_type,
+ last_active: now,
+ subscription: s.subscription,
+ attempts: s.attempts,
+ };
+ self.connected.insert(*node, s.clone());
+ Some(s)
+ }
+
+ pub(super) fn subscribe_to(&mut self, node: &NodeId, rid: &RepoId) -> SubscribeTo {
+ if let Some(session) = self.connected.get_mut(node) {
+ return session.subscribe_to(rid);
+ }
+
+ if let Some(session) = self.disconnected.get_mut(node) {
+ return session.subscribe_to(rid);
+ }
+
+ if let Some(session) = self.attempted.get_mut(node) {
+ return session.subscribe_to(rid);
+ }
+
+ if let Some(session) = self.initial.get_mut(node) {
+ return session.subscribe_to(rid);
+ }
+
+ SubscribeTo::Missing { node: *node }
+ }
+
+ pub(super) fn remove_session(&mut self, node: &NodeId) -> Option<Session<State>> {
+ self.initial
+ .remove(node)
+ .map(|s| s.into_any_state())
+ .or_else(|| self.attempted.remove(node).map(|s| s.into_any_state()))
+ .or_else(|| self.disconnected.remove(node).map(|s| s.into_any_state()))
+ .or_else(|| self.connected.remove(node).map(|s| s.into_any_state()))
+ }
+
+ pub(super) fn outbound(
+ &mut self,
+ node: NodeId,
+ addr: Address,
+ connection_type: ConnectionType,
+ now: LocalTime,
+ ) -> Session<Initial> {
+ let session = Session::outbound(node, addr, connection_type, now);
+ self.initial.insert(node, session.clone());
+ session
+ }
+
+ pub(super) fn inbound(
+ &mut self,
+ node: NodeId,
+ addr: Address,
+ connection_type: ConnectionType,
+ now: LocalTime,
+ ) -> Session<Connected> {
+ let session = Session::inbound(node, addr, connection_type, now);
+ self.connected.insert(node, session.clone());
+ session
+ }
+
+ pub(super) fn number_of_outbound_connections(&self) -> usize {
+ let attempted = self
+ .attempted
+ .iter()
+ .filter(|(_, s)| s.link.is_outbound())
+ .count();
+ let connected = self
+ .connected
+ .iter()
+ .filter(|(_, s)| s.link.is_outbound())
+ .count();
+ attempted + connected
+ }
+
+ pub(super) fn number_of_inbound_connections(&self) -> usize {
+ let attempted = self
+ .attempted
+ .iter()
+ .filter(|(_, s)| s.link.is_inbound())
+ .count();
+ let connected = self
+ .connected
+ .iter()
+ .filter(|(_, s)| s.link.is_inbound())
+ .count();
+ attempted + connected
+ }
+
+ pub(super) fn while_connecting<F, T>(
+ &mut self,
+ node: &NodeId,
+ link: Option<Link>,
+ connection_type: ConnectionType,
+ now: LocalTime,
+ f: F,
+ ) -> Option<T>
+ where
+ F: FnOnce(&mut Session<Connected>) -> T,
+ {
+ let s = self.remove_session(node)?;
+ let link = link.unwrap_or(s.link);
+ let state = match s.state {
+ State::Connected(connected) => connected,
+ State::Initial(_) | State::Attempted(_) | State::Disconnected(_) => Connected::new(now),
+ };
+ let mut s = Session {
+ id: s.id,
+ addr: s.addr,
+ link,
+ connection_type,
+ last_active: now,
+ subscription: s.subscription,
+ attempts: s.attempts,
+ state,
+ };
+ let result = f(&mut s);
+ self.connected.insert(*node, s.clone());
+ Some(result)
+ }
+}
+
+/// Number of attempts made for connecting to a node.
+#[derive(Clone, Copy, Debug, Default, PartialEq, Eq, PartialOrd, Ord, Hash)]
+pub struct Attempts {
+ attempts: usize,
+}
+
+impl fmt::Display for Attempts {
+ fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+ write!(f, "{}", self.attempts)
+ }
+}
+
+impl PartialEq<usize> for Attempts {
+ fn eq(&self, other: &usize) -> bool {
+ self.attempts == *other
+ }
+}
+
+impl PartialOrd<usize> for Attempts {
+ fn partial_cmp(&self, other: &usize) -> Option<std::cmp::Ordering> {
+ self.attempts.partial_cmp(other)
+ }
+}
+
+impl Attempts {
+ pub fn attempted(self) -> Self {
+ Self {
+ attempts: self.attempts + 1,
+ }
+ }
+
+ pub fn attempts(&self) -> usize {
+ self.attempts
+ }
+
+ fn reset(&mut self) {
+ self.attempts = 0;
+ }
+}
+
+impl From<&Attempts> for usize {
+ fn from(Attempts { attempts }: &Attempts) -> Self {
+ *attempts
+ }
+}
+
+impl From<Attempts> for usize {
+ fn from(Attempts { attempts }: Attempts) -> Self {
+ attempts
+ }
+}
+
+#[derive(Debug, Clone, PartialEq, Eq)]
+pub struct Session<S> {
+ /// The [`NodeId`] of the session.
+ id: NodeId,
+ /// The public protocol [`Address`] for the session.
+ addr: Address,
+ /// The [`Link`] direction for the session.
+ link: Link,
+ /// Keep track of whether the session should be persisted. That is, if it is
+ /// disconnected, reconnection attempts should be made.
+ connection_type: ConnectionType,
+ /// Last time a message was received from the peer.
+ last_active: LocalTime,
+ /// The peer's subscription containing the [`RepoId`]'s that this node is
+ /// interested in.
+ subscription: Option<message::Subscribe>,
+ /// Number of attempts over the lifetime of the connection.
+ ///
+ /// The tracking of attempts is preserved through the state transitions of
+ /// the session, and are reset to 0 when the connection is considered
+ /// stable.
+ attempts: Attempts,
+ /// The state the session is in. Can be in the following states:
+ /// - [`Initial`]
+ /// - [`Attempted`]
+ /// - [`Disconnected`]
+ /// - [`Connected`]
+ ///
+ /// Or the enumeration of all of the above via [`State`].
+ state: S,
+}
+
+/// A [`Session`] connection type describes how the session should be treated
+/// when the session becomes disconnected.
+#[derive(Clone, Copy, Debug, PartialEq, Eq)]
+pub enum ConnectionType {
+ /// The connection is ephemeral and the session should be removed on
+ /// disconnection.
+ Ephemeral,
+ /// The connection is persistent and the session should be marked as
+ /// disconnected, and a reconnection attempt should be made.
+ Persistent,
+}
+
+impl ConnectionType {
+ fn as_str(&self) -> &'static str {
+ match self {
+ ConnectionType::Ephemeral => "ephemeral",
+ ConnectionType::Persistent => "persistent",
+ }
+ }
+}
+
+impl fmt::Display for ConnectionType {
+ fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+ f.write_str(self.as_str())
+ }
+}
+
+/// The result of modifying a node's subscription.
+pub enum SubscribeTo {
+ /// No subscription has been set for the node yet.
+ NoSubscription,
+ /// The subscription was successful.
+ Subscribed,
+ /// The node was not found when attempting to modify the subscription.
+ Missing { node: NodeId },
+}
+
+impl From<Session<State>> for radicle::node::Session {
+ fn from(session: Session<State>) -> Self {
+ Self {
+ nid: session.id,
+ link: session.link,
+ addr: session.addr,
+ state: session.state.into(),
+ }
+ }
+}
+
+impl<S> fmt::Display for Session<S>
+where
+ S: ToString,
+{
+ fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+ let mut attrs = Vec::new();
+ let state = self.state.to_string();
+
+ if self.link.is_inbound() {
+ attrs.push("inbound");
+ } else {
+ attrs.push("outbound");
+ }
+ attrs.push(self.connection_type.as_str());
+ attrs.push(state.as_str());
+
+ write!(f, "{} [{}]", self.id, attrs.join(" "))
+ }
+}
+
+impl<S> Session<S> {
+ /// Return the node's identifier.
+ pub fn node(&self) -> NodeId {
+ self.id
+ }
+
+ /// Return the state metadata of the session.
+ pub fn state(&self) -> &S {
+ &self.state
+ }
+
+ /// Return the number of attempts that have been made for connection.
+ pub fn attempts(&self) -> Attempts {
+ self.attempts
+ }
+
+ /// Return the [`Address`] of the node.
+ pub fn address(&self) -> &Address {
+ &self.addr
+ }
+
+ /// Returns `true` if the session is subscribed to the given [`RepoId`].
+ pub fn is_subscribed_to(&self, rid: &RepoId) -> bool {
+ self.subscription
+ .as_ref()
+ .map(|s| s.filter.contains(rid))
+ .unwrap_or(false)
+ }
+
+ /// Returns when the session was last active.
+ ///
+ /// The last active time is updated when the connection performs some
+ /// activity, e.g. receiving a message.
+ pub fn last_active(&self) -> &LocalTime {
+ &self.last_active
+ }
+
+ /// Return the type of [`Link`] for the session connection.
+ pub fn link(&self) -> &Link {
+ &self.link
+ }
+
+ /// Returns `true` if the session is a persistent connection.
+ pub fn persistent(&self) -> bool {
+ matches!(self.connection_type, ConnectionType::Persistent)
+ }
+
+ /// Set the [`message::Subscribe`] of this [`Session`].
+ pub(super) fn set_subscription(&mut self, subscription: message::Subscribe) {
+ self.subscription = Some(subscription);
+ }
+
+ /// Subscribe to the given [`RepoId`], if the [`message::Subscribe`] has
+ /// been set.
+ fn subscribe_to(&mut self, rid: &RepoId) -> SubscribeTo {
+ if let Some(ref mut sub) = self.subscription {
+ sub.filter.insert(rid);
+ return SubscribeTo::Subscribed;
+ }
+ SubscribeTo::NoSubscription
+ }
+
+ fn into_disconnected(self, since: LocalTime, retry_at: LocalTime) -> Session<Disconnected> {
+ self.transition(Disconnected { since, retry_at })
+ }
+
+ #[allow(unused)]
+ fn seen(&mut self, since: LocalTime) {
+ self.last_active = since;
+ }
+
+ fn into_any_state<T>(self) -> Session<T>
+ where
+ T: From<S>,
+ {
+ self.map(|state| state.into())
+ }
+
+ fn transition<T>(self, next: T) -> Session<T> {
+ self.map(|_| next)
+ }
+
+ fn map<T, F>(self, f: F) -> Session<T>
+ where
+ F: FnOnce(S) -> T,
+ {
+ Session {
+ id: self.id,
+ addr: self.addr,
+ link: self.link,
+ connection_type: self.connection_type,
+ last_active: self.last_active,
+ subscription: self.subscription,
+ attempts: self.attempts,
+ state: f(self.state),
+ }
+ }
+}
+
+/// The session is in an initial state, with no extra metadata.
+///
+/// An initial state indicates that it is going to attempt a connection, whether
+/// through a fresh connection or a reconnection.
+#[derive(Clone, Copy, Debug, PartialEq, Eq, PartialOrd, Ord, Hash)]
+pub struct Initial;
+
+impl Session<Initial> {
+ /// Construct a [`Session`] with the [`Initial`] state, and a [`Link`] that
+ /// is [`Outbound`].
+ ///
+ /// The session begins with no subscription, and no attempts made.
+ ///
+ /// [`Outbound`]: Link::Outbound
+ pub fn outbound(
+ id: NodeId,
+ addr: Address,
+ connection_type: ConnectionType,
+ last_active: LocalTime,
+ ) -> Self {
+ Self {
+ id,
+ addr,
+ link: Link::Outbound,
+ connection_type,
+ state: Initial,
+ last_active,
+ subscription: None,
+ attempts: Attempts::default(),
+ }
+ }
+
+ /// Transition the [`Session`] to an [`Attempted`] state, incrementing the
+ /// number of attempts made.
+ fn into_attempted(mut self) -> Session<Attempted> {
+ self.attempts = self.attempts.attempted();
+ self.transition(Attempted)
+ }
+}
+
+/// The session is in an attempted state, with no extra metadata.
+///
+/// An attempted state indicates that at least one attempt was made to connect.
+#[derive(Clone, Copy, Debug, PartialEq, Eq)]
+pub struct Attempted;
+
+/// The session is in an disconnected state.
+///
+/// A disconnected state indicates that the session was connected at one point,
+/// and a reconnection should be made.
+///
+/// # Metadata
+///
+/// [`Session::is_stable`] reports when a connection is considered stable.
+///
+/// [`Session::is_inactive`] reports when a connection is considered inactive.
+#[derive(Debug, Clone, PartialEq, Eq)]
+pub struct Connected {
+ /// Connected since this time.
+ since: LocalTime,
+ /// Ping state.
+ ping: PingState,
+ /// Measured latencies for this peer.
+ latencies: VecDeque<LocalDuration>,
+ /// Whether the connection is stable.
+ stable: bool,
+}
+
+impl fmt::Display for Connected {
+ fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+ f.write_str("connected")
+ }
+}
+
+impl Connected {
+ /// Create a new [`Connected`] state, where `since` is the time of
+ /// connection.
+ fn new(since: LocalTime) -> Self {
+ Self {
+ since,
+ ping: PingState::default(),
+ latencies: VecDeque::default(),
+ stable: false,
+ }
+ }
+}
+
+/// A received pong message for a connected session.
+#[derive(Clone, Debug, PartialEq, Eq)]
+pub struct Pong {
+ pub now: LocalTime,
+ pub zeroes: ZeroBytes,
+}
+
+/// The result of a connected session receiving a pong message.
+#[derive(Clone, Debug, PartialEq, Eq)]
+pub struct Pinged {
+ /// The recorded latency of the received pong.
+ pub latency: LocalDuration,
+}
+
+impl Session<Connected> {
+ /// Construct a [`Session`] with the [`Connected`] state, and a [`Link`] that
+ /// is [`Inbound`].
+ ///
+ /// The session begins with no subscription, and no attempts made.
+ ///
+ /// [`Inbound`]: Link::Inbound
+ pub fn inbound(
+ id: NodeId,
+ addr: Address,
+ connection_type: ConnectionType,
+ now: LocalTime,
+ ) -> Self {
+ Self {
+ id,
+ addr,
+ link: Link::Inbound,
+ connection_type,
+ last_active: now,
+ subscription: None,
+ state: Connected::new(now),
+ attempts: Attempts::default(),
+ }
+ }
+
+ /// Returns true if the connection is considered stable.
+ ///
+ /// A stable connection is one which has a connected time that is before the
+ /// current time, and the duration of the connection exceeds a configured
+ /// threshold.
+ pub fn is_stable(&self) -> bool {
+ self.state.stable
+ }
+
+ /// Checks if the [`Session`] is inactive, i.e. the time passed is greater
+ /// than the `delta`.
+ pub fn is_inactive(&self, now: &LocalTime, delta: LocalDuration) -> bool {
+ *now - self.last_active >= delta
+ }
+
+ /// A ping was sent to connected nodes, and this session is now awaiting a response.
+ pub(super) fn ping(&mut self, ping: message::Ping, since: LocalTime) -> message::Ping {
+ self.state.ping = PingState::AwaitingResponse {
+ len: ping.ponglen,
+ since,
+ };
+ ping
+ }
+
+ /// A pong was received from a connected node.
+ ///
+ /// The current session must be awaiting a response from a sent ping. If so,
+ /// it checks that this is the corresponding pong, and records the latency
+ /// between the sent ping and the received pong.
+ pub(super) fn pinged(&mut self, Pong { zeroes, now }: Pong) -> Option<Pinged> {
+ if let PingState::AwaitingResponse {
+ len: ponglen,
+ since,
+ } = self.state.ping
+ {
+ if (ponglen as usize) == zeroes.len() {
+ self.state.ping = PingState::Ok;
+ let latency = now - since;
+ self.state.latencies.push_back(latency);
+ // TODO(finto): MAX_LATENCIES should likely be configured
+ // somewhere else
+ if self.state.latencies.len() > MAX_LATENCIES {
+ self.state.latencies.pop_front();
+ }
+ return Some(Pinged { latency });
+ }
+ }
+ None
+ }
+
+ /// Checks the idleness of a connection, marking its connectivity as stable,
+ /// and reset its attempt counter.
+ ///
+ /// A stable connection is one which has a connected time that is before the
+ /// current time, and the duration of the connection exceeds a configured
+ /// threshold.
+ pub(super) fn stabilise(&mut self, now: LocalTime, stable_threshold: LocalDuration) -> bool {
+ let Connected {
+ since,
+ ref mut stable,
+ ..
+ } = self.state;
+ if now >= since && now.duration_since(since) >= stable_threshold {
+ *stable = true;
+ self.attempts.reset();
+ true
+ } else {
+ false
+ }
+ }
+}
+
+/// The session is in an disconnected state.
+///
+/// A disconnected state indicates that the session was connected at one point,
+/// and a reconnection should be made.
+///
+/// # Metadata
+///
+/// [`Session::should_retry_at`] reports when a reconnection should occur.
+///
+/// [`Session::disconnected_since`] reports how long the session has been disconnected.
+#[derive(Clone, Copy, Debug, PartialEq, Eq)]
+pub struct Disconnected {
+ /// Since when has this peer been disconnected.
+ since: LocalTime,
+ /// When to retry the connection.
+ retry_at: LocalTime,
+}
+
+impl Session<Disconnected> {
+ /// Returns when the session should attempt a reconnection.
+ pub fn should_retry_at(&self) -> &LocalTime {
+ &self.state.retry_at
+ }
+
+ /// Returns when the session was recorded as disconnected.
+ pub fn disconnected_since(&self) -> &LocalTime {
+ &self.state.since
+ }
+
+ /// Transition the [`Session`] to an [`Initial`] state.
+ fn into_initial(self) -> Session<Initial> {
+ self.transition(Initial)
+ }
+}
diff --git a/crates/radicle-protocol/src/connections/session/iter.rs b/crates/radicle-protocol/src/connections/session/iter.rs
new file mode 100644
index 000000000..c0d44d3d7
--- /dev/null
+++ b/crates/radicle-protocol/src/connections/session/iter.rs
@@ -0,0 +1,106 @@
+use std::collections::hash_map;
+use std::collections::HashMap;
+
+use radicle::node::NodeId;
+
+use super::State;
+use super::{Attempted, Connected, Disconnected, Initial, Session};
+
+/// Provides an [`Iterator`] over all the sessions.
+///
+/// The order of the sessions are in:
+/// - [`Connected`]
+/// - [`Attempted`]
+/// - [`Initial`]
+/// - [`Disconnected`]
+pub struct SessionsIter<'a> {
+ pub(super) initial: hash_map::Iter<'a, NodeId, Session<Initial>>,
+ pub(super) attempted: hash_map::Iter<'a, NodeId, Session<Attempted>>,
+ pub(super) disconnected: hash_map::Iter<'a, NodeId, Session<Disconnected>>,
+ pub(super) connected: hash_map::Iter<'a, NodeId, Session<Connected>>,
+}
+
+impl<'a> Iterator for SessionsIter<'a> {
+ type Item = (&'a NodeId, Session<State>);
+
+ fn next(&mut self) -> Option<Self::Item> {
+ self.connected
+ .next()
+ .map(|(n, s)| (n, s.clone().into_any_state()))
+ .or_else(|| {
+ self.attempted
+ .next()
+ .map(|(n, s)| (n, s.clone().into_any_state()))
+ })
+ .or_else(|| {
+ self.initial
+ .next()
+ .map(|(n, s)| (n, s.clone().into_any_state()))
+ })
+ .or_else(|| {
+ self.disconnected
+ .next()
+ .map(|(n, s)| (n, s.clone().into_any_state()))
+ })
+ }
+}
+
+/// A view into sessions of a particular state.
+///
+/// - [`SessionsView::into_iter`]: to iterate over both the [`NodeId`] and [`Session`]s.
+/// - [`SessionsView::node_ids`]: to iterate over just the [`NodeId`]s.
+/// - [`SessionsView::sessions`]: to iterate over just the [`Session`]s.
+pub struct SessionsView<'a, S> {
+ pub(super) inner: &'a HashMap<NodeId, Session<S>>,
+}
+
+impl<'a, S> SessionsView<'a, S> {
+ /// Return an iterator over the [`NodeId`]s of these sessions.
+ pub fn node_ids(self) -> hash_map::Keys<'a, NodeId, Session<S>> {
+ self.inner.keys()
+ }
+
+ /// Return an iterator over the [`Session`]s.
+ pub fn sessions(self) -> hash_map::Values<'a, NodeId, Session<S>> {
+ self.inner.values()
+ }
+
+ /// Returns the number of sessions.
+ pub fn len(&self) -> usize {
+ self.inner.len()
+ }
+
+ /// Returns `true` if there are no sessions.
+ pub fn is_empty(&self) -> bool {
+ self.inner.is_empty()
+ }
+}
+
+impl<'a, S> IntoIterator for SessionsView<'a, S> {
+ type Item = (&'a NodeId, &'a Session<S>);
+ type IntoIter = hash_map::Iter<'a, NodeId, Session<S>>;
+
+ fn into_iter(self) -> Self::IntoIter {
+ self.inner.iter()
+ }
+}
+
+pub(in crate::connections) struct SessionsViewMut<'a, S> {
+ pub inner: &'a mut HashMap<NodeId, Session<S>>,
+}
+
+impl<'a, S> SessionsViewMut<'a, S> {
+ /// Return an iterator over the [`Session`]s.
+ pub fn sessions(self) -> hash_map::ValuesMut<'a, NodeId, Session<S>> {
+ self.inner.values_mut()
+ }
+}
+
+impl<'a, S> IntoIterator for SessionsViewMut<'a, S> {
+ type Item = (&'a NodeId, &'a mut Session<S>);
+ type IntoIter = hash_map::IterMut<'a, NodeId, Session<S>>;
+
+ fn into_iter(self) -> Self::IntoIter {
+ self.inner.iter_mut()
+ }
+}
diff --git a/crates/radicle-protocol/src/lib.rs b/crates/radicle-protocol/src/lib.rs
index 98fe9c0f0..cc438172a 100644
--- a/crates/radicle-protocol/src/lib.rs
+++ b/crates/radicle-protocol/src/lib.rs
@@ -1,4 +1,5 @@
pub mod bounded;
+pub mod connections;
pub mod deserializer;
pub mod fetcher;
pub mod service;
Exit code: 0
shell: 'export RUSTDOCFLAGS=''-D warnings'' cargo --version rustc --version cargo fmt --check cargo clippy --all-targets --workspace -- --deny warnings cargo build --all-targets --workspace cargo doc --workspace --no-deps --all-features cargo test --workspace --no-fail-fast '
Commands:
$ podman run --name 7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec -v /opt/radcis/ci.rad.levitte.org/cci/state/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/s:/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/s:ro -v /opt/radcis/ci.rad.levitte.org/cci/state/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w:/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w -w /7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w -v /opt/radcis/ci.rad.levitte.org/.radicle:/${id}/.radicle:ro -e RAD_HOME=/${id}/.radicle rust:trixie bash /7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/s/script.sh
+ export 'RUSTDOCFLAGS=-D warnings'
+ RUSTDOCFLAGS='-D warnings'
+ cargo --version
info: syncing channel updates for '1.90-x86_64-unknown-linux-gnu'
info: latest update on 2025-09-18, rust version 1.90.0 (1159e78c4 2025-09-14)
info: downloading component 'cargo'
info: downloading component 'clippy'
info: downloading component 'rust-docs'
info: downloading component 'rust-src'
info: downloading component 'rust-std'
info: downloading component 'rustc'
info: downloading component 'rustfmt'
info: installing component 'cargo'
info: installing component 'clippy'
info: installing component 'rust-docs'
info: installing component 'rust-src'
info: installing component 'rust-std'
info: installing component 'rustc'
info: installing component 'rustfmt'
cargo 1.90.0 (840b83a10 2025-07-30)
+ rustc --version
rustc 1.90.0 (1159e78c4 2025-09-14)
+ cargo fmt --check
+ cargo clippy --all-targets --workspace -- --deny warnings
Updating crates.io index
Downloading crates ...
Downloaded adler2 v2.0.0
Downloaded byteorder v1.5.0
Downloaded addr2line v0.24.2
Downloaded bloomy v1.2.0
Downloaded amplify_derive v4.0.0
Downloaded ahash v0.8.11
Downloaded lexopt v0.3.0
Downloaded base64 v0.21.7
Downloaded crc32fast v1.5.0
Downloaded arc-swap v1.7.1
Downloaded block-buffer v0.10.4
Downloaded cc v1.2.2
Downloaded data-encoding-macro-internal v0.1.12
Downloaded bytecount v0.6.8
Downloaded ecdsa v0.16.9
Downloaded cyphergraphy v0.3.0
Downloaded miniz_oxide v0.8.8
Downloaded cypheraddr v0.4.0
Downloaded email_address v0.2.9
Downloaded const-oid v0.9.6
Downloaded document-features v0.2.11
Downloaded errno v0.3.13
Downloaded base16ct v0.2.0
Downloaded clap_lex v0.7.5
Downloaded blowfish v0.9.1
Downloaded anstyle v1.0.11
Downloaded crossbeam-utils v0.8.19
Downloaded clap v4.5.44
Downloaded getrandom v0.2.15
Downloaded diff v0.1.13
Downloaded env_logger v0.11.8
Downloaded mio v1.0.4
Downloaded gix-lock v18.0.0
Downloaded backtrace v0.3.75
Downloaded qcheck-macros v1.0.0
Downloaded chacha20poly1305 v0.10.1
Downloaded num-iter v0.1.45
Downloaded nu-ansi-term v0.46.0
Downloaded num-cmp v0.1.0
Downloaded once_cell v1.21.3
Downloaded pin-project-lite v0.2.16
Downloaded scrypt v0.11.0
Downloaded salsa20 v0.10.2
Downloaded serde-untagged v0.1.7
Downloaded mio v0.8.11
Downloaded object v0.36.7
Downloaded pkcs1 v0.7.5
Downloaded maybe-async v0.2.10
Downloaded nonempty v0.9.0
Downloaded gix-refspec v0.31.0
Downloaded lock_api v0.4.14
Downloaded gix-config-value v0.15.1
Downloaded git-ref-format-macro v0.6.0
Downloaded gix-utils v0.3.0
Downloaded idna_adapter v1.2.0
Downloaded pkg-config v0.3.30
Downloaded paste v1.0.15
Downloaded phf v0.11.3
Downloaded referencing v0.30.0
Downloaded rfc6979 v0.4.0
Downloaded rand_core v0.6.4
Downloaded prodash v30.0.1
Downloaded pretty_assertions v1.4.0
Downloaded percent-encoding v2.3.1
Downloaded num-traits v0.2.19
Downloaded rusty-fork v0.3.1
Downloaded rsa v0.9.6
Downloaded streaming-iterator v0.1.9
Downloaded schemars_derive v1.0.4
Downloaded scopeguard v1.2.0
Downloaded rand v0.9.2
Downloaded structured-logger v1.0.4
Downloaded spki v0.7.3
Downloaded socket2 v0.5.7
Downloaded os_info v3.12.0
Downloaded same-file v1.0.6
Downloaded ppv-lite86 v0.2.17
Downloaded ryu v1.0.17
Downloaded serde_derive_internals v0.29.1
Downloaded signal-hook v0.3.18
Downloaded unicode-display-width v0.3.0
Downloaded sval_nested v2.14.1
Downloaded universal-hash v0.5.1
Downloaded tree-sitter-highlight v0.24.4
Downloaded ssh-key v0.6.6
Downloaded tree-sitter-go v0.23.4
Downloaded winnow v0.7.13
Downloaded ref-cast-impl v1.0.24
Downloaded sha2 v0.10.8
Downloaded value-bag-serde1 v1.11.1
Downloaded icu_normalizer v1.5.0
Downloaded rand_chacha v0.3.1
Downloaded unit-prefix v0.5.1
Downloaded shlex v1.3.0
Downloaded utf8parse v0.2.1
Downloaded value-bag-sval2 v1.11.1
Downloaded gix-pack v0.60.0
Downloaded unicode-width v0.1.11
Downloaded tree-sitter-json v0.24.8
Downloaded test-log-macros v0.2.18
Downloaded thread_local v1.1.9
Downloaded snapbox v0.4.17
Downloaded sval_ref v2.14.1
Downloaded siphasher v0.3.11
Downloaded test-log v0.2.18
Downloaded xattr v1.3.1
Downloaded zerofrom v0.1.6
Downloaded zeroize v1.7.0
Downloaded url v2.5.4
Downloaded writeable v0.5.5
Downloaded wait-timeout v0.2.1
Downloaded unarray v0.1.4
Downloaded zerofrom-derive v0.1.6
Downloaded write16 v1.0.0
Downloaded vsimd v0.8.0
Downloaded jiff-static v0.2.15
Downloaded value-bag v1.11.1
Downloaded regex v1.11.1
Downloaded yoke-derive v0.7.5
Downloaded unicode-segmentation v1.11.0
Downloaded signals_receipts v0.2.0
Downloaded zerovec-derive v0.10.3
Downloaded tree-sitter-html v0.23.2
Downloaded timeago v0.4.2
Downloaded indicatif v0.18.0
Downloaded tree-sitter v0.24.4
Downloaded yoke v0.7.5
Downloaded zerovec v0.10.4
Downloaded zerocopy v0.7.35
Downloaded typenum v1.17.0
Downloaded tree-sitter-typescript v0.23.2
Downloaded uuid v1.16.0
Downloaded tracing v0.1.41
Downloaded itertools v0.14.0
Downloaded idna v1.0.3
Downloaded unicode-normalization v0.1.23
Downloaded tree-sitter-bash v0.23.3
Downloaded icu_properties_data v1.5.1
Downloaded git2 v0.19.0
Downloaded zlib-rs v0.5.2
Downloaded tracing-subscriber v0.3.19
Downloaded syn v1.0.109
Downloaded unicode-width v0.2.1
Downloaded syn v2.0.106
Downloaded regex-syntax v0.6.29
Downloaded sha1-checked v0.10.0
Downloaded tree-sitter-rust v0.23.2
Downloaded regex-syntax v0.8.5
Downloaded hashbrown v0.14.3
Downloaded rustix v1.0.7
Downloaded sha3 v0.10.8
Downloaded libc v0.2.174
Downloaded libm v0.2.8
Downloaded jsonschema v0.30.0
Downloaded inquire v0.7.5
Downloaded fraction v0.15.3
Downloaded tree-sitter-ruby v0.23.1
Downloaded tracing-core v0.1.34
Downloaded toml_datetime v0.7.0
Downloaded toml v0.9.5
Downloaded tempfile v3.23.0
Downloaded tree-sitter-python v0.23.4
Downloaded tinystr v0.7.6
Downloaded jiff v0.2.15
Downloaded thiserror-impl v2.0.17
Downloaded tinyvec v1.6.0
Downloaded tokio v1.47.1
Downloaded systemd-journal-logger v2.2.2
Downloaded hashbrown v0.15.5
Downloaded yansi v0.5.1
Downloaded vcpkg v0.2.15
Downloaded tree-sitter-md v0.3.2
Downloaded toml_writer v1.0.2
Downloaded spin v0.9.8
Downloaded smallvec v1.15.1
Downloaded icu_locid v1.5.0
Downloaded uuid-simd v0.8.0
Downloaded tracing-log v0.2.0
Downloaded thiserror-impl v1.0.69
Downloaded thiserror v2.0.17
Downloaded thiserror v1.0.69
Downloaded synstructure v0.13.1
Downloaded sval v2.14.1
Downloaded signal-hook-registry v1.4.5
Downloaded icu_provider v1.5.0
Downloaded proptest v1.9.0
Downloaded tree-sitter-toml-ng v0.6.0
Downloaded unicode-ident v1.0.12
Downloaded sval_buffer v2.14.1
Downloaded utf16_iter v1.0.5
Downloaded utf8_iter v1.0.4
Downloaded tinyvec_macros v0.1.1
Downloaded schemars v1.0.4
Downloaded indexmap v2.2.6
Downloaded icu_collections v1.5.0
Downloaded gix-odb v0.70.0
Downloaded regex-automata v0.4.9
Downloaded walkdir v2.5.0
Downloaded stable_deref_trait v1.2.0
Downloaded version_check v0.9.4
Downloaded sval_json v2.14.1
Downloaded serde v1.0.219
Downloaded subtle v2.5.0
Downloaded ssh-encoding v0.2.0
Downloaded sqlite3-sys v0.15.2
Downloaded sec1 v0.7.3
Downloaded linux-raw-sys v0.4.13
Downloaded sval_serde v2.14.1
Downloaded sval_dynamic v2.14.1
Downloaded sqlite v0.32.0
Downloaded serde_fmt v1.0.3
Downloaded sval_fmt v2.14.1
Downloaded icu_properties v1.5.1
Downloaded gix-protocol v0.51.0
Downloaded typeid v1.0.3
Downloaded tree-sitter-language v0.1.2
Downloaded strsim v0.11.1
Downloaded signal-hook-mio v0.2.4
Downloaded rand_xorshift v0.4.0
Downloaded proc-macro2 v1.0.101
Downloaded gix-ref v0.53.1
Downloaded tree-sitter-c v0.23.2
Downloaded tar v0.4.40
Downloaded sha1 v0.10.6
Downloaded libgit2-sys v0.17.0+1.8.1
Downloaded getrandom v0.3.3
Downloaded gix-transport v0.48.0
Downloaded shell-words v1.1.0
Downloaded serde_json v1.0.140
Downloaded rustc-demangle v0.1.26
Downloaded sqlite3-src v0.5.1
Downloaded radicle-std-ext v0.2.0
Downloaded pbkdf2 v0.12.2
Downloaded log v0.4.27
Downloaded libz-rs-sys v0.5.2
Downloaded icu_locid_transform v1.5.0
Downloaded gix-hash v0.19.0
Downloaded socks5-client v0.4.1
Downloaded siphasher v1.0.1
Downloaded qcheck v1.0.0
Downloaded icu_locid_transform_data v1.5.1
Downloaded p384 v0.13.0
Downloaded tree-sitter-css v0.23.1
Downloaded serde_derive v1.0.219
Downloaded gix-revision v0.35.0
Downloaded linux-raw-sys v0.9.4
Downloaded sem_safe v0.2.0
Downloaded gix-tempfile v18.0.0
Downloaded gix-traverse v0.47.0
Downloaded jobserver v0.1.31
Downloaded quick-error v1.2.3
Downloaded opaque-debug v0.3.1
Downloaded litemap v0.7.5
Downloaded gix-prompt v0.11.1
Downloaded signature v1.6.4
Downloaded matchers v0.1.0
Downloaded gix-url v0.32.0
Downloaded ssh-cipher v0.2.0
Downloaded snapbox-macros v0.3.8
Downloaded sharded-slab v0.1.7
Downloaded serde_spanned v1.0.0
Downloaded rustix v0.38.34
Downloaded pkcs8 v0.10.2
Downloaded keccak v0.1.5
Downloaded inout v0.1.3
Downloaded newline-converter v0.3.0
Downloaded radicle-surf v0.26.0
Downloaded proc-macro-error-attr2 v2.0.0
Downloaded rand_chacha v0.9.0
Downloaded quote v1.0.41
Downloaded poly1305 v0.8.0
Downloaded num-rational v0.4.2
Downloaded hmac v0.12.1
Downloaded ff v0.13.0
Downloaded similar v2.5.0
Downloaded signature v2.2.0
Downloaded regex-automata v0.1.10
Downloaded ref-cast v1.0.24
Downloaded rand v0.8.5
Downloaded polyval v0.6.2
Downloaded phf_shared v0.11.3
Downloaded lazy_static v1.5.0
Downloaded human-panic v2.0.3
Downloaded gix-validate v0.10.0
Downloaded rand_core v0.9.3
Downloaded proc-macro-error2 v2.0.1
Downloaded num-bigint v0.4.6
Downloaded icu_provider_macros v1.5.0
Downloaded gix-path v0.10.20
Downloaded portable-atomic v1.11.0
Downloaded parking_lot_core v0.9.12
Downloaded primeorder v0.13.6
Downloaded gix-chunk v0.4.11
Downloaded gix-object v0.50.2
Downloaded radicle-git-ext v0.11.0
Downloaded parking_lot v0.12.5
Downloaded icu_normalizer_data v1.5.1
Downloaded heck v0.5.0
Downloaded gix-shallow v0.5.0
Downloaded overload v0.1.1
Downloaded num-integer v0.1.46
Downloaded num-complex v0.4.6
Downloaded gix-sec v0.12.0
Downloaded form_urlencoded v1.2.1
Downloaded p256 v0.13.2
Downloaded normalize-line-endings v0.3.0
Downloaded gix-commitgraph v0.29.0
Downloaded num-bigint-dig v0.8.4
Downloaded gix-trace v0.1.13
Downloaded gix-quote v0.6.0
Downloaded gix-negotiate v0.21.0
Downloaded gix-hashtable v0.9.0
Downloaded git-ref-format-core v0.6.0
Downloaded git-ref-format v0.6.0
Downloaded home v0.5.9
Downloaded gix-packetline v0.19.1
Downloaded gix-date v0.10.5
Downloaded gix-credentials v0.30.0
Downloaded fnv v1.0.7
Downloaded filetime v0.2.23
Downloaded num v0.4.3
Downloaded litrs v0.4.1
Downloaded iana-time-zone v0.1.60
Downloaded heapless v0.8.0
Downloaded hash32 v0.3.1
Downloaded fxhash v0.2.1
Downloaded fluent-uri v0.3.2
Downloaded flate2 v1.1.1
Downloaded gix-revwalk v0.21.0
Downloaded gix-fs v0.16.1
Downloaded gix-actor v0.35.4
Downloaded gimli v0.31.1
Downloaded base-x v0.2.11
Downloaded generic-array v0.14.7
Downloaded escargot v0.5.10
Downloaded pem-rfc7468 v0.7.0
Downloaded p521 v0.13.3
Downloaded outref v0.5.2
Downloaded clap_builder v4.5.44
Downloaded aho-corasick v1.1.3
Downloaded aes-gcm v0.10.3
Downloaded itoa v1.0.11
Downloaded dunce v1.0.5
Downloaded crossterm v0.29.0
Downloaded chrono v0.4.38
Downloaded libz-sys v1.1.16
Downloaded multibase v0.9.1
Downloaded ghash v0.5.1
Downloaded fancy-regex v0.14.0
Downloaded elliptic-curve v0.13.8
Downloaded bitflags v2.9.1
Downloaded memmap2 v0.9.8
Downloaded memchr v2.7.2
Downloaded gix-features v0.43.1
Downloaded gix-diff v0.53.0
Downloaded gix-command v0.6.2
Downloaded ctr v0.9.2
Downloaded crossterm v0.25.0
Downloaded colored v2.1.0
Downloaded faster-hex v0.10.0
Downloaded amplify v4.6.0
Downloaded ed25519 v1.5.3
Downloaded displaydoc v0.2.5
Downloaded der v0.7.9
Downloaded cipher v0.4.4
Downloaded cfg-if v1.0.0
Downloaded env_filter v0.1.3
Downloaded ascii v1.1.0
Downloaded data-encoding-macro v0.1.14
Downloaded borrow-or-share v0.2.2
Downloaded aead v0.5.2
Downloaded base64ct v1.6.0
Downloaded noise-framework v0.4.0
Downloaded either v1.11.0
Downloaded cyphernet v0.5.2
Downloaded bit-set v0.8.0
Downloaded group v0.13.0
Downloaded emojis v0.6.4
Downloaded derive_more-impl v2.0.1
Downloaded bcrypt-pbkdf v0.10.0
Downloaded derive_more v2.0.1
Downloaded crypto-bigint v0.5.5
Downloaded crossbeam-channel v0.5.15
Downloaded clap_derive v4.5.41
Downloaded bytes v1.10.1
Downloaded bitflags v1.3.2
Downloaded base32 v0.4.0
Downloaded aes v0.8.4
Downloaded fastrand v2.3.0
Downloaded fast-glob v0.3.3
Downloaded erased-serde v0.4.6
Downloaded equivalent v1.0.1
Downloaded ec25519 v0.1.0
Downloaded dyn-clone v1.0.17
Downloaded digest v0.10.7
Downloaded data-encoding v2.5.0
Downloaded crypto-common v0.1.6
Downloaded colorchoice v1.0.0
Downloaded chacha20 v0.9.1
Downloaded anstyle-parse v0.2.3
Downloaded anstream v0.6.13
Downloaded cpufeatures v0.2.12
Downloaded convert_case v0.7.1
Downloaded cbc v0.1.2
Downloaded autocfg v1.2.0
Downloaded ct-codecs v1.1.1
Downloaded console v0.16.0
Downloaded clap_complete v4.5.60
Downloaded bytesize v2.0.1
Downloaded block-padding v0.3.3
Downloaded bstr v1.12.0
Downloaded anstyle-query v1.0.2
Downloaded base64 v0.22.1
Downloaded anyhow v1.0.82
Downloaded amplify_syn v2.0.1
Downloaded bit-vec v0.8.0
Downloaded amplify_num v0.5.2
Compiling libc v0.2.174
Compiling proc-macro2 v1.0.101
Compiling quote v1.0.41
Compiling unicode-ident v1.0.12
Checking cfg-if v1.0.0
Compiling shlex v1.3.0
Compiling version_check v0.9.4
Checking memchr v2.7.2
Compiling jobserver v0.1.31
Checking getrandom v0.2.15
Compiling typenum v1.17.0
Compiling syn v2.0.106
Compiling generic-array v0.14.7
Compiling cc v1.2.2
Checking rand_core v0.6.4
Compiling serde v1.0.219
Checking regex-syntax v0.8.5
Checking crypto-common v0.1.6
Checking aho-corasick v1.1.3
Checking smallvec v1.15.1
Compiling thiserror v2.0.17
Checking subtle v2.5.0
Checking once_cell v1.21.3
Checking stable_deref_trait v1.2.0
Checking regex-automata v0.4.9
Checking cpufeatures v0.2.12
Checking fastrand v2.3.0
Compiling parking_lot_core v0.9.12
Checking scopeguard v1.2.0
Checking lock_api v0.4.14
Checking block-buffer v0.10.4
Checking parking_lot v0.12.5
Checking digest v0.10.7
Compiling crc32fast v1.5.0
Checking byteorder v1.5.0
Checking tinyvec_macros v0.1.1
Checking bitflags v2.9.1
Checking tinyvec v1.6.0
Compiling typeid v1.0.3
Checking gix-trace v0.1.13
Checking home v0.5.9
Compiling synstructure v0.13.1
Checking unicode-normalization v0.1.23
Checking zlib-rs v0.5.2
Checking gix-utils v0.3.0
Checking same-file v1.0.6
Checking walkdir v2.5.0
Checking bstr v1.12.0
Checking prodash v30.0.1
Checking itoa v1.0.11
Compiling heapless v0.8.0
Compiling getrandom v0.3.3
Checking libz-rs-sys v0.5.2
Checking hash32 v0.3.1
Checking flate2 v1.1.1
Checking zeroize v1.7.0
Compiling serde_derive v1.0.219
Compiling thiserror-impl v2.0.17
Compiling zerofrom-derive v0.1.6
Compiling yoke-derive v0.7.5
Compiling zerovec-derive v0.10.3
Checking zerofrom v0.1.6
Checking gix-validate v0.10.0
Checking yoke v0.7.5
Checking gix-path v0.10.20
Compiling displaydoc v0.2.5
Checking gix-features v0.43.1
Checking litemap v0.7.5
Compiling rustix v1.0.7
Checking zerovec v0.10.4
Compiling pkg-config v0.3.30
Compiling icu_locid_transform_data v1.5.1
Checking writeable v0.5.5
Checking faster-hex v0.10.0
Compiling icu_provider_macros v1.5.0
Compiling icu_properties_data v1.5.1
Checking tinystr v0.7.6
Checking linux-raw-sys v0.9.4
Checking icu_locid v1.5.0
Checking sha1 v0.10.6
Checking block-padding v0.3.3
Compiling icu_normalizer_data v1.5.1
Checking icu_provider v1.5.0
Checking inout v0.1.3
Checking sha1-checked v0.10.0
Checking icu_locid_transform v1.5.0
Checking icu_collections v1.5.0
Compiling syn v1.0.109
Checking icu_properties v1.5.1
Checking gix-hash v0.19.0
Checking cipher v0.4.4
Checking utf16_iter v1.0.5
Checking utf8_iter v1.0.4
Checking write16 v1.0.0
Checking erased-serde v0.4.6
Checking serde_fmt v1.0.3
Checking value-bag-serde1 v1.11.1
Checking value-bag v1.11.1
Checking icu_normalizer v1.5.0
Checking log v0.4.27
Checking percent-encoding v2.3.1
Checking idna_adapter v1.2.0
Compiling thiserror v1.0.69
Compiling thiserror-impl v1.0.69
Checking idna v1.0.3
Checking form_urlencoded v1.2.1
Checking sha2 v0.10.8
Compiling vcpkg v0.2.15
Checking url v2.5.4
Checking tempfile v3.23.0
Compiling libz-sys v1.1.16
Checking universal-hash v0.5.1
Checking opaque-debug v0.3.1
Checking equivalent v1.0.1
Checking hashbrown v0.14.3
Compiling serde_json v1.0.140
Compiling ref-cast v1.0.24
Compiling autocfg v1.2.0
Checking ryu v1.0.17
Checking indexmap v2.2.6
Compiling num-traits v0.2.19
Compiling amplify_syn v2.0.1
Compiling libgit2-sys v0.17.0+1.8.1
Compiling ref-cast-impl v1.0.24
Checking signature v1.6.4
Compiling amplify_derive v4.0.0
Checking ed25519 v1.5.3
Checking aead v0.5.2
Checking dyn-clone v1.0.17
Checking ct-codecs v1.1.1
Checking ascii v1.1.0
Checking amplify_num v0.5.2
Checking ec25519 v0.1.0
Checking git-ref-format-core v0.6.0
Checking poly1305 v0.8.0
Checking amplify v4.6.0
Checking chacha20 v0.9.1
Checking polyval v0.6.2
Compiling sqlite3-src v0.5.1
Compiling serde_derive_internals v0.29.1
Checking cyphergraphy v0.3.0
Checking hmac v0.12.1
Checking keccak v0.1.5
Checking base64ct v1.6.0
Checking sha3 v0.10.8
Checking pem-rfc7468 v0.7.0
Checking pbkdf2 v0.12.2
Checking ghash v0.5.1
Checking aes v0.8.4
Compiling schemars_derive v1.0.4
Checking ctr v0.9.2
Checking rand v0.8.5
Checking base32 v0.4.0
Compiling data-encoding v2.5.0
Compiling data-encoding-macro-internal v0.1.12
Checking schemars v1.0.4
Checking cypheraddr v0.4.0
Checking qcheck v1.0.0
Checking aes-gcm v0.10.3
Checking ssh-encoding v0.2.0
Checking chacha20poly1305 v0.10.1
Checking cbc v0.1.2
Checking blowfish v0.9.1
Checking bcrypt-pbkdf v0.10.0
Checking ssh-cipher v0.2.0
Checking noise-framework v0.4.0
Checking data-encoding-macro v0.1.14
Checking socks5-client v0.4.1
Compiling crossbeam-utils v0.8.19
Checking signature v2.2.0
Checking base-x v0.2.11
Checking multibase v0.9.1
Checking ssh-key v0.6.6
Checking cyphernet v0.5.2
Checking radicle-ssh v0.10.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-ssh)
Checking jiff v0.2.15
Checking crossbeam-channel v0.5.15
Checking lazy_static v1.5.0
Checking nonempty v0.9.0
Checking siphasher v1.0.1
Checking anstyle-query v1.0.2
Checking radicle-git-metadata v0.1.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-git-metadata)
Checking radicle-dag v0.10.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-dag)
Checking winnow v0.7.13
Checking hashbrown v0.15.5
Checking utf8parse v0.2.1
Checking anstyle-parse v0.2.3
Checking gix-date v0.10.5
Checking gix-hashtable v0.9.0
Checking radicle-git-ref-format v0.1.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-git-ref-format)
Checking colorchoice v1.0.0
Checking gix-actor v0.35.4
Checking anstyle v1.0.11
Checking iana-time-zone v0.1.60
Checking base64 v0.21.7
Checking chrono v0.4.38
Checking anstream v0.6.13
Checking gix-object v0.50.2
Checking colored v2.1.0
Checking radicle-localtime v0.1.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-localtime)
Checking serde-untagged v0.1.7
Checking bytesize v2.0.1
Checking memmap2 v0.9.8
Checking dunce v1.0.5
Checking tree-sitter-language v0.1.2
Checking fast-glob v0.3.3
Checking gix-chunk v0.4.11
Checking gix-fs v0.16.1
Checking gix-commitgraph v0.29.0
Checking gix-tempfile v18.0.0
Checking mio v1.0.4
Checking gix-revwalk v0.21.0
Checking gix-quote v0.6.0
Checking errno v0.3.13
Checking sem_safe v0.2.0
Checking either v1.11.0
Checking shell-words v1.1.0
Checking gix-command v0.6.2
Checking signals_receipts v0.2.0
Compiling object v0.36.7
Compiling signal-hook v0.3.18
Checking gix-lock v18.0.0
Checking gix-url v0.32.0
Checking gix-config-value v0.15.1
Checking gix-sec v0.12.0
Checking signal-hook-registry v1.4.5
Checking gimli v0.31.1
Compiling rustix v0.38.34
Checking adler2 v2.0.0
Checking miniz_oxide v0.8.8
Checking gix-prompt v0.11.1
Checking addr2line v0.24.2
Checking radicle-signals v0.11.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-signals)
Checking gix-traverse v0.47.0
Checking gix-revision v0.35.0
Checking gix-diff v0.53.0
Checking mio v0.8.11
Checking gix-packetline v0.19.1
Compiling tree-sitter v0.24.4
Checking rustc-demangle v0.1.26
Compiling unicode-segmentation v1.11.0
Compiling linux-raw-sys v0.4.13
Compiling anyhow v1.0.82
Checking backtrace v0.3.75
Compiling convert_case v0.7.1
Checking gix-transport v0.48.0
Checking signal-hook-mio v0.2.4
Checking gix-pack v0.60.0
Checking gix-refspec v0.31.0
Checking gix-credentials v0.30.0
Checking gix-ref v0.53.1
Checking gix-shallow v0.5.0
Checking gix-negotiate v0.21.0
Compiling maybe-async v0.2.10
Checking regex v1.11.1
Compiling proc-macro-error-attr2 v2.0.0
Compiling portable-atomic v1.11.0
Checking arc-swap v1.7.1
Checking gix-odb v0.70.0
Compiling proc-macro-error2 v2.0.1
Checking gix-protocol v0.51.0
Compiling xattr v1.3.1
Compiling derive_more-impl v2.0.1
Compiling filetime v0.2.23
Checking uuid v1.16.0
Checking bytes v1.10.1
Compiling litrs v0.4.1
Checking bitflags v1.3.2
Checking unicode-width v0.2.1
Checking crossterm v0.25.0
Checking console v0.16.0
Compiling document-features v0.2.11
Checking derive_more v2.0.1
Compiling tar v0.4.40
Compiling git-ref-format-macro v0.6.0
Checking newline-converter v0.3.0
Checking snapbox-macros v0.3.8
Checking salsa20 v0.10.2
Checking fxhash v0.2.1
Checking strsim v0.11.1
Checking similar v2.5.0
Checking streaming-iterator v0.1.9
Checking normalize-line-endings v0.3.0
Checking siphasher v0.3.11
Compiling heck v0.5.0
Checking clap_lex v0.7.5
Checking unit-prefix v0.5.1
Checking unicode-width v0.1.11
Checking indicatif v0.18.0
Checking inquire v0.7.5
Checking clap_builder v4.5.44
Compiling clap_derive v4.5.41
Checking sqlite3-sys v0.15.2
Checking sqlite v0.32.0
Checking radicle-crypto v0.14.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-crypto)
Checking bloomy v1.2.0
Checking snapbox v0.4.17
Checking scrypt v0.11.0
Compiling radicle-surf v0.26.0
Checking git-ref-format v0.6.0
Checking crossterm v0.29.0
Checking unicode-display-width v0.3.0
Checking systemd-journal-logger v2.2.2
Checking serde_spanned v1.0.0
Checking toml_datetime v0.7.0
Compiling tree-sitter-python v0.23.4
Compiling tree-sitter-html v0.23.2
Compiling tree-sitter-json v0.24.8
Compiling tree-sitter-ruby v0.23.1
Compiling tree-sitter-go v0.23.4
Compiling tree-sitter-toml-ng v0.6.0
Compiling tree-sitter-typescript v0.23.2
Compiling tree-sitter-c v0.23.2
Compiling tree-sitter-bash v0.23.3
Compiling tree-sitter-css v0.23.1
Compiling tree-sitter-md v0.3.2
Compiling tree-sitter-rust v0.23.2
Checking pin-project-lite v0.2.16
Checking toml_writer v1.0.2
Checking radicle-std-ext v0.2.0
Checking tokio v1.47.1
Checking toml v0.9.5
Checking clap v4.5.44
Checking os_info v3.12.0
Checking yansi v0.5.1
Compiling radicle-cli v0.17.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-cli)
Checking diff v0.1.13
Compiling radicle-node v0.16.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-node)
Checking pretty_assertions v1.4.0
Checking human-panic v2.0.3
Checking clap_complete v4.5.60
Checking structured-logger v1.0.4
Checking radicle-systemd v0.11.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-systemd)
Checking tree-sitter-highlight v0.24.4
Checking itertools v0.14.0
Checking num-integer v0.1.46
Compiling qcheck-macros v1.0.0
Checking socket2 v0.5.7
Checking timeago v0.4.2
Checking lexopt v0.3.0
Compiling escargot v0.5.10
Checking bit-vec v0.8.0
Checking bit-set v0.8.0
Checking num-bigint v0.4.6
Checking rand_core v0.9.3
Compiling ahash v0.8.11
Checking num-iter v0.1.45
Checking num-complex v0.4.6
Checking env_filter v0.1.3
Checking borrow-or-share v0.2.2
Checking zerocopy v0.7.35
Checking fluent-uri v0.3.2
Checking num-rational v0.4.2
Checking env_logger v0.11.8
Checking num v0.4.3
Checking phf_shared v0.11.3
Compiling test-log-macros v0.2.18
Checking wait-timeout v0.2.1
Checking vsimd v0.8.0
Checking fnv v1.0.7
Checking quick-error v1.2.3
Compiling paste v1.0.15
Checking ppv-lite86 v0.2.17
Checking outref v0.5.2
Compiling radicle-remote-helper v0.14.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-remote-helper)
Checking uuid-simd v0.8.0
Checking rand_chacha v0.9.0
Checking test-log v0.2.18
Checking rusty-fork v0.3.1
Checking phf v0.11.3
Checking referencing v0.30.0
Checking fraction v0.15.3
Checking rand v0.9.2
Checking rand_xorshift v0.4.0
Checking fancy-regex v0.14.0
Checking email_address v0.2.9
Checking unarray v0.1.4
Checking bytecount v0.6.8
Checking base64 v0.22.1
Checking num-cmp v0.1.0
Checking proptest v1.9.0
Checking emojis v0.6.4
Checking jsonschema v0.30.0
Checking git2 v0.19.0
Checking radicle-oid v0.1.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-oid)
Checking radicle-git-ext v0.11.0
Checking radicle-term v0.16.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-term)
Checking radicle-cob v0.17.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-cob)
Checking radicle-core v0.1.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-core)
Checking radicle v0.20.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle)
Checking radicle-fetch v0.16.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-fetch)
Checking radicle-cli-test v0.13.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-cli-test)
Checking radicle-protocol v0.4.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-protocol)
Checking radicle-schemars v0.6.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-schemars)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 42.02s
+ cargo build --all-targets --workspace
Compiling libc v0.2.174
Compiling cfg-if v1.0.0
Compiling shlex v1.3.0
Compiling memchr v2.7.2
Compiling typenum v1.17.0
Compiling serde v1.0.219
Compiling jobserver v0.1.31
Compiling getrandom v0.2.15
Compiling generic-array v0.14.7
Compiling rand_core v0.6.4
Compiling cc v1.2.2
Compiling regex-syntax v0.8.5
Compiling crypto-common v0.1.6
Compiling aho-corasick v1.1.3
Compiling smallvec v1.15.1
Compiling thiserror v2.0.17
Compiling subtle v2.5.0
Compiling once_cell v1.21.3
Compiling regex-automata v0.4.9
Compiling stable_deref_trait v1.2.0
Compiling fastrand v2.3.0
Compiling cpufeatures v0.2.12
Compiling scopeguard v1.2.0
Compiling lock_api v0.4.14
Compiling parking_lot_core v0.9.12
Compiling block-buffer v0.10.4
Compiling bitflags v2.9.1
Compiling digest v0.10.7
Compiling parking_lot v0.12.5
Compiling tinyvec_macros v0.1.1
Compiling byteorder v1.5.0
Compiling tinyvec v1.6.0
Compiling crc32fast v1.5.0
Compiling gix-trace v0.1.13
Compiling typeid v1.0.3
Compiling home v0.5.9
Compiling erased-serde v0.4.6
Compiling serde_fmt v1.0.3
Compiling zlib-rs v0.5.2
Compiling unicode-normalization v0.1.23
Compiling value-bag-serde1 v1.11.1
Compiling same-file v1.0.6
Compiling walkdir v2.5.0
Compiling gix-utils v0.3.0
Compiling bstr v1.12.0
Compiling zerofrom v0.1.6
Compiling value-bag v1.11.1
Compiling gix-validate v0.10.0
Compiling prodash v30.0.1
Compiling gix-path v0.10.20
Compiling itoa v1.0.11
Compiling yoke v0.7.5
Compiling log v0.4.27
Compiling zerovec v0.10.4
Compiling hash32 v0.3.1
Compiling zeroize v1.7.0
Compiling heapless v0.8.0
Compiling libz-rs-sys v0.5.2
Compiling tinystr v0.7.6
Compiling flate2 v1.1.1
Compiling getrandom v0.3.3
Compiling litemap v0.7.5
Compiling gix-features v0.43.1
Compiling writeable v0.5.5
Compiling faster-hex v0.10.0
Compiling linux-raw-sys v0.9.4
Compiling icu_locid v1.5.0
Compiling icu_locid_transform_data v1.5.1
Compiling sha1 v0.10.6
Compiling block-padding v0.3.3
Compiling inout v0.1.3
Compiling sha1-checked v0.10.0
Compiling icu_properties_data v1.5.1
Compiling icu_collections v1.5.0
Compiling icu_provider v1.5.0
Compiling rustix v1.0.7
Compiling icu_locid_transform v1.5.0
Compiling gix-hash v0.19.0
Compiling cipher v0.4.4
Compiling icu_normalizer_data v1.5.1
Compiling write16 v1.0.0
Compiling utf16_iter v1.0.5
Compiling utf8_iter v1.0.4
Compiling percent-encoding v2.3.1
Compiling sha2 v0.10.8
Compiling form_urlencoded v1.2.1
Compiling icu_properties v1.5.1
Compiling libz-sys v1.1.16
Compiling thiserror v1.0.69
Compiling universal-hash v0.5.1
Compiling equivalent v1.0.1
Compiling opaque-debug v0.3.1
Compiling hashbrown v0.14.3
Compiling ryu v1.0.17
Compiling libgit2-sys v0.17.0+1.8.1
Compiling indexmap v2.2.6
Compiling signature v1.6.4
Compiling ed25519 v1.5.3
Compiling ref-cast v1.0.24
Compiling serde_json v1.0.140
Compiling icu_normalizer v1.5.0
Compiling tempfile v3.23.0
Compiling idna_adapter v1.2.0
Compiling idna v1.0.3
Compiling aead v0.5.2
Compiling amplify_num v0.5.2
Compiling dyn-clone v1.0.17
Compiling url v2.5.4
Compiling ascii v1.1.0
Compiling ct-codecs v1.1.1
Compiling num-traits v0.2.19
Compiling ec25519 v0.1.0
Compiling amplify v4.6.0
Compiling poly1305 v0.8.0
Compiling git-ref-format-core v0.6.0
Compiling chacha20 v0.9.1
Compiling cyphergraphy v0.3.0
Compiling polyval v0.6.2
Compiling sqlite3-src v0.5.1
Compiling hmac v0.12.1
Compiling base64ct v1.6.0
Compiling keccak v0.1.5
Compiling pem-rfc7468 v0.7.0
Compiling sha3 v0.10.8
Compiling pbkdf2 v0.12.2
Compiling ghash v0.5.1
Compiling aes v0.8.4
Compiling ctr v0.9.2
Compiling rand v0.8.5
Compiling base32 v0.4.0
Compiling cypheraddr v0.4.0
Compiling qcheck v1.0.0
Compiling aes-gcm v0.10.3
Compiling schemars v1.0.4
Compiling ssh-encoding v0.2.0
Compiling chacha20poly1305 v0.10.1
Compiling blowfish v0.9.1
Compiling cbc v0.1.2
Compiling data-encoding v2.5.0
Compiling ssh-cipher v0.2.0
Compiling data-encoding-macro v0.1.14
Compiling bcrypt-pbkdf v0.10.0
Compiling noise-framework v0.4.0
Compiling socks5-client v0.4.1
Compiling base-x v0.2.11
Compiling signature v2.2.0
Compiling multibase v0.9.1
Compiling ssh-key v0.6.6
Compiling cyphernet v0.5.2
Compiling radicle-ssh v0.10.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-ssh)
Compiling crossbeam-utils v0.8.19
Compiling crossbeam-channel v0.5.15
Compiling jiff v0.2.15
Compiling lazy_static v1.5.0
Compiling nonempty v0.9.0
Compiling siphasher v1.0.1
Compiling anstyle-query v1.0.2
Compiling radicle-dag v0.10.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-dag)
Compiling radicle-git-metadata v0.1.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-git-metadata)
Compiling winnow v0.7.13
Compiling hashbrown v0.15.5
Compiling utf8parse v0.2.1
Compiling anstyle-parse v0.2.3
Compiling gix-hashtable v0.9.0
Compiling gix-date v0.10.5
Compiling gix-actor v0.35.4
Compiling radicle-git-ref-format v0.1.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-git-ref-format)
Compiling colorchoice v1.0.0
Compiling anstyle v1.0.11
Compiling iana-time-zone v0.1.60
Compiling base64 v0.21.7
Compiling chrono v0.4.38
Compiling anstream v0.6.13
Compiling gix-object v0.50.2
Compiling colored v2.1.0
Compiling radicle-localtime v0.1.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-localtime)
Compiling serde-untagged v0.1.7
Compiling bytesize v2.0.1
Compiling memmap2 v0.9.8
Compiling dunce v1.0.5
Compiling tree-sitter-language v0.1.2
Compiling fast-glob v0.3.3
Compiling gix-chunk v0.4.11
Compiling adler2 v2.0.0
Compiling gix-fs v0.16.1
Compiling gix-commitgraph v0.29.0
Compiling gix-tempfile v18.0.0
Compiling gix-revwalk v0.21.0
Compiling mio v1.0.4
Compiling gix-quote v0.6.0
Compiling errno v0.3.13
Compiling sem_safe v0.2.0
Compiling unicode-segmentation v1.11.0
Compiling shell-words v1.1.0
Compiling either v1.11.0
Compiling gix-command v0.6.2
Compiling signals_receipts v0.2.0
Compiling gix-lock v18.0.0
Compiling gix-url v0.32.0
Compiling gix-config-value v0.15.1
Compiling gix-sec v0.12.0
Compiling signal-hook-registry v1.4.5
Compiling gimli v0.31.1
Compiling signal-hook v0.3.18
Compiling gix-prompt v0.11.1
Compiling object v0.36.7
Compiling addr2line v0.24.2
Compiling radicle-signals v0.11.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-signals)
Compiling gix-traverse v0.47.0
Compiling gix-revision v0.35.0
Compiling miniz_oxide v0.8.8
Compiling gix-diff v0.53.0
Compiling gix-packetline v0.19.1
Compiling mio v0.8.11
Compiling tree-sitter v0.24.4
Compiling rustc-demangle v0.1.26
Compiling rustix v0.38.34
Compiling backtrace v0.3.75
Compiling sqlite3-sys v0.15.2
Compiling sqlite v0.32.0
Compiling radicle-crypto v0.14.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-crypto)
Compiling signal-hook-mio v0.2.4
Compiling gix-transport v0.48.0
Compiling gix-pack v0.60.0
Compiling gix-refspec v0.31.0
Compiling gix-credentials v0.30.0
Compiling gix-ref v0.53.1
Compiling gix-shallow v0.5.0
Compiling convert_case v0.7.1
Compiling gix-negotiate v0.21.0
Compiling regex v1.11.1
Compiling arc-swap v1.7.1
Compiling gix-odb v0.70.0
Compiling gix-protocol v0.51.0
Compiling derive_more-impl v2.0.1
Compiling xattr v1.3.1
Compiling uuid v1.16.0
Compiling filetime v0.2.23
Compiling bitflags v1.3.2
Compiling unicode-width v0.2.1
Compiling bytes v1.10.1
Compiling crossterm v0.25.0
Compiling console v0.16.0
Compiling tar v0.4.40
Compiling git-ref-format-macro v0.6.0
Compiling derive_more v2.0.1
Compiling anyhow v1.0.82
Compiling portable-atomic v1.11.0
Compiling newline-converter v0.3.0
Compiling snapbox-macros v0.3.8
Compiling salsa20 v0.10.2
Compiling fxhash v0.2.1
Compiling strsim v0.11.1
Compiling siphasher v0.3.11
Compiling unit-prefix v0.5.1
Compiling unicode-width v0.1.11
Compiling clap_lex v0.7.5
Compiling similar v2.5.0
Compiling streaming-iterator v0.1.9
Compiling normalize-line-endings v0.3.0
Compiling clap_builder v4.5.44
Compiling snapbox v0.4.17
Compiling inquire v0.7.5
Compiling indicatif v0.18.0
Compiling bloomy v1.2.0
Compiling scrypt v0.11.0
Compiling radicle-surf v0.26.0
Compiling crossterm v0.29.0
Compiling git-ref-format v0.6.0
Compiling unicode-display-width v0.3.0
Compiling systemd-journal-logger v2.2.2
Compiling serde_spanned v1.0.0
Compiling toml_datetime v0.7.0
Compiling tree-sitter-rust v0.23.2
Compiling tree-sitter-html v0.23.2
Compiling tree-sitter-md v0.3.2
Compiling tree-sitter-ruby v0.23.1
Compiling tree-sitter-json v0.24.8
Compiling tree-sitter-c v0.23.2
Compiling tree-sitter-python v0.23.4
Compiling tree-sitter-go v0.23.4
Compiling tree-sitter-toml-ng v0.6.0
Compiling tree-sitter-typescript v0.23.2
Compiling tree-sitter-css v0.23.1
Compiling tree-sitter-bash v0.23.3
Compiling toml_writer v1.0.2
Compiling pin-project-lite v0.2.16
Compiling radicle-std-ext v0.2.0
Compiling tokio v1.47.1
Compiling toml v0.9.5
Compiling clap v4.5.44
Compiling os_info v3.12.0
Compiling diff v0.1.13
Compiling radicle-node v0.16.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-node)
Compiling radicle-cli v0.17.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-cli)
Compiling yansi v0.5.1
Compiling human-panic v2.0.3
Compiling pretty_assertions v1.4.0
Compiling clap_complete v4.5.60
Compiling structured-logger v1.0.4
Compiling radicle-systemd v0.11.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-systemd)
Compiling tree-sitter-highlight v0.24.4
Compiling itertools v0.14.0
Compiling num-integer v0.1.46
Compiling socket2 v0.5.7
Compiling timeago v0.4.2
Compiling lexopt v0.3.0
Compiling bit-vec v0.8.0
Compiling escargot v0.5.10
Compiling bit-set v0.8.0
Compiling num-bigint v0.4.6
Compiling rand_core v0.9.3
Compiling num-iter v0.1.45
Compiling num-complex v0.4.6
Compiling env_filter v0.1.3
Compiling num-rational v0.4.2
Compiling zerocopy v0.7.35
Compiling borrow-or-share v0.2.2
Compiling fluent-uri v0.3.2
Compiling num v0.4.3
Compiling ahash v0.8.11
Compiling env_logger v0.11.8
Compiling phf_shared v0.11.3
Compiling wait-timeout v0.2.1
Compiling fnv v1.0.7
Compiling quick-error v1.2.3
Compiling radicle-remote-helper v0.14.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-remote-helper)
Compiling ppv-lite86 v0.2.17
Compiling outref v0.5.2
Compiling vsimd v0.8.0
Compiling rand_chacha v0.9.0
Compiling rusty-fork v0.3.1
Compiling uuid-simd v0.8.0
Compiling test-log v0.2.18
Compiling referencing v0.30.0
Compiling phf v0.11.3
Compiling fraction v0.15.3
Compiling rand_xorshift v0.4.0
Compiling rand v0.9.2
Compiling fancy-regex v0.14.0
Compiling email_address v0.2.9
Compiling num-cmp v0.1.0
Compiling git2 v0.19.0
Compiling unarray v0.1.4
Compiling base64 v0.22.1
Compiling bytecount v0.6.8
Compiling jsonschema v0.30.0
Compiling proptest v1.9.0
Compiling emojis v0.6.4
Compiling radicle-oid v0.1.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-oid)
Compiling radicle-core v0.1.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-core)
Compiling radicle-cob v0.17.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-cob)
Compiling radicle-git-ext v0.11.0
Compiling radicle-term v0.16.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-term)
Compiling radicle v0.20.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle)
Compiling radicle-fetch v0.16.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-fetch)
Compiling radicle-protocol v0.4.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-protocol)
Compiling radicle-cli-test v0.13.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-cli-test)
Compiling radicle-schemars v0.6.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-schemars)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 54.30s
+ cargo doc --workspace --no-deps --all-features
Checking regex-automata v0.4.9
Compiling syn v1.0.109
Checking idna v1.0.3
Compiling num-traits v0.2.19
Checking radicle-ssh v0.10.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-ssh)
Checking url v2.5.4
Checking git2 v0.19.0
Checking proptest v1.9.0
Checking bstr v1.12.0
Compiling amplify_syn v2.0.1
Checking gix-validate v0.10.0
Checking gix-path v0.10.20
Checking git-ref-format-core v0.6.0
Checking gix-features v0.43.1
Compiling data-encoding-macro-internal v0.1.12
Checking gix-hash v0.19.0
Compiling amplify_derive v4.0.0
Checking radicle-git-ref-format v0.1.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-git-ref-format)
Checking gix-date v0.10.5
Checking radicle-oid v0.1.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-oid)
Checking gix-actor v0.35.4
Checking data-encoding-macro v0.1.14
Checking gix-hashtable v0.9.0
Checking multibase v0.9.1
Checking radicle-dag v0.10.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-dag)
Checking gix-object v0.50.2
Checking radicle-git-metadata v0.1.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-git-metadata)
Checking chrono v0.4.38
Checking gix-commitgraph v0.29.0
Checking radicle-localtime v0.1.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-localtime)
Checking gix-fs v0.16.1
Checking gix-revwalk v0.21.0
Checking gix-tempfile v18.0.0
Checking gix-quote v0.6.0
Checking gix-url v0.32.0
Checking gix-lock v18.0.0
Checking gix-command v0.6.2
Checking gix-config-value v0.15.1
Checking radicle-signals v0.11.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-signals)
Checking gix-revision v0.35.0
Checking amplify v4.6.0
Checking gix-traverse v0.47.0
Checking gix-prompt v0.11.1
Checking gix-diff v0.53.0
Checking gix-packetline v0.19.1
Checking cyphergraphy v0.3.0
Checking regex v1.11.1
Checking gix-pack v0.60.0
Checking gix-transport v0.48.0
Checking cypheraddr v0.4.0
Checking noise-framework v0.4.0
Checking tree-sitter v0.24.4
Checking socks5-client v0.4.1
Checking gix-credentials v0.30.0
Checking cyphernet v0.5.2
Checking radicle-crypto v0.14.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-crypto)
Checking gix-refspec v0.31.0
Checking git-ref-format v0.6.0
Checking gix-shallow v0.5.0
Checking gix-ref v0.53.1
Checking radicle-core v0.1.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-core)
Checking radicle-cob v0.17.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-cob)
Checking gix-negotiate v0.21.0
Checking gix-odb v0.70.0
Checking radicle-git-ext v0.11.0
Checking uuid v1.16.0
Checking radicle v0.20.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle)
Checking gix-protocol v0.51.0
Compiling radicle-cli v0.17.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-cli)
Checking human-panic v2.0.3
Checking radicle-surf v0.26.0
Checking tree-sitter-toml-ng v0.6.0
Checking radicle-term v0.16.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-term)
Checking tree-sitter-highlight v0.24.4
Checking radicle-systemd v0.11.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-systemd)
Documenting radicle-systemd v0.11.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-systemd)
Documenting radicle v0.20.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle)
Documenting radicle-term v0.16.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-term)
Documenting radicle-cob v0.17.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-cob)
Documenting radicle-core v0.1.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-core)
Documenting radicle-crypto v0.14.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-crypto)
Documenting radicle-signals v0.11.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-signals)
Documenting radicle-oid v0.1.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-oid)
Documenting radicle-git-ref-format v0.1.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-git-ref-format)
Documenting radicle-localtime v0.1.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-localtime)
Documenting radicle-ssh v0.10.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-ssh)
Documenting radicle-dag v0.10.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-dag)
Documenting radicle-git-metadata v0.1.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-git-metadata)
Checking radicle-fetch v0.16.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-fetch)
Documenting radicle-cli v0.17.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-cli)
Documenting radicle-fetch v0.16.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-fetch)
Checking radicle-protocol v0.4.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-protocol)
Documenting radicle-protocol v0.4.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-protocol)
Documenting radicle-node v0.16.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-node)
Documenting radicle-schemars v0.6.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-schemars)
Documenting radicle-cli-test v0.13.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-cli-test)
Documenting radicle-remote-helper v0.14.0 (/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-remote-helper)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.33s
Generated /7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/target/doc/radicle/index.html and 20 other files
+ cargo test --workspace --no-fail-fast
Finished `test` profile [unoptimized + debuginfo] target(s) in 0.14s
Running unittests src/lib.rs (target/debug/deps/radicle-17353fb59e43dcb4)
running 236 tests
test canonical::formatter::test::ascii_control_characters ... ok
test canonical::formatter::test::ordered_nested_object ... ok
test canonical::formatter::test::securesystemslib_asserts ... ok
test cob::cache::migrations::_2::tests::test_patch_json_deserialization ... ok
test cob::cache::tests::test_check_version ... ok
test cob::common::test::test_color ... ok
test cob::common::test::test_title ... ok
test cob::cache::tests::test_migrate_to ... ok
test cob::common::test::test_emojis ... ok
test cob::cache::migrations::_2::tests::test_migration_2 ... ok
test cob::identity::test::prop_json_eq_str ... ok
test cob::identity::test::test_identity_redact_revision ... ok
test cob::identity::test::test_identity_remove_delegate_concurrent ... ok
test cob::identity::test::test_identity_update_rejected ... ok
test cob::identity::test::test_identity_reject_concurrent ... ok
test cob::identity::test::test_identity_updates ... ok
test cob::issue::cache::tests::test_counts ... ok
test cob::issue::cache::tests::test_get ... ok
test cob::issue::cache::tests::test_is_empty ... ok
test cob::issue::cache::tests::test_list ... ok
test cob::issue::cache::tests::test_list_by_status ... ok
test cob::issue::cache::tests::test_remove ... ok
test cob::identity::test::test_valid_identity ... ok
test cob::identity::test::test_identity_updates_concurrent ... ok
test cob::issue::test::test_embeds ... ok
test cob::identity::test::test_identity_updates_concurrent_outdated ... ok
test cob::issue::test::test_embeds_edit ... ok
test cob::issue::test::test_invalid_actions ... ok
test cob::issue::test::test_invalid_tx ... ok
test cob::issue::test::test_invalid_tx_reference ... ok
test cob::issue::test::test_invalid_cob ... ok
test cob::issue::test::test_issue_all ... ok
test cob::issue::test::test_concurrency ... ok
test cob::issue::test::test_issue_comment ... ok
test cob::issue::test::test_issue_comment_redact ... ok
test cob::issue::test::test_issue_create_and_assign ... ok
test cob::issue::test::test_issue_create_and_change_state ... ok
test cob::issue::test::test_issue_create_and_get ... ok
test cob::issue::test::test_issue_create_and_unassign ... ok
test cob::issue::test::test_issue_create_and_reassign ... ok
test cob::issue::test::test_issue_edit ... ok
test cob::issue::test::test_issue_edit_description ... ok
test cob::issue::test::test_issue_label ... ok
test cob::issue::test::test_issue_state_serde ... ok
test cob::issue::test::test_ordering ... ok
test cob::patch::actions::test::test_review_edit ... ok
test cob::issue::test::test_issue_multilines ... ok
test cob::issue::test::test_issue_react ... ok
test cob::patch::cache::tests::test_get ... ok
test cob::patch::cache::tests::test_is_empty ... ok
test cob::issue::test::test_issue_reply ... ok
test cob::patch::cache::tests::test_list_by_status ... ok
test cob::patch::cache::tests::test_remove ... ok
test cob::patch::encoding::review::test::test_review_deserialize_summary_migration_null_summary ... ok
test cob::patch::encoding::review::test::test_review_deserialize_summary_migration_with_summary ... ok
test cob::patch::encoding::review::test::test_review_deserialize_summary_migration_without_summary ... ok
test cob::patch::encoding::review::test::test_review_deserialize_summary_v2 ... ok
test cob::patch::encoding::review::test::test_review_summary ... ok
test cob::patch::test::test_json ... ok
test cob::patch::test::test_json_serialization ... ok
test cob::patch::test::test_patch_create_and_get ... ok
test cob::patch::cache::tests::test_list ... ok
test cob::patch::test::test_patch_discussion ... ok
test cob::patch::test::test_patch_merge ... ok
test cob::patch::test::test_patch_redact ... ok
test cob::patch::test::test_patch_review ... ok
test cob::patch::cache::tests::test_counts ... ok
test cob::patch::test::test_patch_review_comment ... ok
test cob::patch::test::test_patch_review_duplicate ... ok
test cob::patch::test::test_patch_review_edit ... ok
test cob::patch::test::test_patch_review_remove_summary ... ok
test cob::patch::test::test_patch_review_edit_comment ... ok
test cob::patch::test::test_reactions_json_serialization ... ok
test cob::patch::test::test_revision_edit_redact ... ok
test cob::patch::test::test_revision_reaction ... ok
test cob::patch::test::test_revision_review_merge_redacted ... ok
test cob::patch::test::test_patch_review_revision_redact ... ok
test cob::stream::tests::test_all_from ... ok
test cob::stream::tests::test_all_from_until ... ok
test cob::stream::tests::test_all_until ... ok
test cob::stream::tests::test_regression_from_until ... ok
test cob::stream::tests::test_from_until ... ok
test cob::thread::tests::test_comment_edit_missing ... ok
test cob::thread::tests::test_comment_edit_redacted ... ok
test cob::thread::tests::test_comment_redact_missing ... ok
test cob::thread::tests::test_duplicate_comments ... ok
test cob::thread::tests::test_edit_comment ... ok
test cob::patch::test::test_patch_update ... ok
test cob::thread::tests::test_redact_comment ... ok
test git::canonical::quorum::test::merge_base_commutative ... ok
test git::canonical::quorum::test::test_merge_bases ... ok
test cob::thread::tests::test_timeline ... ok
test git::canonical::rules::tests::test_deserialization ... ok
test git::canonical::rules::tests::test_deserialize_extensions ... ok
test git::canonical::rules::tests::test_order ... ok
test git::canonical::rules::tests::test_roundtrip ... ok
test git::canonical::rules::tests::test_canonical ... ok
test git::canonical::rules::tests::test_rule_validate_success ... ok
test git::canonical::rules::tests::test_special_branches ... ok
test git::canonical::tests::test_commit_quorum_fork_of_a_fork ... ok
test git::canonical::tests::test_commit_quorum_forked_merge_commits ... ok
test git::canonical::tests::test_commit_quorum_groups ... ok
test git::canonical::tests::test_commit_quorum_linear ... ok
test git::canonical::tests::test_commit_quorum_merges ... ok
test git::canonical::tests::test_commit_quorum_single ... ok
test git::canonical::tests::test_commit_quorum_three_way_fork ... ok
test git::canonical::tests::test_commit_quorum_two_way_fork ... ok
test git::canonical::tests::test_quorum_different_types ... ok
test git::canonical::rules::tests::test_rule_validate_failures ... ok
test git::canonical::tests::test_tag_quorum ... ok
test git::test::test_version_from_str ... ok
test git::test::test_version_ord ... ok
test identity::did::test::test_did_encode_decode ... ok
test identity::did::test::test_did_vectors ... ok
test git::canonical::tests::test_quorum_properties ... ok
test identity::doc::test::test_canonical_doc ... ok
test cob::thread::tests::prop_ordering ... ok
test identity::doc::test::test_duplicate_dids ... ok
test identity::doc::test::test_future_version_error ... ok
test identity::doc::test::test_is_valid_version ... ok
test identity::doc::test::test_canonical_example ... ok
test identity::doc::test::test_not_found ... ok
test identity::doc::test::test_parse_version ... ok
test identity::doc::test::test_visibility_json ... ok
test identity::doc::update::test::test_can_update_crefs ... ok
test identity::doc::update::test::test_cannot_include_default_branch_rule ... ok
test identity::doc::update::test::test_default_branch_rule_exists_after_verification ... ok
test identity::project::test::test_project_name ... ok
test node::address::store::test::test_alias ... ok
test node::address::store::test::test_disconnected ... ok
test node::address::store::test::test_disconnected_ban ... ok
test node::address::store::test::test_empty ... ok
test node::address::store::test::test_entries ... ok
test node::address::store::test::test_get_none ... ok
test node::address::store::test::test_insert_and_get ... ok
test node::address::store::test::test_insert_and_remove ... ok
test node::address::store::test::test_insert_and_update ... ok
test node::address::store::test::test_insert_duplicate ... ok
test node::address::store::test::test_node_aliases ... ok
test node::address::store::test::test_remove_nothing ... ok
test node::command::test::command_result ... ok
test node::config::test::partial ... ok
test node::db::test::test_version ... ok
test node::features::test::test_operations ... ok
test node::notifications::store::test::test_branch_notifications ... ok
test node::notifications::store::test::test_clear ... ok
test node::notifications::store::test::test_cob_notifications ... ok
test node::notifications::store::test::test_counts_by_repo ... ok
test node::notifications::store::test::test_duplicate_notifications ... ok
test node::notifications::store::test::test_notification_status ... ok
test node::policy::store::test::test_follow_and_unfollow_node ... ok
test node::policy::store::test::test_node_aliases ... ok
test node::policy::store::test::test_node_policies ... ok
test node::policy::store::test::test_node_policy ... ok
test node::policy::store::test::test_repo_policies ... ok
test node::policy::store::test::test_repo_policy ... ok
test node::policy::store::test::test_seed_and_unseed_repo ... ok
test node::policy::store::test::test_update_alias ... ok
test node::policy::store::test::test_update_scope ... ok
test node::refs::store::test::test_count ... ok
test node::refs::store::test::test_set_and_delete ... ok
test node::refs::store::test::test_set_and_get ... ok
test node::routing::test::test_count ... ok
test node::routing::test::test_entries ... ok
test identity::doc::test::test_max_delegates ... ok
test node::routing::test::test_insert_and_get ... ok
test node::routing::test::test_insert_and_get_resources ... ok
test node::routing::test::test_insert_and_remove ... ok
test node::routing::test::test_insert_duplicate ... ok
test node::routing::test::test_insert_existing_updated_time ... ok
test node::routing::test::test_len ... ok
test node::routing::test::test_remove_many ... ok
test node::routing::test::test_remove_redundant ... ok
test node::routing::test::test_update_existing_multi ... ok
test node::sync::announce::test::all_synced_nodes_are_preferred_seeds ... ok
test node::sync::announce::test::announcer_adapts_target_to_reach ... ok
test node::sync::announce::test::announcer_preferred_seeds_or_replica_factor ... ok
test node::routing::test::test_prune ... ok
test node::sync::announce::test::announcer_reached_max_replication_target ... ok
test node::sync::announce::test::announcer_reached_min_replication_target ... ok
test node::sync::announce::test::announcer_synced_with_unknown_node ... ok
test node::sync::announce::test::announcer_reached_preferred_seeds ... ok
test node::sync::announce::test::announcer_with_replication_factor_zero_and_preferred_seeds ... ok
test node::sync::announce::test::announcer_timed_out ... ok
test node::sync::announce::test::cannot_construct_announcer ... ok
test node::sync::announce::test::construct_node_appears_in_multiple_input_sets ... ok
test node::sync::announce::test::construct_only_preferred_seeds_provided ... ok
test node::sync::announce::test::local_node_in_multiple_sets ... ok
test node::sync::announce::test::invariant_progress_should_match_state ... ok
test node::sync::announce::test::local_node_in_preferred_seeds ... ok
test node::sync::announce::test::local_node_in_unsynced_set ... ok
test node::sync::announce::test::local_node_in_synced_set ... ok
test node::sync::announce::test::local_node_only_in_all_sets_results_in_no_seeds_error ... ok
test node::sync::announce::test::preferred_seeds_already_synced ... ok
test node::sync::announce::test::synced_with_local_node_is_ignored ... ok
test node::sync::announce::test::timed_out_after_reaching_success ... ok
test node::sync::announce::test::synced_with_same_node_multiple_times ... ok
test node::sync::fetch::test::all_nodes_are_candidates ... ok
test node::sync::fetch::test::could_not_reach_target ... ok
test node::sync::fetch::test::all_nodes_are_fetchable ... ok
test node::sync::fetch::test::ignores_duplicates_and_local_node ... ok
test node::sync::fetch::test::preferred_seeds_target_returned_over_replicas ... ok
test node::sync::fetch::test::reaches_target_of_max_replicas ... ok
test node::sync::fetch::test::reaches_target_of_preferred_seeds ... ok
test node::sync::test::ensure_replicas_construction ... ok
test node::sync::test::replicas_constrain_to ... ok
test node::test::test_alias ... ok
test node::test::test_command_result ... ok
test node::test::test_user_agent ... ok
test node::timestamp::tests::test_timestamp_max ... ok
test node::sync::fetch::test::reaches_target_of_replicas ... ok
test profile::test::canonicalize_home ... ok
test profile::test::test_config ... ok
test rad::tests::test_checkout ... ok
test cob::patch::cache::tests::test_find_by_revision ... ok
test rad::tests::test_init ... ok
test rad::tests::test_fork ... ok
test storage::git::tests::test_references_of ... ok
test storage::git::tests::test_sign_refs ... ok
test storage::git::transport::local::url::test::test_url_parse ... ok
test storage::git::transport::local::url::test::test_url_to_string ... ok
test storage::git::transport::remote::url::test::test_url_parse ... ok
test profile::config::test::schema ... ok
test storage::refs::tests::prop_canonical_roundtrip ... ok
test storage::tests::test_storage ... ok
test test::assert::test::assert_with_message ... ok
test test::assert::test::test_assert_no_move ... ok
test test::assert::test::test_assert_panic_0 - should panic ... ok
test test::assert::test::test_assert_panic_1 - should panic ... ok
test test::assert::test::test_assert_panic_2 - should panic ... ok
test test::assert::test::test_assert_succeed ... ok
test test::assert::test::test_panic_message ... ok
test version::test::test_version ... ok
test storage::git::tests::test_remote_refs ... ok
test storage::refs::tests::test_rid_verification ... ok
test identity::doc::test::prop_encode_decode ... ok
test result: ok. 236 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.07s
Running unittests src/lib.rs (target/debug/deps/radicle_cli-edbd69a9593a9f0b)
running 46 tests
test commands::block::args::test::should_not_parse ... ok
test commands::block::args::test::should_parse_nid ... ok
test commands::clone::args::test::should_parse_rid_non_urn ... ok
test commands::block::args::test::should_parse_rid ... ok
test commands::clone::args::test::should_parse_rid_urn ... ok
test commands::clone::args::test::should_parse_rid_url ... ok
test commands::cob::args::test::should_allow_log_pretty_format ... ok
test commands::cob::args::test::should_not_allow_show_pretty_format ... ok
test commands::cob::args::test::should_allow_show_json_format ... ok
test commands::cob::args::test::should_allow_update_json_format ... ok
test commands::fork::args::test::should_not_parse_rid_url ... ok
test commands::cob::args::test::should_allow_log_json_format ... ok
test commands::fork::args::test::should_parse_rid_non_urn ... ok
test commands::cob::args::test::should_not_allow_update_pretty_format ... ok
test commands::id::args::test::should_not_parse_into_payload - should panic ... ok
test commands::fork::args::test::should_parse_rid_urn ... ok
test commands::id::args::test::should_not_clobber_payload_args ... ok
test commands::id::args::test::should_not_parse_single_payload ... ok
test commands::id::args::test::should_parse_into_payload ... ok
test commands::id::args::test::should_parse_single_payload ... ok
test commands::id::args::test::should_parse_multiple_payloads ... ok
test commands::init::args::test::should_parse_rid_non_urn ... ok
test commands::init::args::test::should_not_parse_rid_url ... ok
test commands::init::args::test::should_parse_rid_urn ... ok
test commands::patch::review::builder::tests::test_review_comments_before ... ok
test commands::patch::review::builder::tests::test_review_comments_basic ... ok
test commands::id::args::test::should_not_parse_single_payloads ... ok
test commands::inspect::test::test_tree ... ok
test commands::patch::review::builder::tests::test_review_comments_split_hunk ... ok
test commands::patch::review::builder::tests::test_review_comments_multiline ... ok
test commands::publish::args::test::should_not_parse_rid_url ... ok
test commands::publish::args::test::should_parse_rid_non_urn ... ok
test commands::publish::args::test::should_parse_rid_urn ... ok
test git::pretty_diff::test::test_pretty ... ignored
test git::ddiff::tests::diff_encode_decode_ddiff_hunk ... ok
test git::unified_diff::test::test_diff_content_encode_decode_content ... ok
test commands::watch::args::test::should_parse_ref_str ... ok
test terminal::args::test::should_not_parse ... ok
test terminal::args::test::should_parse_nid ... ok
test terminal::args::test::should_parse_rid ... ok
test terminal::format::test::test_bytes ... ok
test terminal::format::test::test_strip_comments ... ok
test git::unified_diff::test::test_diff_encode_decode_diff ... ok
test terminal::patch::test::test_edit_display_message ... ok
test terminal::patch::test::test_create_display_message ... ok
test terminal::patch::test::test_update_display_message ... ok
test result: ok. 45 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 0.01s
Running unittests src/main.rs (target/debug/deps/rad-4ed1fbcef7a99fe7)
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Running tests/commands.rs (target/debug/deps/commands-2321cc2144c5d04a)
running 111 tests
test framework_home ... ok
test git_push_and_fetch ... ok
test git_push_amend ... ok
test git_push_canonical_annotated_tags ... ok
test git_push_canonical_lightweight_tags ... ok
test git_push_force_with_lease ... ok
test git_push_diverge ... ok
test rad_auth ... ok
test rad_auth_errors ... ok
test rad_block ... ok
test rad_checkout ... ok
test git_tag ... ok
test git_push_rollback ... ok
test git_push_converge ... ok
test rad_clone ... ok
test rad_clean ... ok
test rad_clone_bare ... ok
test rad_clone_connect ... ok
test rad_clone_all ... ok
test rad_clone_unknown ... ok
test rad_cob_log ... ok
test rad_cob_multiset ... ok
test rad_clone_directory ... ok
test rad_cob_migrate ... ok
test rad_clone_partial_fail ... ok
test rad_cob_operations ... ok
test rad_cob_update_identity ... ok
test rad_cob_show ... ok
test rad_cob_update ... ok
test rad_diff ... ok
test rad_config ... ok
test rad_help ... ok
test rad_id_collaboration ... ignored, slow
test rad_id ... ok
test rad_id_conflict ... ok
test rad_id_private ... ok
test rad_id_threshold ... ok
test rad_id_multi_delegate ... ok
test rad_id_threshold_soft_fork ... ok
test rad_id_unauthorized_delegate ... ok
test rad_id_unknown_field ... ok
test rad_id_update_delete_field ... ok
test rad_init ... ignored, part of many other tests
test rad_init_bare ... ok
test rad_init_detached_head ... ok
test rad_init_existing ... ok
test rad_init_existing_bare ... ok
test rad_init_no_git ... ok
test rad_init_no_seed ... ok
test rad_init_private ... ok
test rad_fork ... ok
test rad_inbox ... ok
test rad_fetch ... ok
test rad_init_private_no_seed ... ok
test rad_init_private_clone ... ok
test rad_init_sync_not_connected ... ok
test rad_init_private_seed ... ok
test rad_init_private_clone_seed ... ok
test rad_init_with_existing_remote ... ok
test rad_init_sync_preferred ... ok
test rad_inspect ... ok
test rad_issue ... ok
test rad_jj_bare ... ok
test rad_jj_colocated_patch ... ok
test rad_key_mismatch ... ok
test rad_issue_list ... ok
test rad_merge_no_ff ... ok
test rad_merge_after_update ... ok
test rad_merge_via_push ... ok
test rad_node_connect ... ok
test rad_node_connect_without_address ... ok
test rad_patch ... ok
test rad_node ... ok
test rad_patch_change_base ... ok
test rad_patch_ahead_behind ... ok
test rad_patch_checkout ... ok
test rad_patch_checkout_revision ... ok
test rad_patch_checkout_force ... ok
test rad_patch_detached_head ... ok
test rad_init_sync_and_clone ... ok
test rad_patch_diff ... ok
test rad_patch_draft ... ok
test rad_init_sync_timeout ... ok
test rad_patch_edit ... ok
test rad_patch_fetch_2 ... FAILED
test rad_patch_merge_draft ... ok
test rad_patch_fetch_1 ... ok
test rad_patch_delete ... ok
test rad_patch_revert_merge ... ok
test rad_patch_update ... ok
test rad_patch_open_explore ... ok
test rad_patch_via_push ... FAILED
test rad_publish ... ok
test rad_review_by_hunk ... ok
test rad_seed_and_follow ... ok
test rad_remote ... ok
test rad_self ... ok
test rad_seed_many ... ok
test rad_sync_without_node ... ok
test rad_push_and_pull_patches ... ok
test rad_unseed ... ok
test rad_warn_old_nodes ... ok
test rad_unseed_many ... ok
test rad_sync ... ok
test rad_watch ... ok
test test_clone_without_seeds ... ok
test test_cob_deletion ... ok
test test_cob_replication ... ok
test rad_workflow ... ok
test rad_patch_pull_update ... ok
test test_replication_via_seed ... ok
failures:
---- rad_patch_fetch_2 stdout ----
1769448133 test: Using PATH ["/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-cli/target/debug", "/usr/local/cargo/bin", "/usr/local/sbin", "/usr/local/bin", "/usr/sbin", "/usr/bin", "/sbin", "/bin", "/tmp/.tmpA4P5kO/alice/work"]
1769448133 test: rad-init.md: Running `/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/target/debug/rad` with ["init", "--name", "heartwood", "--description", "Radicle Heartwood Protocol & Stack", "--no-confirm", "--public", "-v"] in `/tmp/.tmpA4P5kO/alice/work`..
1769448133 test: rad-init.md: Running `/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/target/debug/rad` with ["init"] in `/tmp/.tmpA4P5kO/alice/work`..
1769448133 test: rad-init.md: Running `/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/target/debug/rad` with ["ls"] in `/tmp/.tmpA4P5kO/alice/work`..
1769448133 test: rad-init.md: Running `/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/target/debug/rad` with ["node", "inventory"] in `/tmp/.tmpA4P5kO/alice/work`..
1769448133 test: Using PATH ["/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-cli/target/debug", "/usr/local/cargo/bin", "/usr/local/sbin", "/usr/local/bin", "/usr/sbin", "/usr/bin", "/sbin", "/bin", "/tmp/.tmpA4P5kO/alice/work"]
1769448133 test: rad-patch-fetch-2.md: Running `git` with ["checkout", "-b", "alice/1", "-q"] in `/tmp/.tmpA4P5kO/alice/work`..
1769448133 test: rad-patch-fetch-2.md: Running `git` with ["commit", "--allow-empty", "-m", "Changes #1", "-q"] in `/tmp/.tmpA4P5kO/alice/work`..
1769448133 test: rad-patch-fetch-2.md: Running `git` with ["push", "rad", "-o", "patch.message=Changes", "HEAD:refs/patches"] in `/tmp/.tmpA4P5kO/alice/work`..
1769448133 test: rad-patch-fetch-2.md: Running `git` with ["checkout", "master", "-q"] in `/tmp/.tmpA4P5kO/alice/work`..
1769448133 test: rad-patch-fetch-2.md: Running `git` with ["branch", "-D", "alice/1", "-q"] in `/tmp/.tmpA4P5kO/alice/work`..
1769448133 test: rad-patch-fetch-2.md: Running `git` with ["update-ref", "-d", "refs/remotes/rad/alice/1"] in `/tmp/.tmpA4P5kO/alice/work`..
1769448133 test: rad-patch-fetch-2.md: Running `git` with ["update-ref", "-d", "refs/remotes/rad/patches/5e2dedcc5d515fcbc1cca483d3376609fe889bfb"] in `/tmp/.tmpA4P5kO/alice/work`..
1769448133 test: rad-patch-fetch-2.md: Running `git` with ["gc", "--prune=now"] in `/tmp/.tmpA4P5kO/alice/work`..
1769448133 test: rad-patch-fetch-2.md: Running `git` with ["branch", "-r"] in `/tmp/.tmpA4P5kO/alice/work`..
1769448133 test: rad-patch-fetch-2.md: Running `git` with ["pull"] in `/tmp/.tmpA4P5kO/alice/work`..
1769448133 test: rad-patch-fetch-2.md: Running `git` with ["branch", "-r"] in `/tmp/.tmpA4P5kO/alice/work`..
thread 'rad_patch_fetch_2' panicked at crates/radicle-cli-test/src/lib.rs:503:36:
--- Expected
++++ actual: stdout
1 - rad/HEAD -> rad/master
2 1 | rad/master
3 2 | rad/patches/5e2dedcc5d515fcbc1cca483d3376609fe889bfb
Exit status: 0
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
---- rad_patch_via_push stdout ----
1769448134 test: Using PATH ["/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-cli/target/debug", "/usr/local/cargo/bin", "/usr/local/sbin", "/usr/local/bin", "/usr/sbin", "/usr/bin", "/sbin", "/bin", "/tmp/.tmpZIsFfU/alice/work"]
1769448134 test: rad-init.md: Running `/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/target/debug/rad` with ["init", "--name", "heartwood", "--description", "Radicle Heartwood Protocol & Stack", "--no-confirm", "--public", "-v"] in `/tmp/.tmpZIsFfU/alice/work`..
1769448134 test: rad-init.md: Running `/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/target/debug/rad` with ["init"] in `/tmp/.tmpZIsFfU/alice/work`..
1769448134 test: rad-init.md: Running `/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/target/debug/rad` with ["ls"] in `/tmp/.tmpZIsFfU/alice/work`..
1769448134 test: rad-init.md: Running `/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/target/debug/rad` with ["node", "inventory"] in `/tmp/.tmpZIsFfU/alice/work`..
1769448134 test: Using PATH ["/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/crates/radicle-cli/target/debug", "/usr/local/cargo/bin", "/usr/local/sbin", "/usr/local/bin", "/usr/sbin", "/usr/bin", "/sbin", "/bin", "/tmp/.tmpZIsFfU/alice/work"]
1769448134 test: rad-patch-via-push.md: Running `git` with ["checkout", "-b", "feature/1"] in `/tmp/.tmpZIsFfU/alice/work`..
1769448134 test: rad-patch-via-push.md: Running `git` with ["commit", "-a", "-m", "Add things", "-q", "--allow-empty"] in `/tmp/.tmpZIsFfU/alice/work`..
1769448134 test: rad-patch-via-push.md: Running `git` with ["push", "-o", "patch.message=Add things #1", "-o", "patch.message=See commits for details.", "rad", "HEAD:refs/patches"] in `/tmp/.tmpZIsFfU/alice/work`..
1769448134 test: rad-patch-via-push.md: Running `/7ece1017-5ca5-4b25-b0b4-0cd3cecd7aec/w/target/debug/rad` with ["patch", "show", "6035d2f582afbe01ff23ea87528ae523d76875b6"] in `/tmp/.tmpZIsFfU/alice/work`..
1769448134 test: rad-patch-via-push.md: Running `git` with ["branch", "-vv"] in `/tmp/.tmpZIsFfU/alice/work`..
1769448134 test: rad-patch-via-push.md: Running `git` with ["status", "--short", "--branch"] in `/tmp/.tmpZIsFfU/alice/work`..
1769448134 test: rad-patch-via-push.md: Running `git` with ["fetch"] in `/tmp/.tmpZIsFfU/alice/work`..
1769448134 test: rad-patch-via-push.md: Running `git` with ["push"] in `/tmp/.tmpZIsFfU/alice/work`..
1769448134 test: rad-patch-via-push.md: Running `git` with ["show-ref"] in `/tmp/.tmpZIsFfU/alice/work`..
thread 'rad_patch_via_push' panicked at crates/radicle-cli-test/src/lib.rs:503:36:
--- Expected
++++ actual: stdout
1 1 | 42d894a83c9c356552a57af09ccdbd5587a99045 refs/heads/feature/1
2 2 | f2de534b5e81d7c6e2dcaf58c3dd91573c0a0354 refs/heads/master
3 - f2de534b5e81d7c6e2dcaf58c3dd91573c0a0354 refs/remotes/rad/HEAD
4 3 | f2de534b5e81d7c6e2dcaf58c3dd91573c0a0354 refs/remotes/rad/master
5 4 | 42d894a83c9c356552a57af09ccdbd5587a99045 refs/remotes/rad/patches/6035d2f582afbe01ff23ea87528ae523d76875b6
Exit status: 0
failures:
rad_patch_fetch_2
rad_patch_via_push
test result: FAILED. 107 passed; 2 failed; 2 ignored; 0 measured; 0 filtered out; finished in 68.24s
error: test failed, to rerun pass `-p radicle-cli --test commands`
Running unittests src/lib.rs (target/debug/deps/radicle_cli_test-271eee1f80c41c0d)
running 3 tests
test tests::test_parse ... ok
test tests::test_run ... ok
test tests::test_example_spaced_brackets ... ok
test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Running unittests src/lib.rs (target/debug/deps/radicle_cob-84c4e41a69174119)
running 8 tests
test object::tests::test_serde ... ok
test tests::git::update_cob ... ok
test tests::git::list_cobs ... ok
test tests::git::roundtrip ... ok
test tests::invalid_parse_refstr ... ok
test tests::git::traverse_cobs ... ok
test type_name::test::valid_typenames ... ok
test tests::parse_refstr ... ok
test result: ok. 8 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
Running unittests src/lib.rs (target/debug/deps/radicle_core-ef9dfc09b2e6d61d)
running 2 tests
test repo::test::assert_prop_roundtrip_parse ... ok
test repo::serde_impls::test::assert_prop_roundtrip_serde_json ... ok
test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
Running unittests src/lib.rs (target/debug/deps/radicle_crypto-2cdf91f3179b3527)
running 12 tests
test ssh::fmt::test::test_key ... ok
test ssh::fmt::test::test_fingerprint ... ok
test ssh::keystore::tests::test_init_no_passphrase ... ok
test ssh::test::prop_encode_decode_sk ... ok
test ssh::test::test_agent_encoding_remove ... ok
test ssh::test::test_agent_encoding_sign ... ok
test tests::prop_encode_decode ... ok
test tests::test_e25519_dh ... ok
test tests::test_encode_decode ... ok
test tests::prop_key_equality ... ok
test ssh::keystore::tests::test_signer ... ok
test ssh::keystore::tests::test_init_passphrase ... ok
test result: ok. 12 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.85s
Running unittests src/lib.rs (target/debug/deps/radicle_dag-05f7457e7194a495)
running 20 tests
test tests::test_contains ... ok
test tests::test_cycle ... ok
test tests::test_dependencies ... ok
test tests::test_diamond ... ok
test tests::test_fold_diamond ... ok
test tests::test_fold_multiple_roots ... ok
test tests::test_complex ... ok
test tests::test_fold_reject ... ok
test tests::test_fold_sorting_1 ... ok
test tests::test_fold_sorting_2 ... ok
test tests::test_get ... ok
test tests::test_is_empty ... ok
test tests::test_len ... ok
test tests::test_merge_2 ... ok
test tests::test_merge_1 ... ok
test tests::test_prune_1 ... ok
test tests::test_prune_by_sorting ... ok
test tests::test_prune_2 ... ok
test tests::test_remove ... ok
test tests::test_siblings ... ok
test result: ok. 20 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Running unittests src/lib.rs (target/debug/deps/radicle_fetch-55beca16093fba7c)
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Running unittests src/lib.rs (target/debug/deps/radicle_git_metadata-ccdb6d430095148e)
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Running unittests src/lib.rs (target/debug/deps/radicle_git_ref_format-b808ac22aa3ddce7)
running 9 tests
test test::component ... ok
test test::pattern ... ok
test test::component_invalid - should panic ... ok
test test::qualified ... ok
test test::qualified_invalid - should panic ... ok
test test::qualified_pattern ... ok
test test::qualified_pattern_invalid - should panic ... ok
test test::refname ... ok
test test::refname_invalid - should panic ... ok
test result: ok. 9 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Running unittests src/lib.rs (target/debug/deps/radicle_localtime-b324a722f6463902)
running 1 test
test serde_impls::test::test_localtime ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Running unittests src/lib.rs (target/debug/deps/radicle_node-9731215c7afa8b2d)
running 74 tests
test reactor::timer::tests::test_next ... ok
test reactor::timer::tests::test_wake ... ok
test control::tests::test_control_socket ... ok
test reactor::timer::tests::test_wake_exact ... ok
test control::tests::test_seed_unseed ... ok
test fingerprint::tests::matching ... ok
test tests::e2e::missing_default_branch ... ok
test tests::e2e::test_catchup_on_refs_announcements ... ok
test tests::e2e::missing_delegate_default_branch ... ok
test tests::e2e::test_background_foreground_fetch ... ok
test tests::e2e::test_channel_reader_limit ... ok
test tests::e2e::test_clone ... ok
test tests::e2e::test_dont_fetch_owned_refs ... ok
test tests::e2e::test_connection_crossing ... ok
test tests::e2e::test_fetch_followed_remotes ... ok
test tests::e2e::test_concurrent_fetches ... ok
test tests::e2e::test_fetch_preserve_owned_refs ... ok
test tests::e2e::test_fetch_unseeded ... ok
test tests::e2e::test_fetch_up_to_date ... ok
test tests::e2e::test_inventory_sync_basic ... ok
test tests::e2e::test_fetch_emits_canonical_ref_update ... ok
test tests::e2e::test_large_fetch ... ok
test tests::e2e::test_migrated_clone ... ok
test tests::e2e::test_missing_remote ... ok
test tests::e2e::test_multiple_offline_inits ... ok
test tests::e2e::test_non_fastforward_sigrefs ... ok
test tests::e2e::test_outdated_delegate_sigrefs ... ok
test tests::e2e::test_outdated_sigrefs ... ok
test tests::e2e::test_replication ... ok
test tests::e2e::test_replication_invalid ... ok
test tests::e2e::test_inventory_sync_bridge ... ok
test tests::e2e::test_replication_ref_in_sigrefs ... ok
test tests::e2e::test_inventory_sync_ring ... ok
test tests::e2e::test_inventory_sync_star ... ok
test tests::test_announcement_rebroadcast ... ok
test tests::test_announcement_rebroadcast_duplicates ... ok
test tests::test_announcement_relay ... ok
test tests::test_announcement_rebroadcast_timestamp_filtered ... ok
test tests::test_disconnecting_unresponsive_peer ... ok
test tests::test_connection_kept_alive ... ok
test tests::test_fetch_missing_inventory_on_gossip ... ok
test tests::test_fetch_missing_inventory_on_schedule ... ok
test tests::test_inbound_connection ... ok
test tests::test_inventory_decode ... ok
test tests::test_init_and_seed ... ok
test tests::test_inventory_relay ... ok
test tests::test_inventory_relay_bad_timestamp ... ok
test tests::test_inventory_sync ... ok
test tests::test_maintain_connections ... ok
test tests::test_maintain_connections_failed_attempt ... ok
test tests::test_maintain_connections_transient ... ok
test tests::test_outbound_connection ... ok
test tests::test_inventory_pruning ... ok
test tests::test_persistent_peer_connect ... ok
test tests::test_persistent_peer_reconnect_success ... ok
test tests::test_persistent_peer_reconnect_attempt ... ok
test tests::test_ping_response ... ok
test tests::test_queued_fetch_from_command_same_rid ... ok
test tests::test_queued_fetch_from_ann_same_rid ... ok
test tests::test_redundant_connect ... ok
test tests::test_queued_fetch_max_capacity ... ok
test tests::test_refs_announcement_followed ... ok
test tests::test_refs_announcement_fetch_trusted_no_inventory ... ok
test tests::test_refs_announcement_no_subscribe ... ok
test tests::test_refs_announcement_offline ... ok
test tests::test_refs_announcement_relay_private ... ok
test tests::test_refs_announcement_relay_public ... ok
test tests::test_refs_synced_event ... ok
test tests::test_seeding ... ok
test wire::test::test_inventory_ann_with_extension ... ok
test wire::test::test_pong_message_with_extension ... ok
test tests::test_seed_repo_subscribe ... ok
test tests::prop_inventory_exchange_dense ... ok
test tests::test_announcement_message_amplification ... ok
test result: ok. 74 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 16.52s
Running unittests src/main.rs (target/debug/deps/radicle_node-ccb4efa548845ab3)
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Running unittests src/lib.rs (target/debug/deps/radicle_oid-d6586171c5e5bfc1)
running 10 tests
test fmt::test::fixture ... ok
test fmt::test::zero ... ok
test fmt::test::git2 ... ok
test git2::test::zero ... ok
test gix::test::zero ... ok
test str::test::fixture ... ok
test fmt::test::gix ... ok
test str::test::zero ... ok
test str::test::gix_roundrip ... ok
test str::test::git2_roundtrip ... ok
test result: ok. 10 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Running unittests src/lib.rs (target/debug/deps/radicle_protocol-2eb9deac47943445)
running 156 tests
test connections::state::test::prop_attempt_monotonic ... ok
test connections::state::test::prop_attempt_increments ... ok
test connections::state::test::prop_attempt_preserved_on_disconnect ... ok
test connections::state::test::prop_attempt_reset_on_stabilise ... ok
test connections::state::test::prop_connect_blocked_for_connecting ... ok
test connections::state::test::prop_connect_blocked_for_disconnected ... ok
test connections::state::test::prop_connect_idempotency ... ok
test connections::state::test::prop_delay_bounds ... ok
test connections::state::test::prop_address_preservation ... ok
test connections::state::test::prop_double_disconnect ... ok
test connections::state::test::prop_empty_initial ... ok
test connections::state::test::prop_ephemeral_removes ... ok
test connections::state::test::prop_connected_iterator ... ok
test connections::state::test::prop_exponential_backoff ... ok
test connections::state::test::prop_host_rate_limited ... ok
test connections::state::test::prop_has_retry_time ... ok
test connections::state::test::prop_inactivity_detection ... ok
test connections::state::test::prop_inbound_limit ... ok
test connections::state::test::prop_all_invariants ... ok
test connections::state::test::prop_inbound_creates ... ok
test connections::state::test::prop_inbound_overwrites_attempted ... ok
test connections::state::test::prop_inbound_link ... ok
test connections::state::test::prop_deterministic_transitions ... ok
test connections::state::test::prop_inbound_overwrites_disconnected ... ok
test connections::state::test::prop_last_active_on_connect ... ok
test connections::state::test::prop_inbound_overwrites_initial ... ok
test connections::state::test::prop_latency_bounded ... ok
test connections::state::test::prop_last_active_on_message ... ok
test connections::state::test::prop_link_conflict_inbound_session ... ok
test connections::state::test::prop_link_conflict_outbound_session ... ok
test connections::state::test::prop_localhost_accepted ... ok
test connections::state::test::prop_message_from_disconnected ... ok
test connections::state::test::prop_message_rate_limited ... ok
test connections::state::test::prop_missing_session_handling ... ok
test connections::state::test::prop_no_record_ip_for_dns ... ok
test connections::state::test::prop_no_record_ip_for_localhost ... ok
test connections::state::test::prop_local_node_exclusion ... ok
test connections::state::test::prop_iterator_complete ... ok
test connections::state::test::prop_link_counts ... ok
test connections::state::test::prop_number_of_outbound_connections ... ok
test connections::state::test::prop_outbound_link ... ok
test connections::state::test::prop_outbound_requires_session ... ok
test connections::state::test::prop_pong_only_connected ... ok
test connections::state::test::prop_persistent_preserves ... ok
test connections::state::test::prop_ping_state_transition ... ok
test connections::state::test::prop_no_state_loss ... ok
test connections::state::test::prop_record_ip_for_routable ... ok
test connections::state::test::prop_reconnect_reverses_disconnect ... ok
test connections::state::test::prop_stability_threshold ... ok
test connections::state::test::prop_stabilise_returns_newly_stable ... ok
test connections::state::test::prop_subscribe_requires_connected_session ... ok
test connections::state::test::prop_subscription_persistence_through_disconnect ... ok
test connections::state::test::prop_unresponsive_filter ... ok
test connections::state::test::prop_subscription_persistence ... ok
test deserializer::test::prop_decode_next ... ok
test deserializer::test::test_decode_next ... ok
test deserializer::test::test_unparsed ... ok
test connections::state::test::prop_session_existence_consistency ... ok
test connections::state::test::prop_single_session_per_node ... ok
test fetcher::test::queue::properties::capacity::capacity_reached_returns_same_item ... ok
test connections::state::test::prop_valid_transitions ... ok
test fetcher::test::queue::properties::dequeue::drained_queue_returns_none ... ok
test fetcher::test::queue::properties::dequeue::empty_queue_returns_none ... ok
test fetcher::test::queue::properties::dequeue::enables_reenqueue ... ok
test fetcher::test::queue::properties::equality::reflexive ... ok
test fetcher::test::queue::properties::equality::symmetric ... ok
test fetcher::test::queue::properties::equality::transitive ... ok
test fetcher::test::queue::properties::capacity::rejection ... ok
test fetcher::test::queue::properties::fifo::interleaved_operations ... ok
test fetcher::test::queue::properties::capacity::bounded ... ok
test fetcher::test::queue::properties::merge::combines_refs ... ok
test fetcher::test::queue::properties::merge::different_rid_accepted ... ok
test fetcher::test::queue::properties::fifo::ordering ... ok
test fetcher::test::queue::properties::merge::does_not_increase_queue_length ... ok
test fetcher::test::queue::properties::merge::longer_timeout_preserved ... ok
test fetcher::test::queue::properties::merge::empty_refs_fetches_all ... ok
test fetcher::test::queue::unit::capacity_takes_precedence_over_merge_for_new_items ... ok
test fetcher::test::queue::unit::empty_refs_at_items_can_be_equal ... ok
test fetcher::test::queue::unit::max_timeout_accepted ... ok
test fetcher::test::queue::unit::merge_preserves_position_in_queue ... ok
test fetcher::test::queue::unit::zero_timeout_accepted ... ok
test fetcher::test::state::command::cancel::cancellation_is_isolated ... ok
test fetcher::test::state::command::cancel::non_existent_returns_unexpected ... ok
test fetcher::test::state::command::cancel::ongoing_and_queued ... ok
test fetcher::test::state::command::cancel::single_ongoing ... ok
test fetcher::test::state::command::fetch::fetch_after_previous_completed ... ok
test fetcher::test::state::command::fetch::fetch_at_capacity_enqueues ... ok
test fetcher::test::state::command::fetch::fetch_different_repo_same_node_within_capacity ... ok
test fetcher::test::state::command::fetch::fetch_duplicate_returns_already_fetching ... ok
test fetcher::test::state::command::fetch::fetch_queue_merge_empty_refs_fetches_all ... ok
test fetcher::test::state::command::fetch::fetch_queue_merge_takes_longer_timeout ... ok
test fetcher::test::state::command::fetch::fetch_queue_merges_already_queued ... ok
test fetcher::test::state::command::fetch::fetch_queue_rejected_capacity_reached ... ok
test fetcher::test::state::command::fetch::fetch_same_repo_different_nodes_queues_second ... ok
test fetcher::test::state::command::fetch::fetch_same_repo_different_refs_enqueues ... ok
test fetcher::test::state::command::fetch::fetch_start_first_fetch_for_node ... ok
test fetcher::test::state::command::fetched::complete_one_of_multiple ... ok
test fetcher::test::state::command::fetched::complete_single_ongoing ... ok
test fetcher::test::state::command::fetched::complete_then_dequeue_fifo ... ok
test fetcher::test::state::command::fetched::non_existent_returns_not_found ... ok
test fetcher::test::state::concurrent::fetched_then_cancel ... ok
test fetcher::test::state::concurrent::interleaved_operations ... ok
test fetcher::test::state::config::high_concurrency ... ok
test fetcher::test::state::config::min_queue_size ... ok
test fetcher::test::state::dequeue::cannot_dequeue_while_node_at_capacity ... ok
test fetcher::test::state::dequeue::empty_queue_returns_none ... ok
test fetcher::test::state::dequeue::maintains_fifo_order ... ok
test fetcher::test::state::invariant::queue_integrity_after_merge ... ok
test fetcher::test::queue::properties::merge::succeed_when_at_capacity ... ok
test fetcher::test::state::multinode::independent_queues ... ok
test service::filter::test::compatible ... ok
test service::filter::test::test_parameters ... ok
test service::filter::test::test_sizes ... ok
test service::gossip::store::test::test_announced ... ok
test service::limiter::test::test_limitter_different_rates ... ok
test service::limiter::test::test_limitter_multi ... ok
test service::limiter::test::test_limitter_refill ... ok
test fetcher::test::state::multinode::high_count ... ok
test service::message::tests::test_inventory_limit ... ok
test service::message::tests::prop_refs_announcement_signing ... ok
test service::message::tests::test_ref_remote_limit ... ok
test wire::frame::test::test_encode_git_large ... ok
test wire::frame::test::test_stream_id ... ok
test wire::message::tests::prop_message_decoder ... ok
test wire::message::tests::prop_roundtrip_address ... ok
test wire::message::tests::prop_roundtrip_message ... ok
test wire::message::tests::prop_zero_bytes_encode_decode ... ok
test wire::message::tests::test_inv_ann_max_size ... ok
test wire::message::tests::test_node_ann_max_size ... ok
test wire::message::tests::test_ping_encode_size_overflow - should panic ... ok
test wire::message::tests::test_pingpong_encode_max_size ... ok
test wire::message::tests::test_pong_encode_size_overflow - should panic ... ok
test service::message::tests::test_node_announcement_validate ... ok
test wire::tests::prop_oid ... ok
test wire::tests::prop_roundtrip_filter ... ok
test wire::tests::prop_roundtrip_publickey ... ok
test wire::message::tests::test_refs_ann_max_size ... ok
test wire::tests::prop_roundtrip_repoid ... ok
test wire::tests::prop_roundtrip_refs ... ok
test wire::tests::prop_roundtrip_tuple ... ok
test wire::tests::prop_roundtrip_u16 ... ok
test wire::tests::prop_roundtrip_u32 ... ok
test wire::tests::prop_roundtrip_u64 ... ok
test wire::tests::prop_roundtrip_vec ... ok
test wire::tests::prop_signature ... ok
test wire::tests::prop_string ... ok
test wire::tests::test_alias ... ok
test wire::tests::test_bounded_vec_limit ... ok
test wire::tests::test_filter_invalid ... ok
test wire::tests::test_string ... ok
test wire::varint::test::prop_roundtrip_varint ... ok
test wire::varint::test::test_encode_overflow - should panic ... ok
test wire::varint::test::test_encoding ... ok
test wire::tests::prop_roundtrip_signed_refs ... ok
test fetcher::test::queue::properties::capacity::restored_after_dequeue ... ok
test fetcher::test::queue::properties::merge::same_rid_merges_anywhere_in_queue ... ok
test result: ok. 156 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 12.08s
Running unittests src/main.rs (target/debug/deps/git_remote_rad-403bd130a4109572)
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Running unittests src/main.rs (target/debug/deps/radicle_schemars-3814598870a0c326)
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Running unittests src/lib.rs (target/debug/deps/radicle_signals-bb66f1d798396f61)
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Running unittests src/lib.rs (target/debug/deps/radicle_ssh-ced840136c32d8e4)
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Running unittests src/lib.rs (target/debug/deps/radicle_systemd-36e3b0b1253d2879)
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Running unittests src/lib.rs (target/debug/deps/radicle_term-fac874e5460320c3)
running 21 tests
test ansi::tests::colors_disabled ... ok
test cell::test::test_width ... ok
test ansi::tests::wrapping ... ok
test ansi::tests::colors_enabled ... ok
test element::test::test_spaced ... ok
test element::test::test_truncate ... ok
test element::test::test_width ... ok
test table::test::test_table ... ok
test table::test::test_table_border ... ok
test table::test::test_table_border_maximized ... ok
test table::test::test_table_border_truncated ... ok
test table::test::test_table_truncate ... ok
test table::test::test_truncate ... ok
test table::test::test_table_unicode ... ok
test table::test::test_table_unicode_truncate ... ok
test textarea::test::test_wrapping ... ok
test textarea::test::test_wrapping_code_block ... ok
test textarea::test::test_wrapping_fenced_block ... ok
test vstack::test::test_vstack ... ok
test vstack::test::test_vstack_maximize ... ok
test textarea::test::test_wrapping_paragraphs ... ok
test result: ok. 21 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Doc-tests radicle
running 1 test
test crates/radicle/src/cob/patch/encoding/review.rs - cob::patch::encoding::review::Review (line 23) ... ignored
test result: ok. 0 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 0.00s
Doc-tests radicle_cli
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Doc-tests radicle_cli_test
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Doc-tests radicle_cob
running 1 test
test crates/radicle-cob/src/backend/stable.rs - backend::stable::with_advanced_timestamp (line 56) ... ignored
test result: ok. 0 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 0.00s
Doc-tests radicle_core
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Doc-tests radicle_crypto
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Doc-tests radicle_dag
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Doc-tests radicle_fetch
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Doc-tests radicle_git_metadata
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Doc-tests radicle_git_ref_format
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Doc-tests radicle_localtime
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Doc-tests radicle_node
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Doc-tests radicle_oid
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Doc-tests radicle_protocol
running 6 tests
test crates/radicle-protocol/src/bounded.rs - bounded::BoundedVec<T,N>::push (line 122) ... ok
test crates/radicle-protocol/src/bounded.rs - bounded::BoundedVec<T,N>::truncate (line 50) ... ok
test crates/radicle-protocol/src/bounded.rs - bounded::BoundedVec<T,N>::max (line 96) ... ok
test crates/radicle-protocol/src/bounded.rs - bounded::BoundedVec<T,N>::collect_from (line 30) ... ok
test crates/radicle-protocol/src/bounded.rs - bounded::BoundedVec<T,N>::unbound (line 149) ... ok
test crates/radicle-protocol/src/bounded.rs - bounded::BoundedVec<T,N>::with_capacity (line 66) ... ok
test result: ok. 6 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.33s
Doc-tests radicle_signals
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Doc-tests radicle_ssh
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Doc-tests radicle_systemd
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Doc-tests radicle_term
running 1 test
test crates/radicle-term/src/table.rs - table (line 4) ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.15s
error: 1 target failed:
`-p radicle-cli --test commands`
Exit code: 101
{
"response": "finished",
"result": "failure"
}