rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5 heartwood7561c869f130b5353c77ff2f2fc4e3b5d021914b
{
"request": "trigger",
"version": 1,
"event_type": "patch",
"repository": {
"id": "rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5",
"name": "heartwood",
"description": "Radicle Heartwood Protocol & Stack",
"private": false,
"default_branch": "master",
"delegates": [
"did:key:z6MksFqXN3Yhqk8pTJdUGLwATkRfQvwZXPqR2qMEhbS9wzpT",
"did:key:z6MktaNvN1KVFMkSRAiN4qK5yvX1zuEEaseeX5sffhzPZRZW",
"did:key:z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM",
"did:key:z6MkgFq6z5fkF2hioLLSNu1zP2qEL1aHXHZzGH1FLFGAnBGz",
"did:key:z6MkkPvBfjP4bQmco5Dm7UGsX2ruDBieEHi8n9DVJWX5sTEz"
]
},
"action": "Created",
"patch": {
"id": "94a133747c2d74311db7df55b485e4c1a6fd23e1",
"author": {
"id": "did:key:z6Mkpszihfmm6ddC14wHK7ZwJGCujcpsA4P7Y7eZFzmrnsaA",
"alias": "n4ch7@4m0n5u1"
},
"title": "feat(config): add config option node.externalAddressFiles",
"state": {
"status": "open",
"conflicts": []
},
"before": "54fd8c40a0b64e061d0ec4f32b9471b36ec11ee0",
"after": "7561c869f130b5353c77ff2f2fc4e3b5d021914b",
"commits": [
"7561c869f130b5353c77ff2f2fc4e3b5d021914b"
],
"target": "54fd8c40a0b64e061d0ec4f32b9471b36ec11ee0",
"labels": [],
"assignees": [],
"revisions": [
{
"id": "94a133747c2d74311db7df55b485e4c1a6fd23e1",
"author": {
"id": "did:key:z6Mkpszihfmm6ddC14wHK7ZwJGCujcpsA4P7Y7eZFzmrnsaA",
"alias": "n4ch7@4m0n5u1"
},
"description": "with externalAddressFile you can configure the external address or\nparts of it through a file(s) instead of putting the host/port into\nthe config file.\nMotivation:\n this makes it easier for users to:\n - hide their host from their config\n - reuse their config\n - configure their externalAddress via an external program\nExample:\n```json\n \"externalAddressesFiles\": [\n {\n \"type\": \"split\",\n \"host\": {\n \"file\": \"/var/lib/tor/onion/radicle/host\"\n },\n \"port\": {\n \"string\": \"42069\"\n }\n },\n {\n \"type\": \"full\",\n \"file\": \"/run/secrets/ext_full_host\"\n }\n ]\n```\nfor more see:\nhttps://radicle.zulipchat.com/#narrow/channel/383670-patches/topic/read.20externalAddresses.20from.20external.20file.20instead.20of.20config/with/532591796",
"base": "54fd8c40a0b64e061d0ec4f32b9471b36ec11ee0",
"oid": "7561c869f130b5353c77ff2f2fc4e3b5d021914b",
"timestamp": 1754293384
}
]
}
}
{
"response": "triggered",
"run_id": {
"id": "45c2f302-aee4-4006-9ce9-501190c2dac6"
},
"info_url": "https://cci.rad.levitte.org//45c2f302-aee4-4006-9ce9-501190c2dac6.html"
}
Started at: 2025-08-04 09:43:28.045372+02:00
Commands:
$ rad clone rad:z3gqcJUoA1n9HaHKufZs5FCSGazv5 .
✓ Creating checkout in ./...
✓ Remote cloudhead@z6MksFqXN3Yhqk8pTJdUGLwATkRfQvwZXPqR2qMEhbS9wzpT added
✓ Remote-tracking branch cloudhead@z6MksFqXN3Yhqk8pTJdUGLwATkRfQvwZXPqR2qMEhbS9wzpT/master created for z6MksFq…bS9wzpT
✓ Remote cloudhead@z6MktaNvN1KVFMkSRAiN4qK5yvX1zuEEaseeX5sffhzPZRZW added
✓ Remote-tracking branch cloudhead@z6MktaNvN1KVFMkSRAiN4qK5yvX1zuEEaseeX5sffhzPZRZW/master created for z6MktaN…hzPZRZW
✓ Remote fintohaps@z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM added
✓ Remote-tracking branch fintohaps@z6MkireRatUThvd3qzfKht1S44wpm4FEWSSa4PRMTSQZ3voM/master created for z6Mkire…SQZ3voM
✓ Remote erikli@z6MkgFq6z5fkF2hioLLSNu1zP2qEL1aHXHZzGH1FLFGAnBGz added
✓ Remote-tracking branch erikli@z6MkgFq6z5fkF2hioLLSNu1zP2qEL1aHXHZzGH1FLFGAnBGz/master created for z6MkgFq…FGAnBGz
✓ Remote lorenz@z6MkkPvBfjP4bQmco5Dm7UGsX2ruDBieEHi8n9DVJWX5sTEz added
✓ Remote-tracking branch lorenz@z6MkkPvBfjP4bQmco5Dm7UGsX2ruDBieEHi8n9DVJWX5sTEz/master created for z6MkkPv…WX5sTEz
✓ Repository successfully cloned under /opt/radcis/ci.rad.levitte.org/cci/state/45c2f302-aee4-4006-9ce9-501190c2dac6/w/
╭────────────────────────────────────╮
│ heartwood │
│ Radicle Heartwood Protocol & Stack │
│ 112 issues · 10 patches │
╰────────────────────────────────────╯
Run `cd ./.` to go to the repository directory.
Exit code: 0
$ rad patch checkout 94a133747c2d74311db7df55b485e4c1a6fd23e1
✓ Switched to branch patch/94a1337 at revision 94a1337
✓ Branch patch/94a1337 setup to track rad/patches/94a133747c2d74311db7df55b485e4c1a6fd23e1
Exit code: 0
$ git config advice.detachedHead false
Exit code: 0
$ git checkout 7561c869f130b5353c77ff2f2fc4e3b5d021914b
HEAD is now at 7561c869 feat(config): add config option node.externalAddressFiles with externalAddressFile you can configure the external address or parts of it through a file(s) instead of putting the host/port into the config file. Motivation: this makes it easier for users to: - hide their host from their config - reuse their config - configure their externalAddress via an external program Example: "externalAddressesFiles": [ { "type": "split", "host": { "file": "/var/lib/tor/onion/radicle/host" }, "port": { "string": "42069" } }, { "type": "full", "file": "/run/secrets/ext_full_host" } ] for more see: https://radicle.zulipchat.com/#narrow/channel/383670-patches/topic/read.20externalAddresses.20from.20external.20file.20instead.20of.20config/with/532591796
Exit code: 0
$ git show 7561c869f130b5353c77ff2f2fc4e3b5d021914b
commit 7561c869f130b5353c77ff2f2fc4e3b5d021914b
Author: N4CH723HR3R <n4ch7@4m0n5u1>
Date: Mon Aug 4 09:37:03 2025 +0200
feat(config): add config option node.externalAddressFiles
with externalAddressFile you can configure the external address or
parts of it through a file(s) instead of putting the host/port into
the config file.
Motivation:
this makes it easier for users to:
- hide their host from their config
- reuse their config
- configure their externalAddress via an external program
Example:
"externalAddressesFiles": [
{
"type": "split",
"host": {
"file": "/var/lib/tor/onion/radicle/host"
},
"port": {
"string": "42069"
}
},
{
"type": "full",
"file": "/run/secrets/ext_full_host"
}
]
for more see:
https://radicle.zulipchat.com/#narrow/channel/383670-patches/topic/read.20externalAddresses.20from.20external.20file.20instead.20of.20config/with/532591796
diff --git a/crates/radicle-cli/src/commands/node.rs b/crates/radicle-cli/src/commands/node.rs
index db1be3fe..86dd0733 100644
--- a/crates/radicle-cli/src/commands/node.rs
+++ b/crates/radicle-cli/src/commands/node.rs
@@ -295,7 +295,7 @@ pub fn run(options: Options, ctx: impl term::Context) -> anyhow::Result<()> {
Operation::Config { addresses } => {
if addresses {
let cfg = node.config()?;
- for addr in cfg.external_addresses {
+ for addr in cfg.get_external_addresses() {
term::print(ConnectAddress::from((*profile.id(), addr)).to_string());
}
} else {
diff --git a/crates/radicle-cli/tests/util/environment.rs b/crates/radicle-cli/tests/util/environment.rs
index dfa91148..b700c90e 100644
--- a/crates/radicle-cli/tests/util/environment.rs
+++ b/crates/radicle-cli/tests/util/environment.rs
@@ -161,7 +161,7 @@ impl Environment {
&alias,
&UserAgent::default(),
LocalTime::now().into(),
- config.node.external_addresses.iter(),
+ config.node.get_external_addresses().iter(),
)
.unwrap();
diff --git a/crates/radicle-node/src/runtime.rs b/crates/radicle-node/src/runtime.rs
index 86954152..9893af46 100644
--- a/crates/radicle-node/src/runtime.rs
+++ b/crates/radicle-node/src/runtime.rs
@@ -176,7 +176,7 @@ impl Runtime {
.and_then(|ann| {
if config.features() == ann.features
&& config.alias == ann.alias
- && config.external_addresses == ann.addresses.as_ref()
+ && config.get_external_addresses() == ann.addresses.as_ref()
{
Some(ann)
} else {
diff --git a/crates/radicle-node/src/test/environment.rs b/crates/radicle-node/src/test/environment.rs
index edf98c13..4e147dcb 100644
--- a/crates/radicle-node/src/test/environment.rs
+++ b/crates/radicle-node/src/test/environment.rs
@@ -137,7 +137,7 @@ impl Environment {
&Alias::new(alias),
&UserAgent::default(),
now.into(),
- config.node.external_addresses.iter(),
+ config.node.get_external_addresses().iter(),
)
.unwrap();
diff --git a/crates/radicle-node/src/test/peer.rs b/crates/radicle-node/src/test/peer.rs
index 59ffe1e8..f30a175e 100644
--- a/crates/radicle-node/src/test/peer.rs
+++ b/crates/radicle-node/src/test/peer.rs
@@ -168,7 +168,10 @@ where
let inventory = storage.repositories().unwrap();
// Make sure the peer address is advertized.
- config.config.external_addresses.push(local_addr.into());
+ config
+ .config
+ .get_external_addresses()
+ .push(local_addr.into());
for repo in &inventory {
policies.seed(&repo.rid, Scope::Followed).unwrap();
}
@@ -181,7 +184,7 @@ where
&config.config.alias,
&UserAgent::default(),
config.local_time.into(),
- config.config.external_addresses.iter(),
+ config.config.get_external_addresses().iter(),
)
.unwrap()
.into();
diff --git a/crates/radicle-protocol/src/service.rs b/crates/radicle-protocol/src/service.rs
index 8901a011..54cd8cb6 100644
--- a/crates/radicle-protocol/src/service.rs
+++ b/crates/radicle-protocol/src/service.rs
@@ -2476,7 +2476,12 @@ where
.filter(|entry| !entry.address.banned)
.filter(|entry| !entry.penalty.is_connect_threshold_reached())
.filter(|entry| !self.sessions.contains_key(&entry.node))
- .filter(|entry| !self.config.external_addresses.contains(&entry.address.addr))
+ .filter(|entry| {
+ !self
+ .config
+ .get_external_addresses()
+ .contains(&entry.address.addr)
+ })
.filter(|entry| &entry.node != self.nid())
.fold(HashMap::new(), |mut acc, entry| {
acc.entry(entry.node)
diff --git a/crates/radicle-protocol/src/service/gossip.rs b/crates/radicle-protocol/src/service/gossip.rs
index 0d04c80f..f9c72bc0 100644
--- a/crates/radicle-protocol/src/service/gossip.rs
+++ b/crates/radicle-protocol/src/service/gossip.rs
@@ -20,7 +20,7 @@ pub fn node(config: &Config, timestamp: Timestamp) -> NodeAnnouncement {
let features = config.features();
let alias = config.alias.clone();
let addresses: BoundedVec<_, ADDRESS_LIMIT> = config
- .external_addresses
+ .get_external_addresses()
.clone()
.try_into()
.expect("external addresses are within the limit");
diff --git a/crates/radicle/src/node/config.rs b/crates/radicle/src/node/config.rs
index 164591dd..bfdf5fab 100644
--- a/crates/radicle/src/node/config.rs
+++ b/crates/radicle/src/node/config.rs
@@ -1,7 +1,7 @@
use std::collections::HashSet;
use std::ops::Deref;
use std::str::FromStr;
-use std::{fmt, net};
+use std::{fmt, fs, net};
use cyphernet::addr::PeerAddr;
use localtime::LocalDuration;
@@ -371,6 +371,70 @@ pub enum Relay {
Auto,
}
+/// The actual FilePath (maybe use some std struct instead)
+#[derive(Clone, Eq, PartialEq, Debug, Hash, Serialize, Deserialize)]
+#[serde(rename_all = "camelCase")]
+#[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))]
+pub struct FilePath(String);
+impl FilePath {
+ // maybe implement caching if needed
+ // NOTE: permission changes might CRASH radicle-node
+ fn get(&self) -> String {
+ fs::read_to_string(&self.0)
+ .expect(format!("Couldnt read from file: {}", &self.0).as_str())
+ .trim()
+ .to_string()
+ }
+}
+
+/// Part of a address. Either a file path or a string
+/// this allows the user to point to /var/lib/tor for the hostname only for example
+#[derive(Clone, Eq, PartialEq, Debug, Hash, From, Serialize, Deserialize)]
+#[serde(rename_all = "camelCase")]
+#[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))]
+pub enum AddressFilePart {
+ File(FilePath),
+ String(String),
+}
+
+/// encapsulate differences between path and string into a function, encouraging DRY & least knowledge
+impl ToString for AddressFilePart {
+ fn to_string(&self) -> String {
+ match self {
+ AddressFilePart::File(file_path) => file_path.get(),
+ AddressFilePart::String(string) => string.clone(),
+ }
+ }
+}
+
+/// The external Address from a file or multiple files
+#[derive(Clone, Eq, PartialEq, Debug, Hash, From, Serialize, Deserialize)]
+#[serde(rename_all = "camelCase", tag = "type")]
+#[cfg_attr(
+ feature = "schemars",
+ derive(schemars::JsonSchema),
+ schemars(description = "An file path in which the address is stored.")
+)]
+pub enum AddressFile {
+ /// read the entire host from one file
+ Full(AddressFilePart),
+ /// split host and port
+ Split {
+ host: AddressFilePart,
+ port: AddressFilePart,
+ },
+}
+
+/// encapsulate Full or Split files into a common $host:$port string
+impl ToString for AddressFile {
+ fn to_string(&self) -> String {
+ match self {
+ AddressFile::Full(path) => path.to_string(),
+ AddressFile::Split { host, port } => host.to_string() + ":" + port.to_string().as_str(),
+ }
+ }
+}
+
/// Proxy configuration.
#[derive(Debug, Clone, Serialize, Deserialize)]
#[serde(rename_all = "camelCase", tag = "mode")]
@@ -448,6 +512,9 @@ pub struct Config {
/// Specify the node's public addresses
#[serde(default)]
pub external_addresses: Vec<Address>,
+ /// Specify the node's public addresses which should not be in the config file
+ #[serde(default, skip_serializing_if = "Option::is_none")]
+ pub external_addresses_files: Option<Vec<AddressFile>>,
/// Global proxy.
#[serde(default, skip_serializing_if = "Option::is_none")]
pub proxy: Option<net::SocketAddr>,
@@ -497,6 +564,7 @@ impl Config {
listen: vec![],
connect: HashSet::default(),
external_addresses: vec![],
+ external_addresses_files: None,
network: Network::default(),
proxy: None,
onion: None,
@@ -529,7 +597,7 @@ impl Config {
match self.relay {
// In "auto" mode, we only relay if we're a public seed node.
// This reduces traffic for private nodes, as well as message redundancy.
- Relay::Auto => !self.external_addresses.is_empty(),
+ Relay::Auto => !self.get_external_addresses().is_empty(),
Relay::Never => false,
Relay::Always => true,
}
@@ -538,6 +606,19 @@ impl Config {
pub fn features(&self) -> node::Features {
node::Features::SEED
}
+
+ pub fn get_external_addresses(&self) -> Vec<Address> {
+ let mut out: Vec<Address> = self.external_addresses.clone();
+ for i in &self.external_addresses_files.clone().unwrap_or(Vec::new()) {
+ let addr = i.to_string();
+ let addr_str = addr.as_str();
+ out.push(
+ Address::from_str(&addr_str)
+ .expect(format!("Invalid Address: {}", &addr_str).as_str()),
+ );
+ }
+ return out;
+ }
}
/// Defaults as functions, for serde.
diff --git a/crates/radicle/src/profile.rs b/crates/radicle/src/profile.rs
index 7236399b..3348f7d2 100644
--- a/crates/radicle/src/profile.rs
+++ b/crates/radicle/src/profile.rs
@@ -231,7 +231,7 @@ impl Profile {
&config.node.alias,
&UserAgent::default(),
LocalTime::now().into(),
- config.node.external_addresses.iter(),
+ config.node.get_external_addresses().iter(),
)?;
// Migrate COBs cache.
Exit code: 0
shell: 'cargo --version rustc --version cargo fmt --check cargo clippy --all-targets --workspace -- --deny warnings cargo build --all-targets --workspace cargo doc --workspace --no-deps cargo test --workspace --no-fail-fast '
Commands:
$ podman run --name 45c2f302-aee4-4006-9ce9-501190c2dac6 -v /opt/radcis/ci.rad.levitte.org/cci/state/45c2f302-aee4-4006-9ce9-501190c2dac6/s:/45c2f302-aee4-4006-9ce9-501190c2dac6/s:ro -v /opt/radcis/ci.rad.levitte.org/cci/state/45c2f302-aee4-4006-9ce9-501190c2dac6/w:/45c2f302-aee4-4006-9ce9-501190c2dac6/w -w /45c2f302-aee4-4006-9ce9-501190c2dac6/w -v /opt/radcis/ci.rad.levitte.org/.radicle:/${id}/.radicle:ro -e RAD_HOME=/${id}/.radicle rust:bookworm bash /45c2f302-aee4-4006-9ce9-501190c2dac6/s/script.sh
+ cargo --version
info: syncing channel updates for '1.88-x86_64-unknown-linux-gnu'
info: latest update on 2025-06-26, rust version 1.88.0 (6b00bc388 2025-06-23)
info: downloading component 'cargo'
info: downloading component 'clippy'
info: downloading component 'rust-docs'
info: downloading component 'rust-src'
info: downloading component 'rust-std'
info: downloading component 'rustc'
info: downloading component 'rustfmt'
info: installing component 'cargo'
info: installing component 'clippy'
info: installing component 'rust-docs'
info: installing component 'rust-src'
info: installing component 'rust-std'
info: installing component 'rustc'
info: installing component 'rustfmt'
cargo 1.88.0 (873a06493 2025-05-10)
+ rustc --version
rustc 1.88.0 (6b00bc388 2025-06-23)
+ cargo fmt --check
+ cargo clippy --all-targets --workspace -- --deny warnings
Updating crates.io index
Downloading crates ...
Downloaded document-features v0.2.11
Downloaded derive_more v2.0.1
Downloaded fxhash v0.2.1
Downloaded aead v0.5.2
Downloaded percent-encoding v2.3.1
Downloaded parking_lot v0.12.3
Downloaded git-ref-format v0.3.1
Downloaded p521 v0.13.3
Downloaded parking_lot_core v0.9.9
Downloaded p384 v0.13.0
Downloaded bytecount v0.6.8
Downloaded p256 v0.13.2
Downloaded elliptic-curve v0.13.8
Downloaded equivalent v1.0.1
Downloaded base64 v0.22.1
Downloaded fluent-uri v0.3.2
Downloaded unicode-normalization v0.1.23
Downloaded generic-array v0.14.7
Downloaded rsa v0.9.6
Downloaded scrypt v0.11.0
Downloaded ppv-lite86 v0.2.17
Downloaded phf_shared v0.11.3
Downloaded derive_more-impl v2.0.1
Downloaded icu_properties v1.5.1
Downloaded inout v0.1.3
Downloaded faster-hex v0.9.0
Downloaded radicle-git-ext v0.8.1
Downloaded form_urlencoded v1.2.1
Downloaded ref-cast-impl v1.0.24
Downloaded ff v0.13.0
Downloaded gix-commitgraph v0.25.1
Downloaded ryu v1.0.17
Downloaded siphasher v0.3.11
Downloaded shell-words v1.1.0
Downloaded sha1_smol v1.0.0
Downloaded digest v0.10.7
Downloaded shlex v1.3.0
Downloaded fraction v0.15.3
Downloaded serde_derive_internals v0.29.1
Downloaded jobserver v0.1.31
Downloaded emojis v0.6.4
Downloaded inquire v0.7.5
Downloaded multibase v0.9.1
Downloaded radicle-std-ext v0.1.0
Downloaded sem_safe v0.2.0
Downloaded ref-cast v1.0.24
Downloaded tree-sitter-typescript v0.23.2
Downloaded tinyvec_macros v0.1.1
Downloaded gix-hashtable v0.6.0
Downloaded prodash v29.0.2
Downloaded yoke-derive v0.7.5
Downloaded gix-revwalk v0.17.0
Downloaded gix-odb v0.66.0
Downloaded num-iter v0.1.45
Downloaded opaque-debug v0.3.1
Downloaded localtime v1.3.1
Downloaded normalize-line-endings v0.3.0
Downloaded tree-sitter-language v0.1.2
Downloaded icu_provider_macros v1.5.0
Downloaded siphasher v1.0.1
Downloaded tinystr v0.7.6
Downloaded nonempty v0.5.0
Downloaded num-complex v0.4.6
Downloaded thiserror v2.0.12
Downloaded gix-date v0.9.4
Downloaded gix-revision v0.31.1
Downloaded noise-framework v0.4.0
Downloaded gix-hash v0.15.1
Downloaded gix-refspec v0.27.0
Downloaded gix-credentials v0.26.0
Downloaded group v0.13.0
Downloaded io-reactor v0.5.2
Downloaded uuid-simd v0.8.0
Downloaded iana-time-zone v0.1.60
Downloaded memmap2 v0.9.4
Downloaded smallvec v1.13.2
Downloaded lexopt v0.3.0
Downloaded gix-transport v0.44.0
Downloaded unicode-segmentation v1.11.0
Downloaded idna_adapter v1.2.0
Downloaded gix-fs v0.12.1
Downloaded num-bigint v0.4.6
Downloaded indexmap v2.2.6
Downloaded utf8parse v0.2.1
Downloaded yansi v0.5.1
Downloaded memchr v2.7.2
Downloaded mio v0.8.11
Downloaded tree-sitter v0.24.4
Downloaded yoke v0.7.5
Downloaded hashbrown v0.14.3
Downloaded tree-sitter-python v0.23.4
Downloaded uuid v1.16.0
Downloaded icu_properties_data v1.5.1
Downloaded miniz_oxide v0.8.8
Downloaded icu_collections v1.5.0
Downloaded vcpkg v0.2.15
Downloaded ssh-key v0.6.6
Downloaded jsonschema v0.30.0
Downloaded tree-sitter-md v0.3.2
Downloaded idna v1.0.3
Downloaded radicle-surf v0.22.0
Downloaded tree-sitter-bash v0.23.3
Downloaded winnow v0.6.26
Downloaded git2 v0.19.0
Downloaded syn v2.0.89
Downloaded syn v1.0.109
Downloaded libc v0.2.174
Downloaded tree-sitter-ruby v0.23.1
Downloaded rustix v1.0.7
Downloaded rustix v0.38.34
Downloaded regex v1.11.1
Downloaded tree-sitter-rust v0.23.2
Downloaded tree-sitter-go v0.23.4
Downloaded schemars v1.0.4
Downloaded url v2.5.4
Downloaded regex-automata v0.4.9
Downloaded tree-sitter-css v0.23.1
Downloaded gix-ref v0.49.1
Downloaded serde_json v1.0.140
Downloaded litrs v0.4.1
Downloaded tree-sitter-c v0.23.2
Downloaded signal-hook v0.3.18
Downloaded sha3 v0.10.8
Downloaded utf8_iter v1.0.4
Downloaded gix-features v0.39.1
Downloaded zerocopy v0.7.35
Downloaded num-traits v0.2.19
Downloaded jiff v0.2.1
Downloaded rand v0.8.5
Downloaded mio v1.0.4
Downloaded once_cell v1.21.3
Downloaded num-bigint-dig v0.8.4
Downloaded socket2 v0.5.7
Downloaded tinyvec v1.6.0
Downloaded similar v2.5.0
Downloaded signals_receipts v0.2.0
Downloaded xattr v1.3.1
Downloaded version_check v0.9.4
Downloaded tree-sitter-toml-ng v0.6.0
Downloaded num-rational v0.4.2
Downloaded lock_api v0.4.11
Downloaded zerovec v0.10.4
Downloaded netservices v0.8.0
Downloaded tar v0.4.40
Downloaded utf16_iter v1.0.5
Downloaded icu_provider v1.5.0
Downloaded hmac v0.12.1
Downloaded gix-diff v0.49.0
Downloaded linux-raw-sys v0.4.13
Downloaded typenum v1.17.0
Downloaded gix-protocol v0.47.0
Downloaded gix-pack v0.56.0
Downloaded serde_derive v1.0.219
Downloaded walkdir v2.5.0
Downloaded sha2 v0.10.8
Downloaded libgit2-sys v0.17.0+1.8.1
Downloaded sqlite3-src v0.5.1
Downloaded gix-traverse v0.43.1
Downloaded gix-trace v0.1.12
Downloaded spin v0.9.8
Downloaded gix-object v0.46.1
Downloaded gix-negotiate v0.17.0
Downloaded referencing v0.30.0
Downloaded gix-path v0.10.15
Downloaded icu_normalizer v1.5.0
Downloaded icu_locid_transform_data v1.5.1
Downloaded lazy_static v1.5.0
Downloaded gix-utils v0.1.14
Downloaded gix-url v0.28.2
Downloaded num-cmp v0.1.0
Downloaded vsimd v0.8.0
Downloaded gix-validate v0.9.4
Downloaded tree-sitter-json v0.24.8
Downloaded nonempty v0.9.0
Downloaded home v0.5.9
Downloaded gix-config-value v0.14.12
Downloaded linux-raw-sys v0.9.4
Downloaded gix-actor v0.33.2
Downloaded unicode-display-width v0.3.0
Downloaded typeid v1.0.3
Downloaded tree-sitter-html v0.23.2
Downloaded tree-sitter-highlight v0.24.4
Downloaded keccak v0.1.5
Downloaded itoa v1.0.11
Downloaded gix-quote v0.4.15
Downloaded gix-prompt v0.9.1
Downloaded gix-lock v15.0.1
Downloaded gix-command v0.4.1
Downloaded gix-chunk v0.4.11
Downloaded outref v0.5.2
Downloaded synstructure v0.13.1
Downloaded streaming-iterator v0.1.9
Downloaded snapbox v0.4.17
Downloaded proc-macro2 v1.0.92
Downloaded schemars_derive v1.0.4
Downloaded icu_normalizer_data v1.5.1
Downloaded icu_locid v1.5.0
Downloaded stable_deref_trait v1.2.0
Downloaded sqlite v0.32.0
Downloaded signal-hook-registry v1.4.5
Downloaded signal-hook-mio v0.2.4
Downloaded git-ref-format-macro v0.3.1
Downloaded thiserror-impl v1.0.69
Downloaded thiserror-impl v2.0.12
Downloaded num-integer v0.1.46
Downloaded num v0.4.3
Downloaded litemap v0.7.5
Downloaded icu_locid_transform v1.5.0
Downloaded universal-hash v0.5.1
Downloaded signature v2.2.0
Downloaded thiserror v1.0.69
Downloaded gix-tempfile v15.0.0
Downloaded gix-shallow v0.1.0
Downloaded gix-sec v0.10.12
Downloaded gix-packetline v0.18.4
Downloaded newline-converter v0.3.0
Downloaded git-ref-format-core v0.3.1
Downloaded zerovec-derive v0.10.3
Downloaded zeroize v1.7.0
Downloaded zerofrom-derive v0.1.6
Downloaded zerofrom v0.1.6
Downloaded writeable v0.5.5
Downloaded write16 v1.0.0
Downloaded unicode-width v0.1.11
Downloaded libz-sys v1.1.16
Downloaded unicode-ident v1.0.12
Downloaded libm v0.2.8
Downloaded qcheck-macros v1.0.0
Downloaded pretty_assertions v1.4.0
Downloaded polyval v0.6.2
Downloaded timeago v0.4.2
Downloaded tempfile v3.10.1
Downloaded ssh-encoding v0.2.0
Downloaded ssh-cipher v0.2.0
Downloaded sqlite3-sys v0.15.2
Downloaded spki v0.7.3
Downloaded signature v1.6.4
Downloaded scopeguard v1.2.0
Downloaded salsa20 v0.10.2
Downloaded subtle v2.5.0
Downloaded sec1 v0.7.3
Downloaded same-file v1.0.6
Downloaded qcheck v1.0.0
Downloaded rand_chacha v0.3.1
Downloaded proc-macro-error v1.0.4
Downloaded maybe-async v0.2.10
Downloaded snapbox-macros v0.3.8
Downloaded log v0.4.27
Downloaded regex-syntax v0.8.5
Downloaded flate2 v1.1.1
Downloaded bstr v1.9.1
Downloaded socks5-client v0.4.1
Downloaded cypheraddr v0.4.0
Downloaded cyphergraphy v0.3.0
Downloaded primeorder v0.13.6
Downloaded either v1.11.0
Downloaded ecdsa v0.16.9
Downloaded colored v2.1.0
Downloaded ascii v1.1.0
Downloaded arc-swap v1.7.1
Downloaded anstyle v1.0.6
Downloaded serde-untagged v0.1.7
Downloaded getrandom v0.2.15
Downloaded displaydoc v0.2.5
Downloaded bitflags v2.9.1
Downloaded amplify_syn v2.0.1
Downloaded filetime v0.2.23
Downloaded der v0.7.9
Downloaded quote v1.0.36
Downloaded pem-rfc7468 v0.7.0
Downloaded convert_case v0.7.1
Downloaded anstyle-parse v0.2.3
Downloaded data-encoding-macro v0.1.14
Downloaded crypto-bigint v0.5.5
Downloaded autocfg v1.2.0
Downloaded amplify_derive v4.0.0
Downloaded cyphernet v0.5.2
Downloaded crossterm v0.25.0
Downloaded cfg-if v1.0.0
Downloaded fancy-regex v0.14.0
Downloaded data-encoding v2.5.0
Downloaded escargot v0.5.10
Downloaded ec25519 v0.1.0
Downloaded ct-codecs v1.1.1
Downloaded borrow-or-share v0.2.2
Downloaded poly1305 v0.8.0
Downloaded errno v0.3.13
Downloaded email_address v0.2.9
Downloaded crossbeam-channel v0.5.15
Downloaded chacha20poly1305 v0.10.1
Downloaded dyn-clone v1.0.17
Downloaded crc32fast v1.4.0
Downloaded proc-macro-error-attr v1.0.4
Downloaded pbkdf2 v0.12.2
Downloaded cipher v0.4.4
Downloaded block-padding v0.3.3
Downloaded block-buffer v0.10.4
Downloaded serde v1.0.219
Downloaded rfc6979 v0.4.0
Downloaded ghash v0.5.1
Downloaded crossterm v0.29.0
Downloaded const-oid v0.9.6
Downloaded colorchoice v1.0.0
Downloaded blowfish v0.9.1
Downloaded chrono v0.4.38
Downloaded base16ct v0.2.0
Downloaded anyhow v1.0.82
Downloaded popol v3.0.0
Downloaded pkg-config v0.3.30
Downloaded pkcs1 v0.7.5
Downloaded fastrand v2.1.0
Downloaded data-encoding-macro-internal v0.1.12
Downloaded ctr v0.9.2
Downloaded crossbeam-utils v0.8.19
Downloaded chacha20 v0.9.1
Downloaded base-x v0.2.11
Downloaded rand_core v0.6.4
Downloaded phf v0.11.3
Downloaded erased-serde v0.4.6
Downloaded ed25519 v1.5.3
Downloaded diff v0.1.13
Downloaded cc v1.2.2
Downloaded byteorder v1.5.0
Downloaded base64 v0.21.7
Downloaded amplify v4.6.0
Downloaded pkcs8 v0.10.2
Downloaded cbc v0.1.2
Downloaded base32 v0.4.0
Downloaded aho-corasick v1.1.3
Downloaded fast-glob v0.3.3
Downloaded bytesize v2.0.1
Downloaded crypto-common v0.1.6
Downloaded bitflags v1.3.2
Downloaded bit-vec v0.8.0
Downloaded anstream v0.6.13
Downloaded amplify_num v0.5.2
Downloaded base64 v0.13.1
Downloaded cpufeatures v0.2.12
Downloaded bytes v1.10.1
Downloaded bloomy v1.2.0
Downloaded bcrypt-pbkdf v0.10.0
Downloaded base64ct v1.6.0
Downloaded ahash v0.8.11
Downloaded aes-gcm v0.10.3
Downloaded adler2 v2.0.0
Downloaded bit-set v0.8.0
Downloaded aes v0.8.4
Downloaded anstyle-query v1.0.2
Compiling libc v0.2.174
Compiling proc-macro2 v1.0.92
Compiling unicode-ident v1.0.12
Checking cfg-if v1.0.0
Compiling shlex v1.3.0
Compiling version_check v0.9.4
Compiling serde v1.0.219
Checking memchr v2.7.2
Compiling quote v1.0.36
Compiling syn v2.0.89
Compiling autocfg v1.2.0
Checking getrandom v0.2.15
Compiling jobserver v0.1.31
Checking smallvec v1.13.2
Checking aho-corasick v1.1.3
Checking regex-syntax v0.8.5
Compiling cc v1.2.2
Compiling typenum v1.17.0
Compiling generic-array v0.14.7
Checking regex-automata v0.4.9
Checking rand_core v0.6.4
Checking log v0.4.27
Checking crypto-common v0.1.6
Checking fastrand v2.1.0
Compiling lock_api v0.4.11
Compiling parking_lot_core v0.9.9
Compiling synstructure v0.13.1
Checking bitflags v2.9.1
Checking scopeguard v1.2.0
Checking bstr v1.9.1
Checking subtle v2.5.0
Checking stable_deref_trait v1.2.0
Checking parking_lot v0.12.3
Checking once_cell v1.21.3
Checking tinyvec_macros v0.1.1
Compiling syn v1.0.109
Checking tinyvec v1.6.0
Checking zeroize v1.7.0
Checking cpufeatures v0.2.12
Checking writeable v0.5.5
Compiling serde_derive v1.0.219
Compiling zerofrom-derive v0.1.6
Compiling yoke-derive v0.7.5
Compiling zerovec-derive v0.10.3
Checking zerofrom v0.1.6
Checking yoke v0.7.5
Compiling displaydoc v0.2.5
Checking zerovec v0.10.4
Checking unicode-normalization v0.1.23
Compiling thiserror v2.0.12
Checking tinystr v0.7.6
Compiling icu_locid_transform_data v1.5.1
Checking litemap v0.7.5
Compiling crc32fast v1.4.0
Checking icu_locid v1.5.0
Compiling icu_provider_macros v1.5.0
Compiling thiserror-impl v2.0.12
Checking block-padding v0.3.3
Compiling icu_properties_data v1.5.1
Checking icu_provider v1.5.0
Checking inout v0.1.3
Checking block-buffer v0.10.4
Checking itoa v1.0.11
Compiling icu_normalizer_data v1.5.1
Checking hashbrown v0.14.3
Compiling pkg-config v0.3.30
Checking digest v0.10.7
Checking cipher v0.4.4
Checking icu_locid_transform v1.5.0
Checking icu_collections v1.5.0
Checking utf8_iter v1.0.4
Checking write16 v1.0.0
Compiling thiserror v1.0.69
Checking utf16_iter v1.0.5
Compiling thiserror-impl v1.0.69
Compiling rustix v0.38.34
Checking icu_properties v1.5.1
Checking percent-encoding v2.3.1
Checking linux-raw-sys v0.4.13
Checking sha2 v0.10.8
Checking form_urlencoded v1.2.1
Checking universal-hash v0.5.1
Checking opaque-debug v0.3.1
Compiling vcpkg v0.2.15
Compiling amplify_syn v2.0.1
Checking icu_normalizer v1.5.0
Checking gix-trace v0.1.12
Compiling libz-sys v1.1.16
Checking idna_adapter v1.2.0
Checking idna v1.0.3
Compiling data-encoding v2.5.0
Compiling amplify_derive v4.0.0
Checking url v2.5.4
Compiling data-encoding-macro-internal v0.1.12
Checking tempfile v3.10.1
Checking amplify_num v0.5.2
Checking signature v1.6.4
Checking ascii v1.1.0
Checking ed25519 v1.5.3
Checking data-encoding-macro v0.1.14
Compiling libgit2-sys v0.17.0+1.8.1
Checking faster-hex v0.9.0
Checking aead v0.5.2
Compiling num-traits v0.2.19
Compiling proc-macro-error-attr v1.0.4
Checking byteorder v1.5.0
Checking ct-codecs v1.1.1
Checking base-x v0.2.11
Checking ec25519 v0.1.0
Checking amplify v4.6.0
Checking multibase v0.9.1
Checking poly1305 v0.8.0
Checking chacha20 v0.9.1
Checking gix-utils v0.1.14
Compiling proc-macro-error v1.0.4
Checking adler2 v2.0.0
Checking miniz_oxide v0.8.8
Checking cyphergraphy v0.3.0
Checking gix-hash v0.15.1
Compiling crossbeam-utils v0.8.19
Checking same-file v1.0.6
Checking keccak v0.1.5
Checking walkdir v2.5.0
Checking sha3 v0.10.8
Checking flate2 v1.1.1
Compiling git-ref-format-core v0.3.1
Checking polyval v0.6.2
Compiling sqlite3-src v0.5.1
Checking hmac v0.12.1
Checking prodash v29.0.2
Compiling serde_json v1.0.140
Checking base32 v0.4.0
Checking equivalent v1.0.1
Checking sha1_smol v1.0.0
Checking ppv-lite86 v0.2.17
Checking base64ct v1.6.0
Checking gix-features v0.39.1
Checking indexmap v2.2.6
Checking pem-rfc7468 v0.7.0
Checking rand_chacha v0.3.1
Checking cypheraddr v0.4.0
Checking pbkdf2 v0.12.2
Compiling git-ref-format-macro v0.3.1
Checking ghash v0.5.1
Checking chacha20poly1305 v0.10.1
Checking aes v0.8.4
Checking ctr v0.9.2
Checking ryu v1.0.17
Checking aes-gcm v0.10.3
Checking git-ref-format v0.3.1
Checking noise-framework v0.4.0
Checking crossbeam-channel v0.5.15
Checking socks5-client v0.4.1
Checking rand v0.8.5
Checking ssh-encoding v0.2.0
Checking blowfish v0.9.1
Checking cbc v0.1.2
Checking radicle-std-ext v0.1.0
Checking home v0.5.9
Compiling ref-cast v1.0.24
Checking gix-path v0.10.15
Checking ssh-cipher v0.2.0
Checking bcrypt-pbkdf v0.10.0
Checking cyphernet v0.5.2
Compiling ref-cast-impl v1.0.24
Checking signature v2.2.0
Checking ssh-key v0.6.6
Checking qcheck v1.0.0
Checking radicle-ssh v0.9.0 (/45c2f302-aee4-4006-9ce9-501190c2dac6/w/crates/radicle-ssh)
Checking lazy_static v1.5.0
Checking dyn-clone v1.0.17
Compiling typeid v1.0.3
Checking siphasher v1.0.1
Checking nonempty v0.9.0
Compiling serde_derive_internals v0.29.1
Checking radicle-dag v0.10.0 (/45c2f302-aee4-4006-9ce9-501190c2dac6/w/crates/radicle-dag)
Checking erased-serde v0.4.6
Checking iana-time-zone v0.1.60
Checking jiff v0.2.1
Compiling schemars_derive v1.0.4
Checking schemars v1.0.4
Checking chrono v0.4.38
Checking gix-date v0.9.4
Checking serde-untagged v0.1.7
Checking colored v2.1.0
Checking bytesize v2.0.1
Checking localtime v1.3.1
Checking winnow v0.6.26
Checking fast-glob v0.3.3
Checking tree-sitter-language v0.1.2
Checking base64 v0.21.7
Checking gix-hashtable v0.6.0
Checking gix-validate v0.9.4
Checking memmap2 v0.9.4
Compiling anyhow v1.0.82
Checking gix-actor v0.33.2
Checking gix-chunk v0.4.11
Checking anstyle-query v1.0.2
Checking gix-object v0.46.1
Checking gix-commitgraph v0.25.1
Checking gix-fs v0.12.1
Checking sem_safe v0.2.0
Checking errno v0.3.13
Checking signals_receipts v0.2.0
Checking gix-revwalk v0.17.0
Checking gix-tempfile v15.0.0
Compiling signal-hook v0.3.18
Checking signal-hook-registry v1.4.5
Checking shell-words v1.1.0
Checking gix-command v0.4.1
Checking radicle-signals v0.11.0 (/45c2f302-aee4-4006-9ce9-501190c2dac6/w/crates/radicle-signals)
Checking mio v0.8.11
Checking mio v1.0.4
Compiling tree-sitter v0.24.4
Compiling unicode-segmentation v1.11.0
Compiling convert_case v0.7.1
Checking signal-hook-mio v0.2.4
Checking gix-lock v15.0.1
Checking gix-config-value v0.14.12
Checking gix-url v0.28.2
Checking gix-quote v0.4.15
Checking regex v1.11.1
Checking gix-sec v0.10.12
Compiling rustix v1.0.7
Checking gix-prompt v0.9.1
Compiling xattr v1.3.1
Compiling derive_more-impl v2.0.1
Compiling filetime v0.2.23
Checking gix-traverse v0.43.1
Checking gix-revision v0.31.1
Checking gix-diff v0.49.0
Checking gix-packetline v0.18.4
Checking bitflags v1.3.2
Checking sqlite3-sys v0.15.2
Checking lexopt v0.3.0
Checking sqlite v0.32.0
Checking linux-raw-sys v0.9.4
Checking utf8parse v0.2.1
Compiling litrs v0.4.1
Checking anstyle-parse v0.2.3
Checking gix-transport v0.44.0
Compiling document-features v0.2.11
Checking crossterm v0.25.0
Checking gix-pack v0.56.0
Checking gix-refspec v0.27.0
Checking derive_more v2.0.1
Compiling tar v0.4.40
Checking gix-credentials v0.26.0
Checking newline-converter v0.3.0
Checking gix-ref v0.49.1
Checking gix-shallow v0.1.0
Checking gix-negotiate v0.17.0
Checking fxhash v0.2.1
Compiling maybe-async v0.2.10
Checking unicode-width v0.1.11
Checking anstyle v1.0.6
Checking arc-swap v1.7.1
Checking colorchoice v1.0.0
Checking streaming-iterator v0.1.9
Checking gix-odb v0.66.0
Checking gix-protocol v0.47.0
Checking anstream v0.6.13
Checking inquire v0.7.5
Compiling radicle-surf v0.22.0
Checking crossterm v0.29.0
Checking unicode-display-width v0.3.0
Compiling tree-sitter-bash v0.23.3
Compiling tree-sitter-go v0.23.4
Compiling tree-sitter-html v0.23.2
Compiling tree-sitter-typescript v0.23.2
Compiling tree-sitter-md v0.3.2
Compiling tree-sitter-toml-ng v0.6.0
Compiling tree-sitter-rust v0.23.2
Compiling tree-sitter-css v0.23.1
Compiling tree-sitter-ruby v0.23.1
Compiling tree-sitter-c v0.23.2
Compiling tree-sitter-python v0.23.4
Compiling tree-sitter-json v0.24.8
Checking either v1.11.0
Checking snapbox-macros v0.3.8
Checking salsa20 v0.10.2
Checking similar v2.5.0
Compiling radicle-cli v0.14.0 (/45c2f302-aee4-4006-9ce9-501190c2dac6/w/crates/radicle-cli)
Checking normalize-line-endings v0.3.0
Checking nonempty v0.5.0
Checking siphasher v0.3.11
Checking base64 v0.13.1
Checking bloomy v1.2.0
Checking snapbox v0.4.17
Checking scrypt v0.11.0
Checking tree-sitter-highlight v0.24.4
Checking popol v3.0.0
Checking timeago v0.4.2
Checking bytes v1.10.1
Checking io-reactor v0.5.2
Checking socket2 v0.5.7
Compiling radicle-node v0.12.0 (/45c2f302-aee4-4006-9ce9-501190c2dac6/w/crates/radicle-node)
Checking yansi v0.5.1
Checking diff v0.1.13
Checking netservices v0.8.0
Checking pretty_assertions v1.4.0
Checking num-integer v0.1.46
Compiling escargot v0.5.10
Checking radicle-systemd v0.9.0 (/45c2f302-aee4-4006-9ce9-501190c2dac6/w/crates/radicle-systemd)
Compiling qcheck-macros v1.0.0
Checking num-bigint v0.4.6
Compiling ahash v0.8.11
Compiling radicle-remote-helper v0.11.0 (/45c2f302-aee4-4006-9ce9-501190c2dac6/w/crates/radicle-remote-helper)
Checking num-iter v0.1.45
Checking num-complex v0.4.6
Checking num-rational v0.4.2
Checking zerocopy v0.7.35
Checking bit-vec v0.8.0
Checking borrow-or-share v0.2.2
Checking fluent-uri v0.3.2
Checking bit-set v0.8.0
Checking num v0.4.3
Checking phf_shared v0.11.3
Checking uuid v1.16.0
Checking vsimd v0.8.0
Checking outref v0.5.2
Checking referencing v0.30.0
Checking phf v0.11.3
Checking fraction v0.15.3
Checking uuid-simd v0.8.0
Checking fancy-regex v0.14.0
Checking email_address v0.2.9
Checking bytecount v0.6.8
Checking base64 v0.22.1
Checking num-cmp v0.1.0
Checking emojis v0.6.4
Checking jsonschema v0.30.0
Checking git2 v0.19.0
Checking radicle-git-ext v0.8.1
Checking radicle-term v0.13.0 (/45c2f302-aee4-4006-9ce9-501190c2dac6/w/crates/radicle-term)
Checking radicle-crypto v0.12.0 (/45c2f302-aee4-4006-9ce9-501190c2dac6/w/crates/radicle-crypto)
Checking radicle-cob v0.14.0 (/45c2f302-aee4-4006-9ce9-501190c2dac6/w/crates/radicle-cob)
Checking radicle v0.16.1 (/45c2f302-aee4-4006-9ce9-501190c2dac6/w/crates/radicle)
error: function call inside of `expect`
--> crates/radicle/src/node/config.rs:384:14
|
384 | .expect(format!("Couldnt read from file: {}", &self.0).as_str())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Couldnt read from file: {}", &self.0))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
= note: `-D clippy::expect-fun-call` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::expect_fun_call)]`
error: direct implementation of `ToString`
--> crates/radicle/src/node/config.rs:401:1
|
401 | / impl ToString for AddressFilePart {
402 | | fn to_string(&self) -> String {
403 | | match self {
404 | | AddressFilePart::File(file_path) => file_path.get(),
... |
408 | | }
| |_^
|
= help: prefer implementing `Display` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
= note: `-D clippy::to-string-trait-impl` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::to_string_trait_impl)]`
error: direct implementation of `ToString`
--> crates/radicle/src/node/config.rs:429:1
|
429 | / impl ToString for AddressFile {
430 | | fn to_string(&self) -> String {
431 | | match self {
432 | | AddressFile::Full(path) => path.to_string(),
... |
436 | | }
| |_^
|
= help: prefer implementing `Display` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
error: unneeded `return` statement
--> crates/radicle/src/node/config.rs:620:9
|
620 | return out;
| ^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `-D clippy::needless-return` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_return)]`
help: remove `return`
|
620 - return out;
620 + out
|
error: use of `unwrap_or` to construct default value
--> crates/radicle/src/node/config.rs:612:57
|
612 | for i in &self.external_addresses_files.clone().unwrap_or(Vec::new()) {
| ^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
= note: `-D clippy::unwrap-or-default` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unwrap_or_default)]`
error: function call inside of `expect`
--> crates/radicle/src/node/config.rs:617:22
|
617 | .expect(format!("Invalid Address: {}", &addr_str).as_str()),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Invalid Address: {}", &addr_str))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
error: this expression creates a reference which is immediately dereferenced by the compiler
--> crates/radicle/src/node/config.rs:616:35
|
616 | Address::from_str(&addr_str)
| ^^^^^^^^^ help: change this to: `addr_str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
error: could not compile `radicle` (lib) due to 7 previous errors
warning: build failed, waiting for other jobs to finish...
error: could not compile `radicle` (lib test) due to 7 previous errors
Exit code: 101
{
"response": "finished",
"result": "failure"
}